@mintlify/common 1.0.1298 → 1.0.1300

package/dist/navigation/filterDivisions.js

@@ -291,13 +291,17 @@ function buildDivisionItem(param) {
     const divisionItem = Object.fromEntries(Object.entries(item).filter(([key]) => !keysToDrop.includes(key)));
     // if href is absolute url, use it, otherwise use the href from the first page
     if (!href) {
-        const isUserDefinedHref = 'href' in item && isAbsoluteUrl(item.href);
+        const userHref = 'href' in item ? item.href : undefined;
+        const hasChildNav = divisionKey === 'languages' || keysToDrop.some((key) => key in item);
+        const isUserDefinedHref = !!userHref &&
+            (isAbsoluteUrl(userHref) ||
+                (!hasChildNav && userHref.startsWith('/') && !userHref.startsWith('//')));
         if (!isUserDefinedHref && divisionKey === 'dropdowns' && !isActive && currentPath) {
             href =
                 (_c = (_b = findCorrespondingDropdownHref(item, currentPath, userGroups !== null && userGroups !== void 0 ? userGroups : new Set(), isPreview)) !== null && _b !== void 0 ? _b : findSamePageInDropdownVersion(page === null || page === void 0 ? void 0 : page.href, findDivisionName(item), currentPath, rootNav, userGroups !== null && userGroups !== void 0 ? userGroups : new Set(), isPreview)) !== null && _c !== void 0 ? _c : '';
         }
         if (!href) {
-            href = isUserDefinedHref ? item.href : (page === null || page === void 0 ? void 0 : page.href) || '/';
+            href = isUserDefinedHref ? userHref : (page === null || page === void 0 ? void 0 : page.href) || '/';
             // when users switch languages, we should stay on the same page
             // instead of switching to the first page in the new language
             if (!isUserDefinedHref && divisionKey === 'languages') {

package/dist/navigation/filterDivisions.test.js

@@ -970,3 +970,78 @@ describe('filterDivisions dropdown corresponding pages', () => {
         });
     });
 });
+describe('filterDivisions root-relative division hrefs', () => {
+    const defaultArgs = {
+        decoratedNav: { groups: [] },
+        currentPath: '/guides/intro',
+        userGroups: new Set(),
+        currentVersion: '',
+        currentLanguage: undefined,
+        shouldUseDivisionMatch: true,
+        cache: {
+            dropdownCache: new Map(),
+        },
+    };
+    const guidesGroups = [{ group: 'Start', pages: [{ title: 'Intro', href: '/guides/intro' }] }];
+    const platformGroups = [
+        { group: 'Platform', pages: [{ title: 'Analytics', href: '/platform/analytics' }] },
+    ];
+    it.each(['tabs', 'anchors', 'dropdowns'])('uses a root-relative href on %s without child navigation', (key) => {
+        var _a;
+        const divisionName = { tabs: 'tab', anchors: 'anchor', dropdowns: 'dropdown' }[key];
+        const result = filterDivisions(Object.assign(Object.assign({}, defaultArgs), { decoratedNav: {
+                [key]: [
+                    { [divisionName]: 'Guides', groups: guidesGroups },
+                    { [divisionName]: 'Analytics', href: '/platform/analytics' },
+                ],
+            } }));
+        expect((_a = result[key].find((d) => d.name === 'Analytics')) === null || _a === void 0 ? void 0 : _a.href).toBe('/platform/analytics');
+    });
+    it('uses a root-relative href on a menu item without child navigation', () => {
+        var _a, _b;
+        const result = filterDivisions(Object.assign(Object.assign({}, defaultArgs), { decoratedNav: {
+                tabs: [
+                    {
+                        tab: 'Guides',
+                        menu: [
+                            { item: 'Intro', groups: guidesGroups },
+                            { item: 'Analytics', href: '/platform/analytics' },
+                        ],
+                    },
+                    { tab: 'Platform', groups: platformGroups },
+                ],
+            } }));
+        const menu = (_a = result.tabs.find((t) => t.name === 'Guides')) === null || _a === void 0 ? void 0 : _a.menu;
+        expect((_b = menu === null || menu === void 0 ? void 0 : menu.find((m) => m.name === 'Analytics')) === null || _b === void 0 ? void 0 : _b.href).toBe('/platform/analytics');
+    });
+    it('keeps the first page href when the division also has child navigation', () => {
+        var _a;
+        const result = filterDivisions(Object.assign(Object.assign({}, defaultArgs), { decoratedNav: {
+                tabs: [
+                    { tab: 'Guides', groups: guidesGroups },
+                    { tab: 'Platform', href: '/elsewhere', groups: platformGroups },
+                ],
+            } }));
+        expect((_a = result.tabs.find((t) => t.name === 'Platform')) === null || _a === void 0 ? void 0 : _a.href).toBe('/platform/analytics');
+    });
+    it('leaves language hrefs on the current page', () => {
+        var _a;
+        const result = filterDivisions(Object.assign(Object.assign({}, defaultArgs), { decoratedNav: {
+                languages: [
+                    { language: 'en', groups: guidesGroups },
+                    { language: 'fr', href: '/fr/guides/intro' },
+                ],
+            } }));
+        expect((_a = result.languages.find((l) => l.language === 'fr')) === null || _a === void 0 ? void 0 : _a.href).toBe('');
+    });
+    it('does not treat protocol-relative hrefs as internal', () => {
+        var _a;
+        const result = filterDivisions(Object.assign(Object.assign({}, defaultArgs), { decoratedNav: {
+                tabs: [
+                    { tab: 'Guides', groups: guidesGroups },
+                    { tab: 'Other', href: '//evil.example.com' },
+                ],
+            } }));
+        expect((_a = result.tabs.find((t) => t.name === 'Other')) === null || _a === void 0 ? void 0 : _a.href).toBe('/');
+    });
+});