@mintlify/common 1.0.1108 → 1.0.1110

package/dist/navigation/scopeNavToPath.js

@@ -154,10 +154,10 @@ function divisionValue(division, key) {
     const value = key === 'versions' ? division.version : division.language;
     return typeof value === 'string' ? value : undefined;
 }
-function resolveStubTarget(division, key, ctx) {
+function resolveStubTarget(division, key, ctx, usePrecomputedTarget) {
     const targets = key === 'versions' ? ctx.versionTargets : ctx.languageTargets;
     const value = divisionValue(division, key);
-    const resolved = targets === null || targets === void 0 ? void 0 : targets.get(value);
+    const resolved = usePrecomputedTarget ? targets === null || targets === void 0 ? void 0 : targets.get(value) : undefined;
     const fallback = pickStubTarget(division, ctx, DIVISION_TYPE_BY_KEY[key]);
     // the jump-map walk records targets without access checks, so a precomputed
     // entry only supplies the switch destination; hidden/groups still come from
@@ -172,10 +172,10 @@ function resolveStubTarget(division, key, ctx) {
     }
     return fallback;
 }
-function stubDivision(division, key, ctx) {
+function stubDivision(division, key, ctx, usePrecomputedTarget) {
     if (typeof division.href === 'string')
         return division;
-    const target = resolveStubTarget(division, key, ctx);
+    const target = resolveStubTarget(division, key, ctx, usePrecomputedTarget);
     // a division with no page candidates carries no page payload worth stripping,
     // so keep it unchanged rather than inventing a switch target
     if (!target)
@@ -328,6 +328,9 @@ function scopeDivisionArray(entries, key, ctx) {
     }
     const currentValue = key === 'versions' ? ctx.currentVersion : ctx.currentLanguage;
     const containsPath = entries.map((entry) => isNavNode(entry) && divisionContainsPath(entry, ctx.currentPath));
+    // Precomputed targets belong to the version/language block that owns the
+    // current path. Reusing them in an off-path sibling can cross dropdowns.
+    const usePrecomputedTarget = containsPath.some(Boolean);
     let activeIndex = -1;
     if (currentValue) {
         activeIndex = entries.findIndex((entry, index) => isNavNode(entry) && divisionValue(entry, key) === currentValue && containsPath[index]);
@@ -354,7 +357,7 @@ function scopeDivisionArray(entries, key, ctx) {
         // a stub would collapse the sidebar to its single switch-target page
         if (containsPath[index])
             return scopeNode(entry, ctx);
-        return stubDivision(entry, key, ctx);
+        return stubDivision(entry, key, ctx, usePrecomputedTarget);
     });
 }
 function collectProductVersionMetadata(node, out, seen) {

package/dist/navigation/scopeOffPathDivisions.test.js

@@ -167,6 +167,38 @@ const dropdownNav = {
         },
     ],
 };
+const parallelVersionedDropdownNav = {
+    dropdowns: [
+        {
+            dropdown: 'Primary API',
+            versions: [
+                {
+                    version: 'v2',
+                    pages: [{ title: 'Overview', href: '/api/primary/v2/overview' }],
+                },
+                {
+                    version: 'v1',
+                    default: true,
+                    pages: [{ title: 'Overview', href: '/api/primary/v1/overview' }],
+                },
+            ],
+        },
+        {
+            dropdown: 'Secondary API',
+            versions: [
+                {
+                    version: 'v2',
+                    pages: [{ title: 'Overview', href: '/api/secondary/v2/overview' }],
+                },
+                {
+                    version: 'v1',
+                    default: true,
+                    pages: [{ title: 'Overview', href: '/api/secondary/v1/overview' }],
+                },
+            ],
+        },
+    ],
+};
 // groups: [] denies every viewer (checkNavAccess), unlike an absent groups key
 const denyAllGroupsTabNav = {
     tabs: [
@@ -639,6 +671,18 @@ describe('off-path tab and anchor stubbing', () => {
         expect(scopedNav.dropdowns[1]).toEqual(dropdownNav.dropdowns[1]);
         expect(scopedNav.dropdowns[2]).toEqual(dropdownNav.dropdowns[2]);
     });
+    it('keeps version targets within their dropdown when version labels are reused', () => {
+        var _a;
+        const currentPath = '/api/secondary/v1/overview';
+        const scoped = getScopedNavForPath({
+            decoratedNav: parallelVersionedDropdownNav,
+            currentPath,
+        });
+        const full = filterWith(parallelVersionedDropdownNav, currentPath, scoped.currentVersion, scoped.currentLanguage);
+        const rescoped = filterWith(scoped.scopedNav, currentPath, scoped.currentVersion, scoped.currentLanguage);
+        expect((_a = rescoped.dropdowns.find(({ name }) => name === 'Primary API')) === null || _a === void 0 ? void 0 : _a.href).toBe('/api/primary/v1/overview');
+        expect(chromeSummary(rescoped)).toEqual(chromeSummary(full));
+    });
     it('keeps hidden/gated sibling versions invisible even with precomputed jump targets', () => {
         assertChromeInvariantForEveryPath(hiddenVersionNav);
         assertChromeInvariantForEveryPath(hiddenVersionNav, false, new Set(['staff']));