@mintlify/common 1.0.1024 → 1.0.1025

package/dist/navigation/updateFirstHrefInDivision.js

@@ -10,6 +10,7 @@ export var DivisionMatchLevel;
     DivisionMatchLevel[DivisionMatchLevel["GROUP"] = 2] = "GROUP";
     DivisionMatchLevel[DivisionMatchLevel["DIVISION"] = 3] = "DIVISION";
     DivisionMatchLevel[DivisionMatchLevel["NONE"] = 4] = "NONE";
+    DivisionMatchLevel[DivisionMatchLevel["UNVERSIONED"] = 5] = "UNVERSIONED";
 })(DivisionMatchLevel || (DivisionMatchLevel = {}));
 const ACCEPTED_BASE_PATHS = ['docs', 'doc', 'documentation', 'help'];
 export function updateFirstHrefInDivision({ type, currentPath, entry, parentGroups, nearestDivisionValue, isActiveGroup, inActiveDivision, currentDivisionValue, allDivisionValues, firstHrefInDivision, navigationDivisions, isHiddenPage, activeGroupNames, }) {
@@ -297,9 +298,13 @@ function maybeUpdateFirstHrefInDivision(type, href, finalVersion, inActiveGroup,
         }
         return;
     }
+    // a page that belongs to the target division beats a division-less catch-all,
+    // so rule 3 ("first page in the new version") holds regardless of walk order
+    const fallbackLevel = finalVersion !== undefined ? DivisionMatchLevel.NONE : DivisionMatchLevel.UNVERSIONED;
     for (const version of versionsToUpdate) {
-        if (!firstHrefInDivision.has(version)) {
-            firstHrefInDivision.set(version, { href, matchLevel: DivisionMatchLevel.NONE });
+        const existingHref = firstHrefInDivision.get(version);
+        if (existingHref === undefined || fallbackLevel < existingHref.matchLevel) {
+            firstHrefInDivision.set(version, { href, matchLevel: fallbackLevel });
         }
     }
 }

package/dist/navigation/updateFirstHrefInDivision.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/navigation/updateFirstHrefInDivision.test.js

@@ -0,0 +1,52 @@
+import { DivisionMatchLevel, updateFirstHrefInDivision, } from './updateFirstHrefInDivision.js';
+const emptyDivisions = {
+    tabs: [],
+    anchors: [],
+    versions: [],
+    languages: [],
+    dropdowns: [],
+    products: [],
+    menu: [],
+};
+function visit(firstHrefInDivision, href, nearestDivisionValue) {
+    const page = { title: href, href };
+    updateFirstHrefInDivision({
+        type: 'version',
+        currentPath: '/docs',
+        entry: page,
+        parentGroups: [],
+        nearestDivisionValue,
+        isActiveGroup: false,
+        inActiveDivision: false,
+        currentDivisionValue: undefined,
+        allDivisionValues: ['v2', 'v1'],
+        firstHrefInDivision,
+        navigationDivisions: emptyDivisions,
+        isHiddenPage: false,
+    });
+}
+describe(updateFirstHrefInDivision, () => {
+    it('prefers a division-owned page over an earlier unversioned catch-all', () => {
+        const map = new Map();
+        visit(map, '/docs/getting-started', undefined);
+        visit(map, '/docs/v1/overview', 'v1');
+        expect(map.get('v1')).toEqual({
+            href: '/docs/v1/overview',
+            matchLevel: DivisionMatchLevel.NONE,
+        });
+        expect(map.get('v2')).toEqual({
+            href: '/docs/getting-started',
+            matchLevel: DivisionMatchLevel.UNVERSIONED,
+        });
+    });
+    it('keeps the first division-owned page regardless of visit order', () => {
+        const map = new Map();
+        visit(map, '/docs/v1/overview', 'v1');
+        visit(map, '/docs/getting-started', undefined);
+        visit(map, '/docs/v1/later-page', 'v1');
+        expect(map.get('v1')).toEqual({
+            href: '/docs/v1/overview',
+            matchLevel: DivisionMatchLevel.NONE,
+        });
+    });
+});