@mintlify/cli 4.0.1800 → 4.0.1802

package/__test__/validateCommand.test.ts

@@ -478,7 +478,7 @@ describe('mint validate', () => {
       },
     ]);
     expect(rules(result)).toEqual(['unknown-component']);
-    expect(processExitMock).toHaveBeenCalledWith(0);
+    expect(processExitMock).toHaveBeenCalledWith(1);
   });
 
   it('turns rules and groups on and off', async () => {

package/__test__/validateEngine.test.ts

@@ -28,6 +28,8 @@ describe('selectRules', () => {
       'void-tags',
       'duplicate-h1',
       'unknown-component',
+      'undefined-variable',
+      'missing-snippet',
       'katex',
       'foreign-syntax',
       'missing-file',

package/__test__/validateRules.test.ts

@@ -492,7 +492,7 @@ describe('validate rules', () => {
     expect(severities).toEqual({
       'void-tags': 'error',
       'duplicate-h1': 'warning',
-      'unknown-component': 'warning',
+      'unknown-component': 'error',
       katex: 'warning',
     });
     expect(hasErrors(issues)).toBe(true);
@@ -549,6 +549,61 @@ describe('validate rules', () => {
     expect(issues.map(({ message }) => message)).toEqual([expect.stringContaining('<Color.Nope>')]);
   });
 
+  it('reports {{variables}} docs.json does not define, outside code', async () => {
+    write(dir, {
+      'index.mdx':
+        "---\ntitle: Home\n---\n\nVersion {{version}} of {{product}}.\n\n`{{inline}}`\n\n```jinja\n{{ fenced }}\n```\n\nexport const color = 'red';\n\n<div style={{color}} data-x = {{ color }}>Hi</div>\n",
+      'snippets/note.mdx': 'Hi {{ missing }}\n',
+    });
+    fs.writeJSONSync(path.join(dir, 'docs.json'), {
+      name: 'Test',
+      navigation: { pages: ['index'] },
+      variables: { product: 'Acme' },
+    });
+
+    const { issues } = await check(dir, { rules: ['undefined-variable'] });
+
+    expect(
+      issues.map(({ file, line, column, severity, message }) => [
+        file,
+        line,
+        column,
+        severity,
+        message,
+      ])
+    ).toEqual([
+      ['index.mdx', 5, 9, 'error', '{{version}} is not defined in the variables of docs.json'],
+      [
+        'snippets/note.mdx',
+        1,
+        4,
+        'error',
+        '{{missing}} is not defined in the variables of docs.json',
+      ],
+    ]);
+  });
+
+  it('reports legacy <Snippet file> tags the build cannot resolve', async () => {
+    write(dir, {
+      '_snippets/a.mdx': 'A\n',
+      'snippets/b.mdx': 'B\n',
+      'index.mdx':
+        '---\ntitle: Home\n---\n\n<Snippet file="a.mdx" />\n\n<Snippet file="{{part}}" />\n\n<Snippet file="snippets/b.mdx" />\n\n<Snippet file="b.mdx" />\n\n<Snippet file="/a.mdx" />\n',
+    });
+    fs.writeJSONSync(path.join(dir, 'docs.json'), {
+      name: 'Test',
+      navigation: { pages: ['index'] },
+      variables: { part: 'a.mdx' },
+    });
+
+    const { issues } = await check(dir, { rules: ['missing-snippet'] });
+
+    expect(issues.map(({ line, severity, message }) => [line, severity, message])).toEqual([
+      [11, 'error', '<Snippet file="b.mdx"> renders nothing: no snippet matches "b.mdx"'],
+      [13, 'error', '<Snippet file="/a.mdx"> renders nothing: no snippet matches "/a.mdx"'],
+    ]);
+  });
+
   it('leaves escaped void tags alone', async () => {
     write(dir, { 'index.mdx': '---\ntitle: Home\n---\n\nText \\<br> and \\<img src="/a.png">\n' });
 

package/bin/cli.js

@@ -180,7 +180,6 @@ export const cli = ({ packageName = 'mint' }) => {
     })
         .option('github', {
         type: 'boolean',
-        default: false,
         description: 'Trust this GitHub repository to deploy the site and write a GitHub Actions workflow',
     })
         .option('force', {