@mintjamsinc/ichigojs 0.1.68 → 0.1.69

package/dist/ichigo.esm.js

@@ -10264,9 +10264,18 @@ class VForDirective {
     #sourceName;
     #useOfSyntax = false; // Track if 'of' syntax was used
     /**
-     * Map to track rendered items by their keys
+     * Ordered list of currently rendered items.
+     *
+     * This is intentionally an ordered array of { key, vNode } entries rather
+     * than a Map<key, VNode>. The :key attribute is a *reconciliation hint*
+     * used to identify and reuse the same logical row across re-renders — it is
+     * not the identity of the rendered set. Keying the rendered set by a Map
+     * would make it structurally impossible to hold two rows that resolve to
+     * the same key, which would silently drop application data. The most
+     * fundamental invariant of a list directive is "N items in => N rows out",
+     * so the rendered set must be a positional list that can carry duplicates.
      */
-    #renderedItems = new Map();
+    #renderedItems = [];
     /**
      * Previous iterations to detect changes
      */
@@ -10389,11 +10398,11 @@ class VForDirective {
     destroy() {
         // Clean up all rendered items
         // First destroy all VNodes (calls @unmount hooks), then remove from DOM
-        for (const vNode of this.#renderedItems.values()) {
+        for (const { vNode } of this.#renderedItems) {
             vNode.destroy();
         }
         // Then remove DOM nodes
-        for (const vNode of this.#renderedItems.values()) {
+        for (const { vNode } of this.#renderedItems) {
             const range = vNode.fragmentRange;
             if (range) {
                 range.remove();
@@ -10404,7 +10413,7 @@ class VForDirective {
                 vNode.node.parentNode.removeChild(vNode.node);
             }
         }
-        this.#renderedItems.clear();
+        this.#renderedItems = [];
         this.#previousIterations = [];
     }
     /**
@@ -10445,7 +10454,24 @@ class VForDirective {
         this.#previousIterations = iterations;
     }
     /**
-     * Key-based diffing for efficient DOM updates
+     * Key-based diffing for efficient DOM updates.
+     *
+     * Reconciliation model
+     * --------------------
+     * The :key attribute is treated as a *hint* for reusing the same logical
+     * row across re-renders, not as the identity of the rendered set. The
+     * previously rendered rows are placed into a pool keyed by :key (a queue
+     * per key, so equal keys can hold more than one row). Each incoming
+     * iteration then claims a row from its key's queue when one is available,
+     * otherwise a fresh row is created. Whatever stays in the pool at the end
+     * is genuinely gone and is destroyed and removed.
+     *
+     * This guarantees the directive's most fundamental invariant — "N items in
+     * => N rows out" — even when the application supplies duplicate keys. We
+     * still warn on duplicates because they make reuse ambiguous (reordering
+     * becomes positional rather than identity-stable), but we never silently
+     * drop the application's data, and no row is ever orphaned: every old row
+     * is either reused or explicitly removed.
      */
     #updateList(newIterations) {
         const parent = this.#vNode.anchorNode?.parentNode;
@@ -10453,22 +10479,38 @@ class VForDirective {
         if (!parent || !anchor) {
             throw new Error('v-for element must have a parent and anchor');
         }
-        const newRenderedItems = new Map();
-        // Track which keys are still needed and detect duplicates
-        const neededKeys = new Set();
+        // Build a reuse pool from the currently rendered rows. A queue per key
+        // (FIFO) lets duplicate keys reuse multiple rows: the first incoming
+        // occurrence claims the first existing row, the second claims the next,
+        // and so on.
+        const pool = new Map();
+        for (const { key, vNode } of this.#renderedItems) {
+            let queue = pool.get(key);
+            if (!queue) {
+                queue = [];
+                pool.set(key, queue);
+            }
+            queue.push(vNode);
+        }
+        // Decide, for each incoming iteration in order, whether it reuses an
+        // existing row or needs a new one. Reused rows are taken out of the
+        // pool so that what remains afterwards is exactly the set to remove.
         const seenKeys = new Set();
-        for (const ctx of newIterations) {
-            if (seenKeys.has(ctx.key)) {
-                console.warn(`[ichigo.js] Duplicate key detected in v-for: "${ctx.key}". This may cause unexpected behavior. Keys should be unique.`);
+        const plan = [];
+        for (const context of newIterations) {
+            if (seenKeys.has(context.key)) {
+                console.warn(`[ichigo.js] Duplicate key detected in v-for: "${context.key}". All entries are still rendered, but reordering may be unstable. Keys should be unique.`);
             }
-            seenKeys.add(ctx.key);
-            neededKeys.add(ctx.key);
+            seenKeys.add(context.key);
+            const queue = pool.get(context.key);
+            const reused = queue && queue.length ? queue.shift() : undefined;
+            plan.push({ context, reused });
         }
-        // Remove items that are no longer needed
+        // Remove rows that were not reused.
         // First destroy VNodes (calls @unmount hooks while DOM is still accessible)
         const nodesToRemove = [];
-        for (const [key, vNode] of this.#renderedItems) {
-            if (!neededKeys.has(key)) {
+        for (const queue of pool.values()) {
+            for (const vNode of queue) {
                 nodesToRemove.push(vNode);
                 vNode.destroy();
             }
@@ -10487,11 +10529,12 @@ class VForDirective {
                 parentOfNode.removeChild(vNode.node);
             }
         }
-        // Add or reorder items
+        // Add or reorder rows, building the new ordered rendered set.
+        const newRenderedItems = [];
         let prevNode = anchor;
-        for (const context of newIterations) {
+        for (const { context, reused } of plan) {
             const { key } = context;
-            let vNode = this.#renderedItems.get(key);
+            let vNode = reused;
             if (!vNode) {
                 // Create new item
                 const clone = this.#cloneNode();
@@ -10523,7 +10566,7 @@ class VForDirective {
                 if (clone.nodeType === Node.DOCUMENT_FRAGMENT_NODE) {
                     const range = VFragmentRange.insert(parent, prevNode.nextSibling, 'vfor-fragment', clone);
                     vNode.fragmentRange = range;
-                    newRenderedItems.set(key, vNode);
+                    newRenderedItems.push({ key, vNode });
                     vNode.forceUpdate();
                     prevNode = range.lastNode;
                     continue;
@@ -10537,12 +10580,12 @@ class VForDirective {
                 else {
                     parent.appendChild(nodeToInsert);
                 }
-                newRenderedItems.set(key, vNode);
+                newRenderedItems.push({ key, vNode });
                 vNode.forceUpdate();
             }
             else {
                 // Reuse existing item
-                newRenderedItems.set(key, vNode);
+                newRenderedItems.push({ key, vNode });
                 // Update bindings
                 this.#updateItemBindings(vNode, context);
                 // For fragment-backed iterations, move the entire range atomically.
@@ -10568,7 +10611,7 @@ class VForDirective {
             // Advance prevNode to this iteration's last DOM node
             prevNode = vNode.fragmentRange?.lastNode ?? vNode.anchorNode ?? vNode.node;
         }
-        // Update rendered items map
+        // Update the ordered rendered set
         this.#renderedItems = newRenderedItems;
     }
     /**