@ministryofjustice/hmpps-prison-permissions-lib 2.0.0 → 2.0.1

package/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 Please use this to capture reasoning behind changes:
 
+# 2.0.1
+Fixes incorrect usage of `previousPrisonId` and `previousPrisonLeavingDate` when checking contacts read permissions. These are only used in the context of transfers, not releases. The correct ones now in use are `lastPrisonId` and `releaseDate`.
+
 # 2.0.0
 Replaced contacts read permissions check with one that handles released prisoners differently. Checks for current prisoners are unaffected.
 

package/dist/data/hmppsPrisonerSearch/interfaces/Prisoner.d.ts

@@ -5,4 +5,6 @@ export default interface Prisoner {
     supportingPrisonId?: string;
     previousPrisonId?: string;
     previousPrisonLeavingDate?: string;
+    lastPrisonId?: string;
+    releaseDate?: string;
 }

package/dist/index.cjs

@@ -122,8 +122,8 @@ const isTransferring = (prisoner) => {
 };
 const wasReleasedWithinThreeYears = (prisoner) => {
     return (isReleased(prisoner) &&
-        !!prisoner.previousPrisonLeavingDate &&
-        Date.parse(prisoner.previousPrisonLeavingDate) > Date.now() - 3 * 365 * 24 * 60 * 60 * 1000);
+        !!prisoner.releaseDate &&
+        Date.parse(prisoner.releaseDate) > Date.now() - 3 * 365 * 24 * 60 * 60 * 1000);
 };
 function userHasSomeRolesFrom(rolesToCheck, user) {
     return (rolesToCheck.length === 0 ||
@@ -758,7 +758,7 @@ const contactsReadCheck = matchBaseCheckAnd({
                 return exports.PermissionCheckStatus.ROLE_NOT_PRESENT;
             if (!wasReleasedWithinThreeYears(prisoner))
                 return exports.PermissionCheckStatus.EXCEEDS_TIME_RESTRICTION;
-            if (!isInUsersCaseLoad(prisoner.previousPrisonId, user))
+            if (!isInUsersCaseLoad(prisoner.lastPrisonId, user))
                 return exports.PermissionCheckStatus.NOT_IN_CASELOAD;
             return exports.PermissionCheckStatus.OK;
         }