@mingfuyun/star-allinone 0.1.6 → 0.1.8

package/skills/shared/review-and-submit/SKILL.md

@@ -0,0 +1,75 @@
+---
+name: {{sharedSkillName}}
+description: Run the frontend pre-submit workflow: impact analysis, verification, then confirmation-gated commit review. Use when the user asks for the full submit flow or says 使用完整流程提交代码. Never stage, commit, or push before explicit confirmation.
+---
+
+# Review and Submit
+
+This is the unified pre-submit entry and is fully shared. Do not mutate Git until the user confirms the exact reviewed scope.
+
+If `.agents/project/review-rules.md` exists, apply extra domain checks only; do not weaken shared hard rules.
+
+## Workflow
+
+Execute in this order.
+
+### 1. Impact analysis
+
+Follow `.agents/skills/shared-impact-analysis/SKILL.md`. Output:
+
+- Change summary
+- Direct callers and affected pages
+- Related services, types, mocks, routes, and permissions
+- Shared-component blast radius
+- Recommended automated and manual regression paths
+
+### 2. Verification
+
+Follow `.agents/skills/shared-verify/SKILL.md`. Output:
+
+- P0/P1/P2 blockers
+- Completeness of route, permission, API, types, mock, and page states
+- Async, loading, overlay, and list-reload behavior
+- Prettier, TypeScript, lint, and build results
+- Uncovered risks
+
+If the current change introduced P0/P1 issues or validation failures, stop. Do not enter commit review.
+
+### 3. Commit review
+
+Follow `.agents/skills/shared-commit-current-changes/SKILL.md`. Output:
+
+- Findings sorted P0–P2
+- Optional improvements
+- Validation results and residual risk
+- Change summary
+- Suggested Chinese Conventional Commit message
+- Current branch and target remote
+- Exact file paths to submit
+
+Then stop and wait. Do not run Git writes.
+
+## Confirmation gate
+
+Execute the commit phase only after an explicit reply such as `确认` or `确认提交并推送` that authorizes the latest proposal.
+
+1. Re-check branch, status, and full diff.
+2. Confirm the review scope did not change.
+3. Stage only the confirmed paths.
+4. Create the confirmed commit message.
+5. Push only if the user asked to push.
+6. Report commit, remote branch, and workspace status.
+
+If the user only says `确认` but the scope is unclear, do not commit; ask for the exact files and message.
+
+If the user says `提交代码` before a review proposal exists, run the three steps above first. Do not skip review.
+
+## Related skills
+
+| Skill | Purpose |
+| --- | --- |
+| `$shared-impact-analysis` | Read-only impact analysis |
+| `$shared-verify` | Convention and command verification |
+| `$shared-commit-current-changes` | Review plus confirmation-gated commit |
+| `$shared-ai-review` | Standalone review without commit |
+| `$shared-publish-test` | After a confirmed push, publish the current branch using `publishPipelineId` |

package/skills/shared/verify/SKILL.md

@@ -0,0 +1,44 @@
+---
+name: {{sharedSkillName}}
+description: Verify generated or manually changed frontend code against shared conventions, API contracts, permissions, async behavior, and validation commands. Use after API, mock, page, or refactor work. Do not generate business code.
+---
+
+# Frontend Verification
+
+This skill is fully shared. Read the current diff, related callers, and:
+
+1. `.agents/skills/shared-project-conventions/references/review-checklist.md`
+2. `.agents/skills/shared-project-conventions/references/architecture.md`
+
+Do not auto-fix. If `.agents/project/review-rules.md` exists, apply extra domain checks only.
+
+## Checks
+
+1. Route, service, namespace types, `src/services/index.ts`, mocks, and permissions updated as a set.
+2. Pages follow `MFProTable`, `ProForm`, `CustomDrawer` / `BaseModal` / `HocModal`, and `@/services`.
+3. Every `await` has `try-catch`; loading restores in `finally`; overlays clear state on close; successful mutations reload lists.
+4. Scan new `any`, `as any`, `@ts-ignore`, direct Ant Design `Modal` / `Drawer` / `<Form>` containers, and production fake data.
+5. Empty table values, duplicate-submit guards, permission wrappers, and narrow-screen overflow.
+
+## Commands
+
+Choose by risk. Do not auto-fix to make a command pass.
+
+```bash
+git diff --check
+pnpm exec prettier --check <changed-files>
+pnpm exec eslint <changed-files>
+pnpm exec tsc --noEmit
+pnpm lint
+```
+
+Run the project's build script when routes, entry, or shared runtime change.
+
+## Output
+
+1. Blocking issues P0–P2, with file, line, impact, and fix direction.
+2. Completeness: route, permission, API, types, mock, page states.
+3. Command results, distinguishing new, existing, and environment failures.
+4. Regression list: affected pages, suggested manual paths, uncovered risks.
+
+If there are no blockers, write `未发现阻断问题`. Do not report only that commands passed.