@mindful-web/marko-web-omeda-identity-x 1.90.1 → 1.90.2

package/README.md

@@ -166,10 +166,14 @@ Two caveats:
 - **Each hook names the value differently.** `onLoginLinkSent` receives `source`,
   `onAuthenticationSuccess` receives `loginSource`, `onUserProfileUpdate` receives `actionSource`.
   Pass whichever local holds it.
-- **`onUserProfileUpdate` has no reliable source.** Neither `routes/profile.js` nor
-  `routes/progressive-profile.js` passes one; `actionSource` only arrives if a client put it in
-  `additionalEventData`, and is usually `undefined`. Overrides on that hook are inert whenever it
-  is — the value resolves to the base config.
+- **`onUserProfileUpdate` reports which surface saved the profile, not a registration source.**
+  Both routes that fire it now pass one: `routes/profile.js` sends `profileUpdate` and
+  `routes/progressive-profile.js` sends `progressiveProfile` (a client-supplied
+  `additionalEventData.actionSource` still wins over either). Neither is in any conversion bucket,
+  so **only an exact-source key matches them** — a `newsletter` or `contentGating` bucket override
+  will never apply to this hook. Before mindful-web#341 no route passed a source at all and every
+  override here was inert; if you are reading an older tenant config that relied on that, it now
+  resolves.
 
 An unrecognized, empty or missing source is never an error: the set of login sources is open (any
 site template can introduce a new `source="…"`), so it resolves to the base config.

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.90.1/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.90.2/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_getCookieId = require("@mindful-web/marko-web-omeda-identity-x/utils/get-cookie-id"),
@@ -51,7 +51,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-omeda-identity-x$1.90.1/components/identify.marko",
+    id: "/@mindful-web/marko-web-omeda-identity-x$1.90.2/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-identity-x/components/identify.marko",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-omeda-identity-x",
-  "version": "1.90.1",
+  "version": "1.90.2",
   "description": "Marko Omeda+IdentityX integration tools",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-omeda-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -13,7 +13,7 @@
     "test": "yarn compile --no-clean && yarn lint && mocha --reporter spec"
   },
   "dependencies": {
-    "@mindful-web/marko-web-identity-x": "^1.89.2",
+    "@mindful-web/marko-web-identity-x": "^1.90.2",
     "@mindful-web/marko-web-omeda": "^1.88.0",
     "@mindful-web/object-path": "^1.83.1",
     "@mindful-web/utils": "^1.83.1",
@@ -33,5 +33,5 @@
     "chai": "^4.3.7",
     "mocha": "^6.2.3"
   },
-  "gitHead": "e0185d370d34b4d465ceedae9e453b1925e5e6f5"
+  "gitHead": "0e498d1c31b3c6a8856b9d75cd9233a121fa173b"
 }

package/test/build-behavior.spec.js

@@ -0,0 +1,65 @@
+const { describe, it } = require('mocha');
+const { expect } = require('chai');
+const buildBehaviorFactory = require('../utils/build-behavior');
+
+// A realistic tenant behavior config (PMMI's, trimmed). Note what `actionSource` does NOT map:
+// there is no `valueId` fallback on it and no entry for the profile-update sources, which is the
+// property the tests below pin.
+const behaviors = { logIn: 103, verifyEmail: 104, submitProfile: 105 };
+const behaviorAttributes = {
+  website: { id: 8, valueId: 12345 },
+  actionSource: {
+    id: 11,
+    valueIds: {
+      default: 199623,
+      newsletterSignup: 199625,
+      comments: 199626,
+      contentGate: 199620,
+    },
+  },
+};
+
+const buildBehaviorFor = buildBehaviorFactory({ behaviors, behaviorAttributes });
+const attrsById = (behavior) => behavior.attributes.reduce((o, { id, valueId }) => ({
+  ...o,
+  [id]: valueId,
+}), {});
+
+describe('utils/build-behavior', () => {
+  it('maps each hook to its behavior id', () => {
+    expect(buildBehaviorFor('onLoginLinkSent', {}).id).to.equal(103);
+    expect(buildBehaviorFor('onAuthenticationSuccess', {}).id).to.equal(104);
+    expect(buildBehaviorFor('onUserProfileUpdate', {}).id).to.equal(105);
+    expect(buildBehaviorFor('onSomethingElse', {})).to.equal(undefined);
+  });
+
+  it('resolves a mapped action source to its value id', () => {
+    const attrs = attrsById(buildBehaviorFor('onLoginLinkSent', { actionSource: 'contentGate' }));
+    expect(attrs[11]).to.equal(199620);
+  });
+
+  // This is the guarantee that let `routes/profile.js` start passing a real `actionSource`
+  // (mindful-web#341) without touching a single tenant's Omeda behavior data. `profileUpdate` and
+  // `progressiveProfile` are mapped by no tenant, and an unmapped source must be OMITTED — it must
+  // never fall through to `valueIds.default` (which would silently relabel every profile save as a
+  // default-source action) and must never emit an undefined value id to Omeda.
+  //
+  // If a tenant later adds `valueIds.profileUpdate`, that is an opt-in and this test still holds:
+  // it asserts the behavior for a config that does not map the source.
+  ['profileUpdate', 'progressiveProfile', 'somethingNobodyMapped'].forEach((actionSource) => {
+    it(`omits the action source attribute for unmapped source '${actionSource}'`, () => {
+      const behavior = buildBehaviorFor('onUserProfileUpdate', { actionSource });
+      expect(behavior.id).to.equal(105);
+      expect(behavior.attributes.map(({ id }) => id)).to.not.include(11);
+      // The website attribute has a `valueId` fallback, so it still rides along.
+      expect(attrsById(behavior)[8]).to.equal(12345);
+    });
+  });
+
+  it('omits the action source attribute when no source is passed at all', () => {
+    // The pre-#341 behavior of `routes/profile.js`. Identical to the unmapped case above, which is
+    // precisely why passing a source is safe.
+    const behavior = buildBehaviorFor('onUserProfileUpdate', {});
+    expect(behavior.attributes.map(({ id }) => id)).to.not.include(11);
+  });
+});

package/utils/resolve-opt-in-hook-config.js

@@ -46,8 +46,12 @@ const isPlainObject = (v) => Boolean(v) && typeof v === 'object' && !Array.isArr
  *
  * Note the three hooks name this value differently in their formatter args: `onLoginLinkSent`
  * receives `source`, `onAuthenticationSuccess` receives `loginSource`, and `onUserProfileUpdate`
- * receives `actionSource` (which is client-supplied and frequently `undefined` — overrides on that
- * hook are inert whenever it is). Pass whichever local holds the value.
+ * receives `actionSource`. Pass whichever local holds the value.
+ *
+ * `actionSource` carries the surface that saved the profile — `profileUpdate` from
+ * `routes/profile.js`, `progressiveProfile` from `routes/progressive-profile.js`, or whatever a
+ * client put in `additionalEventData`. Neither route value belongs to a conversion bucket, so on
+ * that hook only an exact-source key can match.
  *
  * @param {object} params
  * @param {object} [params.optInHooks] The site's `identityXOptInHooks` config.