@mindful-web/marko-web-omeda-identity-x 1.85.5 → 1.85.6

package/README.md

@@ -18,7 +18,7 @@ All configuration data must be passed to the middleware when loaded (See [Middle
 | `clientKey` | No | The Omeda client key (such as `client_orgc`.) *Required if sending deployment optIns via the underlying omeda package!* [marko-web-omeda docs](../marko-web-omeda)
 | `appId` | **Yes** | The Omeda application API read token
 | `inputId` | **Yes** | The Omeda application API write token
-| `rapidIdentProductId` | **Yes** | The Omeda identifier for a Website product (ProductType=7).
+| `rapidIdentProductId` | No — **deprecated**, see [Website products](#website-products-do-not-use-rapididentproductid) | The Omeda identifier for a Website product (ProductType=7). Sends the product on **every** rapid identification, which cuts a duplicate Omeda order each time. Put the website product in the site's deduped opt-in hook instead. | _none_
 | `idxConfig` | **Yes** | An instance of the IdentityX configuration class (see [marko-web-identity-x#1](../marko-web-identity-x/config.js)) | _n/a_
 | `idxRouteTemplates` | **Yes** | An object containing the Marko templates to use for each IdentityX endpoint. (see [marko-web-identity-x#2](../marko-web-identity-x/index.js))
 | `omedaPromoCodeCookieName` | No | The name of the cookie to look for a persisted/original promo code. | `omeda_promo_code` |
@@ -38,6 +38,67 @@ All configuration data must be passed to the middleware when loaded (See [Middle
 | `appendPromoCodeToHook[].hook` | | The name of the hook, such as `onLoginLinkSent`
 | `appendPromoCodeToHook[].promoCode` || The Omeda Promo Code (`String`) to append.
 
+### Website products: do not use `rapidIdentProductId`
+
+`rapidIdentProductId` reads like site *identification* metadata, distinct from subscriptions. It
+isn't. It is forwarded as `productId` to the rapid identification call, and in the omeda GraphQL
+`rapidCustomerIdentification` resolver it is merged with `input.subscriptions` into a single
+`Products` array on Save Customer and Order:
+
+```js
+const productMap = new Map([...(input.productId ? [[input.productId, true]] : [])]);
+// …
+subscriptions.forEach(({ id, receive }) => {
+  subscriptionMap.set(id, receive);
+  if (!productMap.has(id)) productMap.set(id, receive);
+});
+// …
+Products: [...productMap].map(([OmedaProductId, Receive]) => ({ … }))
+```
+
+Omeda cuts an order for whatever lands in `Products`. So `rapidIdentProductId` orders the website
+product on **every** identification — every login-link send, auth success and profile update — which
+is a duplicate order per login, not a one-time attribution.
+
+**Do this instead.** Leave `rapidIdentProductId` unset and list the website product in the site's
+`identityXOptInHooks.onLoginLinkSent.productIds`. The site's `onLoginLinkSentFormatter` (in each
+repo's `packages/global/config/omeda-identity-x.js`) filters those ids through this package's
+[`getOmedaSubscriptionIds`](./omeda-data/get-omeda-subscription-ids.js) before building
+`payload.appendSubscriptions`, so the product is ordered once — when the customer doesn't already
+hold it — and every later identification is a no-op:
+
+```js
+// sites/<site>/config/identity-x-opt-in-hooks.js
+module.exports = {
+  onLoginLinkSent: {
+    productIds: [
+      15375, // <Site> Website — deduped against the live Omeda record; ordered only when missing
+    ],
+  },
+};
+```
+
+```js
+// sites/<site>/config/omeda-identity-x.js — no `rapidIdentProductId`
+module.exports = configure({ omedaConfig, idxConfig, websiteBehaviorAttributeId, omedaPromoCodePrefix });
+```
+
+The website product still belongs on the customer's record — it just needs to get there once. The
+field is retained for backwards compatibility and is optional in the Joi schema; it should not be
+set on new sites.
+
+History: the duplicate orders were found and fixed on allured (allured-business-media-websites#395,
+Oct 2025) and the placement was rolled out fleet-wide through Aug 2026 (ab-media-websites#539,
+ironmarkets-websites#993, cox-matthews-associates-websites#534, fusable-websites#1040,
+watt-global-media-websites#731, industrial-media-websites#623). This README previously listed the
+field as **required** and did not document the hook at all, which is what led two of those PRs to
+initially move the ids the wrong way.
+
+A related trap when reading site configs: some repos' `onAuthenticationSuccess.productIds` hold
+**deployment type** ids despite the key name, because that formatter matches
+`product.deploymentTypeId` and emits `deploymentTypes`. Check which formatter consumes a list before
+assuming its ids are products.
+
 ### Customer re-sync interval
 
 `userResyncIntervalMs` is read from the **IdentityX** config (`idxConfig`), not from the properties

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.85.5/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.85.6/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_getCookieId = require("@mindful-web/marko-web-omeda-identity-x/utils/get-cookie-id"),
@@ -51,7 +51,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-omeda-identity-x$1.85.5/components/identify.marko",
+    id: "/@mindful-web/marko-web-omeda-identity-x$1.85.6/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-identity-x/components/identify.marko",

package/index.js

@@ -45,7 +45,11 @@ const schemas = require('./validation/schemas');
  * @prop {?Promise<object>} onLoginLinkSentFormatter
  * @prop {?Promise<object>} onAuthenticationSuccessFormatter
  * @prop {?Promise<object>} onUserProfileUpdateFormatter
- * @prop {number} rapidIdentProductId
+ * @prop {?number} rapidIdentProductId **Deprecated.** Sends this website product on _every_ rapid
+ *   identification, which cuts a duplicate Omeda order each time — the resolver merges it into the
+ *   same `Products` array as `subscriptions`. Leave unset and put the website product in the site's
+ *   `identityXOptInHooks.onLoginLinkSent.productIds`, which is deduped against the live customer
+ *   record via `getOmedaSubscriptionIds`. Retained for backwards compatibility only; see README.
  *
  * @typedef BehaviorSchema
  * @prop {number} logIn
@@ -194,6 +198,17 @@ module.exports = (app, params = {}) => {
     rapidIdentProductId: Joi.number(),
   }), params);
 
+  // `rapidIdentProductId` is deprecated: the omeda `rapidCustomerIdentification` resolver merges it
+  // into the same SCAO `Products` array as `subscriptions`, so setting it orders the website
+  // product on every identification rather than once. Deliberately `console.warn` over the `warn`
+  // util, matching `resolveDurationMS`: this needs to be visible in production, which is where a
+  // reintroduced value would quietly start cutting duplicate orders again. No fleet repo sets it as
+  // of Aug 2026, so this should never fire outside of a regression.
+  if (rapidIdentProductId != null) {
+    // eslint-disable-next-line no-console
+    console.warn(`[config] rapidIdentProductId (${rapidIdentProductId}) is deprecated for brand ${brandKey}: it orders this website product on EVERY rapid identification, creating duplicate Omeda orders. Move it to the site's identityXOptInHooks.onLoginLinkSent.productIds, which is deduped against the live customer record. See @mindful-web/marko-web-omeda-identity-x README.`);
+  }
+
   // strip `oly_enc_id` when identity-x user is logged-in
   app.use(stripOlyticsParam());
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-omeda-identity-x",
-  "version": "1.85.5",
+  "version": "1.85.6",
   "description": "Marko Omeda+IdentityX integration tools",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-omeda-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -33,5 +33,5 @@
     "chai": "^4.3.7",
     "mocha": "^6.2.3"
   },
-  "gitHead": "26553d897cb2c39e798031e4e2727a81123b1402"
+  "gitHead": "189d80823090e82c78aaca54dbe2209dbb230fa0"
 }