@mindful-web/marko-web-omeda-identity-x 1.83.0 → 1.83.1

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.83.0/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.83.1/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_getCookieId = require("@mindful-web/marko-web-omeda-identity-x/utils/get-cookie-id"),
@@ -51,7 +51,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-omeda-identity-x$1.83.0/components/identify.marko",
+    id: "/@mindful-web/marko-web-omeda-identity-x$1.83.1/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-identity-x/components/identify.marko",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-omeda-identity-x",
-  "version": "1.83.0",
+  "version": "1.83.1",
   "description": "Marko Omeda+IdentityX integration tools",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-omeda-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -13,10 +13,10 @@
     "test": "yarn compile --no-clean && yarn lint"
   },
   "dependencies": {
-    "@mindful-web/marko-web-identity-x": "^1.83.0",
-    "@mindful-web/marko-web-omeda": "^1.83.0",
-    "@mindful-web/object-path": "^1.83.0",
-    "@mindful-web/utils": "^1.83.0",
+    "@mindful-web/marko-web-identity-x": "^1.83.1",
+    "@mindful-web/marko-web-omeda": "^1.83.1",
+    "@mindful-web/object-path": "^1.83.1",
+    "@mindful-web/utils": "^1.83.1",
     "@parameter1/joi": "^1.2.10",
     "graphql": "^14.7.0",
     "graphql-tag": "^2.12.6"
@@ -29,5 +29,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "2b694183f136fdd763ae0d1bc47843c5bf6e9290"
+  "gitHead": "c9507129d0e30847cb2b2a941cb383746d1fd501"
 }

package/rapid-identify.js

@@ -185,6 +185,28 @@ module.exports = async ({
     ...(subscriptions.length && { subscriptions }),
   });
 
+  /**
+   * `RapidCustomerIdentification.id` and `.encryptedCustomerId` are both *nullable*
+   * in the Omeda GraphQL schema — only `transactionId` is non-null — so a response
+   * can arrive without either one. Written unchecked, `${id}` stored the literal
+   * string `'null'` as an external ID and the encrypted identifier was sent with a
+   * null value (which is what the `idx/AddExternalUserId` errors in `MindfulApiCall`
+   * were).
+   *
+   * A bogus `encrypted` external ID is worse than none at all: `appendSubscriptions`
+   * locates the Omeda customer record by exactly that ID, so a garbage value costs
+   * the user every future newsletter auto-signup, silently and permanently. Nothing
+   * downstream can proceed without both values, so fail loudly instead of persisting
+   * them. This stays non-fatal for the user's sign-in — `callHooksFor` routes the
+   * rejection to `onHookError`.
+   */
+  const isBlank = (value) => value == null || `${value}`.trim() === '';
+  const missing = ['id', 'encryptedCustomerId']
+    .filter((key) => isBlank({ id, encryptedCustomerId }[key]));
+  if (missing.length) {
+    throw new Error(`Omeda rapid identification for brand '${brandKey}' returned no ${missing.join(' and no ')}. No external IDs were written for IdentityX user ${appUser.id}.`);
+  }
+
   const namespace = { provider: 'omeda', tenant: brandKey.toLowerCase(), type: 'customer' };
   await Promise.all([
     identityX.addExternalUserId({