@mindful-web/marko-web-omeda-identity-x 1.80.3 → 1.83.1

package/README.md

@@ -38,6 +38,21 @@ All configuration data must be passed to the middleware when loaded (See [Middle
 | `appendPromoCodeToHook[].hook` | | The name of the hook, such as `onLoginLinkSent`
 | `appendPromoCodeToHook[].promoCode` || The Omeda Promo Code (`String`) to append.
 
+### Customer re-sync interval
+
+`userResyncIntervalMs` is read from the **IdentityX** config (`idxConfig`), not from the properties
+above. It sets the lifetime of the `__idx_omeda_sync` cookie, which is what suppresses repeat Omeda
+customer re-syncs.
+
+| Property | Required? | Description | Default value |
+| - | - | - | - |
+| `userResyncIntervalMs` | No | **Milliseconds** between Omeda customer re-syncs for a given user. | `604800000` (1 week) |
+| `userResyncInterval` | No | **Deprecated** alias of `userResyncIntervalMs`. | _n/a_ |
+
+The unit matters: a re-sync costs two Omeda GraphQL round trips plus an IdentityX write, so a value
+of `604800` supplied as "a week in seconds" resolves to ten minutes and re-syncs on nearly every page
+view. Non-numeric or non-positive values are ignored with a warning and the default applies.
+
 ## Usage
 This package:
 1. Configures the underlying [omeda](../marko-web-omeda) and [identity-x](../marko-web-identity-x) packages

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.80.3/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.83.1/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_getCookieId = require("@mindful-web/marko-web-omeda-identity-x/utils/get-cookie-id"),
@@ -51,7 +51,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-omeda-identity-x$1.80.3/components/identify.marko",
+    id: "/@mindful-web/marko-web-omeda-identity-x$1.83.1/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-identity-x/components/identify.marko",

package/middleware/resync-customer-data.js

@@ -1,4 +1,4 @@
-const { asyncRoute } = require('@mindful-web/utils');
+const { asyncRoute, resolveDurationMS } = require('@mindful-web/utils');
 const { getAsArray } = require('@mindful-web/object-path');
 const resyncCookie = require('../utils/resync-cookie');
 const findEncryptedId = require('../external-id/find-encrypted-customer-id');
@@ -62,7 +62,14 @@ module.exports = ({
 
   // Set the cookie to prevent further resyncs until interval is reached.
   const value = { lastSync: Date.now() };
-  const maxAge = identityX.config.get('userResyncInterval', 7 * 24 * 60 * 60 * 1000); // 1 week
+  // `userResyncInterval` is a deprecated alias -- it carried no unit in its name, so a value of
+  // `604800` intended as "a week in seconds" yielded 10 minutes, resyncing on nearly every page
+  // view (two Omeda GraphQL round trips plus an IdentityX write each time).
+  const maxAge = resolveDurationMS({
+    value: identityX.config.get('userResyncIntervalMs', identityX.config.get('userResyncInterval')),
+    defaultValue: 7 * 24 * 60 * 60 * 1000, // 1 week, in ms
+    name: 'userResyncIntervalMs',
+  });
   resyncCookie.setTo({ res, value, maxAge });
 
   return next();

package/middleware/set-promo-source.js

@@ -1,3 +1,7 @@
+// Express's `res.cookie` maxAge is in **milliseconds**. This was previously expressed in seconds,
+// which silently reduced the cookie's lifetime from one year to ~8.76 hours.
+const COOKIE_MAX_AGE = 1000 * 60 * 60 * 24 * 365;
+
 /**
  * Sets the `omeda_promo_code` cookie to identify the customer's promotion source if the
  * `omeda_promo_code` URL parameter is present.
@@ -12,7 +16,7 @@ module.exports = ({
 
   // Set the promo source cookie
   if (incomingPromoCode) {
-    const options = { maxAge: 60 * 60 * 24 * 365, httpOnly: false };
+    const options = { maxAge: COOKIE_MAX_AGE, httpOnly: false };
     res.cookie(omedaPromoCodeCookieName, incomingPromoCode, options);
   }
 

package/middleware/strip-olytics-param.js

@@ -18,6 +18,9 @@ module.exports = () => (req, res, next) => {
     const redirectTo = `${req.path}${params ? `?${params}` : ''}`;
     res.redirect(302, redirectTo);
   } else {
+    // No incoming id, or it matches what's already set. Extend the existing cookie's expiration so
+    // an active visitor's olytics identity only lapses after a genuine year of absence.
+    if (currentEncId && !res.headersSent) olyticsCookie.setTo(res, currentEncId);
     next();
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-omeda-identity-x",
-  "version": "1.80.3",
+  "version": "1.83.1",
   "description": "Marko Omeda+IdentityX integration tools",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-omeda-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -13,10 +13,10 @@
     "test": "yarn compile --no-clean && yarn lint"
   },
   "dependencies": {
-    "@mindful-web/marko-web-identity-x": "^1.80.3",
-    "@mindful-web/marko-web-omeda": "^1.80.2",
-    "@mindful-web/object-path": "^1.80.2",
-    "@mindful-web/utils": "^1.80.2",
+    "@mindful-web/marko-web-identity-x": "^1.83.1",
+    "@mindful-web/marko-web-omeda": "^1.83.1",
+    "@mindful-web/object-path": "^1.83.1",
+    "@mindful-web/utils": "^1.83.1",
     "@parameter1/joi": "^1.2.10",
     "graphql": "^14.7.0",
     "graphql-tag": "^2.12.6"
@@ -29,5 +29,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "02de6be94c16fd962d5c94b37b9f09a151142f48"
+  "gitHead": "c9507129d0e30847cb2b2a941cb383746d1fd501"
 }

package/rapid-identify.js

@@ -185,6 +185,28 @@ module.exports = async ({
     ...(subscriptions.length && { subscriptions }),
   });
 
+  /**
+   * `RapidCustomerIdentification.id` and `.encryptedCustomerId` are both *nullable*
+   * in the Omeda GraphQL schema — only `transactionId` is non-null — so a response
+   * can arrive without either one. Written unchecked, `${id}` stored the literal
+   * string `'null'` as an external ID and the encrypted identifier was sent with a
+   * null value (which is what the `idx/AddExternalUserId` errors in `MindfulApiCall`
+   * were).
+   *
+   * A bogus `encrypted` external ID is worse than none at all: `appendSubscriptions`
+   * locates the Omeda customer record by exactly that ID, so a garbage value costs
+   * the user every future newsletter auto-signup, silently and permanently. Nothing
+   * downstream can proceed without both values, so fail loudly instead of persisting
+   * them. This stays non-fatal for the user's sign-in — `callHooksFor` routes the
+   * rejection to `onHookError`.
+   */
+  const isBlank = (value) => value == null || `${value}`.trim() === '';
+  const missing = ['id', 'encryptedCustomerId']
+    .filter((key) => isBlank({ id, encryptedCustomerId }[key]));
+  if (missing.length) {
+    throw new Error(`Omeda rapid identification for brand '${brandKey}' returned no ${missing.join(' and no ')}. No external IDs were written for IdentityX user ${appUser.id}.`);
+  }
+
   const namespace = { provider: 'omeda', tenant: brandKey.toLowerCase(), type: 'customer' };
   await Promise.all([
     identityX.addExternalUserId({