@mindful-web/marko-web-omeda-identity-x 1.106.1 → 1.107.1

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.106.1/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-omeda-identity-x$1.107.1/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_getCookieId = require("@mindful-web/marko-web-omeda-identity-x/utils/get-cookie-id"),
@@ -51,7 +51,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-omeda-identity-x$1.106.1/components/identify.marko",
+    id: "/@mindful-web/marko-web-omeda-identity-x$1.107.1/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-identity-x/components/identify.marko",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-omeda-identity-x",
-  "version": "1.106.1",
+  "version": "1.107.1",
   "description": "Marko Omeda+IdentityX integration tools",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-omeda-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -33,5 +33,5 @@
     "chai": "^4.3.7",
     "mocha": "^6.2.3"
   },
-  "gitHead": "a7a90d04e081aac7c14a326e9a40dc63e43569d1"
+  "gitHead": "53223059709e01a61635206e5f2f319896c359d3"
 }

package/rapid-identify.js

@@ -125,7 +125,26 @@ module.exports = async (params = {}) => {
   }).map((select) => {
     const { field } = select;
     const { identifier } = field.externalId;
-    const writeInValue = select.answers.reduce((v, answer) => (v || answer.writeInValue), null);
+    // A write-in is only sent for an option that currently accepts one. Omeda rejects the WHOLE
+    // rapid identification when `WriteInDesc` accompanies a value whose type is not "Other", and
+    // stored answers can carry write-ins the option no longer allows (e.g. text kept from before
+    // an option's write-in support was removed). When the field's options aren't on the user,
+    // nothing is known about them and the write-in passes through as before.
+    const writeInAllowed = (() => {
+      const options = getAsArray(field, 'options');
+      if (!options.length) return () => true;
+      const ids = new Set();
+      options.forEach((option) => {
+        if (option.canWriteIn) ids.add(`${option.id}`);
+        getAsArray(option, 'options').forEach((child) => {
+          if (child.canWriteIn) ids.add(`${child.id}`);
+        });
+      });
+      return (answer) => ids.has(`${answer.id}`);
+    })();
+    const writeInValue = select.answers.reduce((v, answer) => (
+      v || (writeInAllowed(answer) ? answer.writeInValue : null)
+    ), null);
     return {
       id: parseInt(identifier.value, 10),
       values: select.answers.map((answer) => answer.externalIdentifier).filter((v) => v),

package/test/rapid-identify.spec.js

@@ -174,6 +174,58 @@ describe('rapid-identify (idx → omeda payload)', () => {
     });
   });
 
+  describe('select write-ins', () => {
+    // AQUA "Business Type - New": the stored answer carries a write-in, but option 343 is a
+    // None-of-the-above value in Omeda and no longer accepts one.
+    const writeInSelect = ({ options, answerId = 'opt-other' } = {}) => ({
+      id: 'business',
+      hasAnswered: true,
+      answers: [{ id: answerId, externalIdentifier: '343', writeInValue: 'Manufacture' }],
+      field: {
+        id: 'business',
+        active: true,
+        externalId: {
+          id: `omeda.demographic.${BRAND}*67`,
+          namespace: { provider: 'omeda', tenant: BRAND, type: 'demographic' },
+          identifier: { value: '67', type: null },
+        },
+        ...(options && { options }),
+      },
+    });
+
+    it('drops a stored write-in when its option does not accept one', async () => {
+      const payload = await run({
+        customSelectFieldAnswers: [writeInSelect({
+          options: [{ id: 'opt-build', canWriteIn: false }, { id: 'opt-other', canWriteIn: false }],
+        })],
+      });
+      expect(payload.demographics).to.deep.equal([{ id: 67, values: ['343'] }]);
+    });
+
+    it('sends the write-in when its option accepts one', async () => {
+      const payload = await run({
+        customSelectFieldAnswers: [writeInSelect({
+          options: [{ id: 'opt-other', canWriteIn: true }],
+        })],
+      });
+      expect(payload.demographics).to.deep.equal([{ id: 67, values: ['343'], writeInValue: 'Manufacture' }]);
+    });
+
+    it('honours canWriteIn on options nested in a group', async () => {
+      const payload = await run({
+        customSelectFieldAnswers: [writeInSelect({
+          options: [{ id: 'group', options: [{ id: 'opt-other', canWriteIn: true }] }],
+        })],
+      });
+      expect(payload.demographics[0].writeInValue).to.equal('Manufacture');
+    });
+
+    it('passes the write-in through when the field options are not on the user', async () => {
+      const payload = await run({ customSelectFieldAnswers: [writeInSelect()] });
+      expect(payload.demographics[0].writeInValue).to.equal('Manufacture');
+    });
+  });
+
   describe('payload validation (the contract is enforced, not assumed)', () => {
     const expectRejects = async (opts, match) => {
       try {