@mindful-web/marko-web-identity-x 1.87.1 → 1.89.1

package/CLAUDE.md

@@ -138,6 +138,49 @@ seam Omeda uses for rapid-identify + subscription sync. **Note:** `onLogout` cur
 in the tokenless logout branch — a "fire `onLogout` always" change would let the `g_state` clear
 become a hook rather than inline route code.
 
+## Boolean questions have three states — added 2026-08
+
+`AppUserCustomBooleanFieldAnswer.answer` is a **nullable** `Boolean`, and the schema says so:
+*"A null value signifies a non answer. It's up to the implementing components to account for this."*
+`hasAnswered` is literally `answer != null`. The three states are `true`, `false`, and *never
+answered* — and on a subscription question the third is not a "no", it is silence.
+
+The write side has no null: `UpdateAppUserCustomBooleanAnswer { fieldId: String!, value: Boolean! }`
+on both identity-x and idx-compat. **Omission is the encoding for "no statement"**, and it is
+load-bearing at every layer below this package: an absent entry in the `answers` array is a no-op,
+`marko-web-omeda-identity-x/rapid-identify.js` skips `hasAnswered: false` answers *and* anything
+outside `restrictAnswersToFieldIds`, and the Omeda resolver does `if (optedIn == null) return;`.
+
+**The profile form used to break this in two places, and no longer does.**
+
+- `browser/form/fields/custom-boolean-yes-no.vue` — the profile form's subscription control. Two
+  radios, and a `null` value selects **neither**, so unanswered is visually distinct from answered-
+  no. Emits the boolean, never null: a user can move between yes and no but cannot un-answer.
+  `required` is set on both radios and the browser validates them as a group — strictly better than
+  the checkbox it replaced, which could only ever be satisfied by opting *in*.
+  `browser/profile.vue`'s `onCustomBooleanChange` **assigns** the emitted answer; it used to
+  `!answer`, which on a `null` would read a "no" click as `true`.
+- `utils/build-boolean-answers-input.js` — `routes/profile.js` used to map every rendered answer
+  with `value: Boolean(fieldAnswer.answer)` and push every field id into `submittedFieldIds`. A
+  member who opened /user/profile to fix a typo and never touched the subscription block therefore
+  sent `optedIn: false` / `Receive: 0` for every question they had never answered. The util drops
+  `answer == null` before both the mutation and `submittedFieldIds`, so the Omeda hook's
+  `restrictAnswersToFieldIds` drops them too. Spec:
+  `test/utils/build-boolean-answers-input.spec.js`.
+
+**This is fleet-wide and unconditional** — no config flag; it arrives on a `mindful-web` dep bump.
+
+**Scope is `/user/profile` only.** `custom-boolean.vue` (the checkbox) is untouched and still
+renders in `custom-column.vue` (register/login required rows), `access.vue`/`download.vue` (gating),
+and the theme's `idx-newsletter-form/*`. Those forms only ever create opt-ins on user creation, and
+a signup box reads better as a checkbox.
+
+**What this cannot fix.** For channel-backed booleans (`_kind: EMAIL|MAGAZINE`), idx-compat derives
+`answer` from the member's stored `subscriptions[].active`
+(`idx-compat/src/resolvers/app-user.ts:76-101`) — so once *any* subscription doc exists,
+`active: false` is indistinguishable from an explicit no and renders with **No** pre-selected.
+Channels have no unanswered state. This prevents new damage; it cannot un-answer history.
+
 ## Google Sign-In (One-Tap + button) — folded in 2026-07
 
 Verifies a Google Identity Services (GIS) credential server-side and drops the user into the
@@ -348,7 +391,7 @@ configurations that are each a user-facing trap:
 | Boot check | Why the runtime failure is worse than a failed deploy |
 | --- | --- |
 | `type: 'built-in'` | Unwritable ⇒ permanent gate loop. **Silent** — the only one of these with no visible symptom until a user is stuck. |
-| `type: 'custom-boolean'` | The renderer bug that once made it unsatisfiable is fixed, but the gate forces every column `required: true`, and a *required* HTML5 checkbox can only ever be submitted checked — a progressive boolean could only ever record `true`, a toll rather than an answer. Re-allow only if the gate ever supports optional columns or explicit yes/no booleans. |
+| `type: 'custom-boolean'` | The renderer bug that once made it unsatisfiable is fixed, but the gate forces every column `required: true`, and a *required* HTML5 checkbox can only ever be submitted checked — a progressive boolean could only ever record `true`, a toll rather than an answer. The profile form now uses an explicit yes/no control that would satisfy this (see *Boolean questions have three states*), but it is not wired into `custom-column.vue` and the check still stands — re-allow only once the gate actually renders that control. |
 | any other type | Falls through to `custom-column.vue`'s `<pre v-else>` debug block, printing raw field metadata to a real visitor. |
 | id missing from a non-empty `activeCustomFieldIds` | `routes/profile.js:88-104` silently discards the answer ⇒ gate loop. |
 | rows configured with no `apiToken` | Every write uses `getOrgUserApiToken()` and the form token is signed from it. |
@@ -439,8 +482,8 @@ wholesale: 18 of the first 48 production submitters on athleticbusiness had thei
 subscription killed (`Receive: 0`, "Controlled Kills") at their exact submit second — the
 2026-08-19 incident. The spec asserting the payload shape lives in
 `marko-web-omeda-identity-x/test/rapid-identify.spec.js`. The profile route (`routes/profile.js`)
-still passes booleans deliberately — its form renders the subscription checkboxes — but it shares
-the divergence exposure; see the incident follow-ups in the rollout doc.
+still passes booleans deliberately — its form renders the subscription questions — but it now only
+passes the ones the member has actually answered; see *Boolean questions have three states*.
 
 ### Bot protection — verify, then discard the write rather than the visitor
 

package/browser/form/fields/custom-boolean-yes-no.vue

@@ -0,0 +1,132 @@
+<template>
+  <form-group class-name="custom-boolean-yes-no">
+    <fieldset class="custom-boolean-yes-no__fieldset">
+      <legend class="custom-boolean-yes-no__legend">
+        <span v-html="message" />
+        <strong v-if="required" class="text-danger">*</strong>
+      </legend>
+      <div class="custom-boolean-yes-no__options">
+        <div
+          v-for="option in options"
+          :key="option.value"
+          class="custom-control custom-radio custom-control-inline"
+        >
+          <input
+            :id="`custom-boolean-${id}-${option.value}`"
+            :name="`custom-boolean-${id}`"
+            :checked="value === option.answer"
+            :disabled="disabled"
+            :required="required"
+            :value="option.value"
+            type="radio"
+            class="custom-control-input"
+            @change="$emit('input', option.answer)"
+          >
+          <label
+            class="custom-control-label"
+            :for="`custom-boolean-${id}-${option.value}`"
+          >{{ option.label }}</label>
+        </div>
+      </div>
+    </fieldset>
+  </form-group>
+</template>
+
+<script>
+import FormGroup from '../common/form-group.vue';
+
+/**
+ * An explicit yes/no answer for a boolean (subscription) question.
+ *
+ * Unlike `custom-boolean.vue` — the checkbox this replaces on the profile form — a `null` value
+ * selects NEITHER radio, so "never answered" is visually distinct from "answered no". The route
+ * then omits unanswered questions from the write rather than sending them as `false`, which is
+ * what keeps a profile save from unsubscribing someone who never touched the question.
+ *
+ * A user can move between yes and no but cannot return a question to unanswered; that is
+ * deliberate. `required` is set on both radios, which the browser validates as a group — strictly
+ * better than a required checkbox, which can only ever be satisfied by opting IN.
+ *
+ * The asterisk is inlined rather than reusing `form/common/form-label.vue`: the question here
+ * labels a radio GROUP, so it belongs in a `<legend>`, and that component always renders a
+ * `<label>` element.
+ */
+export default {
+  components: { FormGroup },
+  props: {
+    id: {
+      type: String,
+      required: true,
+    },
+    disabled: {
+      type: Boolean,
+      default: false,
+    },
+    /**
+     * `true`, `false`, or `null` when the question has never been answered.
+     * Deliberately untyped so `null` passes through without a Vue type warning.
+     */
+    value: {
+      default: null,
+      validator: (v) => v === null || typeof v === 'boolean',
+    },
+    required: {
+      type: Boolean,
+      default: false,
+    },
+    message: {
+      type: String,
+      required: true,
+    },
+    yesLabel: {
+      type: String,
+      default: 'Yes',
+    },
+    noLabel: {
+      type: String,
+      default: 'No',
+    },
+  },
+  computed: {
+    options() {
+      return [
+        { value: 'yes', answer: true, label: this.yesLabel },
+        { value: 'no', answer: false, label: this.noLabel },
+      ];
+    },
+  },
+};
+</script>
+
+<!--
+  Structural resets ship with the component, not the theme, because this renders on every theme.
+  Bootstrap Reboot styles a bare `legend` at `font-size: 1.5rem` and full width, so without these
+  a subscription question renders half again as large as the rest of the form. `theme-default`
+  (allured) has no identity-x stylesheet at all, so a theme-only rule would miss it entirely.
+  Cosmetic overrides — radio roundness, wider inline spacing — stay in theme-monorail.
+  Global rather than scoped, matching form/common/checkbox-group.vue; the class names are unique.
+-->
+<style>
+.custom-boolean-yes-no__fieldset {
+  border: 0;
+  padding: 0;
+  margin: 0;
+  min-width: 0;
+}
+.custom-boolean-yes-no__legend {
+  float: none;
+  width: auto;
+  max-width: 100%;
+  padding: 0;
+  margin-bottom: 0.25rem;
+  font-size: 1rem;
+  line-height: 1.4;
+}
+.custom-boolean-yes-no__legend strong {
+  line-height: inherit;
+}
+.custom-boolean-yes-no__options {
+  display: flex;
+  flex-wrap: wrap;
+}
+</style>

package/browser/profile.vue

@@ -173,12 +173,14 @@
             :key="fieldAnswer.id"
             class="col-12"
           >
-            <custom-boolean
+            <custom-boolean-yes-no
               :id="fieldAnswer.id"
               :message="fieldAnswer.field.label"
               :required="fieldAnswer.field.required"
               :value="fieldAnswer.answer"
-              @input="onCustomBooleanChange(fieldAnswer.id)"
+              :yes-label="translate({ key: 'Yes' })"
+              :no-label="translate({ key: 'No' })"
+              @input="onCustomBooleanChange(fieldAnswer.id, $event)"
             />
           </div>
         </div>
@@ -264,7 +266,7 @@ import regionCountryCodes from './utils/region-country-codes';
 
 import AddressBlock from './form/address-block.vue';
 import FormConsent from './form/consent.vue';
-import CustomBoolean from './form/fields/custom-boolean.vue';
+import CustomBooleanYesNo from './form/fields/custom-boolean-yes-no.vue';
 import CustomSelect from './form/fields/custom-select.vue';
 import CustomText from './form/fields/custom-text.vue';
 import GivenName from './form/fields/given-name.vue';
@@ -285,7 +287,7 @@ const { isArray } = Array;
 export default {
   components: {
     AddressBlock,
-    CustomBoolean,
+    CustomBooleanYesNo,
     CustomSelect,
     CustomText,
     GivenName,
@@ -631,9 +633,13 @@ export default {
     /**
      *
      */
-    onCustomBooleanChange(id) {
+    /**
+     * Assigns the answer the control emitted. Deliberately NOT a toggle of the stored value:
+     * the yes/no control has three input states and `!null` would read a "no" click as `true`.
+     */
+    onCustomBooleanChange(id, answer) {
       const objIndex = this.customBooleanFieldAnswers.findIndex(((obj) => obj.id === id));
-      const answer = !this.customBooleanFieldAnswers[objIndex].answer;
+      if (objIndex === -1) return;
       this.customBooleanFieldAnswers[objIndex].answer = answer;
 
       this.user.customBooleanFieldAnswers = this.customBooleanFieldAnswers;
@@ -652,6 +658,8 @@ export default {
           'To continue modifying your profile,': 'Para continuar editando seu perfil,',
           'To return to the home page, ': 'Para voltar à página inicial, ',
           'You must be logged in to modify your user profile.': 'Você precisa estar logado para modificar seu perfil de usuário.',
+          Yes: 'Sim',
+          No: 'Não',
         },
         es: {
           'An error occurred': 'Se produjo un error:',
@@ -663,6 +671,8 @@ export default {
           'To continue modifying your profile,': 'Para continuar modificando tu perfil, ',
           'To return to the home page, ': 'Para volver a la página de inicio, ',
           'You must be logged in to modify your user profile.': 'Você precisa estar logado para modificar seu perfil de usuário.',
+          Yes: 'Sí',
+          No: 'No',
         },
         en: {
           'An error occurred: ': 'An error occurred: ',
@@ -674,6 +684,8 @@ export default {
           'To continue modifying your profile,': 'To continue modifying your profile,',
           'Your profile has been saved.': 'Your profile has been saved.',
           'You must be logged in to modify your user profile.': 'You must be logged in to modify your user profile.',
+          Yes: 'Yes',
+          No: 'No',
         },
       };
       const value = (i18n[lang] && i18n[lang][key]) ? i18n[lang][key] : i18n.en[key] || '';

package/components/access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/access.marko",
     marko_component = require("./access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -53,7 +53,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/access.marko",
     component: "./access.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/comment-stream.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/comment-stream.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/comment-stream.marko",
     marko_component = require("./comment-stream.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -91,7 +91,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/comment-stream.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/comment-stream.marko",
     component: "./comment-stream.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/context.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/context.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/context.marko",
     marko_component = require("./context.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -49,7 +49,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/context.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/context.marko",
     component: "./context.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/form-access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-access.marko",
     marko_component = require("./form-access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
@@ -179,7 +179,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-access.marko",
     component: "./form-access.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-authenticate.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-authenticate.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-authenticate.marko",
     marko_component = require("./form-authenticate.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -81,7 +81,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-authenticate.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-authenticate.marko",
     component: "./form-authenticate.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-change-email.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-change-email.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-change-email.marko",
     marko_component = require("./form-change-email.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -59,7 +59,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-change-email.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-change-email.marko",
     component: "./form-change-email.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-login.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-login.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-login.marko",
     marko_component = require("./form-login.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -92,7 +92,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-login.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-login.marko",
     component: "./form-login.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-logout.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-logout.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-logout.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
     defaultValue = module_defaultValue.default || module_defaultValue,
@@ -29,7 +29,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-logout.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-logout.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko"
     ]

package/components/form-profile.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-profile.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-profile.marko",
     marko_component = require("./form-profile.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -84,7 +84,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-profile.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-profile.marko",
     component: "./form-profile.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-register.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/form-register.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/form-register.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_assign = require("marko/dist/runtime/helpers/assign"),
     marko_web_identity_x_form_login_template = require("./form-login.marko"),
@@ -25,7 +25,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/form-register.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/form-register.marko",
     tags: [
       "./form-login.marko"
     ]

package/components/google-init.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/google-init.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/google-init.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_attr = require("marko/dist/runtime/html/helpers/attr"),
     marko_str = require("marko/dist/runtime/helpers/to-string");
@@ -239,5 +239,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/google-init.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/google-init.marko"
   };

package/components/google-sign-in-button.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/google-sign-in-button.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/google-sign-in-button.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     helpers_escape_xml = require("marko/dist/runtime/html/helpers/escape-xml"),
     marko_escapeXml = helpers_escape_xml.x,
@@ -40,5 +40,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/google-sign-in-button.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/google-sign-in-button.marko"
   };

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -50,7 +50,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-gtm/components/push.marko",

package/components/non-auth-identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/non-auth-identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/non-auth-identify.marko",
     marko_component = require("./non-auth-identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -45,7 +45,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/non-auth-identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/non-auth-identify.marko",
     component: "./non-auth-identify.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/progressive-profile-form.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/progressive-profile-form.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/progressive-profile-form.marko",
     marko_component = require("./progressive-profile-form.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
@@ -137,7 +137,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/progressive-profile-form.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/progressive-profile-form.marko",
     component: "./progressive-profile-form.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/subscribe.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.87.1/components/subscribe.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.89.1/components/subscribe.marko",
     marko_component = require("./subscribe.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -73,7 +73,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.87.1/components/subscribe.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.89.1/components/subscribe.marko",
     component: "./subscribe.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-identity-x",
-  "version": "1.87.1",
+  "version": "1.89.1",
   "description": "Marko Wrapper for IdentityX",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -43,5 +43,5 @@
     "chai": "^4.3.7",
     "mocha": "^6.2.3"
   },
-  "gitHead": "c9fef30dc3d3dbf2c538e3850fae61f629b8791d"
+  "gitHead": "4d832561c21206813db5d5f53bc275503cbefe35"
 }

package/routes/profile.js

@@ -3,6 +3,7 @@ const { asyncRoute } = require('@mindful-web/utils');
 const { getAsArray, getAsObject } = require('@mindful-web/object-path');
 const userFragment = require('../api/fragments/active-user');
 const callHooksFor = require('../utils/call-hooks-for');
+const buildBooleanAnswersInput = require('../utils/build-boolean-answers-input');
 const overlaySubmittedBooleanAnswers = require('../utils/overlay-submitted-boolean-answers');
 
 const mutation = gql`
@@ -125,18 +126,18 @@ module.exports = asyncRoute(async (req, res) => {
   // guards against).
   const submittedBooleanValues = new Map();
 
-  if (customBooleanFieldAnswers.length) {
+  // An answer can be true, false or null. A null is a NON-answer and is DROPPED here rather than
+  // written as `false` — see build-boolean-answers-input for why that distinction is the whole
+  // difference between "the user said no" and "we unsubscribed someone who never answered".
+  // Unanswered ids never reach `submittedFieldIds` either, so the Omeda hook's
+  // `restrictAnswersToFieldIds` drops them from rapid-identify too.
+  const customBooleanFieldsInput = buildBooleanAnswersInput(
+    customBooleanFieldAnswers,
+    customFieldIds,
+  );
+
+  if (customBooleanFieldsInput.length) {
     // only update custom questions when there some :)
-    const customBooleanFieldsInput = customBooleanFieldAnswers.map((fieldAnswer) => ({
-      fieldId: fieldAnswer.field.id,
-      // can either be true, false or null. convert null to false.
-      // the form submit is effectively answers the question.
-      value: Boolean(fieldAnswer.answer),
-    })).filter(
-      customFieldIds.length > 0
-        ? ({ fieldId }) => customFieldIds.includes(fieldId)
-        : () => true,
-    );
     submittedFieldIds.push(...customBooleanFieldsInput.map(({ fieldId }) => fieldId));
     customBooleanFieldsInput.forEach(({ fieldId, value }) => {
       submittedBooleanValues.set(fieldId, value);

package/test/utils/build-boolean-answers-input.spec.js

@@ -0,0 +1,62 @@
+const { describe, it } = require('mocha');
+const { expect } = require('chai');
+const build = require('../../utils/build-boolean-answers-input');
+
+const answer = ({ id, value = null }) => ({
+  id: `ans-${id}`,
+  hasAnswered: value != null,
+  answer: value,
+  value,
+  field: { id, active: true },
+});
+
+describe('utils/build-boolean-answers-input', () => {
+  it('omits an unanswered question rather than writing it as false', () => {
+    // The whole point: this is what stops /user/profile from unsubscribing someone who never
+    // touched the subscription block.
+    expect(build([answer({ id: 'chan-mag' })])).to.deep.equal([]);
+  });
+
+  it('preserves an explicit no as false', () => {
+    expect(build([answer({ id: 'chan-mag', value: false })]))
+      .to.deep.equal([{ fieldId: 'chan-mag', value: false }]);
+  });
+
+  it('preserves an explicit yes as true', () => {
+    expect(build([answer({ id: 'chan-mag', value: true })]))
+      .to.deep.equal([{ fieldId: 'chan-mag', value: true }]);
+  });
+
+  it('keeps answered questions when mixed with unanswered ones', () => {
+    const answers = [
+      answer({ id: 'a', value: true }),
+      answer({ id: 'b' }),
+      answer({ id: 'c', value: false }),
+    ];
+    expect(build(answers)).to.deep.equal([
+      { fieldId: 'a', value: true },
+      { fieldId: 'c', value: false },
+    ]);
+  });
+
+  it('applies the writable field id allowlist', () => {
+    const answers = [answer({ id: 'a', value: true }), answer({ id: 'b', value: false })];
+    expect(build(answers, ['b'])).to.deep.equal([{ fieldId: 'b', value: false }]);
+  });
+
+  it('writes every answered field when the allowlist is empty', () => {
+    const answers = [answer({ id: 'a', value: true }), answer({ id: 'b', value: false })];
+    expect(build(answers, [])).to.have.lengthOf(2);
+  });
+
+  it('ignores answers carrying no field', () => {
+    expect(build([{ answer: true }, answer({ id: 'a', value: true })]))
+      .to.deep.equal([{ fieldId: 'a', value: true }]);
+  });
+
+  it('returns an empty array for missing or empty input', () => {
+    expect(build()).to.deep.equal([]);
+    expect(build(null)).to.deep.equal([]);
+    expect(build([])).to.deep.equal([]);
+  });
+});

package/utils/build-boolean-answers-input.js

@@ -0,0 +1,32 @@
+/**
+ * Marshals submitted boolean field answers into `UpdateAppUserCustomBooleanAnswer` input.
+ *
+ * A boolean answer has THREE states, not two: `true`, `false`, and `null` (never answered —
+ * `hasAnswered` is `answer != null`). This drops the third rather than collapsing it to `false`.
+ *
+ * Why that matters: an unanswered question written as `false` is a *statement*. The profile route
+ * feeds its returned field ids to `onUserProfileUpdate` as `restrictAnswersToFieldIds`, and
+ * `marko-web-omeda-identity-x/rapid-identify.js` turns a deployment-type boolean into
+ * `optedIn: false` and a product boolean into `receive: false` (`Receive: 0`, a Controlled Kill).
+ * So a member who opened /user/profile to fix a typo and never touched the subscription block
+ * would unsubscribe themselves from every question they had never answered.
+ *
+ * Omission is the supported encoding for "no statement" at every layer below this one: the
+ * mutation input is `value: Boolean!` (there is no null to send), an absent entry in the `answers`
+ * array is a no-op, rapid-identify skips anything outside `restrictAnswersToFieldIds`, and the
+ * Omeda resolver does `if (optedIn == null) return;`.
+ *
+ * @param {object[]} answers The posted `customBooleanFieldAnswers`.
+ * @param {string[]} [customFieldIds] When non-empty, the allowlist of writable field ids.
+ * @returns {{ fieldId: string, value: boolean }[]} Answered, writable answers only.
+ */
+module.exports = (answers, customFieldIds = []) => (Array.isArray(answers) ? answers : [])
+  // A null answer is a NON-answer. Never coerce it to `false`.
+  .filter((fieldAnswer) => fieldAnswer && fieldAnswer.field && fieldAnswer.answer != null)
+  .map((fieldAnswer) => ({
+    fieldId: fieldAnswer.field.id,
+    value: Boolean(fieldAnswer.answer),
+  }))
+  .filter(customFieldIds.length > 0
+    ? ({ fieldId }) => customFieldIds.includes(fieldId)
+    : () => true);