@mindful-web/marko-web-identity-x 1.85.2 → 1.85.4

package/CLAUDE.md

@@ -348,7 +348,7 @@ configurations that are each a user-facing trap:
 | Boot check | Why the runtime failure is worse than a failed deploy |
 | --- | --- |
 | `type: 'built-in'` | Unwritable ⇒ permanent gate loop. **Silent** — the only one of these with no visible symptom until a user is stuck. |
-| `type: 'custom-boolean'` | `custom-column.vue` binds the checkbox to `customField.answer` but its handler writes `customField.value`, so a *required* checkbox can never be checked. The diff util, payload builder and mutation all handle booleans correctly — only the shared renderer does not. Re-allow once that is fixed. |
+| `type: 'custom-boolean'` | The renderer bug that once made it unsatisfiable is fixed, but the gate forces every column `required: true`, and a *required* HTML5 checkbox can only ever be submitted checked — a progressive boolean could only ever record `true`, a toll rather than an answer. Re-allow only if the gate ever supports optional columns or explicit yes/no booleans. |
 | any other type | Falls through to `custom-column.vue`'s `<pre v-else>` debug block, printing raw field metadata to a real visitor. |
 | id missing from a non-empty `activeCustomFieldIds` | `routes/profile.js:88-104` silently discards the answer ⇒ gate loop. |
 | rows configured with no `apiToken` | Every write uses `getOrgUserApiToken()` and the form token is signed from it. |
@@ -358,11 +358,11 @@ No coverage is lost: every field the fleet-wide impact analysis measured is a se
 ### Files
 
 - `utils/get-missing-progressive-fields.js` — the diff. Matches on **`answer.field.id`**, never
-  `answer.id`. That distinction is the whole reason this feature does not reuse
-  `get-form-custom-fields.js` (or `config.getGTMUserData`): an idx answer's `id` is the *answer's*
-  id, so comparing it to a configured field id never matches, and the truthy-empty-array bug that
-  follows returns an answer object with no `field`. Returns `missingRows` with every column forced
-  `required: true`, so `custom-column.vue` needs no changes.
+  `answer.id`. That distinction is why this feature did not reuse `get-form-custom-fields.js`
+  (or `config.getGTMUserData`) at ship time: that util keyed on the answer's own `id` and its
+  truthy-empty-array check returned answer objects with no `field` — both fixed in
+  mindful-web#324, but the dedicated util stays (it also forces every column `required: true` in
+  the `missingRows` it returns, so `custom-column.vue` needs no changes).
 - `utils/get-progressive-form-fields.js` — correct, feature-scoped replacement for
   `get-form-custom-fields.js`. Stamps `id` with the **field** id, which is the contract
   `custom-column.vue` reads and what `get-create-user-custom-fields.js` already emits.
@@ -612,18 +612,19 @@ reaches the bridge. The content entity is passed as `emit`'s third argument inst
 Submitted **answer values are never tracked** anywhere — `fieldKeys` and the member-event's
 `fieldIds` record which questions were asked, nothing more.
 
-### Two live follow-ups, neither in this package
-
-1. 🔴 **Index drop/recreate, production.** `completed_auth_date_website_channel` and
-   `completed_auth_email_website_channel` had their `partialFilterExpression` widened; a changed
-   partial filter does not alter an index in place, so both must be dropped and recreated. Until
-   then progressive-profiling `member-events` queries collection-scan. Owner: audience/infra.
-2. **The shared-code PR.** `get-form-custom-fields.js`, the commented-out `custom-boolean` branches
-   in `generate-required-field-payload.js`, the `routes/profile.js` allowlist, `custom-column.vue`'s
-   boolean binding, and the p1events bridge's `contentGatingType`/`contentGateType` mismatch (every
-   producer in the fleet sets the latter, so gate type has **never** reached p1events for any
-   gate). All shared with live flows across 18 repos — deliberately not fixed alongside a new
-   feature.
+### Follow-ups — both resolved 2026-08-15
+
+1. ✅ **Index drop/recreate, production** — done. Both `completed_auth_*` indexes in production
+   carry `PROGRESSIVE_PROFILE_SUBMIT` in their partial filters (verified on `audience:abmedia`
+   and `audience:transpire`).
+2. ✅ **The shared-code PR** — landed as mindful-web#324 (this package: `get-form-custom-fields.js`
+   field-id keying, `custom-column.vue` boolean binding, `routes/profile.js` allowlist,
+   `generate-required-field-payload.js` boolean branches + `hasAnswered` false-boolean fix) and
+   mindful-web#325 (the p1events bridge's `contentGatingType`→`contentGateType` rename — the gate
+   type had never reached p1events on any conversion event). The allured copied-meter frozen-clock
+   bug went separately as allured-business-media-websites#461. Progressive-profile field rows
+   still exclude `custom-boolean` — no longer for the renderer bug, but because the gate forces
+   required columns and a required checkbox can only submit `true` (see the boot-check table).
 
 ## Fleet / rollout
 

package/browser/custom-column.vue

@@ -353,9 +353,14 @@ export default {
     /**
      *
      */
-    onCustomBooleanChange(field) {
+    onCustomBooleanChange(field, checked) {
+      // `.answer` is canonical (it's what the template binds and what `routes/profile.js`
+      // reads); `.value` is kept in sync because the payload builders read it. Assign from the
+      // emitted event rather than toggling, so the model can never invert against the checkbox.
       // eslint-disable-next-line no-param-reassign
-      field.value = !field.value;
+      field.answer = checked;
+      // eslint-disable-next-line no-param-reassign
+      field.value = checked;
       // eslint-disable-next-line no-param-reassign
       field.hasAnswered = true;
       this.user.customBooleanFieldAnswers = this.customBooleanFieldAnswers;

package/components/access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/access.marko",
     marko_component = require("./access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -53,7 +53,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/access.marko",
     component: "./access.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/comment-stream.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/comment-stream.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/comment-stream.marko",
     marko_component = require("./comment-stream.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -91,7 +91,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/comment-stream.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/comment-stream.marko",
     component: "./comment-stream.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/context.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/context.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/context.marko",
     marko_component = require("./context.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -49,7 +49,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/context.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/context.marko",
     component: "./context.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/form-access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-access.marko",
     marko_component = require("./form-access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
@@ -179,7 +179,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-access.marko",
     component: "./form-access.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-authenticate.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-authenticate.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-authenticate.marko",
     marko_component = require("./form-authenticate.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -81,7 +81,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-authenticate.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-authenticate.marko",
     component: "./form-authenticate.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-change-email.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-change-email.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-change-email.marko",
     marko_component = require("./form-change-email.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -59,7 +59,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-change-email.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-change-email.marko",
     component: "./form-change-email.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-login.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-login.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-login.marko",
     marko_component = require("./form-login.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -92,7 +92,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-login.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-login.marko",
     component: "./form-login.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-logout.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-logout.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-logout.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
     defaultValue = module_defaultValue.default || module_defaultValue,
@@ -29,7 +29,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-logout.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-logout.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko"
     ]

package/components/form-profile.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-profile.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-profile.marko",
     marko_component = require("./form-profile.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -84,7 +84,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-profile.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-profile.marko",
     component: "./form-profile.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-register.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/form-register.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/form-register.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_assign = require("marko/dist/runtime/helpers/assign"),
     marko_web_identity_x_form_login_template = require("./form-login.marko"),
@@ -25,7 +25,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/form-register.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/form-register.marko",
     tags: [
       "./form-login.marko"
     ]

package/components/google-init.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/google-init.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/google-init.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_attr = require("marko/dist/runtime/html/helpers/attr"),
     marko_str = require("marko/dist/runtime/helpers/to-string");
@@ -239,5 +239,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/google-init.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/google-init.marko"
   };

package/components/google-sign-in-button.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/google-sign-in-button.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/google-sign-in-button.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     helpers_escape_xml = require("marko/dist/runtime/html/helpers/escape-xml"),
     marko_escapeXml = helpers_escape_xml.x,
@@ -40,5 +40,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/google-sign-in-button.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/google-sign-in-button.marko"
   };

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -50,7 +50,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-gtm/components/push.marko",

package/components/non-auth-identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/non-auth-identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/non-auth-identify.marko",
     marko_component = require("./non-auth-identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -45,7 +45,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/non-auth-identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/non-auth-identify.marko",
     component: "./non-auth-identify.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/progressive-profile-form.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/progressive-profile-form.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/progressive-profile-form.marko",
     marko_component = require("./progressive-profile-form.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
@@ -137,7 +137,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/progressive-profile-form.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/progressive-profile-form.marko",
     component: "./progressive-profile-form.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/subscribe.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.2/components/subscribe.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.85.4/components/subscribe.marko",
     marko_component = require("./subscribe.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -73,7 +73,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.85.2/components/subscribe.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.85.4/components/subscribe.marko",
     component: "./subscribe.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/config.js

@@ -15,12 +15,12 @@ const { log } = console;
  *   attributes-only (core/root member fields were cut on review), so a built-in column renders,
  *   accepts a value, and is then silently dropped: the user submits, gets `changed: false`, and is
  *   re-gated forever. This is the only one of these checks whose runtime failure is *silent*.
- * - **`custom-boolean` is unsatisfiable.** `custom-column.vue` binds the checkbox to
- *   `customField.answer` but its change handler writes `customField.value`, so the box never
- *   registers as checked — and a *required* checkbox that cannot be checked traps the user behind
- *   HTML5 validation. The diff util, the payload builder and the mutation all handle booleans
- *   correctly; only the shared renderer does not, and that is fixed in the separate shared-code
- *   PR rather than here. Remove `custom-boolean` from this list once it is.
+ * - **`custom-boolean` is semantically useless here.** The renderer bug that once made it
+ *   unsatisfiable (custom-column.vue read `.answer` but wrote `.value`) is fixed, and the diff
+ *   util, payload builder, and mutation all handle booleans — but the gate forces every column
+ *   `required: true`, and a *required* HTML5 checkbox can only ever be submitted checked. A
+ *   progressive boolean could therefore only ever record `true`, which is not an answer, it's a
+ *   toll. Re-allow only if the gate ever supports optional columns or explicit yes/no booleans.
  *
  * No coverage is lost: every field the fleet-wide impact analysis measured is a select attribute.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-identity-x",
-  "version": "1.85.2",
+  "version": "1.85.4",
   "description": "Marko Wrapper for IdentityX",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -10,7 +10,7 @@
     "lint": "eslint --ext .js --ext .vue --max-warnings 5 ./",
     "compile": "mindful-web-marko-compile compile",
     "prepublish": "yarn compile --silent",
-    "test": "yarn compile --no-clean && yarn lint"
+    "test": "yarn compile --no-clean && yarn lint && mocha --reporter spec"
   },
   "dependencies": {
     "@mindful-web/marko-web-gtm": "^1.83.1",
@@ -39,5 +39,9 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "96764a47941171b3da9865ac201c891494926f37"
+  "devDependencies": {
+    "chai": "^4.3.7",
+    "mocha": "^6.2.3"
+  },
+  "gitHead": "e793692becf12f650680a93a12f36f227aaace30"
 }

package/routes/change-email-confirm.js

@@ -41,6 +41,8 @@ module.exports = asyncRoute(async (req, res) => {
 
   const decoded = await jwt.decode(token);
   await callHooksFor(identityX, 'onChangeEmailSuccess', {
+    req,
+    res,
     user,
     oldEmail: get(decoded, 'data.email'),
   });

package/routes/profile.js

@@ -85,13 +85,17 @@ module.exports = asyncRoute(async (req, res) => {
     receiveEmail,
   };
 
-  // get identity-x.forms custom-select question ids to append to ActiveCustomQuestionIds
+  // get identity-x.forms custom question ids to append to ActiveCustomQuestionIds
   const customFormFieldIds = Object.values(getAsObject(identityX, 'config.options.forms')).reduce((questions, form) => {
     // loop over the fieldRows
     getAsArray(form, 'fieldRows').forEach((row) => row.forEach((question) => {
-      // push the custom-select form being used with those forms to acceptable profile inputs
-      // @todo figure out if other types should also make it... custom-boolean specifically.
-      if (question.type === 'custom-select') questions.push(question.id);
+      // Every custom question a form renders must be writable on submit. This list filters all
+      // three answer mutations below, so omitting a type here (custom-select-only, previously)
+      // silently discarded that form's boolean/text answers unless the site also listed the id
+      // in `activeCustomFieldIds`.
+      if (question.id && typeof question.type === 'string' && question.type.startsWith('custom-')) {
+        questions.push(question.id);
+      }
     }));
     return questions;
   }, []);

package/test/mocha.opts

@@ -0,0 +1,2 @@
+--recursive
+--timeout 2000

package/test/utils/generate-required-field-payload.spec.js

@@ -0,0 +1,92 @@
+const { describe, it } = require('mocha');
+const { expect } = require('chai');
+const generate = require('../../utils/generate-required-field-payload');
+
+const boolDef = {
+  type: 'custom-boolean', id: 'bool-1', key: 'bool-1', required: true,
+};
+const selectDef = {
+  type: 'custom-select', id: 'select-1', key: 'select-1', required: true,
+};
+
+const boolAnswer = (answer, { fieldId = 'bool-1', hasAnswered = true } = {}) => ({
+  id: fieldId, hasAnswered, answer, value: answer, field: { id: fieldId },
+});
+const selectAnswer = (optionIds, { fieldId = 'select-1' } = {}) => ({
+  id: fieldId,
+  hasAnswered: Boolean(optionIds.length),
+  answers: optionIds.map((id) => ({ id })),
+  field: { id: fieldId },
+});
+
+describe('utils/generate-required-field-payload', () => {
+  describe('required custom-boolean fields', () => {
+    it('should treat an answered `false` as answered', () => {
+      const out = generate({
+        appUser: { customBooleanFieldAnswers: [boolAnswer(false)] },
+        body: {},
+        definitions: [boolDef],
+      });
+      expect(out.appUserHasAllRequiredFields).to.equal(true);
+      expect(out.hasAllRequiredFields).to.equal(true);
+    });
+
+    it('should treat an unanswered boolean as missing', () => {
+      const out = generate({
+        appUser: { customBooleanFieldAnswers: [boolAnswer(null, { hasAnswered: false })] },
+        body: {},
+        definitions: [boolDef],
+      });
+      expect(out.appUserHasAllRequiredFields).to.equal(false);
+      expect(out.hasAllRequiredFields).to.equal(false);
+    });
+
+    it('should satisfy requirements from the submitted body and build the payload', () => {
+      const out = generate({
+        appUser: {},
+        body: { customBooleanFieldAnswers: [boolAnswer(true)] },
+        definitions: [boolDef],
+      });
+      expect(out.appUserHasAllRequiredFields).to.equal(false);
+      expect(out.hasAllRequiredFields).to.equal(true);
+      expect(out.payload.customBooleanFieldAnswers).to.deep.equal([
+        { fieldId: 'bool-1', value: true },
+      ]);
+    });
+
+    it('should carry a submitted `false` into the payload as false', () => {
+      const out = generate({
+        appUser: {},
+        body: { customBooleanFieldAnswers: [boolAnswer(false)] },
+        definitions: [boolDef],
+      });
+      expect(out.hasAllRequiredFields).to.equal(true);
+      expect(out.payload.customBooleanFieldAnswers).to.deep.equal([
+        { fieldId: 'bool-1', value: false },
+      ]);
+    });
+  });
+
+  describe('required custom-select fields (existing behavior preserved)', () => {
+    it('should treat an empty answers array as unanswered', () => {
+      const out = generate({
+        appUser: { customSelectFieldAnswers: [selectAnswer([])] },
+        body: {},
+        definitions: [selectDef],
+      });
+      expect(out.appUserHasAllRequiredFields).to.equal(false);
+    });
+
+    it('should satisfy from the app user and exclude satisfied fields from the body payload', () => {
+      const out = generate({
+        appUser: { customSelectFieldAnswers: [selectAnswer(['opt-1'])] },
+        body: {},
+        definitions: [selectDef],
+      });
+      expect(out.appUserHasAllRequiredFields).to.equal(true);
+      expect(out.payload.customSelectFieldAnswers).to.deep.equal([
+        { fieldId: 'select-1', optionIds: ['opt-1'], writeInValues: [] },
+      ]);
+    });
+  });
+});

package/test/utils/get-form-custom-fields.spec.js

@@ -0,0 +1,76 @@
+const { describe, it } = require('mocha');
+const { expect } = require('chai');
+const getFormCustomFields = require('../../utils/get-form-custom-fields');
+
+const fields = [
+  { id: 'bool-field-1', __typename: 'BooleanField', label: 'Opt in?' },
+  { id: 'select-field-1', __typename: 'SelectField', label: 'Title' },
+  { id: 'text-field-1', __typename: 'TextField', label: 'Nickname' },
+];
+const fieldRows = [[{ id: 'bool-field-1' }, { id: 'select-field-1' }, { id: 'text-field-1' }]];
+
+describe('utils/get-form-custom-fields', () => {
+  it('should return unanswered stubs carrying the field id when there is no user', () => {
+    const out = getFormCustomFields({ fields, fieldRows, user: null });
+    expect(out.customBooleanFieldAnswers).to.deep.equal([
+      {
+        id: 'bool-field-1', hasAnswered: false, answer: null, value: null, field: fields[0],
+      },
+    ]);
+    expect(out.customSelectFieldAnswers[0]).to.include({ id: 'select-field-1', hasAnswered: false });
+    expect(out.customTextFieldAnswers[0]).to.include({ id: 'text-field-1', hasAnswered: false });
+  });
+
+  it('should key user answers by field.id, not the answer document id', () => {
+    const user = {
+      customBooleanFieldAnswers: [],
+      customSelectFieldAnswers: [
+        // `id` here is an answer-document id that does NOT equal the field id.
+        {
+          id: 'answer-doc-9', hasAnswered: true, answers: [{ id: 'opt-1' }], field: { id: 'select-field-1' },
+        },
+      ],
+      customTextFieldAnswers: [],
+    };
+    const out = getFormCustomFields({ fields, fieldRows, user });
+    const [select] = out.customSelectFieldAnswers;
+    expect(select.hasAnswered).to.equal(true);
+    expect(select.answers).to.deep.equal([{ id: 'opt-1' }]);
+    // Normalized for custom-column.vue, which finds answers via `ans.id === fieldId`.
+    expect(select.id).to.equal('select-field-1');
+    expect(select.field).to.equal(fields[1]);
+  });
+
+  it('should return an unanswered stub (not an empty object) when the user has no matching answer', () => {
+    const user = {
+      customBooleanFieldAnswers: [
+        {
+          id: 'other', hasAnswered: true, answer: true, field: { id: 'some-other-field' },
+        },
+      ],
+      customSelectFieldAnswers: [],
+      customTextFieldAnswers: [],
+    };
+    const out = getFormCustomFields({ fields, fieldRows, user });
+    const [bool] = out.customBooleanFieldAnswers;
+    expect(bool.id).to.equal('bool-field-1');
+    expect(bool.hasAnswered).to.equal(false);
+    expect(bool.field).to.equal(fields[0]);
+  });
+
+  it('should preserve a false boolean answer', () => {
+    const user = {
+      customBooleanFieldAnswers: [
+        {
+          id: 'bool-field-1', hasAnswered: true, answer: false, value: false, field: { id: 'bool-field-1' },
+        },
+      ],
+      customSelectFieldAnswers: [],
+      customTextFieldAnswers: [],
+    };
+    const out = getFormCustomFields({ fields, fieldRows, user });
+    const [bool] = out.customBooleanFieldAnswers;
+    expect(bool.hasAnswered).to.equal(true);
+    expect(bool.answer).to.equal(false);
+  });
+});

package/utils/generate-required-field-payload.js

@@ -1,7 +1,13 @@
 const { get } = require('@mindful-web/object-path');
 
-// eslint-disable-next-line max-len
-const hasAnswered = (ans) => ans && ans.hasAnswered && (ans.value || (ans.answers && ans.answers.length));
+const hasAnswered = (ans) => {
+  if (!ans || !ans.hasAnswered) return false;
+  // A boolean field is answered by having been answered — `false` is a legitimate value that
+  // must not read as missing, so never truth-test it. Boolean answers carry a boolean
+  // `answer`/`value`; selects carry `answers`, texts a string `value`.
+  if (typeof ans.answer === 'boolean' || typeof ans.value === 'boolean') return true;
+  return Boolean(ans.value || (ans.answers && ans.answers.length));
+};
 
 const hasMappedAnswers = (map) => (id) => {
   const ans = map.get(id);
@@ -40,10 +46,10 @@ module.exports = ({ appUser, body, definitions }) => {
 
   const requiredFieldKeys = [...requiredFieldKeySet];
 
-  // const requiredCustomBooleans = [...definitions.reduce((set, def) => {
-  //   if (def.type === 'custom-boolean' && def.required) set.add(def.id);
-  //   return set;
-  // }, new Set())];
+  const requiredCustomBooleans = [...definitions.reduce((set, def) => {
+    if (def.type === 'custom-boolean' && def.required) set.add(def.id);
+    return set;
+  }, new Set())];
 
   const requiredCustomSelects = [...definitions.reduce((set, def) => {
     if (def.type === 'custom-select' && def.required) set.add(def.id);
@@ -56,15 +62,15 @@ module.exports = ({ appUser, body, definitions }) => {
   }, new Set())];
 
   const userCustomFieldAnswers = new Map([
-    // ...(get(appUser, 'customBooleanFieldAnswers') || []).map((a) => [a.field.id, a]),
+    ...(get(appUser, 'customBooleanFieldAnswers') || []).map((a) => [a.field.id, a]),
     ...(get(appUser, 'customSelectFieldAnswers') || []).map((a) => [a.field.id, a]),
     ...(get(appUser, 'customTextFieldAnswers') || []).map((a) => [a.field.id, a]),
   ]);
 
   const customFieldAnswers = new Map([
     ...userCustomFieldAnswers,
-    // ...(get(body, 'customBooleanFieldAnswers') || [])
-    //   .filter(hasAnswered).map((a) => [a.field.id, a]),
+    ...(get(body, 'customBooleanFieldAnswers') || [])
+      .filter(hasAnswered).map((a) => [a.field.id, a]),
     ...(get(body, 'customSelectFieldAnswers') || []).filter(hasAnswered).map((a) => [a.field.id, a]),
     ...(get(body, 'customTextFieldAnswers') || [])
       .filter(hasAnswered).map((a) => [a.field.id, a]),
@@ -74,9 +80,7 @@ module.exports = ({ appUser, body, definitions }) => {
     requiredFieldKeys.every(
       (key) => get(appUser, key),
     ),
-    // requiredCustomBooleans.every(
-    //   (id) => userCustomFieldAnswers.has(id) && userCustomFieldAnswers.get(id).hasAnswered,
-    // ),
+    requiredCustomBooleans.every(hasMappedAnswers(userCustomFieldAnswers)),
     requiredCustomSelects.every(hasMappedAnswers(userCustomFieldAnswers)),
     requiredCustomTexts.every(
       (id) => userCustomFieldAnswers.has(id) && userCustomFieldAnswers.get(id).hasAnswered,
@@ -87,14 +91,23 @@ module.exports = ({ appUser, body, definitions }) => {
     requiredFieldKeys.every(
       (key) => get(appUser, key) || get(body, key),
     ),
-    // requiredCustomBooleans.every(hasMappedAnswers(customFieldAnswers)),
+    requiredCustomBooleans.every(hasMappedAnswers(customFieldAnswers)),
     requiredCustomSelects.every(hasMappedAnswers(customFieldAnswers)),
     requiredCustomTexts.every(hasMappedAnswers(customFieldAnswers)),
   ].every((v) => v);
 
   const payload = {
     ...(requiredFieldKeys.reduce((obj, key) => ({ ...obj, [key]: body[key] }), {})),
-    // customBooleanFieldAnswers: [], // @todo
+    customBooleanFieldAnswers: requiredCustomBooleans
+      .filter(hasMappedAnswers(customFieldAnswers))
+      .map((id) => {
+        const answer = customFieldAnswers.get(id);
+        return {
+          fieldId: answer.field.id,
+          // `.answer` is canonical (what the profile route reads); fall back to `.value`.
+          value: Boolean(typeof answer.answer === 'boolean' ? answer.answer : answer.value),
+        };
+      }),
     customSelectFieldAnswers: requiredCustomSelects
       .filter(hasMappedAnswers(customFieldAnswers))
       .map((id) => {

package/utils/get-form-custom-fields.js

@@ -11,44 +11,35 @@ module.exports = ({
     });
   });
 
+  // A user answer is keyed by its `field.id` — never the answer's own `id`, which some backends
+  // set to the answer document id. The returned object always carries `id` = the field id and
+  // `field` = the form's field definition, because `custom-column.vue` finds answers via
+  // `ans.id === fieldId` and renders from `customField.field`.
+  const findUserAnswer = (answers, f) => {
+    const found = (answers || []).find((a) => a && a.field && a.field.id === f.id);
+    return found ? { ...found, id: f.id, field: f } : null;
+  };
+
   // eslint-disable-next-line no-underscore-dangle
   const customBooleanFieldAnswers = fieldRowFields.filter((f) => f.__typename === 'BooleanField').map((f) => {
-    if (user) {
-      const userAnswer = user.customBooleanFieldAnswers.filter(({ id }) => id === f.id);
-      if (userAnswer) {
-        return ({
-          ...userAnswer[0],
-        });
-      }
-    }
+    const userAnswer = user ? findUserAnswer(user.customBooleanFieldAnswers, f) : null;
+    if (userAnswer) return userAnswer;
     return ({
       id: f.id, hasAnswered: false, answer: null, value: null, field: f,
     });
   });
-  // eslint-disable-next-line no-underscore-dangle, eqeqeq
-  const customSelectFieldAnswers = fieldRowFields.filter((f) => f.__typename == 'SelectField').map((f) => {
-    if (user) {
-      const userAnswer = user.customSelectFieldAnswers.filter(({ id }) => id === f.id);
-      if (userAnswer) {
-        return ({
-          ...userAnswer[0],
-        });
-      }
-    }
+  // eslint-disable-next-line no-underscore-dangle
+  const customSelectFieldAnswers = fieldRowFields.filter((f) => f.__typename === 'SelectField').map((f) => {
+    const userAnswer = user ? findUserAnswer(user.customSelectFieldAnswers, f) : null;
+    if (userAnswer) return userAnswer;
     return ({
       id: f.id, hasAnswered: false, answers: [], field: f,
     });
   });
-  // eslint-disable-next-line no-underscore-dangle, eqeqeq
-  const customTextFieldAnswers = fieldRowFields.filter((f) => f.__typename == 'TextField').map((f) => {
-    if (user) {
-      const userAnswer = user.customTextFieldAnswers.filter(({ id }) => id === f.id);
-      if (userAnswer) {
-        return ({
-          ...userAnswer[0],
-        });
-      }
-    }
+  // eslint-disable-next-line no-underscore-dangle
+  const customTextFieldAnswers = fieldRowFields.filter((f) => f.__typename === 'TextField').map((f) => {
+    const userAnswer = user ? findUserAnswer(user.customTextFieldAnswers, f) : null;
+    if (userAnswer) return userAnswer;
     return ({
       id: f.id, hasAnswered: false, value: null, field: f,
     });