@mindful-web/marko-web-identity-x 1.80.2 → 1.80.3

package/CLAUDE.md

@@ -184,9 +184,26 @@ simply cannot authorize this mutation, and the fix is to stop using it — backf
 via `setUnverifiedAppUserData` (org-token, but writes *unverified* data, so it is a semantic change
 worth deciding deliberately).
 
-`idxGoogleStepMs` records elapsed ms at the start of each step, making the route self-profiling:
-`FACET idxGoogleStep SELECT max(idxGoogleStepMs)` shows where the ~12s on a *successful* sign-in
-goes, and a request that dies mid-flight still reports how far it got. Responds `{ ok, requiresUserInput,
+**Timing comes in two parts, deliberately.** `idxGoogleStepMs` is elapsed-at-last-step and
+**last-write-wins** — on a completed request it is effectively total route time, and on one that dies
+mid-flight it says how far in it got. It cannot attribute time to a step: every `setStep` overwrites
+it, which is why the per-step breakdown it was originally meant to provide never actually survived
+(confirmed in production — the query returned one value per transaction, not a profile).
+
+`idxMs<Step>` is the real breakdown: one attribute per step (`idxMsVerifyCredential`,
+`idxMsImpersonateAppUser`, `idxMsHooksLoginLinkSent`, `idxMsHooksAuthenticationSuccess`, …), each
+holding how long **that step** took, emitted when the next step begins. `complete` has no duration of
+its own — it is a marker, not work. The durations sum to `idxGoogleStepMs`. About ten attributes, well
+inside New Relic's per-transaction budget.
+
+```
+SELECT average(idxMsHooksAuthenticationSuccess), average(idxMsImpersonateAppUser),
+       average(idxMsHooksLoginLinkSent), average(idxGoogleStepMs)
+FROM Transaction WHERE name LIKE '%__idx/google%'
+```
+
+Both hook steps sit on the blocking path and Omeda shows a ~4s tail, so this is what says whether
+they own the remaining latency. Responds `{ ok, requiresUserInput,
 redirectTo, user, entity, additionalEventData, … }`; the client redirects to `/user/profile` when
 input is required.
 

package/components/access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/access.marko",
     marko_component = require("./access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -53,7 +53,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/access.marko",
     component: "./access.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/comment-stream.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/comment-stream.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/comment-stream.marko",
     marko_component = require("./comment-stream.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -91,7 +91,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/comment-stream.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/comment-stream.marko",
     component: "./comment-stream.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/context.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/context.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/context.marko",
     marko_component = require("./context.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -49,7 +49,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/context.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/context.marko",
     component: "./context.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/form-access.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-access.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-access.marko",
     marko_component = require("./form-access.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
@@ -179,7 +179,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-access.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-access.marko",
     component: "./form-access.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-authenticate.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-authenticate.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-authenticate.marko",
     marko_component = require("./form-authenticate.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -81,7 +81,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-authenticate.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-authenticate.marko",
     component: "./form-authenticate.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-change-email.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-change-email.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-change-email.marko",
     marko_component = require("./form-change-email.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -59,7 +59,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-change-email.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-change-email.marko",
     component: "./form-change-email.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-login.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-login.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-login.marko",
     marko_component = require("./form-login.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -92,7 +92,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-login.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-login.marko",
     component: "./form-login.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-logout.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-logout.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-logout.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_defaultValue = require("@mindful-web/marko-core/utils/default-value"),
     defaultValue = module_defaultValue.default || module_defaultValue,
@@ -29,7 +29,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-logout.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-logout.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko"
     ]

package/components/form-profile.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-profile.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-profile.marko",
     marko_component = require("./form-profile.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -84,7 +84,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-profile.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-profile.marko",
     component: "./form-profile.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/components/form-register.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/form-register.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/form-register.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_assign = require("marko/dist/runtime/helpers/assign"),
     marko_web_identity_x_form_login_template = require("./form-login.marko"),
@@ -25,7 +25,7 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/form-register.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/form-register.marko",
     tags: [
       "./form-login.marko"
     ]

package/components/google-init.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/google-init.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/google-init.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_attr = require("marko/dist/runtime/html/helpers/attr"),
     marko_str = require("marko/dist/runtime/helpers/to-string");
@@ -239,5 +239,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/google-init.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/google-init.marko"
   };

package/components/google-sign-in-button.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/google-sign-in-button.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/google-sign-in-button.marko",
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     helpers_escape_xml = require("marko/dist/runtime/html/helpers/escape-xml"),
     marko_escapeXml = helpers_escape_xml.x,
@@ -40,5 +40,5 @@ marko_template._ = marko_renderer(render, {
   });
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/google-sign-in-button.marko"
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/google-sign-in-button.marko"
   };

package/components/identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/identify.marko",
     marko_component = require("./identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -50,7 +50,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/identify.marko",
     component: "./identify.marko",
     tags: [
       "@mindful-web/marko-web-gtm/components/push.marko",

package/components/non-auth-identify.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/non-auth-identify.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/non-auth-identify.marko",
     marko_component = require("./non-auth-identify.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     marko_dynamicTag = require("marko/dist/runtime/helpers/dynamic-tag"),
@@ -45,7 +45,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/non-auth-identify.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/non-auth-identify.marko",
     component: "./non-auth-identify.marko",
     tags: [
       "@mindful-web/marko-core/components/resolve.marko"

package/components/subscribe.marko.js

@@ -2,7 +2,7 @@
 "use strict";
 
 var marko_template = module.exports = require("marko/dist/html").t(__filename),
-    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.2/components/subscribe.marko",
+    marko_componentType = "/@mindful-web/marko-web-identity-x$1.80.3/components/subscribe.marko",
     marko_component = require("./subscribe.marko"),
     marko_renderer = require("marko/dist/runtime/components/renderer"),
     module_objectPath_module = require("@mindful-web/object-path"),
@@ -73,7 +73,7 @@ marko_template._ = marko_renderer(render, {
   }, marko_component);
 
 marko_template.meta = {
-    id: "/@mindful-web/marko-web-identity-x$1.80.2/components/subscribe.marko",
+    id: "/@mindful-web/marko-web-identity-x$1.80.3/components/subscribe.marko",
     component: "./subscribe.marko",
     tags: [
       "@mindful-web/marko-web/components/browser-component.marko",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindful-web/marko-web-identity-x",
-  "version": "1.80.2",
+  "version": "1.80.3",
   "description": "Marko Wrapper for IdentityX",
   "repository": "https://github.com/parameter1/mindful-web/tree/main/packages/marko-web-identity-x",
   "author": "Josh Worden <josh@parameter1.com>",
@@ -38,5 +38,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "59e2be57d4905ab42c5acfa590c270a8c12bfce7"
+  "gitHead": "02de6be94c16fd962d5c94b37b9f09a151142f48"
 }

package/routes/google.js

@@ -105,18 +105,44 @@ module.exports = asyncRoute(async (req, res) => {
   // the request dies is the step that failed, so an error arrives already
   // localized instead of being a bare GraphQL message to reverse-engineer.
   //
-  // `idxGoogleStepMs` is the elapsed time when each step *began*, which makes the
-  // route self-profiling: `FACET idxGoogleStep` with `max(idxGoogleStepMs)` shows
-  // where the time goes, and a request that dies mid-flight still reports how far
-  // it got and when. Sign-ins here average ~12s even when they succeed, and
-  // without this there is no way to tell which of the ~10 sequential upstream
-  // calls owns that.
+  // Timing comes in two parts, because they answer different questions.
+  //
+  // `idxGoogleStepMs` is elapsed-at-last-step: last-write-wins, so on a completed
+  // request it is effectively total route time, and on one that dies mid-flight it
+  // says how far in it got. Useful, but it cannot attribute time to a *step* —
+  // every `setStep` overwrites the previous value, so the breakdown it was
+  // originally meant to provide never survived.
+  //
+  // `idxMs<Step>` fixes that: one attribute per step, holding how long that step
+  // took. Emitted when the *next* step starts, since that is when the previous
+  // one is known to be over. `complete` therefore has no duration of its own,
+  // which is correct — it is a marker, not work. Roughly ten attributes, well
+  // inside New Relic's per-transaction custom attribute budget.
+  //
+  //   SELECT average(idxMsHooksAuthenticationSuccess), average(idxMsImpersonateAppUser),
+  //          average(idxMsHooksLoginLinkSent)
+  //   FROM Transaction WHERE name LIKE '%__idx/google%'
+  //
+  // With Omeda calls showing a ~4s tail and both hook steps sitting on the
+  // blocking path, this is what says whether they own the remaining latency.
   const startedAt = Date.now();
   const addAttrs = config.get('addRequestAttributes') || (() => {});
-  const setStep = (step) => addAttrs({
-    idxGoogleStep: step,
-    idxGoogleStepMs: Date.now() - startedAt,
-  });
+
+  // 'hooks-login-link-sent' -> 'idxMsHooksLoginLinkSent'
+  const attrNameForStep = (step) => `idxMs${step.split('-').map((part) => (
+    part.charAt(0).toUpperCase() + part.slice(1)
+  )).join('')}`;
+
+  let currentStep;
+  let currentStepStartedAt = startedAt;
+  const setStep = (step) => {
+    const now = Date.now();
+    // Close out the step being left, not the one being entered.
+    if (currentStep) addAttrs({ [attrNameForStep(currentStep)]: now - currentStepStartedAt });
+    currentStep = step;
+    currentStepStartedAt = now;
+    addAttrs({ idxGoogleStep: step, idxGoogleStepMs: now - startedAt });
+  };
 
   const { clientId, missingFieldsBehavior = 'profile-gate' } = config.getAsObject('googleAuth');
   // `surface` is the GIS `select_by` bucket ('button' | 'prompt'), sent by the