@mindfoldhq/trellis 0.5.0-beta.9 → 0.5.0-rc.0

package/dist/templates/opencode/plugins/session-start.js

@@ -14,21 +14,55 @@ import { TrellisContext, contextCollector, debugLog } from "../lib/trellis-conte
 
 const PYTHON_CMD = platform() === "win32" ? "python" : "python3"
 
+const FIRST_REPLY_NOTICE = `<first-reply-notice>
+On the first visible assistant reply in this session, begin with exactly one short Chinese sentence:
+Trellis SessionStart 已注入：workflow、当前任务状态、开发者身份、git 状态、active tasks、spec 索引已加载。
+Then continue directly with the user's request. This notice is one-shot: do not repeat it after the first assistant reply in the same session.
+</first-reply-notice>`
+
+
+/**
+ * Return true iff jsonl has at least one row with a `file` field.
+ * A freshly seeded jsonl only contains a `{"_example": ...}` row (no `file`
+ * key) — that is NOT "ready". Readiness requires at least one curated entry.
+ * Matches the contract used by `shared-hooks/inject-subagent-context.py`.
+ */
+function hasCuratedJsonlEntry(jsonlPath) {
+  try {
+    const content = readFileSync(jsonlPath, "utf-8")
+    for (const rawLine of content.split(/\r?\n/)) {
+      const line = rawLine.trim()
+      if (!line) continue
+      try {
+        const row = JSON.parse(line)
+        if (row && typeof row === "object" && typeof row.file === "string" && row.file) {
+          return true
+        }
+      } catch {
+        // Ignore malformed line — move on.
+      }
+    }
+  } catch {
+    return false
+  }
+  return false
+}
 
 /**
  * Check current task status and return structured status string.
  * JavaScript equivalent of _get_task_status in Claude's session-start.py.
  */
-function getTaskStatus(ctx) {
-  const taskRef = ctx.getCurrentTask()
+function getTaskStatus(ctx, platformInput = null) {
+  const active = ctx.getActiveTask(platformInput)
+  const taskRef = active.taskPath
   if (!taskRef) {
-    return "Status: NO ACTIVE TASK\nNext: Describe what you want to work on"
+    return `Status: NO ACTIVE TASK\nSource: ${active.source}\nNext: Describe what you want to work on`
   }
 
   const taskDir = ctx.resolveTaskDir(taskRef)
 
-  if (!taskDir || !existsSync(taskDir)) {
-    return `Status: STALE POINTER\nTask: ${taskRef}\nNext: Task directory not found. Run: python3 ./.trellis/scripts/task.py finish`
+  if (active.stale || !taskDir || !existsSync(taskDir)) {
+    return `Status: STALE POINTER\nTask: ${taskRef}\nSource: ${active.source}\nNext: Task directory not found. Run: python3 ./.trellis/scripts/task.py finish`
   }
 
   let taskData = {}
@@ -46,43 +80,46 @@ function getTaskStatus(ctx) {
 
   if (taskStatus === "completed") {
     const dirName = basename(taskDir)
-    return `Status: COMPLETED\nTask: ${taskTitle}\nNext: Archive with \`python3 ./.trellis/scripts/task.py archive ${dirName}\` or start a new task`
+    return `Status: COMPLETED\nTask: ${taskTitle}\nSource: ${active.source}\nNext: Archive with \`python3 ./.trellis/scripts/task.py archive ${dirName}\` or start a new task`
   }
 
   let hasContext = false
   for (const jsonlName of ["implement.jsonl", "check.jsonl"]) {
     const jsonlPath = join(taskDir, jsonlName)
-    if (existsSync(jsonlPath)) {
-      try {
-        const st = statSync(jsonlPath)
-        if (st.size > 0) {
-          hasContext = true
-          break
-        }
-      } catch {
-        // Ignore stat errors
-      }
+    if (existsSync(jsonlPath) && hasCuratedJsonlEntry(jsonlPath)) {
+      hasContext = true
+      break
     }
   }
 
   const hasPrd = existsSync(join(taskDir, "prd.md"))
 
   if (!hasPrd) {
-    return `Status: NOT READY\nTask: ${taskTitle}\nMissing: prd.md not created\nNext: Write PRD, then research → init-context → start`
+    return `Status: NOT READY\nTask: ${taskTitle}\nSource: ${active.source}\nMissing: prd.md not created\nNext: Write PRD (see workflow.md Phase 1.1) then curate implement.jsonl per Phase 1.3`
   }
 
   if (!hasContext) {
-    return `Status: NOT READY\nTask: ${taskTitle}\nMissing: Context not configured (no jsonl files)\nNext: Complete Phase 2 (research → init-context → start) before implementing`
+    return `Status: NOT READY\nTask: ${taskTitle}\nSource: ${active.source}\nMissing: implement.jsonl / check.jsonl missing or empty\nNext: Curate entries per workflow.md Phase 1.3 (spec + research files only), then \`task.py start\``
   }
 
-  return `Status: READY\nTask: ${taskTitle}\nNext: Continue with implement or check`
+  return (
+    `Status: READY\nTask: ${taskTitle}\n` +
+    `Source: ${active.source}\n` +
+    "Next required action: dispatch `trellis-implement` per Phase 2.1. " +
+    "For agent-capable platforms, the default is to NOT edit code in the main session. " +
+    "After implementation, dispatch `trellis-check` per Phase 2.2 before reporting completion.\n" +
+    "User override (per-turn escape hatch): if the user's CURRENT message explicitly tells the " +
+    "main session to handle it directly (\"你直接改\" / \"别派 sub-agent\" / \"main session 写就行\" / " +
+    "\"do it inline\" / \"不用 sub-agent\"), honor it for this turn and edit code directly. " +
+    "Per-turn only; do NOT invent an override the user did not say."
+  )
 }
 
 /**
  * Load Trellis config for session-start decisions.
  * Calls get_context.py --mode packages --json for reliable config data.
  */
-function loadTrellisConfig(directory) {
+function loadTrellisConfig(directory, contextKey = null) {
   const scriptPath = join(directory, ".trellis", "scripts", "get_context.py")
   if (!existsSync(scriptPath)) {
     return { isMonorepo: false, packages: {}, specScope: null, activeTaskPackage: null, defaultPackage: null }
@@ -93,6 +130,10 @@ function loadTrellisConfig(directory) {
       timeout: 5000,
       encoding: "utf-8",
       stdio: ["pipe", "pipe", "pipe"],
+      env: {
+        ...process.env,
+        ...(contextKey ? { TRELLIS_CONTEXT_ID: contextKey } : {}),
+      },
     })
     const data = JSON.parse(output)
     if (data.mode !== "monorepo") {
@@ -195,11 +236,14 @@ function resolveSpecScope(config) {
 /**
  * Build session context for injection
  */
-function buildSessionContext(ctx) {
+export function buildSessionContext(ctx, platformInput = null) {
   const directory = ctx.directory
   const trellisDir = join(directory, ".trellis")
+  const contextKey = typeof ctx.getContextKey === "function"
+    ? ctx.getContextKey(platformInput)
+    : null
 
-  const config = loadTrellisConfig(directory)
+  const config = loadTrellisConfig(directory, contextKey)
   const allowedPkgs = resolveSpecScope(config)
 
   const parts = []
@@ -209,6 +253,7 @@ function buildSessionContext(ctx) {
 You are starting a new session in a Trellis-managed project.
 Read and follow all instructions below carefully.
 </trellis-context>`)
+  parts.push(FIRST_REPLY_NOTICE)
 
   // Legacy migration warning
   const legacyWarning = checkLegacySpec(directory, config)
@@ -219,7 +264,7 @@ Read and follow all instructions below carefully.
   // 2. Current Context (dynamic)
   const contextScript = join(trellisDir, "scripts", "get_context.py")
   if (existsSync(contextScript)) {
-    const output = ctx.runScript(contextScript)
+    const output = ctx.runScript(contextScript, undefined, contextKey)
     if (output) {
       parts.push("<current-state>")
       parts.push(output)
@@ -268,8 +313,7 @@ Read and follow all instructions below carefully.
   }
 
   // 4. Guidelines — paths-only for most indexes; guides/ inlined (cross-package,
-  //    broadly useful). Sub-agents get their specific specs via jsonl injection —
-  //    main agent reads paths on demand when editing code directly.
+  //    broadly useful). Sub-agents get their specific specs via jsonl injection.
   parts.push("<guidelines>")
   parts.push(
     "Project spec indexes are listed by path below. Each index contains a " +
@@ -278,8 +322,9 @@ Read and follow all instructions below carefully.
     "- If you're spawning an implement/check sub-agent, context is injected " +
     "automatically via `{task}/implement.jsonl` / `check.jsonl`. You do NOT " +
     "need to read these indexes yourself.\n" +
-    "- If you're editing code directly in the main session, Read the relevant " +
-    "index(es) on-demand and follow their Pre-Dev Checklist.\n"
+    "- For agent-capable platforms, do NOT edit code directly in the main " +
+    "session; dispatch `trellis-implement` and `trellis-check` so JSONL " +
+    "context is loaded by the sub-agents.\n"
   )
 
   const specDir = join(directory, ".trellis", "spec")
@@ -353,14 +398,14 @@ Read and follow all instructions below carefully.
   parts.push("</guidelines>")
 
   // 6. Task status
-  const taskStatus = getTaskStatus(ctx)
+  const taskStatus = getTaskStatus(ctx, platformInput)
   parts.push(`<task-status>\n${taskStatus}\n</task-status>`)
 
   // 7. Final directive
   parts.push(`<ready>
 Context loaded. Workflow index, project state, and guidelines are already injected above — do NOT re-read them.
-Wait for the user's first message, then handle it following the workflow guide.
-If there is an active task, ask whether to continue it.
+When the user sends the first message, follow <task-status> and the workflow guide.
+If a task is READY, execute its Next required action without asking whether to continue.
 </ready>`)
 
   return parts.join("\n\n")
@@ -482,7 +527,7 @@ export default async ({ directory, client }) => {
           }
 
           // Build context
-          const context = buildSessionContext(ctx)
+          const context = buildSessionContext(ctx, input)
           debugLog("session", "Built context, length:", context.length)
 
           // Inject context directly into output.parts so it gets persisted by updatePart

package/dist/templates/pi/agents/trellis-check.md

@@ -0,0 +1,28 @@
+---
+name: trellis-check
+description: |
+  Code quality check expert. Reviews changes against Trellis specs, fixes issues directly, and verifies quality gates.
+tools: Read, Write, Edit, Bash, Glob, Grep
+---
+# Check Agent
+
+You are the Check Agent in the Trellis workflow.
+
+## Core Responsibilities
+
+1. Inspect the current git diff.
+2. Read and follow the spec and research files listed in the task's `check.jsonl`.
+3. Review all changed code against the task PRD and project specs.
+4. Fix issues directly when they are within scope.
+5. Run the relevant lint, typecheck, and focused tests available for the touched code.
+
+## Review Priorities
+
+- Behavioral regressions and missing requirements.
+- Spec or platform contract violations.
+- Missing or weak tests for logic changes.
+- Cross-platform path, command, and encoding assumptions.
+
+## Output
+
+Report findings fixed, files changed, and verification results. If no issues remain, say that clearly.

package/dist/templates/pi/agents/trellis-implement.md

@@ -0,0 +1,33 @@
+---
+name: trellis-implement
+description: |
+  Code implementation expert. Understands Trellis specs and requirements, then implements features. No git commit allowed.
+tools: Read, Write, Edit, Bash, Glob, Grep
+---
+# Implement Agent
+
+You are the Implement Agent in the Trellis workflow.
+
+## Core Responsibilities
+
+1. Understand the active task requirements.
+2. Read and follow the spec and research files listed in the task's `implement.jsonl`.
+3. Implement the requested change using existing project patterns.
+4. Run the relevant lint, typecheck, and focused tests available for the touched code.
+5. Report files changed and verification results.
+
+## Forbidden Operations
+
+Do not run:
+
+- `git commit`
+- `git push`
+- `git merge`
+
+## Working Rules
+
+- Read adjacent code and tests before editing.
+- Keep changes scoped to the task.
+- Do not revert unrelated user or concurrent changes.
+- Fix root causes rather than masking symptoms.
+- Prefer existing local helpers and platform patterns over new abstractions.

package/dist/templates/pi/agents/trellis-research.md

@@ -0,0 +1,25 @@
+---
+name: trellis-research
+description: |
+  Code and technical research expert. Finds relevant files, patterns, docs, and persists findings to the current task's research/ directory.
+tools: Read, Write, Bash, Glob, Grep
+---
+# Research Agent
+
+You are the Research Agent in the Trellis workflow.
+
+## Core Principle
+
+Persist every finding to a file. Chat context is temporary; files under the task directory survive compaction and handoff.
+
+## Core Responsibilities
+
+1. Resolve the active task with `python3 ./.trellis/scripts/task.py current --source`.
+2. Create `<task-dir>/research/` when it does not exist.
+3. Search internal code, specs, and relevant external documentation.
+4. Write each distinct topic to `<task-dir>/research/<topic-slug>.md`.
+5. Report only file paths and concise summaries to the caller.
+
+## Scope Limits
+
+Write only under the current task's `research/` directory. Do not edit code, specs, platform config, or task files outside research artifacts.