@mindfoldhq/runtime-manager 0.1.5 → 0.1.7-hotfix.1

package/README.md

@@ -16,7 +16,7 @@ VINE_REMOTE_SANDBOX_PROVIDER='e2b' \
 VINE_RUNNER_LINK_HOST='0.0.0.0' \
 VINE_RUNNER_LINK_PORT='8788' \
 VINE_RUNNER_LINK_PUBLIC_URL='<public-runner-link-wss-url>' \
-npx @mindfoldhq/runtime-manager serve
+npx -y @mindfoldhq/runtime-manager serve
 ```
 
 `VINE_MANAGER_TOKEN` is created in Vine Web Settings -> Runtime managers. The

package/dist/vine-runtime-manager.js

@@ -1739,7 +1739,11 @@ var WRITABLE_TASK_DOCS = [
   "implement_md"
 ];
 var WritableTaskDoc = z8.enum(WRITABLE_TASK_DOCS);
-var TASK_MUTATIONS = ["create", "update_status"];
+var TASK_MUTATIONS = [
+  "create",
+  "update_status",
+  "review_request"
+];
 var TaskMutationCapability = z8.enum(TASK_MUTATIONS);
 var contextPolicyFields = {
   channelHistory: ChannelHistoryMode,
@@ -3026,6 +3030,16 @@ var AgentSessionStatePayload = z20.object({
   last_error: z20.string().nullable(),
   metadata: z20.record(z20.string(), z20.unknown()).optional()
 });
+var ManagerTurnStartedPayload = z20.object({
+  agent_turn_id: z20.string().min(1),
+  organization_id: z20.string().min(1),
+  session_id: z20.string().min(1),
+  runner_id: z20.string().min(1),
+  agent_session_id: z20.string().min(1),
+  agent_profile_id: z20.string().min(1),
+  project_agent_profile_id: z20.string().nullable(),
+  backend_kind: ManagerBackendKind
+});
 var ManagerTurnEventPayload = z20.object({
   agent_turn_id: z20.string().min(1),
   kind: ManagerTurnEventKind,
@@ -3077,6 +3091,15 @@ var TaskCliStatusUpdatePayload = z20.object({
   status: TaskStatus,
   expected_version: z20.number().int().optional()
 }).strict();
+var TaskCliReviewRequestCreatePayload = z20.object({
+  request_id: z20.string().min(1),
+  session_id: z20.string().min(1),
+  agent_turn_id: z20.string().min(1),
+  project_repository_id: z20.string().min(1).optional(),
+  repo_slug: z20.string().min(1).optional(),
+  title: z20.string().min(1).max(256).optional(),
+  body: z20.string().max(65000).optional()
+}).strict();
 var ManagerTaskRefsSnapshotPayload = TaskRefsSnapshotPayload;
 var AgentQuestionCreatePayload = z20.object({
   request_id: z20.string().min(1),
@@ -3237,6 +3260,15 @@ var TaskCliStatusUpdateResultPayload = z20.object({
     message: z20.string().min(1)
   }).optional()
 });
+var TaskCliReviewRequestCreateResultPayload = z20.object({
+  request_id: z20.string().min(1),
+  status: z20.enum(["ok", "error"]),
+  review_request: TaskReviewRequestDto.optional(),
+  error: z20.object({
+    code: z20.string().min(1),
+    message: z20.string().min(1)
+  }).optional()
+});
 var AgentQuestionCreateResultPayload = z20.object({
   request_id: z20.string().min(1),
   status: z20.enum(["ok", "error"]),
@@ -3395,6 +3427,10 @@ var ManagerToServerMessage = z20.discriminatedUnion("type", [
     type: z20.literal("agent_session.state"),
     payload: AgentSessionStatePayload
   }),
+  z20.object({
+    type: z20.literal("turn.started"),
+    payload: ManagerTurnStartedPayload
+  }),
   z20.object({ type: z20.literal("turn.event"), payload: ManagerTurnEventPayload }),
   z20.object({
     type: z20.literal("turn.finished"),
@@ -3420,6 +3456,10 @@ var ManagerToServerMessage = z20.discriminatedUnion("type", [
     type: z20.literal("task.cli_status_update"),
     payload: TaskCliStatusUpdatePayload
   }),
+  z20.object({
+    type: z20.literal("task.cli_review_request_create"),
+    payload: TaskCliReviewRequestCreatePayload
+  }),
   z20.object({
     type: z20.literal("task.refs_snapshot"),
     payload: ManagerTaskRefsSnapshotPayload
@@ -3511,6 +3551,10 @@ var ServerToManagerMessage = z20.discriminatedUnion("type", [
     type: z20.literal("task.cli_status_update.result"),
     payload: TaskCliStatusUpdateResultPayload
   }),
+  z20.object({
+    type: z20.literal("task.cli_review_request_create.result"),
+    payload: TaskCliReviewRequestCreateResultPayload
+  }),
   z20.object({
     type: z20.literal("agent.question.create.result"),
     payload: AgentQuestionCreateResultPayload
@@ -6679,6 +6723,7 @@ var VineCliCommandName = z44.enum([
   "task.update_implement",
   "task.create",
   "task.update_status",
+  "task.create_review_request",
   "task.ask"
 ]);
 var VineCliTaskUpdateArgs = z44.object({
@@ -6719,6 +6764,19 @@ var VineCliTaskStatusUpdateCommand = z44.object({
   command: z44.literal("task.update_status"),
   args: VineCliTaskStatusUpdateArgs
 });
+var VineCliTaskReviewRequestCreateArgs = z44.object({
+  project_repository_id: z44.string().min(1).optional(),
+  repo_slug: z44.string().min(1).optional(),
+  title: z44.string().min(1).max(256).optional(),
+  body: z44.string().max(65000).optional()
+}).strict().refine((args) => !(args.project_repository_id && args.repo_slug), {
+  message: "pass either project_repository_id or repo_slug, not both",
+  path: ["repo_slug"]
+});
+var VineCliTaskReviewRequestCreateCommand = z44.object({
+  command: z44.literal("task.create_review_request"),
+  args: VineCliTaskReviewRequestCreateArgs
+});
 var VineCliAskArgs = z44.object({
   questions: z44.array(AgentQuestionSpec).min(1)
 });
@@ -6735,6 +6793,7 @@ var VineCliCommand = z44.discriminatedUnion("command", [
   VineCliTaskUpdateImplementCommand,
   VineCliTaskCreateCommand,
   VineCliTaskStatusUpdateCommand,
+  VineCliTaskReviewRequestCreateCommand,
   VineCliAskCommand
 ]);
 var TASK_DOC_WRITEBACK = {
@@ -8355,6 +8414,50 @@ async function handleTaskStatusUpdateCommand(input, command, deps) {
     }
   };
 }
+async function handleTaskReviewRequestCreateCommand(input, command, deps) {
+  const args = VineCliTaskReviewRequestCreateArgs.safeParse(command.args);
+  if (!args.success) {
+    return errorResponse2(input.request.request_id, "VALIDATION_MALFORMED_PAYLOAD", "task review request command args are malformed");
+  }
+  const binding = deps.sessionBinding(input.sessionId);
+  if (!binding) {
+    return errorResponse2(input.request.request_id, "RUNTIME_SESSION_NOT_FOUND", "runtime session is not active");
+  }
+  if (binding.taskId === null) {
+    return errorResponse2(input.request.request_id, "AUTH_FORBIDDEN", "runtime session is not linked to a task");
+  }
+  const activeTurn = deps.resolveActiveTurn(input.sessionId);
+  if (!activeTurn.ok) {
+    return activeTurnError2(input.request.request_id, activeTurn.code);
+  }
+  const result = await deps.taskClient.createTaskReviewRequestFromCli({
+    request_id: input.request.request_id,
+    session_id: input.sessionId,
+    agent_turn_id: activeTurn.turnId,
+    ...args.data.project_repository_id === undefined ? {} : { project_repository_id: args.data.project_repository_id },
+    ...args.data.repo_slug === undefined ? {} : { repo_slug: args.data.repo_slug },
+    ...args.data.title === undefined ? {} : { title: args.data.title },
+    ...args.data.body === undefined ? {} : { body: args.data.body }
+  });
+  if (result.status === "ok") {
+    if (result.review_request === undefined) {
+      return errorResponse2(input.request.request_id, "INTERNAL_BUG", "task review request succeeded without review request details");
+    }
+    return {
+      request_id: input.request.request_id,
+      status: "ok",
+      body: result.review_request
+    };
+  }
+  return {
+    request_id: input.request.request_id,
+    status: "error",
+    error: result.error ?? {
+      code: "INTERNAL_BUG",
+      message: "task review request failed"
+    }
+  };
+}
 function activeTurnError2(requestId, code) {
   return errorResponse2(requestId, code, code === "ASK_AMBIGUOUS_ACTIVE_TURN" ? "runtime session has multiple active turns" : "runtime session has no active turn");
 }
@@ -8450,6 +8553,8 @@ async function routeCliRequest(input, deps) {
       return handleTaskCreateCommand(input, parsed.data, deps);
     case "task.update_status":
       return handleTaskStatusUpdateCommand(input, parsed.data, deps);
+    case "task.create_review_request":
+      return handleTaskReviewRequestCreateCommand(input, parsed.data, deps);
     case "task.update_prd":
     case "task.update_design":
     case "task.update_implement":
@@ -8929,6 +9034,7 @@ class E2BProvider {
     await this.killTrackedRunnerCommand(tracked, "respawn");
     let command;
     try {
+      await this.cleanupPersistedRunnerState(tracked.sandbox, workspaceRoot, tracked, "respawn");
       tracked.reposFilePath = reposFilePath;
       if (reposFilePath) {
         await tracked.sandbox.files.write(reposFilePath, serializeRuntimeReposManifest(remoteRepos));
@@ -9043,7 +9149,10 @@ class E2BProvider {
     return result;
   }
   async prepareRestoredSandbox(sandbox, workspaceRoot, tracked) {
-    const result = await sandbox.commands.run(this.restoredSandboxCleanupCommand(workspaceRoot), {
+    await this.cleanupPersistedRunnerState(sandbox, workspaceRoot, tracked, "restore");
+  }
+  async cleanupPersistedRunnerState(sandbox, workspaceRoot, tracked, reason) {
+    const result = await sandbox.commands.run(this.persistedRunnerCleanupCommand(workspaceRoot), {
       cwd: "/",
       timeoutMs: DEFAULT_CLEANUP_TIMEOUT_MS,
       onStdout: (data) => {
@@ -9054,13 +9163,14 @@ class E2BProvider {
       }
     });
     if (isCommandHandle(result)) {
-      throw new Error("E2B restore cleanup unexpectedly ran in background");
+      throw new Error(`E2B ${reason} cleanup unexpectedly ran in background`);
     }
     if (result.exitCode !== 0) {
-      throw new Error(`E2B restore cleanup exited ${result.exitCode}: ${redactDiagnosticString(result.stderr)}`);
+      throw new Error(`E2B ${reason} cleanup exited ${result.exitCode}: ${redactDiagnosticString(result.stderr)}`);
     }
+    log8.info({ sandbox_id: sandbox.sandboxId, reason }, "E2B persisted runner cleanup completed");
   }
-  restoredSandboxCleanupCommand(workspaceRoot) {
+  persistedRunnerCleanupCommand(workspaceRoot) {
     const socketPath = shellQuote2(`${workspaceRoot}/.vine/vine.sock`);
     return [
       "set -eu;",
@@ -10868,6 +10978,15 @@ class SessionLifecycle {
         dirty_files: 0
       };
       if (!this.m.runnerLink.hasRunner(session.sessionId)) {
+        if (session.providerKind === "remote_sandbox" && session.repos.length > 0) {
+          log11.warn({
+            session_id: session.sessionId,
+            provider_key: session.providerKey,
+            repo_count: session.repos.length
+          }, "no runner connected for remote repo workspace — treating dirty state as unknown/dirty");
+          resolve3(conservativeDirty);
+          return;
+        }
         log11.info({ session_id: session.sessionId }, "no runner connected — skipping dirty probe, treating workspace as clean");
         resolve3({
           session_id: session.sessionId,
@@ -11573,10 +11692,23 @@ class TaskProjectionBridge {
       const agentKey = session.turnToAgentKey.get(turnStart.turn_id);
       const agentSession = agentKey ? session.agentSessions.get(agentKey) : undefined;
       if (agentSession) {
+        this.emitTurnStarted(session, turnStart, agentSession);
         this.m.emitAgentSessionState(session, agentSession, "active");
       }
     }
   }
+  emitTurnStarted(session, turnStart, agentSession) {
+    this.m.serverClient.emitTurnStarted({
+      agent_turn_id: turnStart.turn_id,
+      organization_id: session.organizationId,
+      session_id: session.sessionId,
+      runner_id: session.runnerId,
+      agent_session_id: agentSession.agentSessionId,
+      agent_profile_id: agentSession.agentProfileId,
+      project_agent_profile_id: agentSession.projectAgentProfileId,
+      backend_kind: agentSession.backendKind
+    });
+  }
 }
 
 // src/runtime-manager-terminal-relay.ts
@@ -12256,6 +12388,16 @@ class TurnRouter {
       this.m.maybeRespawnDisconnectedSession(session, "turn_dispatch");
       return;
     }
+    this.m.serverClient.emitTurnStarted({
+      agent_turn_id: dispatch.agent_turn_id,
+      organization_id: session.organizationId,
+      session_id: session.sessionId,
+      runner_id: session.runnerId,
+      agent_session_id: agentSession.agentSessionId,
+      agent_profile_id: agentSession.agentProfileId,
+      project_agent_profile_id: agentSession.projectAgentProfileId,
+      backend_kind: agentSession.backendKind
+    });
     this.m.emitAgentSessionState(session, agentSession, "active");
     log15.info({
       agent_turn_id: dispatch.agent_turn_id,
@@ -12559,6 +12701,7 @@ class ServerClient {
   pendingTaskCliUpdates = new Map;
   pendingTaskCliCreates = new Map;
   pendingTaskCliStatusUpdates = new Map;
+  pendingTaskCliReviewRequestCreates = new Map;
   pendingQuestionCreates = new Map;
   pendingTerminalFrames = [];
   constructor(opts) {
@@ -12809,6 +12952,10 @@ class ServerClient {
         this.settleTaskCliStatusUpdate(parsed.payload);
         return;
       }
+      case "task.cli_review_request_create.result": {
+        this.settleTaskCliReviewRequestCreate(parsed.payload);
+        return;
+      }
       case "agent.question.create.result": {
         this.settleQuestionCreate(parsed.payload);
         return;
@@ -12950,6 +13097,13 @@ class ServerClient {
       payload: { ...payload, request_id: requestId }
     }));
   }
+  requestTaskCliReviewRequestCreate(payload) {
+    const requestId = payload.request_id ?? randomUUID6();
+    return this.trackTaskRequest(this.pendingTaskCliReviewRequestCreates, requestId, () => this.send({
+      type: "task.cli_review_request_create",
+      payload: { ...payload, request_id: requestId }
+    }));
+  }
   requestQuestionCreate(payload) {
     const requestId = payload.request_id ?? randomUUID6();
     return this.trackTaskRequest(this.pendingQuestionCreates, requestId, () => this.send({
@@ -12988,6 +13142,9 @@ class ServerClient {
   settleTaskCliStatusUpdate(payload) {
     this.settleTaskRequest(this.pendingTaskCliStatusUpdates, payload.request_id, payload);
   }
+  settleTaskCliReviewRequestCreate(payload) {
+    this.settleTaskRequest(this.pendingTaskCliReviewRequestCreates, payload.request_id, payload);
+  }
   settleQuestionCreate(payload) {
     this.settleTaskRequest(this.pendingQuestionCreates, payload.request_id, payload);
   }
@@ -13007,6 +13164,7 @@ class ServerClient {
       this.pendingTaskCliUpdates,
       this.pendingTaskCliCreates,
       this.pendingTaskCliStatusUpdates,
+      this.pendingTaskCliReviewRequestCreates,
       this.pendingQuestionCreates
     ]) {
       for (const request of pending.values()) {
@@ -13025,6 +13183,9 @@ class ServerClient {
   emitAgentSessionState(payload) {
     return this.send({ type: "agent_session.state", payload });
   }
+  emitTurnStarted(payload) {
+    return this.send({ type: "turn.started", payload });
+  }
 }
 function unrefTimer(timer) {
   const maybeTimer = timer;
@@ -13479,6 +13640,7 @@ class RuntimeManager {
       taskClient: {
         createTaskFromCli: (payload) => this.serverClient.requestTaskCliCreate(payload),
         updateTaskStatusFromCli: (payload) => this.serverClient.requestTaskCliStatusUpdate(payload),
+        createTaskReviewRequestFromCli: (payload) => this.serverClient.requestTaskCliReviewRequestCreate(payload),
         updateTaskFromCli: (payload) => this.serverClient.requestTaskCliUpdate(payload)
       },
       questionClient: {
@@ -13546,15 +13708,22 @@ class RuntimeManager {
       }
       this.clearRunnerBootTimer(session);
     }
-    this.runnerLink.stop();
     const releases = sessions.map(async (session) => {
       if (!session.provisioned) {
         this.emitReleasedState(session);
-        return;
+        return "released";
+      }
+      if (session.lastStatus !== "idle_checkpointed" && await this.sessionLifecycle.dirtyProbeHoldsRelease(session)) {
+        log17.info({
+          session_id: session.sessionId,
+          provider_key: session.providerKey
+        }, "shutdown release blocked by dirty workspace — preserving provider runtime");
+        return "preserved";
       }
       try {
         await providerForSession(this, session).releaseSession(session.provisioned);
         this.emitReleasedState(session);
+        return "released";
       } catch (err) {
         log17.warn({ err, session_id: session.sessionId }, "session release failed during shutdown — marking failed");
         const detail = err instanceof Error ? err.message : String(err);
@@ -13563,12 +13732,17 @@ class RuntimeManager {
         }
         this.emitRunnerStateFailed(session, detail);
         this.emitSessionStateFailed(session, detail);
+        return "failed";
       }
     });
+    const results = await Promise.allSettled(releases);
+    this.runnerLink.stop();
     this.sessions.clear();
     this.sessionsById.clear();
-    await Promise.allSettled(releases);
-    log17.info({ released: releases.length }, "all sessions released");
+    const released = results.filter((result) => result.status === "fulfilled" && result.value === "released").length;
+    const preserved = results.filter((result) => result.status === "fulfilled" && result.value === "preserved").length;
+    const failed = results.length - released - preserved;
+    log17.info({ released, preserved, failed }, "shutdown session release drain finished");
     this.serverClient.stop();
   }
   emitReleasedState(session) {
@@ -14356,6 +14530,7 @@ class RuntimeManager2 {
       taskClient: {
         createTaskFromCli: (payload) => this.serverClient.requestTaskCliCreate(payload),
         updateTaskStatusFromCli: (payload) => this.serverClient.requestTaskCliStatusUpdate(payload),
+        createTaskReviewRequestFromCli: (payload) => this.serverClient.requestTaskCliReviewRequestCreate(payload),
         updateTaskFromCli: (payload) => this.serverClient.requestTaskCliUpdate(payload)
       },
       questionClient: {
@@ -14423,15 +14598,22 @@ class RuntimeManager2 {
       }
       this.clearRunnerBootTimer(session);
     }
-    this.runnerLink.stop();
     const releases = sessions.map(async (session) => {
       if (!session.provisioned) {
         this.emitReleasedState(session);
-        return;
+        return "released";
+      }
+      if (session.lastStatus !== "idle_checkpointed" && await this.sessionLifecycle.dirtyProbeHoldsRelease(session)) {
+        log19.info({
+          session_id: session.sessionId,
+          provider_key: session.providerKey
+        }, "shutdown release blocked by dirty workspace — preserving provider runtime");
+        return "preserved";
       }
       try {
         await providerForSession(this, session).releaseSession(session.provisioned);
         this.emitReleasedState(session);
+        return "released";
       } catch (err) {
         log19.warn({ err, session_id: session.sessionId }, "session release failed during shutdown — marking failed");
         const detail = err instanceof Error ? err.message : String(err);
@@ -14440,12 +14622,17 @@ class RuntimeManager2 {
         }
         this.emitRunnerStateFailed(session, detail);
         this.emitSessionStateFailed(session, detail);
+        return "failed";
       }
     });
+    const results = await Promise.allSettled(releases);
+    this.runnerLink.stop();
     this.sessions.clear();
     this.sessionsById.clear();
-    await Promise.allSettled(releases);
-    log19.info({ released: releases.length }, "all sessions released");
+    const released = results.filter((result) => result.status === "fulfilled" && result.value === "released").length;
+    const preserved = results.filter((result) => result.status === "fulfilled" && result.value === "preserved").length;
+    const failed = results.length - released - preserved;
+    log19.info({ released, preserved, failed }, "shutdown session release drain finished");
     this.serverClient.stop();
   }
   emitReleasedState(session) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@mindfoldhq/runtime-manager",
-	"version": "0.1.5",
+	"version": "0.1.7-hotfix.1",
 	"description": "Vine runtime manager CLI",
 	"type": "module",
 	"license": "UNLICENSED",