@minded-ai/mindedjs 2.0.8 → 2.0.9-beta.0.1

package/src/browserTask/localBrowserTask.ts

@@ -1,17 +1,18 @@
 // getOrStartLocalCDP.ts
 import { spawn, ChildProcess } from "child_process";
 import * as fs from "fs/promises";
-import * as fscb from "fs";
 import * as path from "path";
-import * as http from "http";
 import { chromium } from "playwright";
 import { logger } from "../utils/logger";
+import { wait } from "../utils/wait";
 
 let localBrowserTask: {
   cdpUrl: string;
   proc: ChildProcess;
 } | null = null;
 
+const port = 9222;
+
 export type StartChromiumOptions = {
   /** Headless by default. Set to false to see a window. */
   headless?: boolean;
@@ -39,10 +40,7 @@ export async function getOrStartLocalCDP(
     };
   }
 
-  const {
-    env,
-    timeoutMs = 10_000,
-  } = opts;
+  const { env } = opts;
 
   const executablePath = chromium.executablePath();
 
@@ -116,7 +114,7 @@ export async function getOrStartLocalCDP(
     "--enable-extensions",
     "--disable-extensions-file-access-check",
     "--enable-extension-activity-logging",
-    `--remote-debugging-port=0`,
+    `--remote-debugging-port=${port}`,
     "--remote-debugging-address=0.0.0.0",
     "about:blank",
   ];
@@ -126,125 +124,54 @@ export async function getOrStartLocalCDP(
     env: { ...process.env, ...env },
   });
 
-  // If Chromium dies early, surface the error.
-  const earlyExit = new Promise<never>((_, reject) => {
-    proc.once("exit", (code, signal) => {
-      reject(
-        new Error(`Chromium exited prematurely (code=${code}, signal=${signal}).`)
-      );
-    });
+  proc.on("error", (error) => {
+    logger.error({ message: 'Chromium error', error });
   });
 
-  const devtoolsPortFile = path.join(userDataDir, "DevToolsActivePort");
-
-  // Wait for DevToolsActivePort file to appear, then read it for port + browserId.
-  const whenReady = (async () => {
-    const startedAt = Date.now();
-    while (Date.now() - startedAt < timeoutMs) {
-      try {
-        // Access succeeds once the file is written.
-        await fs.access(devtoolsPortFile, fscb.constants.F_OK);
-        break;
-      } catch {
-        await delay(50);
-      }
-    }
-    // If still not there, bail.
-    await fs.access(devtoolsPortFile, fscb.constants.F_OK).catch(() => {
-      throw new Error(
-        `Timed out after ${timeoutMs}ms waiting for DevToolsActivePort at ${devtoolsPortFile}`
-      );
-    });
-
-    const raw = await fs.readFile(devtoolsPortFile, "utf8");
-    const [portLine] = raw.trim().split(/\r?\n/);
-    const port = Number(portLine);
-    if (!Number.isFinite(port)) {
-      throw new Error(`Invalid DevTools port read from file: "${portLine}"`);
-    }
-
-    // Optional: ping /json/version to ensure the endpoint is responsive.
-    await waitForHttpOk(`http://127.0.0.1:${port}/json/version`, timeoutMs);
-
-    const cdpUrl = await fetchWsFromVersionEndpoint(port, timeoutMs);
+  proc.on("exit", (code, signal) => {
+    logger.error({ message: 'Chromium exited', code, signal });
+  });
 
-    localBrowserTask = {
-      cdpUrl,
-      proc,
-    };
+  await waitForCdpEndpoint(port, 30);
 
-    return { cdpUrl };
-  })();
+  const cdpUrl = `http://127.0.0.1:${port}`;
 
-  const { cdpUrl } = await Promise.race([whenReady, earlyExit]);
+  localBrowserTask = {
+    cdpUrl,
+    proc,
+  };
 
   logger.info({ message: 'Local browser task started', cdpUrl });
 
   return { cdpUrl };
 }
 
-// ---- helpers ----
-function delay(ms: number) {
-  return new Promise<void>((r) => setTimeout(r, ms));
-}
-
-async function waitForHttpOk(url: string, timeoutMs: number) {
-  const startedAt = Date.now();
-  while (Date.now() - startedAt < timeoutMs) {
-    const ok = await httpGetOk(url).catch(() => false);
-    if (ok) return;
-    await delay(50);
-  }
-  throw new Error(`Timed out after ${timeoutMs}ms waiting for ${url}`);
-}
-
-function httpGetOk(urlStr: string): Promise<boolean> {
-  return new Promise((resolve, reject) => {
-    const req = http.get(urlStr, (res) => {
-      // Drain data to allow socket reuse.
-      res.resume();
-      resolve(res.statusCode === 200);
-    });
-    req.on("error", reject);
-    req.setTimeout(3000, () => {
-      req.destroy(new Error("HTTP timeout"));
-    });
-  });
-}
-
-async function fetchWsFromVersionEndpoint(
-  port: number,
-  timeoutMs: number
-): Promise<string> {
-  const urlStr = `http://127.0.0.1:${port}/json/version`;
-  const body = await httpGetBody(urlStr, timeoutMs);
-  const parsed = JSON.parse(body);
-  if (!parsed.webSocketDebuggerUrl) {
-    throw new Error(`No webSocketDebuggerUrl in ${urlStr} response`);
+// Legacy HTTP polling helpers removed in favor of waitForCdpEndpoint
+
+async function waitForCdpEndpoint(port: number, maxAttempts: number): Promise<void> {
+  logger.info({ message: `Waiting for CDP endpoint on port ${port}...` });
+  for (let attemptIndex = 0; attemptIndex < maxAttempts; attemptIndex++) {
+    try {
+      const response = await fetch(`http://127.0.0.1:${port}/json/version`);
+      if (response.ok) {
+        const version = await response.json();
+        logger.info({ message: `CDP endpoint ready on port ${port}`, version: version["Browser"] });
+        return;
+      }
+    } catch (error) {
+      if (attemptIndex % 5 === 0) {
+        logger.debug({ message: `CDP endpoint not ready yet, attempt ${attemptIndex + 1}/${maxAttempts}`, error });
+      }
+    }
+    await wait(1000);
   }
-  return parsed.webSocketDebuggerUrl as string;
-}
-
-function httpGetBody(urlStr: string, timeoutMs: number): Promise<string> {
-  return new Promise((resolve, reject) => {
-    const req = http.get(urlStr, (res) => {
-      let data = "";
-      res.setEncoding("utf8");
-      res.on("data", (chunk) => (data += chunk));
-      res.on("end", () => {
-        if (res.statusCode === 200) resolve(data);
-        else reject(new Error(`HTTP ${res.statusCode}: ${data}`));
-      });
-    });
-    req.on("error", reject);
-    req.setTimeout(timeoutMs, () => req.destroy(new Error("HTTP timeout")));
-  });
+  throw new Error(`CDP endpoint not available on port ${port} after ${maxAttempts} attempts`);
 }
 
 export async function kill() {
   if (localBrowserTask) {
     localBrowserTask.proc.kill("SIGTERM");
-    await delay(300);
+    await wait(300);
     localBrowserTask.proc.kill("SIGKILL");
   }
 }

package/src/edges/createPromptRouter.ts

@@ -111,6 +111,7 @@ export const createPromptRouter = ({
       steps: stepsStr,
       messages: messagesStr,
       memory: state.memory,
+      env: process.env,
     });
 
     // Define response schema

package/src/nodes/addAppToolNode.ts

@@ -70,7 +70,7 @@ export const addAppToolNode = async ({
     User instructions for choosing tool parameters are:
         ${node.prompt ? `${node.prompt}` : 'no instructions set by the user'}`;
 
-    const compiledPrompt = compilePrompt(message, { memory: state.memory });
+    const compiledPrompt = compilePrompt(message, { memory: state.memory, env: process.env });
     const systemMessage = new SystemMessage(compiledPrompt);
     if (state.messages.length === 0 || state.messages[0].getType() === 'system') {
       state.messages[0] = systemMessage;

package/src/nodes/addBrowserTaskNode.ts

@@ -62,7 +62,7 @@ export const addBrowserTaskNode = async ({ graph, node, agent, llm }: AddBrowser
 
     const combinedPlaybooks = combinePlaybooks(agent.playbooks);
     if (combinedPlaybooks) {
-      const compiledPrompt = compilePrompt(combinedPlaybooks, { memory: state.memory });
+      const compiledPrompt = compilePrompt(combinedPlaybooks, { memory: state.memory, env: process.env });
       const systemMessage = new SystemMessage(compiledPrompt);
       if (state.messages.length === 0 || state.messages[0].getType() === 'system') {
         state.messages[0] = systemMessage;
@@ -90,7 +90,7 @@ export const addBrowserTaskNode = async ({ graph, node, agent, llm }: AddBrowser
       };
 
       // Compile the prompt with parameters
-      const compiledPrompt = compilePrompt(node.prompt, promptParams);
+      const compiledPrompt = compilePrompt(node.prompt, { ...promptParams, env: process.env });
 
       // Build the full prompt with compiled content
       const fullPrompt = `
@@ -151,6 +151,7 @@ ${Object.keys(inputParams).length > 0 ? `# Input parameters:\n${JSON.stringify(i
       });
 
       state.messages.push(toolCallingMessage);
+      state.cdpUrl = session.cdpUrl;
       state.history.push(
         createHistoryStep<HistoryStep>(state.history, {
           type: NodeType.BROWSER_TASK,

package/src/nodes/addPromptNode.ts

@@ -51,7 +51,7 @@ export const addPromptNode = async ({ graph, node, llm, tools, emit, agent }: Ad
     if (combinedPlaybooks) {
       finalMessage = combinedPlaybooks + '\n\n' + currentPromptNode;
     }
-    const compiledPrompt = compilePrompt(finalMessage, { memory: state.memory });
+    const compiledPrompt = compilePrompt(finalMessage, { memory: state.memory, env: process.env });
     const systemMessage = new SystemMessage(compiledPrompt);
     if (state.messages.length === 0 || state.messages[0].getType() === 'system') {
       state.messages[0] = systemMessage;

package/src/nodes/addToolNode.ts

@@ -34,7 +34,7 @@ export const addToolNode = async ({
     await agent.interruptSessionManager.checkQueueAndInterrupt(state.sessionId);
     logger.debug({ msg: `[Node] Executing tool node`, node: toolNode.displayName });
 
-    const tool = langchainTool(() => {}, {
+    const tool = langchainTool(() => { }, {
       name: matchedTool.name,
       description: matchedTool.description,
       schema: matchedTool.input,
@@ -52,7 +52,7 @@ export const addToolNode = async ({
       }
     }
     if (finalMessage) {
-      const compiledPrompt = compilePrompt(finalMessage, { memory: state.memory });
+      const compiledPrompt = compilePrompt(finalMessage, { memory: state.memory, env: process.env });
       const systemMessage = new SystemMessage(compiledPrompt);
       if (state.messages.length === 0 || state.messages[0].getType() === 'system') {
         state.messages[0] = systemMessage;