@minded-ai/mindedjs 2.0.17 → 2.0.18-beta-1

package/src/browserTask/executeBrowserTask.ts

@@ -11,7 +11,7 @@ import {
   DestroyBrowserSessionRequest,
   DestroyBrowserSessionResponse,
 } from '../platform/mindedConnectionTypes';
-import { kill, getOrStartLocalCDP } from './localBrowserTask';
+import { kill, getOrStartLocalCDP, isLocalBrowserRunning } from './localBrowserTask';
 import { BrowserTaskMode, InvokeBrowserTaskOptions } from './types';
 import { isLocalOperatorSetup, validateLocalOperatorSetup } from '../cli/localOperatorSetup';
 
@@ -111,10 +111,10 @@ export const invokeBrowserTask = async (options: InvokeBrowserTaskOptions): Prom
         stdio: ['pipe', 'pipe', 'pipe'],
         env: isLocalOperatorSetup()
           ? {
-              ...process.env,
-              VIRTUAL_ENV: path.join(process.cwd(), '.venv'),
-              PATH: `${path.join(process.cwd(), '.venv', 'bin')}:${process.env.PATH}`,
-            }
+            ...process.env,
+            VIRTUAL_ENV: path.join(process.cwd(), '.venv'),
+            PATH: `${path.join(process.cwd(), '.venv', 'bin')}:${process.env.PATH}`,
+          }
           : process.env,
       });
 
@@ -146,11 +146,27 @@ export const invokeBrowserTask = async (options: InvokeBrowserTaskOptions): Prom
         process.stderr.write(text);
       });
 
+      const interval = setInterval(() => {
+        // Check if chromium process stopped running
+        if (!isLocalBrowserRunning()) {
+          logger.error({ message: 'Local browser process stopped running, killing browser task' });
+          child.kill();
+          clearInterval(interval);
+        }
+      }, 1000);
+
+      // Automatically clear interval after 20 minutes to avoid memory leaks
+      setTimeout(() => {
+        clearInterval(interval);
+      }, 1200000); // 20 minutes
+
       const exitCode: number = await new Promise((resolve, reject) => {
         child.on('error', (err) => reject(err));
         child.on('close', (code) => resolve(code ?? 1));
       });
 
+      clearInterval(interval);
+
       if (exitCode !== 0) {
         logger.error({ message: 'Operator failed', exitCode, stderr: stderrBuffer });
         throw new Error(`Local browser task failed with exit code ${exitCode}`);
@@ -158,6 +174,7 @@ export const invokeBrowserTask = async (options: InvokeBrowserTaskOptions): Prom
 
       logger.info({ message: 'Operator finished' });
 
+
       let result = stdoutBuffer.split('___RESULT___')[1]?.trim() || stdoutBuffer;
       if (outputSchema?.length) {
         try {

package/src/browserTask/localBrowserTask.ts

@@ -130,6 +130,7 @@ export async function getOrStartLocalCDP(
 
   proc.on("exit", (code, signal) => {
     logger.error({ message: 'Chromium exited', code, signal });
+    localBrowserTask = null;
   });
 
   await waitForCdpEndpoint(port, 30);
@@ -168,10 +169,15 @@ async function waitForCdpEndpoint(port: number, maxAttempts: number): Promise<vo
   throw new Error(`CDP endpoint not available on port ${port} after ${maxAttempts} attempts`);
 }
 
+export function isLocalBrowserRunning(): boolean {
+  return localBrowserTask !== null;
+}
+
 export async function kill() {
   if (localBrowserTask) {
     localBrowserTask.proc.kill("SIGTERM");
     await wait(300);
     localBrowserTask.proc.kill("SIGKILL");
+    localBrowserTask = null; // Reset the variable after killing the process
   }
 }