@mimik/eslint-plugin-logger 1.0.1 → 1.0.2

package/README.md

@@ -87,6 +87,7 @@ logger.info('User logged in', { userId: 123 }, correlationId, { type: 'audit' })
 - `message` must be a string (when passed as a literal)
 - `correlationId` must be a string (when passed as a literal)
 - `options` object must contain a `type` property with a string value
+- When 2 arguments are passed and the 2nd is an object literal, it is treated as `(message, meta)` with a missing `correlationId`
 - When 3 arguments are passed, the 2nd argument type determines the signature:
   - Object literal → `(message, meta, correlationId)`
   - Otherwise → `(message, correlationId, options)`

package/index.js

@@ -126,6 +126,7 @@ const plugin = {
           tooManyArguments: 'logger.{{ level }}() accepts at most 4 arguments: (message, meta, correlationId, options). Found {{ count }}.',
           messageNotString: 'logger.{{ level }}() message (1st argument) must be a string. Found {{ actualType }}.',
           correlationIdNotString: 'logger.{{ level }}() correlationId must be a string. Found {{ actualType }}.',
+          missingCorrelationId: 'logger.{{ level }}() called with (message, meta) but missing required correlationId. Expected (message, meta, correlationId).',
           optionsMissingType: 'logger.{{ level }}() options object must contain a "type" property.',
           optionsTypeNotString: 'logger.{{ level }}() options "type" property must be a string.',
         },
@@ -170,8 +171,18 @@ const plugin = {
             validateStringArg(context, args[0], level, 'messageNotString');
 
             if (args.length === MIN_ARGS) {
-              // (message, correlationId)
-              validateStringArg(context, args[1], level, 'correlationIdNotString');
+              if (isObjectNode(args[1]) || args[1].type === 'ArrayExpression') {
+                // (message, {object}) or (message, [array]) — missing correlationId
+                context.report({
+                  node,
+                  messageId: 'missingCorrelationId',
+                  data: { level },
+                });
+              }
+              else {
+                // (message, correlationId)
+                validateStringArg(context, args[1], level, 'correlationIdNotString');
+              }
             }
             else if (args.length === THREE_ARGS) {
               // Disambiguate: (message, meta, correlationId) vs (message, correlationId, options)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mimik/eslint-plugin-logger",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "validation of the logger parameters for mimik",
   "main": "./index.js",
   "type": "module",