@milpa/comal 0.2.7 → 0.2.8

package/src/plugin-trust.mjs

@@ -13,6 +13,7 @@ registerMessages({
   'Trust record: invalid files.': 'Registro de confianza: archivos inválidos.',
   'Trust record: invalid date.': 'Registro de confianza: fecha inválida.',
   'Trust record: invalid package.': 'Registro de confianza: paquete inválido.',
+  'Trust record: invalid reason.': 'Registro de confianza: motivo inválido.',
   'Unrecognized trust registry format.': 'Formato de registro de confianza no reconocido.',
   'Trust registry ignored: {reason}': 'Registro de confianza ignorado: {reason}',
   'No recorded trust for {id} in this project. Use /plugins enable {id}.': 'No hay confianza registrada para {id} en este proyecto. Usa /plugins enable {id}.',
@@ -27,6 +28,7 @@ const ID = /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/, SHA = /^[a-f0-9]{64}$/;
 const canonical = value => Array.isArray(value) ? value.map(canonical) : value && typeof value === 'object' ? Object.fromEntries(Object.keys(value).sort().map(key => [key, canonical(value[key])])) : value;
 export const configDigest = config => createHash('sha256').update(JSON.stringify(canonical(config ?? {}))).digest('hex');
 const fail = (message, code = 'PLUGIN_TRUST_INVALID') => Object.assign(new Error(message), { code });
+const TRUST_REASONS = ['contract_repair'];
 
 export function pluginTrustFile(env = process.env) {
   return path.resolve(env.XDG_CONFIG_HOME || path.join(os.homedir(), '.config'), 'comal', 'plugin-trust.json');
@@ -34,7 +36,7 @@ export function pluginTrustFile(env = process.env) {
 
 function record(value) {
   if (!value || typeof value !== 'object' || Array.isArray(value)) throw fail(t('Invalid trust record.'));
-  const keys = ['project', 'id', 'module', 'code_fingerprint', 'config_sha256', 'files', 'trusted_at', 'package'];
+  const keys = ['project', 'id', 'module', 'code_fingerprint', 'config_sha256', 'files', 'trusted_at', 'package', 'reason'];
   for (const key of Object.keys(value)) if (!keys.includes(key)) throw fail(t('Trust record: unknown field {key}', { key }));
   if (typeof value.project !== 'string' || !path.isAbsolute(value.project) || typeof value.module !== 'string' || !path.isAbsolute(value.module)) throw fail(t('Trust record: absolute paths required.'));
   if (!ID.test(value.id || '') || !SHA.test(value.code_fingerprint || '') || !SHA.test(value.config_sha256 || '')) throw fail(t('Trust record: invalid id or fingerprints.'));
@@ -42,7 +44,9 @@ function record(value) {
   if (typeof value.trusted_at !== 'string') throw fail(t('Trust record: invalid date.'));
   const pkg = value.package;
   if (pkg !== undefined && (!pkg || typeof pkg.name !== 'string' || pkg.name.length > 214 || typeof pkg.version !== 'string' || pkg.version.length > 64 || !SHA.test(pkg.integrity || '') || Object.keys(pkg).some(key => !['name', 'version', 'integrity'].includes(key)))) throw fail(t('Trust record: invalid package.'));
-  return { project: value.project, id: value.id, module: value.module, code_fingerprint: value.code_fingerprint, config_sha256: value.config_sha256, files: value.files.map(file => ({ path: file.path, sha256: file.sha256 })), trusted_at: value.trusted_at, ...(pkg ? { package: { name: pkg.name, version: pkg.version, integrity: pkg.integrity } } : {}) };
+  // reason: why the house, not the human's card, recorded this trust (only 'contract_repair' today). Absent on human records.
+  if (value.reason !== undefined && !TRUST_REASONS.includes(value.reason)) throw fail(t('Trust record: invalid reason.'));
+  return { project: value.project, id: value.id, module: value.module, code_fingerprint: value.code_fingerprint, config_sha256: value.config_sha256, files: value.files.map(file => ({ path: file.path, sha256: file.sha256 })), trusted_at: value.trusted_at, ...(pkg ? { package: { name: pkg.name, version: pkg.version, integrity: pkg.integrity } } : {}), ...(value.reason !== undefined ? { reason: value.reason } : {}) };
 }
 
 /**
@@ -92,9 +96,9 @@ export class PluginTrustStore {
     await writePrivateJson(this.file, { version: VERSION, plugins: records }, { workspace: this.workspace });
     this.#records = records;
   }
-  async trust({ project, entry, code }) {
+  async trust({ project, entry, code, reason }) {
     await this.#ready();
-    const next = record({ project, id: entry.id, module: code.module, code_fingerprint: code.code_fingerprint, config_sha256: configDigest(entry.config), files: code.files, trusted_at: new Date().toISOString(), ...(code.package ? { package: code.package } : {}) });
+    const next = record({ project, id: entry.id, module: code.module, code_fingerprint: code.code_fingerprint, config_sha256: configDigest(entry.config), files: code.files, trusted_at: new Date().toISOString(), ...(code.package ? { package: code.package } : {}), ...(reason !== undefined ? { reason } : {}) });
     await this.#save([...this.#records.filter(item => !(item.project === project && item.id === entry.id)), next]);
     return structuredClone(next);
   }
@@ -105,6 +109,12 @@ export class PluginTrustStore {
     await this.#save(this.#records.map(item => item.project === project && item.id === id ? next : item));
     return structuredClone(next);
   }
+  /** Puts back exactly the record that was there before (or none): the rollback of a repair's trust. */
+  async restore(project, id, previous) {
+    await this.#ready();
+    const others = this.#records.filter(item => !(item.project === project && item.id === id));
+    await this.#save(previous ? [...others, record(previous)] : others);
+  }
   async revoke(project, id) {
     await this.#ready();
     const found = this.find(project, id); if (!found) return false;