@miller-tech/uap 1.172.12 → 1.172.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@miller-tech/uap",
-  "version": "1.172.12",
+  "version": "1.172.13",
   "description": "Autonomous AI agent memory system with CLAUDE.md protocol enforcement",
   "type": "module",
   "main": "dist/index.js",

package/tools/agents/scripts/anthropic_proxy.py

@@ -2766,7 +2766,7 @@ def _detach_aclose(closeable) -> None:
 
 def _build_http_client() -> httpx.AsyncClient:
     """Upstream client factory — used at startup AND by pool self-healing."""
-    c = httpx.AsyncClient(
+    c = DisconnectAwareClient(
         timeout=httpx.Timeout(
             connect=10.0,  # 10s to establish connection
             read=PROXY_READ_TIMEOUT,  # configurable (default 10 min)
@@ -3364,47 +3364,50 @@ PROXY_DISCONNECT_POLL_SECS = max(
 )
 
 
-async def _post_watching_client(
-    client: httpx.AsyncClient, url: str, payload: dict, headers: dict
-) -> httpx.Response:
-    """POST upstream, cancelling it if the caller hangs up mid-generation.
+class DisconnectAwareClient(httpx.AsyncClient):
+    """An httpx client that abandons a call when the caller hangs up.
 
-    Checking only BEFORE each upstream call stops the retry loops, but does
-    nothing for a generation already in flight: a single turn is one POST, so
-    there is no next call to block and the model runs to completion — up to
-    PROXY_TOOL_TURN_MAX_TOKENS (32k, ~13 minutes here) for a client that has
-    already gone. This closes that.
+    THE CHOKE POINT. The previous attempt guarded ONE call site and claimed to
+    cover them all; there are fourteen, and the guardrail loops that caused the
+    incident call the model directly rather than through _post_with_retry. So
+    the check belongs where it cannot be missed: every high-level httpx method —
+    post(), stream(), request() — funnels through send(), so overriding send()
+    covers all of them, including any added later.
 
-    Cancelling the httpx task closes the upstream connection, and llama.cpp
-    releases the slot when its client disappears — verified directly against the
-    running server: slots went 2 -> 0 within 15s of closing the socket. So this
-    genuinely frees the GPU rather than merely letting the proxy stop waiting.
+    Cancelling matters rather than merely returning: closing the connection is
+    what makes llama.cpp release the slot (verified against the running server —
+    slots went 2 -> 0 within 15s of a raw socket close). Returning early without
+    cancelling would leave the model generating exactly as before.
 
-    No probe (background task, tests) means no watching: plain await, unchanged.
+    No probe (background task, health check, tests) means a plain send,
+    unwatched. Streaming sends are covered for their header phase; a body being
+    written to a vanished client fails on write anyway.
     """
-    probe = _current_client_gone.get()
-    if probe is None:
-        return await client.post(url, json=payload, headers=headers)
 
-    post_task = asyncio.ensure_future(client.post(url, json=payload, headers=headers))
-    try:
-        while True:
-            done, _pending = await asyncio.wait(
-                {post_task}, timeout=PROXY_DISCONNECT_POLL_SECS
-            )
-            if post_task in done:
-                return post_task.result()
-            if await _client_gone():
-                post_task.cancel()
-                try:
-                    await post_task
-                except (asyncio.CancelledError, Exception):  # noqa: BLE001
-                    pass  # cancellation is the point; the connection is closed
-                raise ClientGoneError("client disconnected mid-generation")
-    finally:
-        # Never leave the upstream call running after we stop waiting on it.
-        if not post_task.done():
-            post_task.cancel()
+    async def send(self, request, **kwargs):  # type: ignore[override]
+        probe = _current_client_gone.get()
+        if probe is None:
+            return await super().send(request, **kwargs)
+
+        task = asyncio.ensure_future(super().send(request, **kwargs))
+        try:
+            while True:
+                done, _pending = await asyncio.wait(
+                    {task}, timeout=PROXY_DISCONNECT_POLL_SECS
+                )
+                if task in done:
+                    return task.result()
+                if await _client_gone():
+                    task.cancel()
+                    try:
+                        await task
+                    except (asyncio.CancelledError, Exception):  # noqa: BLE001
+                        pass  # cancellation is the point; the connection is closed
+                    raise ClientGoneError("client disconnected mid-generation")
+        finally:
+            # Never leave an upstream call running once we stop waiting on it.
+            if not task.done():
+                task.cancel()
 
 
 async def _post_with_retry_inner(
@@ -3418,7 +3421,7 @@ async def _post_with_retry_inner(
         try:
             _inflight_inc(client)
             try:
-                resp = await _post_watching_client(client, url, payload, headers)
+                resp = await client.post(url, json=payload, headers=headers)
             finally:
                 _inflight_dec(client)
             # Cycle 19 Option 1: if 503 "Loading model", wait for health then retry
@@ -3495,7 +3498,7 @@ async def _check_slot_hang(slot_url: str) -> bool:
     if PROXY_SLOT_HANG_TIMEOUT <= 0:
         return False
     try:
-        async with httpx.AsyncClient() as check_client:
+        async with DisconnectAwareClient() as check_client:
             resp = await check_client.get(slot_url, timeout=5.0)
             if resp.status_code != 200:
                 return False

package/tools/agents/tests/test_upstream_chokepoint.py

@@ -0,0 +1,178 @@
+#!/usr/bin/env python3
+"""Every upstream call must pass the disconnect check — structurally, not by claim.
+
+This test exists because of a specific mistake. Two releases (v1.172.11,
+v1.172.12) guarded ONE call site while the commit message asserted that "every
+upstream call funnels through _post_with_retry, so one check covers them all".
+There are fourteen upstream call sites, and the guardrail loops that caused the
+incident — malformed-tool retry, completion-contract, empty-max-tokens recovery,
+unexpected-end-turn, recipe — call the model DIRECTLY. Both releases were
+therefore near-no-ops for the workload they were written for, and every unit
+test still passed.
+
+The fix was to move the check somewhere it cannot be missed: httpx routes every
+high-level method (post, stream, request) through send(), so DisconnectAwareClient
+overrides send() and the coverage becomes a property of the client rather than a
+property of remembering.
+
+These tests pin that property. A future call site added anywhere in the proxy is
+covered automatically; a future *client* constructed bare would not be, and that
+is exactly what the enumeration below fails on.
+"""
+
+import ast
+import asyncio
+import importlib.util
+import re
+import unittest
+from pathlib import Path
+
+PROXY_PATH = Path(__file__).resolve().parents[1] / "scripts" / "anthropic_proxy.py"
+
+
+def _load_proxy():
+    spec = importlib.util.spec_from_file_location("anthropic_proxy_choke", PROXY_PATH)
+    assert spec is not None and spec.loader is not None
+    m = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(m)
+    return m
+
+
+proxy = _load_proxy()
+SRC = PROXY_PATH.read_text()
+
+
+class ChokePointEnumerationTest(unittest.TestCase):
+    def test_no_bare_httpx_client_is_ever_constructed(self):
+        """The invariant. A bare httpx.AsyncClient bypasses the override, so its
+        calls silently go unwatched — which is precisely how the first two
+        attempts failed, one call site at a time."""
+        bare = [
+            (i + 1, l.strip())
+            for i, l in enumerate(SRC.split("\n"))
+            if re.search(r"httpx\.AsyncClient\s*\(", l) and "class " not in l
+        ]
+        self.assertEqual(
+            bare, [], f"these construct an unwatched client: {bare}"
+        )
+
+    def test_the_client_actually_subclasses_httpx(self):
+        """Guards the reverse mistake: a wrapper that no longer IS an httpx
+        client would break every caller rather than fail this suite loudly."""
+        import httpx
+
+        self.assertTrue(issubclass(proxy.DisconnectAwareClient, httpx.AsyncClient))
+
+    def test_send_is_overridden_on_the_client_itself(self):
+        """send() is the funnel. If a refactor moves the logic off send() onto,
+        say, post(), then stream() and request() silently lose their guard."""
+        self.assertIn("send", vars(proxy.DisconnectAwareClient))
+
+    def test_every_upstream_call_site_is_reachable_through_send(self):
+        """Inventory, so the count cannot quietly drift.
+
+        Any client.post / client.stream / client.send in the proxy is covered by
+        the override — that is the point of a choke point. This asserts the call
+        sites still exist in numbers consistent with the audit (they were the
+        thing miscounted), and that none of them re-implements its own transport.
+        """
+        calls = re.findall(r"client\.(post|send|stream)\s*\(", SRC)
+        self.assertGreaterEqual(
+            len(calls), 10, "upstream call sites vanished — was transport re-implemented?"
+        )
+        # No call site may build its own client inline and slip the override.
+        self.assertNotRegex(SRC, r"await\s+httpx\.AsyncClient\s*\(")
+
+
+class ChokePointBehaviourTest(unittest.TestCase):
+    """The override must do the job, not merely exist."""
+
+    class _Req:
+        pass
+
+    def setUp(self):
+        proxy.PROXY_DISCONNECT_POLL_SECS = 0.05
+
+    def _client_with_send(self, behaviour):
+        """A DisconnectAwareClient whose SUPERCLASS send is stubbed, so the
+        override under test runs for real."""
+        import httpx
+
+        state = {"cancelled": False}
+
+        async def fake_send(self, request, **kwargs):
+            if behaviour == "fast":
+                return "RESPONSE"
+            try:
+                await asyncio.sleep(3600)
+            except asyncio.CancelledError:
+                state["cancelled"] = True
+                raise
+
+        original = httpx.AsyncClient.send
+        httpx.AsyncClient.send = fake_send  # type: ignore[assignment]
+        client = proxy.DisconnectAwareClient()
+        return client, state, (lambda: setattr(httpx.AsyncClient, "send", original))
+
+    def _set_probe(self, gone: bool):
+        async def probe() -> bool:
+            return gone
+        proxy._current_client_gone.set(probe)
+
+    def test_cancels_upstream_when_the_caller_leaves(self):
+        client, state, restore = self._client_with_send("never")
+        try:
+            self._set_probe(True)
+
+            async def run():
+                with self.assertRaises(proxy.ClientGoneError):
+                    await client.send(self._Req())
+
+            asyncio.run(run())
+            self.assertTrue(state["cancelled"], "upstream call was not cancelled")
+        finally:
+            restore()
+
+    def test_leaves_a_live_call_alone(self):
+        client, state, restore = self._client_with_send("fast")
+        try:
+            self._set_probe(False)
+            self.assertEqual(asyncio.run(client.send(self._Req())), "RESPONSE")
+            self.assertFalse(state["cancelled"])
+        finally:
+            restore()
+
+    def test_no_probe_means_unwatched(self):
+        """Health checks and background tasks have no request context and must
+        keep working rather than acquiring surprise cancellation."""
+        client, state, restore = self._client_with_send("fast")
+        try:
+            proxy._current_client_gone.set(None)
+            self.assertEqual(asyncio.run(client.send(self._Req())), "RESPONSE")
+        finally:
+            restore()
+
+    def test_a_slow_but_live_call_is_left_pending(self):
+        """Mistaking 'slow' for 'gone' would be worse than the bug being fixed."""
+        client, state, restore = self._client_with_send("never")
+        try:
+            self._set_probe(False)
+
+            async def run():
+                task = asyncio.ensure_future(client.send(self._Req()))
+                await asyncio.sleep(0.4)  # ~8 poll intervals
+                still = not task.done()
+                task.cancel()
+                try:
+                    await task
+                except (asyncio.CancelledError, Exception):
+                    pass
+                return still
+
+            self.assertTrue(asyncio.run(run()), "a live-but-slow call was ended early")
+        finally:
+            restore()
+
+
+if __name__ == "__main__":
+    unittest.main()

package/tools/agents/tests/test_inflight_cancel.py

@@ -1,129 +0,0 @@
-#!/usr/bin/env python3
-"""Cancel the upstream generation when the caller hangs up mid-turn.
-
-Checking only BEFORE each upstream call (v1.172.11) stops the retry loops, but
-does nothing for a generation already in flight: a single turn is ONE post, so
-there is no next call to block and the model runs to completion — up to
-PROXY_TOOL_TURN_MAX_TOKENS (32k, ~13 minutes on this box) for a client that has
-already gone.
-
-That gap was caught by an end-to-end test, not by reasoning: the abandon simply
-never fired for a single long request. These tests pin the closing behaviour so
-it cannot silently regress to the pre-check-only version.
-
-Cancelling matters rather than merely returning: closing the upstream connection
-is what makes llama.cpp release the slot (verified against the running server —
-slots went 2 -> 0 within 15s of a raw socket close).
-"""
-
-import asyncio
-import importlib.util
-import unittest
-from pathlib import Path
-
-
-def _load_proxy():
-    p = Path(__file__).resolve().parents[1] / "scripts" / "anthropic_proxy.py"
-    spec = importlib.util.spec_from_file_location("anthropic_proxy_inflight", p)
-    assert spec is not None and spec.loader is not None
-    m = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(m)
-    return m
-
-
-proxy = _load_proxy()
-
-
-class _Client:
-    """Stands in for httpx.AsyncClient.post.
-
-    `never` models the real failure: the model is generating, so the POST is
-    neither erroring nor returning — it is simply not done yet.
-    """
-
-    def __init__(self, mode: str):
-        self.mode = mode
-        self.cancelled = False
-
-    async def post(self, url, json=None, headers=None):  # noqa: A002
-        if self.mode == "fast":
-            return "RESPONSE"
-        try:
-            await asyncio.sleep(3600)
-        except asyncio.CancelledError:
-            self.cancelled = True
-            raise
-        return "RESPONSE"
-
-
-def _set_probe(gone: bool):
-    async def probe() -> bool:
-        return gone
-    proxy._current_client_gone.set(probe)
-
-
-class InflightCancelTest(unittest.TestCase):
-    def setUp(self):
-        proxy.PROXY_DISCONNECT_POLL_SECS = 0.05  # keep the tests quick
-
-    def test_cancels_the_upstream_call_when_the_caller_leaves(self):
-        client = _Client("never")
-        _set_probe(True)
-
-        async def run():
-            with self.assertRaises(proxy.ClientGoneError):
-                await proxy._post_watching_client(client, "u", {}, {})
-
-        asyncio.run(run())
-        # The cancellation is the whole point: it closes the connection, which is
-        # what frees the llama slot. Returning early without it would leave the
-        # model generating exactly as before.
-        self.assertTrue(client.cancelled, "upstream POST was not cancelled")
-
-    def test_leaves_a_live_turn_completely_alone(self):
-        client = _Client("fast")
-        _set_probe(False)
-        self.assertEqual(asyncio.run(proxy._post_watching_client(client, "u", {}, {})), "RESPONSE")
-        self.assertFalse(client.cancelled)
-
-    def test_no_probe_means_a_plain_await(self):
-        """Background tasks and tests have no request context. They must keep
-        working, unwatched, rather than acquiring surprise cancellation."""
-        client = _Client("fast")
-        proxy._current_client_gone.set(None)
-        self.assertEqual(asyncio.run(proxy._post_watching_client(client, "u", {}, {})), "RESPONSE")
-
-    def test_a_slow_but_live_turn_is_left_pending(self):
-        """The poll must not mistake 'slow' for 'gone' — long generations are
-        normal, and cancelling them would be a far worse bug than the one fixed.
-
-        Asserted by letting it poll many times and checking it is STILL running.
-        (Wrapping it in wait_for would prove nothing: a wait_for timeout is the
-        caller giving up, and the cleanup correctly cancels upstream then — which
-        is how the first version of this test fooled itself.)
-        """
-        client = _Client("never")
-        _set_probe(False)
-
-        async def run():
-            task = asyncio.ensure_future(proxy._post_watching_client(client, "u", {}, {}))
-            await asyncio.sleep(0.4)  # ~8 poll intervals
-            still_running = not task.done()
-            task.cancel()
-            try:
-                await task
-            except (asyncio.CancelledError, Exception):
-                pass
-            return still_running
-
-        self.assertTrue(asyncio.run(run()), "a live-but-slow turn was ended early")
-
-    def test_poll_interval_has_a_floor(self):
-        """A zero/negative interval would spin the event loop."""
-        self.assertGreaterEqual(proxy.PROXY_DISCONNECT_POLL_SECS, 0.0)
-        mod = _load_proxy()
-        self.assertGreaterEqual(mod.PROXY_DISCONNECT_POLL_SECS, 0.5)
-
-
-if __name__ == "__main__":
-    unittest.main()