@milaboratories/pl-drivers 1.5.14 → 1.5.16

package/package.json

@@ -1,6 +1,9 @@
 {
   "name": "@milaboratories/pl-drivers",
-  "version": "1.5.14",
+  "version": "1.5.16",
+  "engines": {
+    "node": ">=20"
+  },
   "description": "Drivers and a low-level clients for log streaming, downloading and uploading files from and to pl",
   "types": "./dist/index.d.ts",
   "main": "./dist/index.js",
@@ -27,11 +30,11 @@
     "tar-fs": "^3.0.8",
     "undici": "^7.2.3",
     "zod": "~3.23.8",
-    "@milaboratories/computable": "^2.3.4",
     "@milaboratories/ts-helpers": "^1.1.3",
-    "@milaboratories/pl-client": "^2.7.4",
     "@milaboratories/pl-tree": "^1.4.23",
-    "@milaboratories/pl-model-common": "^1.10.5"
+    "@milaboratories/computable": "^2.3.4",
+    "@milaboratories/pl-model-common": "^1.10.5",
+    "@milaboratories/pl-client": "^2.7.4"
   },
   "devDependencies": {
     "eslint": "^9.16.0",
@@ -44,8 +47,8 @@
     "jest": "^29.7.0",
     "@jest/globals": "^29.7.0",
     "ts-jest": "^29.2.5",
-    "@milaboratories/platforma-build-configs": "1.0.2",
-    "@milaboratories/eslint-config": "^1.0.1"
+    "@milaboratories/eslint-config": "^1.0.1",
+    "@milaboratories/platforma-build-configs": "1.0.2"
   },
   "scripts": {
     "type-check": "tsc --noEmit --composite false",

package/src/clients/download.ts

@@ -1,3 +1,4 @@
+/* eslint-disable n/no-unsupported-features/node-builtins */
 import { addRTypeToMetadata } from '@milaboratories/pl-client';
 import type { ResourceInfo } from '@milaboratories/pl-tree';
 import type { MiLogger } from '@milaboratories/ts-helpers';

package/src/clients/progress.ts

@@ -78,7 +78,7 @@ export class ClientProgress {
 
       yield * responses;
     } catch (e) {
-      this.logger.warn('Failed to get realtime status' + e);
+      this.logger.warn('Failed to get realtime status' + String(e));
       throw e;
     }
   }

package/src/clients/upload.ts

@@ -69,20 +69,24 @@ export class ClientUpload {
     const chunk = await readFileChunk(path, info.chunkStart, info.chunkEnd);
     await checkExpectedMTime(path, expectedMTimeUnix);
 
-    const {
-      body: rawBody,
-      statusCode,
-      headers,
-    } = await request(info.uploadUrl, {
-      dispatcher: this.httpClient,
-      body: chunk,
-      headers: toHeadersMap(info.headers),
-      method: info.method.toUpperCase() as Dispatcher.HttpMethod,
-    });
-
-    // always read the body for resources to be garbage collected.
-    const body = await rawBody.text();
-    checkStatusCodeOk(statusCode, body, headers, info);
+    try {
+      const {
+        body: rawBody,
+        statusCode,
+        headers,
+      } = await request(info.uploadUrl, {
+        dispatcher: this.httpClient,
+        body: chunk,
+        headers: toHeadersMap(info.headers),
+        method: info.method.toUpperCase() as Dispatcher.HttpMethod,
+      });
+
+      // always read the body for resources to be garbage collected.
+      const body = await rawBody.text();
+      checkStatusCodeOk(statusCode, body, headers, info);
+    } catch (e: unknown) {
+      throw new Error(`partUpload: error ${JSON.stringify(e)} happened while trying to do part upload to the url ${info.uploadUrl}, headers: ${JSON.stringify(info.headers)}`);
+    }
 
     await this.grpcUpdateProgress({ id, type }, info.chunkEnd - info.chunkStart, options);
   }
@@ -151,11 +155,11 @@ async function readFileChunk(path: string, chunkStart: bigint, chunkEnd: bigint)
     const bytesRead = await readBytesFromPosition(f, b, len, pos);
 
     return b.subarray(0, bytesRead);
-  } catch (e: any) {
-    if (e.code == 'ENOENT') throw new NoFileForUploading(`there is no file ${path} for uploading`);
+  } catch (e: unknown) {
+    if (e && typeof e === 'object' && ('code' in e) && e.code == 'ENOENT') throw new NoFileForUploading(`there is no file ${path} for uploading`);
     throw e;
   } finally {
-    f?.close();
+    await f?.close();
   }
 }
 
@@ -195,7 +199,7 @@ function checkStatusCodeOk(
   if (statusCode != 200) {
     throw new NetworkError(
       `response is not ok, status code: ${statusCode},`
-      + ` body: ${body}, headers: ${headers}, url: ${info.uploadUrl}`,
+      + ` body: ${body}, headers: ${JSON.stringify(headers)}, url: ${info.uploadUrl}`,
     );
   }
 }

package/src/helpers/download.ts

@@ -1,3 +1,5 @@
+// @TODO Gleb Zakharov
+/* eslint-disable n/no-unsupported-features/node-builtins */
 import type { Dispatcher } from 'undici';
 import { request } from 'undici';
 import { Readable } from 'node:stream';
@@ -36,7 +38,7 @@ export class RemoteFileDownloader {
   }
 }
 
-async function checkStatusCodeOk(statusCode: number, webBody: ReadableStream<any>, url: string) {
+async function checkStatusCodeOk(statusCode: number, webBody: ReadableStream, url: string) {
   if (statusCode != 200) {
     const beginning = (await text(webBody)).substring(0, 1000);