@milaboratories/pl-drivers 1.3.2 → 1.3.4

package/src/drivers/download_url.ts

@@ -3,17 +3,12 @@ import {
   MiLogger,
   TaskProcessor,
   notEmpty,
-  fileExists,
+  fileExists
 } from '@milaboratories/ts-helpers';
 import * as fsp from 'node:fs/promises';
 import * as path from 'node:path';
 import { Writable, Transform } from 'node:stream';
-import {
-  ChangeSource,
-  Computable,
-  ComputableCtx,
-  Watcher
-} from '@milaboratories/computable';
+import { ChangeSource, Computable, ComputableCtx, Watcher } from '@milaboratories/computable';
 import { randomUUID, createHash } from 'node:crypto';
 import * as zlib from 'node:zlib';
 import * as tar from 'tar-fs';
@@ -63,10 +58,7 @@ export class DownloadUrlDriver implements DownloadUrlSyncReader {
       nConcurrentDownloads: 50
     }
   ) {
-    this.downloadQueue = new TaskProcessor(
-      this.logger,
-      this.opts.nConcurrentDownloads
-    );
+    this.downloadQueue = new TaskProcessor(this.logger, this.opts.nConcurrentDownloads);
     this.cache = new FilesCache(this.opts.cacheSoftSizeBytes);
     this.downloadHelper = new DownloadHelper(httpClient);
   }
@@ -148,11 +140,7 @@ export class DownloadUrlDriver implements DownloadUrlSyncReader {
     } else {
       // The task is still in a downloading queue.
       const deleted = task.counter.dec(callerId);
-      if (deleted)
-        this.removeTask(
-          task,
-          `the task ${JSON.stringify(task)} was removed from cache`
-        );
+      if (deleted) this.removeTask(task, `the task ${JSON.stringify(task)} was removed from cache`);
     }
   }
 
@@ -165,10 +153,7 @@ export class DownloadUrlDriver implements DownloadUrlSyncReader {
         await rmRFDir(task.path);
         this.cache.removeCache(task);
 
-        this.removeTask(
-          task,
-          `the task ${task} was released when the driver was closed`
-        );
+        this.removeTask(task, `the task ${task} was released when the driver was closed`);
       })
     );
   }
@@ -240,11 +225,7 @@ class Download {
       return await dirSize(this.path);
     }
 
-    const resp = await clientDownload.downloadRemoteFile(
-      this.url.toString(),
-      {},
-      signal
-    );
+    const resp = await clientDownload.downloadRemoteFile(this.url.toString(), {}, signal);
     let content = resp.content;
 
     if (withGunzip) {

package/src/drivers/helpers/helpers.ts

@@ -73,9 +73,7 @@ export async function getStream(
   });
 }
 
-export type MixcrProgressResponse =
-  | { found: false }
-  | ({ found: true } & MixcrProgressLine);
+export type MixcrProgressResponse = { found: false } | ({ found: true } & MixcrProgressLine);
 
 export type MixcrProgressLine = {
   stage: string; // Building pre-clones from tag groups
@@ -86,8 +84,7 @@ export type MixcrProgressLine = {
 /** Is set by a template code.
  * Mixcr adds this prefix to every log line that contains a progress. */
 const mixcrProgressPrefix = '8C7#F1328%9E089B3D22';
-const mixcrProgressRegex =
-  /(?<stage>.*):\s*(?<progress>[\d.]+%)\s.*(?<eta>ETA:.*)/g;
+const mixcrProgressRegex = /(?<stage>.*):\s*(?<progress>[\d.]+%)\s.*(?<eta>ETA:.*)/g;
 
 export function lineToProgress(line: string): MixcrProgressLine | undefined {
   const noPrefix = line.replace(mixcrProgressPrefix, '');
@@ -111,13 +108,7 @@ export async function mixcrProgressFromLogs(
   client: ClientLogs,
   options?: RpcOptions
 ): Promise<MixcrProgressResponse> {
-  const lastLines = await client.lastLines(
-    rInfo,
-    1,
-    0n,
-    mixcrProgressPrefix,
-    options
-  );
+  const lastLines = await client.lastLines(rInfo, 1, 0n, mixcrProgressPrefix, options);
   if (lastLines.data == null || lastLines.data.length == 0) {
     return { found: false };
   }

package/src/drivers/helpers/test_helpers.ts

@@ -1,5 +1,3 @@
 export const PL_STORAGE_TO_PATH = process.env.PL_STORAGE_TO_PATH
-  ? Object.fromEntries(
-      process.env.PL_STORAGE_TO_PATH.split(';').map((kv) => kv.split(':'))
-    )
+  ? Object.fromEntries(process.env.PL_STORAGE_TO_PATH.split(';').map((kv) => kv.split(':')))
   : {};

package/src/drivers/logs.test.ts

@@ -11,11 +11,7 @@ import {
   stringifyWithResourceId,
   ResourceId
 } from '@milaboratories/pl-client';
-import {
-  ConsoleLoggerAdapter,
-  HmacSha256Signer,
-  notEmpty
-} from '@milaboratories/ts-helpers';
+import { ConsoleLoggerAdapter, HmacSha256Signer, notEmpty } from '@milaboratories/ts-helpers';
 import { scheduler } from 'node:timers/promises';
 import { Computable } from '@milaboratories/computable';
 import * as os from 'node:os';
@@ -47,17 +43,10 @@ test('should get all logs', async () => {
     );
     const logs = new LogsDriver(logsStream, download);
 
-    await createRunCommandWithStdoutStream(client, 'bash', [
-      '-c',
-      'echo 1; sleep 1; echo 2'
-    ]);
+    await createRunCommandWithStdoutStream(client, 'bash', ['-c', 'echo 1; sleep 1; echo 2']);
 
     const c = Computable.make((ctx) => {
-      const streamManager = ctx
-        .accessor(tree.entry())
-        .node()
-        .traverse('result')
-        ?.persist();
+      const streamManager = ctx.accessor(tree.entry()).node().traverse('result')?.persist();
       if (streamManager === undefined) {
         ctx.markUnstable('no stream manager');
         return;
@@ -100,11 +89,7 @@ test('should get last line with a prefix', async () => {
     const logs = new LogsDriver(logsStream, download);
 
     const c = Computable.make((ctx) => {
-      const streamManager = ctx
-        .accessor(tree.entry())
-        .node()
-        .traverse('result')
-        ?.persist();
+      const streamManager = ctx.accessor(tree.entry()).node().traverse('result')?.persist();
       if (streamManager === undefined) {
         ctx.markUnstable('no stream manager');
         return;
@@ -154,11 +139,7 @@ test('should get log smart object and get log lines from that', async () => {
     const logs = new LogsDriver(logsStream, download);
 
     const c = Computable.make((ctx) => {
-      const streamManager = ctx
-        .accessor(tree.entry())
-        .node()
-        .traverse('result')
-        ?.persist();
+      const streamManager = ctx.accessor(tree.entry()).node().traverse('result')?.persist();
       if (streamManager === undefined) {
         ctx.markUnstable('no stream manager');
         return;
@@ -167,10 +148,7 @@ test('should get log smart object and get log lines from that', async () => {
       return logs.getLogHandle(streamManager, ctx);
     });
 
-    await createRunCommandWithStdoutStream(client, 'bash', [
-      '-c',
-      'echo 1; sleep 1; echo 2'
-    ]);
+    await createRunCommandWithStdoutStream(client, 'bash', ['-c', 'echo 1; sleep 1; echo 2']);
 
     let handle = await c.getValue();
 
@@ -204,26 +182,23 @@ async function createRunCommandWithStdoutStream(
   cmd: string,
   args: string[]
 ): Promise<ResourceId> {
-  return await client.withWriteTx(
-    'CreateRunCommandWithStreaming',
-    async (tx: PlTransaction) => {
-      const wdFId: FieldRef = createWd(tx);
-      const workdirOut: FieldRef = createRunCommand(tx, wdFId, cmd, args);
-      const blobsOut: FieldRef = createWdSave(tx, workdirOut);
-      const downloadableFId = createDownloadableBlobFromStdout(tx, blobsOut);
-      const streamManagerId = createStreamManager(tx, wdFId, downloadableFId);
-
-      const dynamicId: FieldId = {
-        resourceId: client.clientRoot,
-        fieldName: 'result'
-      };
-      tx.createField(dynamicId, 'Dynamic', streamManagerId);
-
-      await tx.commit();
-
-      return await streamManagerId.globalId;
-    }
-  );
+  return await client.withWriteTx('CreateRunCommandWithStreaming', async (tx: PlTransaction) => {
+    const wdFId: FieldRef = createWd(tx);
+    const workdirOut: FieldRef = createRunCommand(tx, wdFId, cmd, args);
+    const blobsOut: FieldRef = createWdSave(tx, workdirOut);
+    const downloadableFId = createDownloadableBlobFromStdout(tx, blobsOut);
+    const streamManagerId = createStreamManager(tx, wdFId, downloadableFId);
+
+    const dynamicId: FieldId = {
+      resourceId: client.clientRoot,
+      fieldName: 'result'
+    };
+    tx.createField(dynamicId, 'Dynamic', streamManagerId);
+
+    await tx.commit();
+
+    return await streamManagerId.globalId;
+  });
 }
 
 function createWd(tx: PlTransaction): FieldRef {
@@ -268,11 +243,7 @@ function createRunCommand(
   tx.setField({ resourceId: runCmdId, fieldName: 'refs' }, refsId);
   setInputValue('cmd', { name: 'RunCommandCmd', version: '1' }, cmdData);
   setInputValue('args', { name: 'RunCommandArgs', version: '1' }, argsData);
-  setInputValue(
-    'options',
-    { name: 'run-command/options', version: '1' },
-    optsData
-  );
+  setInputValue('options', { name: 'run-command/options', version: '1' }, optsData);
 
   return { resourceId: runCmdId, fieldName: 'workdirOut' };
 }
@@ -295,10 +266,7 @@ function createWdSave(tx: PlTransaction, workdirOut: FieldRef): FieldRef {
   return { resourceId: wdSave, fieldName: 'blobsOut' };
 }
 
-function createDownloadableBlobFromStdout(
-  tx: PlTransaction,
-  blobsOut: FieldRef
-): FieldRef {
+function createDownloadableBlobFromStdout(tx: PlTransaction, blobsOut: FieldRef): FieldRef {
   const blobOut = tx.getFutureFieldValue(blobsOut, 'logs.txt', 'Input');
   const blobDownloadId = tx.createStruct({
     name: 'BlobDownload',
@@ -316,10 +284,7 @@ function createStreamManager(
 ): ResourceRef {
   const streamId = tx.createEphemeral({ name: 'CreateStream', version: '2' });
   tx.setField({ resourceId: streamId, fieldName: 'workdir' }, wdFId);
-  const filePathId = tx.createValue(
-    { name: 'json/string', version: '1' },
-    jsonToData('logs.txt')
-  );
+  const filePathId = tx.createValue({ name: 'json/string', version: '1' }, jsonToData('logs.txt'));
   tx.setField({ resourceId: streamId, fieldName: 'filePath' }, filePathId);
   const streamFId = { resourceId: streamId, fieldName: 'stream' };
 
@@ -327,10 +292,7 @@ function createStreamManager(
     name: 'StreamManager',
     version: '2'
   });
-  tx.setField(
-    { resourceId: streamManagerId, fieldName: 'downloadable' },
-    downloadableFId
-  );
+  tx.setField({ resourceId: streamManagerId, fieldName: 'downloadable' }, downloadableFId);
   tx.setField({ resourceId: streamManagerId, fieldName: 'stream' }, streamFId);
 
   return streamManagerId;

package/src/drivers/logs.ts

@@ -14,18 +14,13 @@ export class LogsDriver implements sdk.LogsDriver {
   /** Returns all logs and schedules a job that reads remain logs.
    * Notifies when a new portion of the log appeared. */
   getLastLogs(res: PlTreeEntry, lines: number): Computable<string | undefined>;
-  getLastLogs(
-    res: PlTreeEntry,
-    lines: number,
-    ctx: ComputableCtx
-  ): Computable<string | undefined>;
+  getLastLogs(res: PlTreeEntry, lines: number, ctx: ComputableCtx): Computable<string | undefined>;
   getLastLogs(
     res: PlTreeEntry,
     lines: number,
     ctx?: ComputableCtx
   ): Computable<string | undefined> | string | undefined {
-    if (ctx === undefined)
-      return Computable.make((ctx) => this.getLastLogs(res, lines, ctx));
+    if (ctx === undefined) return Computable.make((ctx) => this.getLastLogs(res, lines, ctx));
 
     const stream = streamManagerGetStream(ctx, res);
     if (stream === undefined) {
@@ -33,16 +28,13 @@ export class LogsDriver implements sdk.LogsDriver {
       return undefined;
     }
 
-    if (isBlob(stream))
-      return this.downloadDriver.getLastLogs(stream, lines, ctx);
+    if (isBlob(stream)) return this.downloadDriver.getLastLogs(stream, lines, ctx);
 
     try {
       return this.logsStreamDriver.getLastLogs(stream, lines, ctx);
     } catch (e: any) {
       if (e.name == 'RpcError' && e.code == 'NOT_FOUND') {
-        ctx.markUnstable(
-          `NOT_FOUND in logs stream driver while getting last logs: ${e}`
-        );
+        ctx.markUnstable(`NOT_FOUND in logs stream driver while getting last logs: ${e}`);
         return undefined;
       }
       throw e;
@@ -51,24 +43,15 @@ export class LogsDriver implements sdk.LogsDriver {
 
   /** Returns a last line that has patternToSearch.
    * Notifies when a new line appeared or EOF reached. */
-  getProgressLog(
-    res: PlTreeEntry,
-    patternToSearch: string
-  ): Computable<string | undefined>;
-  getProgressLog(
-    res: PlTreeEntry,
-    patternToSearch: string,
-    ctx: ComputableCtx
-  ): string | undefined;
+  getProgressLog(res: PlTreeEntry, patternToSearch: string): Computable<string | undefined>;
+  getProgressLog(res: PlTreeEntry, patternToSearch: string, ctx: ComputableCtx): string | undefined;
   getProgressLog(
     res: PlTreeEntry,
     patternToSearch: string,
     ctx?: ComputableCtx
   ): Computable<string | undefined> | string | undefined {
     if (ctx === undefined)
-      return Computable.make((ctx) =>
-        this.getProgressLog(res, patternToSearch, ctx)
-      );
+      return Computable.make((ctx) => this.getProgressLog(res, patternToSearch, ctx));
 
     const stream = streamManagerGetStream(ctx, res);
     if (stream === undefined) {
@@ -76,16 +59,13 @@ export class LogsDriver implements sdk.LogsDriver {
       return undefined;
     }
 
-    if (isBlob(stream))
-      return this.downloadDriver.getProgressLog(stream, patternToSearch, ctx);
+    if (isBlob(stream)) return this.downloadDriver.getProgressLog(stream, patternToSearch, ctx);
 
     try {
       return this.logsStreamDriver.getProgressLog(stream, patternToSearch, ctx);
     } catch (e: any) {
       if (e.name == 'RpcError' && e.code == 'NOT_FOUND') {
-        ctx.markUnstable(
-          `NOT_FOUND in logs stream driver while getting a progress log: ${e}`
-        );
+        ctx.markUnstable(`NOT_FOUND in logs stream driver while getting a progress log: ${e}`);
         return undefined;
       }
       throw e;
@@ -94,19 +74,13 @@ export class LogsDriver implements sdk.LogsDriver {
 
   /** Returns an Id of a smart object, that can read logs directly from
    * the platform. */
-  getLogHandle(
-    res: ResourceInfo | PlTreeEntry
-  ): Computable<sdk.AnyLogHandle | undefined>;
-  getLogHandle(
-    res: PlTreeEntry,
-    ctx: ComputableCtx
-  ): sdk.AnyLogHandle | undefined;
+  getLogHandle(res: ResourceInfo | PlTreeEntry): Computable<sdk.AnyLogHandle | undefined>;
+  getLogHandle(res: PlTreeEntry, ctx: ComputableCtx): sdk.AnyLogHandle | undefined;
   getLogHandle(
     res: PlTreeEntry,
     ctx?: ComputableCtx
   ): Computable<sdk.AnyLogHandle | undefined> | sdk.AnyLogHandle | undefined {
-    if (ctx === undefined)
-      return Computable.make((ctx) => this.getLogHandle(res, ctx));
+    if (ctx === undefined) return Computable.make((ctx) => this.getLogHandle(res, ctx));
 
     const stream = streamManagerGetStream(ctx, res);
     if (stream === undefined) {
@@ -126,18 +100,8 @@ export class LogsDriver implements sdk.LogsDriver {
     searchStr?: string
   ): Promise<sdk.StreamingApiResponse> {
     if (isLiveLogHandle(handle))
-      return await this.logsStreamDriver.lastLines(
-        handle,
-        lineCount,
-        offsetBytes,
-        searchStr
-      );
-    return await this.downloadDriver.lastLines(
-      handle,
-      lineCount,
-      offsetBytes,
-      searchStr
-    );
+      return await this.logsStreamDriver.lastLines(handle, lineCount, offsetBytes, searchStr);
+    return await this.downloadDriver.lastLines(handle, lineCount, offsetBytes, searchStr);
   }
 
   async readText(
@@ -147,18 +111,8 @@ export class LogsDriver implements sdk.LogsDriver {
     searchStr?: string
   ): Promise<sdk.StreamingApiResponse> {
     if (isLiveLogHandle(handle))
-      return await this.logsStreamDriver.readText(
-        handle,
-        lineCount,
-        offsetBytes,
-        searchStr
-      );
-    return await this.downloadDriver.readText(
-      handle,
-      lineCount,
-      offsetBytes,
-      searchStr
-    );
+      return await this.logsStreamDriver.readText(handle, lineCount, offsetBytes, searchStr);
+    return await this.downloadDriver.readText(handle, lineCount, offsetBytes, searchStr);
   }
 }
 
@@ -188,10 +142,7 @@ export function handleToData(handle: sdk.AnyLogHandle): ResourceInfo {
   };
 }
 
-export function dataToHandle(
-  live: boolean,
-  rInfo: ResourceInfo
-): sdk.AnyLogHandle {
+export function dataToHandle(live: boolean, rInfo: ResourceInfo): sdk.AnyLogHandle {
   if (live) {
     return `log+live://log/${rInfo.type.name}/${rInfo.type.version}/${BigInt(rInfo.id)}` as sdk.LiveLogHandle;
   }

package/src/drivers/logs_stream.ts

@@ -9,11 +9,7 @@ import { ResourceId } from '@milaboratories/pl-client';
 import { asyncPool, CallersCounter } from '@milaboratories/ts-helpers';
 import { ClientLogs } from '../clients/logs';
 import { randomUUID } from 'node:crypto';
-import {
-  PlTreeEntry,
-  ResourceInfo,
-  treeEntryToResourceInfo
-} from '@milaboratories/pl-tree';
+import { PlTreeEntry, ResourceInfo, treeEntryToResourceInfo } from '@milaboratories/pl-tree';
 import { dataToHandle, handleToData, isLiveLogHandle } from './logs';
 import { scheduler } from 'node:timers/promises';
 import { StreamingAPI_Response } from '../proto/github.com/milaboratory/pl/controllers/shared/grpc/streamingapi/protocol';
@@ -51,10 +47,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     );
   }
 
-  getLastLogs(
-    res: ResourceInfo | PlTreeEntry,
-    lines: number
-  ): Computable<string | undefined>;
+  getLastLogs(res: ResourceInfo | PlTreeEntry, lines: number): Computable<string | undefined>;
   getLastLogs(
     res: ResourceInfo | PlTreeEntry,
     lines: number,
@@ -65,8 +58,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     lines: number,
     ctx?: ComputableCtx
   ): Computable<string | undefined> | string | undefined {
-    if (ctx == undefined)
-      return Computable.make((ctx) => this.getLastLogs(res, lines, ctx));
+    if (ctx == undefined) return Computable.make((ctx) => this.getLastLogs(res, lines, ctx));
 
     const r = treeEntryToResourceInfo(res, ctx);
     const callerId = randomUUID();
@@ -120,21 +112,14 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     ctx?: ComputableCtx
   ): Computable<string | undefined> | string | undefined {
     if (ctx == undefined)
-      return Computable.make((ctx) =>
-        this.getProgressLog(res, patternToSearch, ctx)
-      );
+      return Computable.make((ctx) => this.getProgressLog(res, patternToSearch, ctx));
 
     const r = treeEntryToResourceInfo(res, ctx);
     const callerId = randomUUID();
     ctx.attacheHooks(this.hooks);
     ctx.addOnDestroy(() => this.releaseProgressLog(r.id, callerId));
 
-    const result = this.getProgressLogNoCtx(
-      ctx.watcher,
-      r,
-      patternToSearch,
-      callerId
-    );
+    const result = this.getProgressLogNoCtx(ctx.watcher, r, patternToSearch, callerId);
 
     ctx.markUnstable(
       'The progress log is from the stream, so we consider it unstable. Final value will be got from blobs.'
@@ -152,12 +137,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     let logGetter = this.idToProgressLog.get(rInfo.id);
 
     if (logGetter == undefined) {
-      const newLogGetter = new LogGetter(
-        this.clientLogs,
-        rInfo,
-        1,
-        patternToSearch
-      );
+      const newLogGetter = new LogGetter(this.clientLogs, rInfo, 1, patternToSearch);
       this.idToProgressLog.set(rInfo.id, newLogGetter);
 
       logGetter = newLogGetter;
@@ -171,16 +151,12 @@ export class LogsStreamDriver implements sdk.LogsDriver {
   }
 
   getLogHandle(res: ResourceInfo | PlTreeEntry): Computable<sdk.AnyLogHandle>;
-  getLogHandle(
-    res: ResourceInfo | PlTreeEntry,
-    ctx: ComputableCtx
-  ): sdk.AnyLogHandle;
+  getLogHandle(res: ResourceInfo | PlTreeEntry, ctx: ComputableCtx): sdk.AnyLogHandle;
   getLogHandle(
     res: ResourceInfo | PlTreeEntry,
     ctx?: ComputableCtx
   ): Computable<sdk.AnyLogHandle> | sdk.AnyLogHandle {
-    if (ctx == undefined)
-      return Computable.make((ctx) => this.getLogHandle(res, ctx));
+    if (ctx == undefined) return Computable.make((ctx) => this.getLogHandle(res, ctx));
 
     const r = treeEntryToResourceInfo(res, ctx);
 
@@ -219,12 +195,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     searchStr?: string | undefined
   ) {
     return await this.tryWithNotFound(handle, () =>
-      this.clientLogs.readText(
-        handleToData(handle),
-        lineCount,
-        BigInt(offsetBytes ?? 0),
-        searchStr
-      )
+      this.clientLogs.readText(handleToData(handle), lineCount, BigInt(offsetBytes ?? 0), searchStr)
     );
   }
 
@@ -233,9 +204,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
     method: () => Promise<StreamingAPI_Response>
   ): Promise<sdk.StreamingApiResponse> {
     if (!isLiveLogHandle(handle))
-      throw new Error(
-        `Not live log handle was passed to live log driver, handle: ${handle}`
-      );
+      throw new Error(`Not live log handle was passed to live log driver, handle: ${handle}`);
 
     try {
       const resp = await method();
@@ -269,10 +238,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
 
   private scheduledOnNextState: ScheduledRefresh[] = [];
 
-  private scheduleOnNextState(
-    resolve: () => void,
-    reject: (err: any) => void
-  ): void {
+  private scheduleOnNextState(resolve: () => void, reject: (err: any) => void): void {
     this.scheduledOnNextState.push({ resolve, reject });
   }
 
@@ -300,9 +266,7 @@ export class LogsStreamDriver implements sdk.LogsDriver {
       try {
         await asyncPool(
           this.opts.nConcurrentGetLogs,
-          this.getAllNotDoneLogs().map(
-            (getter) => async () => await getter.update()
-          )
+          this.getAllNotDoneLogs().map((getter) => async () => await getter.update())
         );
 
         toNotify.forEach((n) => n.resolve());

package/src/drivers/ls.test.ts

@@ -1,11 +1,12 @@
 import { ConsoleLoggerAdapter, HmacSha256Signer } from '@milaboratories/ts-helpers';
-import { DefaultVirtualLocalStorages, LsDriver } from './ls';
+import { LsDriver } from './ls';
 import { createLsFilesClient } from '../clients/helpers';
 import { TestHelpers } from '@milaboratories/pl-client';
 import * as os from 'node:os';
 import * as path from 'node:path';
 import { test, expect } from '@jest/globals';
 import { isImportFileHandleIndex, isImportFileHandleUpload } from '@milaboratories/pl-model-common';
+import { DefaultVirtualLocalStorages } from './virtual_storages';
 
 const assetsPath = path.resolve('../../../assets');
 
@@ -18,7 +19,6 @@ test('should ok when get all storages from ls driver', async () => {
       logger,
       client,
       signer,
-      DefaultVirtualLocalStorages(),
       [],
       () => {
         throw Error();
@@ -45,7 +45,6 @@ test('should ok when list files from remote storage in ls driver', async () => {
       logger,
       client,
       signer,
-      DefaultVirtualLocalStorages(),
       [],
       () => {
         throw Error();
@@ -87,7 +86,6 @@ test('should ok when list files from local storage in ls driver', async () => {
       logger,
       client,
       signer,
-      DefaultVirtualLocalStorages(),
       [],
       () => {
         throw Error();
@@ -111,7 +109,6 @@ test('should ok when list files from local storage in ls driver and correctly ap
       logger,
       client,
       signer,
-      DefaultVirtualLocalStorages(),
       [{ storageId: 'test_storage', localPath: path.join(assetsPath, 'ls_dir_structure_test') }],
       async () => [dialogRet]
     );
@@ -153,7 +150,6 @@ test('should ok when get file using local dialog, and read its content', async (
       logger,
       client,
       signer,
-      DefaultVirtualLocalStorages(),
       [],
       async () => [path.join(assetsPath, 'answer_to_the_ultimate_question.txt')]
     );