@milaboratories/pl-drivers 1.2.23 → 1.2.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@milaboratories/pl-drivers",
-  "version": "1.2.23",
+  "version": "1.2.25",
   "description": "Drivers and a low-level clients for log streaming, downloading and uploading files from and to pl",
   "types": "./dist/index.d.ts",
   "main": "./dist/index.js",
@@ -26,10 +26,10 @@
     "tar-fs": "^3.0.6",
     "undici": "^6.19.8",
     "zod": "^3.23.8",
-    "@milaboratories/ts-helpers": "^1.0.27",
-    "@milaboratories/computable": "^2.1.7",
-    "@milaboratories/pl-client": "^2.4.16",
-    "@milaboratories/pl-tree": "^1.3.13",
+    "@milaboratories/ts-helpers": "^1.0.28",
+    "@milaboratories/pl-client": "^2.4.17",
+    "@milaboratories/computable": "^2.1.8",
+    "@milaboratories/pl-tree": "^1.3.14",
     "@milaboratories/pl-model-common": "^1.3.13"
   },
   "devDependencies": {

package/src/drivers/download_and_logs_blob.ts

@@ -662,13 +662,13 @@ export class Download {
       );
 
       if (!(await fileOrDirExists(path.dirname(this.path))))
-        fsp.mkdir(path.dirname(this.path), { recursive: true });
+        await fsp.mkdir(path.dirname(this.path), { recursive: true });
 
       // check in case we already have a file by this resource id
       // in the directory. It can happen when we forgot to call removeAll
       // in the previous launch.
       if (await fileOrDirExists(this.path)) {
-        content.cancel(`the file already existed`); // we don't need the blob
+        await content.cancel(`the file already existed`); // we don't need the blob
       } else {
         const fileToWrite = Writable.toWeb(fs.createWriteStream(this.path));
         await content.pipeTo(fileToWrite);

package/src/helpers/download.ts

@@ -1,6 +1,7 @@
 import { Dispatcher, request } from 'undici';
 import { Readable } from 'node:stream';
 import { ReadableStream } from 'node:stream/web';
+import { text } from 'node:stream/consumers';
 
 export interface DownloadResponse {
   content: ReadableStream;
@@ -24,21 +25,25 @@ export class DownloadHelper {
       signal
     });
 
-    if (400 <= statusCode && statusCode < 500) {
-      body.on('error', (_) => {}).destroy();
-      throw new NetworkError400(
-        `Http error: statusCode: ${statusCode} url: ${url.toString()}`
-      );
-    }
+    const webBody = Readable.toWeb(body);
+
     if (statusCode != 200) {
-      body.on('error', (_) => {}).destroy();
+      const textBody = await text(webBody)
+      const beginning = textBody.substring(0, Math.min(textBody.length, 1000));
+
+      if (400 <= statusCode && statusCode < 500) {
+        throw new NetworkError400(
+          `Http error: statusCode: ${statusCode} url: ${url.toString()}, beginning of body: ${beginning}`
+        );
+      }
+
       throw new Error(
         `Http error: statusCode: ${statusCode} url: ${url.toString()}`
       );
     }
 
     return {
-      content: Readable.toWeb(body),
+      content: webBody,
       size: Number(headers['content-length'])
     };
   }