@mikro-orm/sql 7.2.5-dev.6 → 7.2.5-dev.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/sql",
-  "version": "7.2.5-dev.6",
+  "version": "7.2.5-dev.7",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -53,7 +53,7 @@
     "@mikro-orm/core": "^7.2.4"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.2.5-dev.6"
+    "@mikro-orm/core": "7.2.5-dev.7"
   },
   "engines": {
     "node": ">= 22.17.0"

package/schema/SchemaComparator.js

@@ -166,11 +166,12 @@ export class SchemaComparator {
                 diff.changedTables[viewName] = tableDiff;
             }
         }
-        this.compareRoutines(fromSchema, toSchema, diff);
+        this.compareRoutines(fromSchema, toSchema, diff, !!inverseDiff);
         return diff;
     }
-    compareRoutines(fromSchema, toSchema, diff) {
+    compareRoutines(fromSchema, toSchema, diff, inverse) {
         // `ignoreRoutines` makes routines create-only: new ones are still added, but existing routines are never diffed for drop/alter.
+        // The down diff (`inverse`) mirrors that: it drops what `up` created and never recreates routines unknown to the metadata.
         const ignoreRoutines = this.#platform.getConfig().get('schemaGenerator').ignoreRoutines;
         // Case-fold so user-written `'sql_hash'` matches Oracle's introspected `'SQL_HASH'`.
         const routineKey = (r) => ((r.schema ? `${r.schema}.` : '') + r.name).toLowerCase();
@@ -179,6 +180,9 @@ export class SchemaComparator {
         for (const [key, toRoutine] of toByKey) {
             const fromRoutine = fromByKey.get(key);
             if (!fromRoutine) {
+                if (ignoreRoutines && inverse) {
+                    continue;
+                }
                 diff.newRoutines[key] = toRoutine;
                 this.log(`routine ${key} added`);
                 continue;
@@ -188,7 +192,7 @@ export class SchemaComparator {
                 this.log(`routine ${key} changed`, { fromRoutine, toRoutine });
             }
         }
-        if (!ignoreRoutines) {
+        if (!ignoreRoutines || inverse) {
             for (const [key, fromRoutine] of fromByKey) {
                 if (!toByKey.has(key)) {
                     diff.removedRoutines[key] = fromRoutine;
@@ -493,10 +497,12 @@ export class SchemaComparator {
             tableDifferences.changedChecks[check.name] = toTableCheck;
             changes++;
         }
+        const ignoreTriggers = this.#platform.getConfig().get('schemaGenerator').ignoreTriggers;
         const fromTableTriggers = fromTable.getTriggers();
         const toTableTriggers = toTable.getTriggers();
         for (const trigger of toTableTriggers) {
-            if (fromTable.hasTrigger(trigger.name)) {
+            // see `compareRoutines` for how `ignoreTriggers` applies to the down diff
+            if (fromTable.hasTrigger(trigger.name) || (ignoreTriggers && inverse)) {
                 continue;
             }
             tableDifferences.addedTriggers[trigger.name] = trigger;
@@ -504,7 +510,7 @@ export class SchemaComparator {
             changes++;
         }
         // `ignoreTriggers` makes triggers create-only: declared ones are still added above, but existing triggers are never diffed for drop/alter.
-        if (!this.#platform.getConfig().get('schemaGenerator').ignoreTriggers) {
+        if (!ignoreTriggers || inverse) {
             for (const trigger of fromTableTriggers) {
                 if (!toTable.hasTrigger(trigger.name)) {
                     tableDifferences.removedTriggers[trigger.name] = trigger;
@@ -513,7 +519,7 @@ export class SchemaComparator {
                     continue;
                 }
                 const toTableTrigger = toTable.getTrigger(trigger.name);
-                if (this.diffTrigger(trigger, toTableTrigger)) {
+                if (!ignoreTriggers && this.diffTrigger(trigger, toTableTrigger)) {
                     this.log(`trigger ${trigger.name} changed in table ${tableDifferences.name}`, {
                         fromTableTrigger: trigger,
                         toTableTrigger,