@mikro-orm/sql 7.2.4-dev.0 → 7.2.4-dev.2

package/AbstractSqlDriver.js

@@ -1143,26 +1143,32 @@ export class AbstractSqlDriver extends DatabaseDriver {
         }
         sql += ' where ';
         const pkProps = meta.primaryKeys.concat(...meta.getOwnConcurrencyCheckKeys());
+        // an optimistically locked batch carries the version in every condition
+        if (meta.versionProperty &&
+            where.every(cond => Utils.isPlainObject(cond) && meta.versionProperty in cond)) {
+            pkProps.push(meta.versionProperty);
+        }
         const pks = Utils.flatten(pkProps.map(pk => meta.properties[pk].fieldNames));
         const useTupleIn = pks.length <= 1 || this.platform.allowsComparingTuples();
         const condTemplate = useTupleIn
             ? `(${pks.map(() => '?').join(', ')})`
             : `(${pks.map(pk => `${this.platform.quoteIdentifier(pk)} = ?`).join(' and ')})`;
-        const conds = where.map(cond => {
+        const conds = where.flatMap(cond => {
             // with multiple PK columns the condition is looked up by property name, so it needs to stay an object
             if (pks.length === 1 && Utils.isPlainObject(cond) && Utils.getObjectKeysSize(cond) === 1) {
                 cond = Object.values(cond)[0];
             }
             if (pks.length > 1) {
-                pkProps.forEach(pk => {
-                    if (Array.isArray(cond[pk])) {
-                        params.push(...Utils.flatten(cond[pk]));
-                    }
-                    else {
-                        params.push(cond[pk]);
-                    }
+                // a date version in sqlite matches either of its storage formats (see `convertVersionValue()`)
+                const version = cond[meta.versionProperty];
+                const versions = version?.$in ?? [version];
+                return versions.map(v => {
+                    pkProps.forEach(pk => {
+                        const value = pk === meta.versionProperty ? v : cond[pk];
+                        params.push(...(Array.isArray(value) ? Utils.flatten(value) : [value]));
+                    });
+                    return condTemplate;
                 });
-                return condTemplate;
             }
             params.push(cond);
             return '?';

package/dialects/sqlite/SqliteSchemaHelper.js

@@ -128,8 +128,10 @@ export class SqliteSchemaHelper extends SchemaHelper {
             sql += `, primary key (${primaryKey.columnNames.map(c => this.quote(c)).join(', ')})`;
         }
         const parts = [];
-        for (const fk of Object.values(table.getForeignKeys())) {
-            parts.push(this.createForeignKey(table, fk, false));
+        if (this.options.createForeignKeyConstraints) {
+            for (const fk of Object.values(table.getForeignKeys())) {
+                parts.push(this.createForeignKey(table, fk, false));
+            }
         }
         for (const check of table.getChecks()) {
             const sql = `constraint ${this.quote(check.name)} check (${check.expression})`;
@@ -498,7 +500,7 @@ export class SqliteSchemaHelper extends SchemaHelper {
         const [schemaName, tableName] = this.splitTableName(diff.name);
         if (Utils.hasObjectKeys(diff.removedChecks) ||
             Utils.hasObjectKeys(diff.changedChecks) ||
-            Utils.hasObjectKeys(diff.changedForeignKeys) ||
+            (this.options.createForeignKeyConstraints && Utils.hasObjectKeys(diff.changedForeignKeys)) ||
             Utils.hasObjectKeys(diff.changedColumns) ||
             // sqlite can only add or change a primary key by rebuilding the table
             [...Object.values(diff.addedIndexes), ...Object.values(diff.changedIndexes)].some(index => index.primary)) {
@@ -517,7 +519,8 @@ export class SqliteSchemaHelper extends SchemaHelper {
         if (Object.values(diff.addedColumns).length > 0) {
             this.append(ret, this.getAddColumnsSQL(diff.toTable, Object.values(diff.addedColumns), diff));
         }
-        if (Utils.hasObjectKeys(diff.addedForeignKeys) || Utils.hasObjectKeys(diff.addedChecks)) {
+        if ((this.options.createForeignKeyConstraints && Utils.hasObjectKeys(diff.addedForeignKeys)) ||
+            Utils.hasObjectKeys(diff.addedChecks)) {
             return this.getAlterTempTableSQL(diff);
         }
         for (const [oldColumnName, column] of Object.entries(diff.renamedColumns)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/sql",
-  "version": "7.2.4-dev.0",
+  "version": "7.2.4-dev.2",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -53,7 +53,7 @@
     "@mikro-orm/core": "^7.2.3"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.2.4-dev.0"
+    "@mikro-orm/core": "7.2.4-dev.2"
   },
   "engines": {
     "node": ">= 22.17.0"