@mikro-orm/sql 7.1.7-dev.7 → 7.1.7-dev.8

package/AbstractSqlPlatform.d.ts

@@ -6,6 +6,7 @@ import { NativeQueryBuilder } from './query/NativeQueryBuilder.js';
 /** Base class for SQL database platforms, providing SQL generation and quoting utilities. */
 export declare abstract class AbstractSqlPlatform extends Platform {
     #private;
+    private static readonly ORDER_BY_DIRECTIONS;
     protected readonly schemaHelper?: SchemaHelper;
     usesPivotTable(): boolean;
     indexForeignKeys(): boolean;
@@ -46,6 +47,12 @@ export declare abstract class AbstractSqlPlatform extends Platform {
      * @internal
      */
     getOrderByExpression(column: string, direction: string, collation?: string): string[];
+    /**
+     * `toLowerCase()` folds every `QueryOrder` enum member (and the normalized `QueryOrderNumeric`
+     * values) onto the six allow-listed directions, so only unknown values are rejected.
+     * @internal
+     */
+    validateOrderByDirection(direction: string): string;
     /**
      * Quotes a collation name for use in COLLATE clauses.
      * @internal

package/AbstractSqlPlatform.js

@@ -5,6 +5,14 @@ import { NativeQueryBuilder } from './query/NativeQueryBuilder.js';
 /** Base class for SQL database platforms, providing SQL generation and quoting utilities. */
 export class AbstractSqlPlatform extends Platform {
     static #JSON_PROPERTY_NAME_RE = /^[a-zA-Z_][a-zA-Z0-9_]*$/;
+    static ORDER_BY_DIRECTIONS = new Set([
+        'asc',
+        'desc',
+        'asc nulls first',
+        'asc nulls last',
+        'desc nulls first',
+        'desc nulls last',
+    ]);
     schemaHelper;
     usesPivotTable() {
         return true;
@@ -115,10 +123,23 @@ export class AbstractSqlPlatform extends Platform {
      * @internal
      */
     getOrderByExpression(column, direction, collation) {
+        const dir = this.validateOrderByDirection(direction);
         if (collation) {
-            return [`${column} collate ${this.quoteCollation(collation)} ${direction.toLowerCase()}`];
+            return [`${column} collate ${this.quoteCollation(collation)} ${dir}`];
         }
-        return [`${column} ${direction.toLowerCase()}`];
+        return [`${column} ${dir}`];
+    }
+    /**
+     * `toLowerCase()` folds every `QueryOrder` enum member (and the normalized `QueryOrderNumeric`
+     * values) onto the six allow-listed directions, so only unknown values are rejected.
+     * @internal
+     */
+    validateOrderByDirection(direction) {
+        const dir = ('' + direction).toLowerCase().trim();
+        if (!AbstractSqlPlatform.ORDER_BY_DIRECTIONS.has(dir)) {
+            throw new Error(`Invalid order direction: '${direction}'`);
+        }
+        return dir;
     }
     /**
      * Quotes a collation name for use in COLLATE clauses.

package/dialects/mysql/BaseMySqlPlatform.js

@@ -114,7 +114,7 @@ export class BaseMySqlPlatform extends AbstractSqlPlatform {
     }
     getOrderByExpression(column, direction, collation) {
         const ret = [];
-        const dir = direction.toLowerCase();
+        const dir = this.validateOrderByDirection(direction);
         const col = collation ? `${column} collate ${this.quoteCollation(collation)}` : column;
         if (dir in this.ORDER_BY_NULLS_TRANSLATE) {
             ret.push(`${col} ${this.ORDER_BY_NULLS_TRANSLATE[dir]}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/sql",
-  "version": "7.1.7-dev.7",
+  "version": "7.1.7-dev.8",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -53,7 +53,7 @@
     "@mikro-orm/core": "^7.1.6"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.1.7-dev.7"
+    "@mikro-orm/core": "7.1.7-dev.8"
   },
   "engines": {
     "node": ">= 22.17.0"