@mikro-orm/sql 7.1.5-dev.1 → 7.1.5-dev.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/sql",
-  "version": "7.1.5-dev.1",
+  "version": "7.1.5-dev.11",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -53,7 +53,7 @@
     "@mikro-orm/core": "^7.1.4"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.1.5-dev.1"
+    "@mikro-orm/core": "7.1.5-dev.11"
   },
   "engines": {
     "node": ">= 22.17.0"

package/query/NativeQueryBuilder.js

@@ -389,7 +389,7 @@ export class NativeQueryBuilder {
     }
     processInsertData() {
         const dataAsArray = Utils.asArray(this.options.data);
-        const keys = Object.keys(dataAsArray[0]);
+        const keys = dataAsArray.length > 1 ? [...new Set(dataAsArray.flatMap(row => Object.keys(row)))] : Object.keys(dataAsArray[0]);
         const values = keys.map(() => '?');
         const parts = [];
         this.parts.push(`(${keys.map(key => this.quote(key)).join(', ')})`);

package/schema/DatabaseSchema.js

@@ -1,5 +1,6 @@
 import { ReferenceKind, isRaw, } from '@mikro-orm/core';
 import { DatabaseTable } from './DatabaseTable.js';
+import { normalizeViewDefinition } from './SchemaHelper.js';
 import { getTablePartitioning } from './partitioning.js';
 /**
  * @internal
@@ -364,7 +365,7 @@ export class DatabaseSchema {
     }
     static getViewDefinition(meta, em, platform) {
         if (typeof meta.expression === 'string') {
-            return meta.expression;
+            return normalizeViewDefinition(meta.expression);
         }
         // Expression is a function, need to evaluate it
         /* v8 ignore next */
@@ -378,7 +379,7 @@ export class DatabaseSchema {
         }
         /* v8 ignore next */
         if (typeof result === 'string') {
-            return result;
+            return normalizeViewDefinition(result);
         }
         /* v8 ignore next */
         if (isRaw(result)) {

package/schema/SchemaHelper.d.ts

@@ -6,6 +6,17 @@ import type { DatabaseSchema } from './DatabaseSchema.js';
 import type { DatabaseTable } from './DatabaseTable.js';
 /** Flattens `;\n` boundaries so the schema-generator's statement splitter doesn't break the routine DDL apart. Other whitespace is preserved. */
 export declare function stripStatementNewlines(body: string): string;
+/**
+ * Strips SQL line comments and blank lines from a view definition. Comments are dropped by the
+ * database on `create view` anyway, and a `--` comment would otherwise comment out the rest of the
+ * definition once newlines are collapsed; blank lines act as statement separators in the
+ * schema-generator's statement splitter, which would break the view DDL apart.
+ *
+ * Comment stripping is not string-literal aware, so a `--` inside a string literal (or `a--b` style
+ * arithmetic) is treated as a comment — an accepted tradeoff to avoid a full SQL tokenizer.
+ * @see https://github.com/mikro-orm/mikro-orm/issues/7875
+ */
+export declare function normalizeViewDefinition(definition: string): string;
 /** Base class for database-specific schema helpers. Provides SQL generation for DDL operations. */
 export declare abstract class SchemaHelper {
     protected readonly platform: AbstractSqlPlatform;

package/schema/SchemaHelper.js

@@ -3,6 +3,24 @@ import { isRaw, Utils, } from '@mikro-orm/core';
 export function stripStatementNewlines(body) {
     return body.replace(/;[\t ]*\r?\n/g, '; ');
 }
+/**
+ * Strips SQL line comments and blank lines from a view definition. Comments are dropped by the
+ * database on `create view` anyway, and a `--` comment would otherwise comment out the rest of the
+ * definition once newlines are collapsed; blank lines act as statement separators in the
+ * schema-generator's statement splitter, which would break the view DDL apart.
+ *
+ * Comment stripping is not string-literal aware, so a `--` inside a string literal (or `a--b` style
+ * arithmetic) is treated as a comment — an accepted tradeoff to avoid a full SQL tokenizer.
+ * @see https://github.com/mikro-orm/mikro-orm/issues/7875
+ */
+export function normalizeViewDefinition(definition) {
+    return definition
+        .replace(/--[^\n]*/g, '')
+        .split('\n')
+        .filter(line => line.trim() !== '')
+        .join('\n')
+        .trim();
+}
 /** Base class for database-specific schema helpers. Provides SQL generation for DDL operations. */
 export class SchemaHelper {
     platform;

package/schema/SqlSchemaGenerator.js

@@ -130,7 +130,7 @@ export class SqlSchemaGenerator extends AbstractSchemaGenerator {
             await this.execute(this.helper.disableForeignKeysSQL());
         }
         const schema = options?.schema ?? this.config.get('schema', this.platform.getDefaultSchemaName());
-        for (const meta of this.getOrderedMetadata(schema).reverse()) {
+        for (const meta of this.getOrderedMetadataForClear(schema).reverse()) {
             try {
                 await this.driver
                     .createQueryBuilder(meta.class, this.em?.getTransactionContext(), 'write', false)