@mikro-orm/oracledb 7.3.0-dev.7 → 7.3.0-dev.9

package/OracleSchemaHelper.js

@@ -234,17 +234,12 @@ export class OracleSchemaHelper extends SchemaHelper {
             const isPrimary = index.constraint_type === 'P';
             const isUniqueConstraint = index.constraint_type === 'U';
             const isConstraintIndex = isPrimary || isUniqueConstraint;
-            // Skip indexes that back PRIMARY KEY constraints - they're handled as part of the table definition
-            // and should not be managed as separate indexes
-            if (isPrimary) {
-                continue;
-            }
             const partialMatch = typeof index.expression === 'string' ? OracleSchemaHelper.PARTIAL_INDEX_RE.exec(index.expression) : null;
             const indexDef = {
                 columnNames: [partialMatch ? partialMatch[2] : index.column_name],
                 keyName: index.index_name,
                 unique: index.is_unique === 'YES',
-                primary: false,
+                primary: isPrimary,
                 constraint: isConstraintIndex || index.is_unique === 'YES',
             };
             /* v8 ignore start: function-based (non-partial) index branches */
@@ -412,7 +407,8 @@ export class OracleSchemaHelper extends SchemaHelper {
         const changedTypes = Object.values(tableDiff.changedColumns).filter(col => col.changedProperties.has('type'));
         for (const col of changedTypes) {
             for (const index of indexes) {
-                if (index.columnNames.includes(col.column.name)) {
+                // the index backing the primary key can't be dropped, the key constraint stays in place
+                if (!index.primary && index.columnNames.includes(col.column.name)) {
                     ret.push(this.getDropIndexSQL(name, index));
                 }
             }
@@ -430,7 +426,7 @@ export class OracleSchemaHelper extends SchemaHelper {
         const changedTypes = Object.values(tableDiff.changedColumns).filter(col => col.changedProperties.has('type'));
         for (const col of changedTypes) {
             for (const index of indexes) {
-                if (index.columnNames.includes(col.column.name)) {
+                if (!index.primary && index.columnNames.includes(col.column.name)) {
                     this.append(ret, this.getCreateIndexSQL(name, index));
                 }
             }
@@ -457,8 +453,9 @@ export class OracleSchemaHelper extends SchemaHelper {
         return `drop index ${this.quote(index.keyName)}`;
     }
     dropIndex(table, index, oldIndexName = index.keyName) {
+        // the primary key constraint name is system generated unless named explicitly
         if (index.primary) {
-            return `alter table ${this.quote(table)} drop constraint ${this.quote(oldIndexName)}`;
+            return `alter table ${this.quote(table)} drop primary key`;
         }
         return `drop index ${this.quote(oldIndexName)}`;
     }
@@ -568,7 +565,7 @@ export class OracleSchemaHelper extends SchemaHelper {
     }
     createIndex(index, table, createPrimary = false) {
         if (index.primary) {
-            return '';
+            return createPrimary ? super.createIndex(index, table, true) : '';
         }
         if (index.expression) {
             return index.expression;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/oracledb",
-  "version": "7.3.0-dev.7",
+  "version": "7.3.0-dev.9",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, MariaDB, PostgreSQL, SQLite, MSSQL and Oracle databases.",
   "keywords": [
     "data-mapper",
@@ -42,7 +42,7 @@
     "copy": "node ../../scripts/copy.mjs"
   },
   "dependencies": {
-    "@mikro-orm/sql": "7.3.0-dev.7",
+    "@mikro-orm/sql": "7.3.0-dev.9",
     "kysely": "0.29.6",
     "oracledb": "7.0.1"
   },
@@ -50,7 +50,7 @@
     "@mikro-orm/core": "^7.2.2"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.3.0-dev.7"
+    "@mikro-orm/core": "7.3.0-dev.9"
   },
   "engines": {
     "node": ">= 22.17.0"