@mikro-orm/mssql 7.1.0-dev.20 → 7.1.0-dev.22

package/MsSqlSchemaHelper.d.ts

@@ -30,6 +30,7 @@ export declare class MsSqlSchemaHelper extends SchemaHelper {
     /** Generates SQL to drop an MSSQL trigger. */
     dropTrigger(table: DatabaseTable, trigger: SqlTriggerDef): string;
     private getSchemaQualifiedName;
+    getDatabaseCollation(connection: AbstractSqlConnection, ctx?: Transaction): Promise<string | undefined>;
     getAllTriggers(connection: AbstractSqlConnection, tablesBySchemas: Map<string | undefined, Table[]>): Promise<Dictionary<SqlTriggerDef[]>>;
     loadInformationSchema(schema: DatabaseSchema, connection: AbstractSqlConnection, tables: Table[], schemas?: string[], ctx?: Transaction): Promise<void>;
     getPreAlterTable(tableDiff: TableDifference, safe: boolean): string[];

package/MsSqlSchemaHelper.js

@@ -21,8 +21,29 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         return 'master';
     }
     getDropDatabaseSQL(name) {
+        // `set offline` rejects all connections including the issuing session, so there is no
+        // single-user race window where a torn-down pool connection can reconnect between the
+        // mode switch and the drop (SQL Server error 3702 "currently in use"). Dropping an
+        // offline database leaves the underlying `.mdf`/`.ldf` files behind though, which
+        // makes a subsequent `create database` with the same name fail with error 5170
+        // ("file already exists"). Capture the physical paths up front and call
+        // `master.sys.xp_delete_files` after the drop to clean them up.
         const quoted = this.quote(name);
-        return `if db_id(${this.platform.quoteValue(name)}) is not null begin alter database ${quoted} set single_user with rollback immediate; drop database ${quoted}; end`;
+        const literal = this.platform.quoteValue(name);
+        return (`if db_id(${literal}) is not null begin ` +
+            `declare @drop_files table (path nvarchar(260)); ` +
+            `insert into @drop_files (path) select physical_name from sys.master_files where database_id = db_id(${literal}); ` +
+            `alter database ${quoted} set offline with rollback immediate; ` +
+            `drop database ${quoted}; ` +
+            `declare @drop_path nvarchar(260); ` +
+            `declare drop_files_cursor cursor local fast_forward for select path from @drop_files; ` +
+            `open drop_files_cursor; fetch next from drop_files_cursor into @drop_path; ` +
+            `while @@fetch_status = 0 begin ` +
+            `begin try exec master.sys.xp_delete_files @drop_path; end try begin catch end catch; ` +
+            `fetch next from drop_files_cursor into @drop_path; ` +
+            `end ` +
+            `close drop_files_cursor; deallocate drop_files_cursor; ` +
+            `end`);
     }
     disableForeignKeysSQL() {
         return `exec sp_MSforeachtable 'alter table ? nocheck constraint all';`;
@@ -93,7 +114,8 @@ export class MsSqlSchemaHelper extends SchemaHelper {
       numeric_scale as numeric_scale,
       datetime_precision as datetime_precision,
       character_maximum_length as character_maximum_length,
-      columnproperty(sc.object_id, column_name, 'IsIdentity') is_identity
+      columnproperty(sc.object_id, column_name, 'IsIdentity') is_identity,
+      nullif(ic.collation_name, convert(nvarchar(128), databasepropertyex(db_name(), 'Collation'))) as collation_name
       from information_schema.columns ic
       inner join sys.columns sc on sc.name = ic.column_name and sc.object_id = object_id(ic.table_schema + '.' + ic.table_name)
       left join sys.computed_columns cmp on cmp.name = ic.column_name and cmp.object_id = object_id(ic.table_schema + '.' + ic.table_name)
@@ -145,6 +167,7 @@ export class MsSqlSchemaHelper extends SchemaHelper {
                 precision: col.numeric_precision,
                 scale: col.numeric_scale,
                 comment: col.column_comment,
+                collation: col.collation_name ?? undefined,
                 generated,
             });
         }
@@ -337,6 +360,10 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         }
         return this.quote(name);
     }
+    async getDatabaseCollation(connection, ctx) {
+        const [row] = await connection.execute(`select convert(nvarchar(128), databasepropertyex(db_name(), 'Collation')) as collation`, [], 'all', ctx);
+        return row?.collation;
+    }
     async getAllTriggers(connection, tablesBySchemas) {
         const conditions = [];
         for (const [schema, tables] of tablesBySchemas) {
@@ -398,9 +425,11 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         const checks = await this.getAllChecks(connection, tablesBySchema, ctx);
         const fks = await this.getAllForeignKeys(connection, tablesBySchema, ctx);
         const triggers = await this.getAllTriggers(connection, tablesBySchema);
+        const dbCollation = await this.getDatabaseCollation(connection, ctx);
         for (const t of tables) {
             const key = this.getTableKey(t);
             const table = schema.addTable(t.table_name, t.schema_name, t.table_comment);
+            table.collation = dbCollation;
             const pks = await this.getPrimaryKeys(connection, indexes[key], table.name, table.schema);
             const enums = this.getEnumDefinitions(checks[key] ?? []);
             table.init(columns[key], indexes[key], checks[key], pks, fks[key], enums);
@@ -522,7 +551,11 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         else {
             col.push(columnType);
         }
-        Utils.runIfNotEmpty(() => col.push('identity(1,1)'), column.autoincrement);
+        Utils.runIfNotEmpty(() => col.push(this.getCollateSQL(column.collation)), column.collation);
+        // `IDENTITY(1,1)` is rejected inside `ALTER COLUMN`, so it must only be emitted when the
+        // change actually involves the identity attribute or is a fresh column (no `changedProperties`).
+        Utils.runIfNotEmpty(() => col.push('identity(1,1)'), column.autoincrement &&
+            (!changedProperties || changedProperties.has('autoincrement') || changedProperties.has('type')));
         Utils.runIfNotEmpty(() => col.push('null'), column.nullable);
         Utils.runIfNotEmpty(() => col.push('not null'), !column.nullable && !column.generated);
         if (column.autoincrement &&
@@ -544,7 +577,7 @@ export class MsSqlSchemaHelper extends SchemaHelper {
             const [constraint] = this.getDropDefaultsSQL(table.name, [column], table.schema);
             parts.push(constraint);
         }
-        if (changedProperties.has('type') || changedProperties.has('nullable')) {
+        if (changedProperties.has('type') || changedProperties.has('nullable') || changedProperties.has('collation')) {
             const col = this.createTableColumn(column, table, changedProperties);
             parts.push(`alter table ${table.getQuotedName()} alter column ${col}`);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/mssql",
-  "version": "7.1.0-dev.20",
+  "version": "7.1.0-dev.22",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -47,7 +47,7 @@
     "copy": "node ../../scripts/copy.mjs"
   },
   "dependencies": {
-    "@mikro-orm/sql": "7.1.0-dev.20",
+    "@mikro-orm/sql": "7.1.0-dev.22",
     "kysely": "0.28.16",
     "tarn": "3.0.2",
     "tedious": "19.2.1",
@@ -57,7 +57,7 @@
     "@mikro-orm/core": "^7.0.12"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.1.0-dev.20"
+    "@mikro-orm/core": "7.1.0-dev.22"
   },
   "engines": {
     "node": ">= 22.17.0"