@mikro-orm/mssql 7.1.0-dev.2 → 7.1.0-dev.21

package/MsSqlPlatform.d.ts

@@ -8,6 +8,7 @@ export declare class MsSqlPlatform extends AbstractSqlPlatform {
     #private;
     protected readonly schemaHelper: MsSqlSchemaHelper;
     protected readonly exceptionConverter: MsSqlExceptionConverter;
+    formatIndexHint(indexNames: string[]): string;
     /** @inheritDoc */
     lookupExtensions(orm: MikroORM<MsSqlDriver>): void;
     /** @inheritDoc */

package/MsSqlPlatform.js

@@ -16,6 +16,9 @@ export class MsSqlPlatform extends AbstractSqlPlatform {
         bigint: 'bigint',
         boolean: 'bit',
     };
+    formatIndexHint(indexNames) {
+        return `with (index(${indexNames.join(', ')}))`;
+    }
     /** @inheritDoc */
     lookupExtensions(orm) {
         MsSqlSchemaGenerator.register(orm);
@@ -136,6 +139,7 @@ export class MsSqlPlatform extends AbstractSqlPlatform {
         return 'uniqueidentifier';
     }
     validateMetadata(meta) {
+        super.validateMetadata(meta);
         for (const prop of meta.props) {
             if ((prop.runtimeType === 'string' || ['string', 'nvarchar'].includes(prop.type)) &&
                 !['uuid'].includes(prop.type) &&

package/MsSqlSchemaHelper.d.ts

@@ -1,4 +1,4 @@
-import { type AbstractSqlConnection, type CheckDef, type Column, type DatabaseSchema, type DatabaseTable, type Dictionary, type ForeignKey, type IndexDef, SchemaHelper, type Table, type TableDifference, type Transaction, type Type } from '@mikro-orm/sql';
+import { type AbstractSqlConnection, type CheckDef, type Column, type DatabaseSchema, type DatabaseTable, type Dictionary, type ForeignKey, type IndexDef, SchemaHelper, type Table, type TableDifference, type SqlTriggerDef, type Transaction, type Type } from '@mikro-orm/sql';
 /** Schema introspection helper for Microsoft SQL Server. */
 export declare class MsSqlSchemaHelper extends SchemaHelper {
     static readonly DEFAULT_VALUES: {
@@ -6,6 +6,8 @@ export declare class MsSqlSchemaHelper extends SchemaHelper {
         false: string[];
         'getdate()': string[];
     };
+    private static readonly AUTO_NOT_NULL_RE;
+    protected get bracketQuotedIdentifiers(): boolean;
     getManagementDbName(): string;
     getDropDatabaseSQL(name: string): string;
     disableForeignKeysSQL(): string;
@@ -23,6 +25,12 @@ export declare class MsSqlSchemaHelper extends SchemaHelper {
     private getEnumDefinitions;
     private getChecksSQL;
     getAllChecks(connection: AbstractSqlConnection, tablesBySchemas: Map<string | undefined, Table[]>, ctx?: Transaction): Promise<Dictionary<CheckDef[]>>;
+    /** Generates SQL to create an MSSQL trigger. MSSQL supports AFTER and INSTEAD OF only. */
+    createTrigger(table: DatabaseTable, trigger: SqlTriggerDef): string;
+    /** Generates SQL to drop an MSSQL trigger. */
+    dropTrigger(table: DatabaseTable, trigger: SqlTriggerDef): string;
+    private getSchemaQualifiedName;
+    getAllTriggers(connection: AbstractSqlConnection, tablesBySchemas: Map<string | undefined, Table[]>): Promise<Dictionary<SqlTriggerDef[]>>;
     loadInformationSchema(schema: DatabaseSchema, connection: AbstractSqlConnection, tables: Table[], schemas?: string[], ctx?: Transaction): Promise<void>;
     getPreAlterTable(tableDiff: TableDifference, safe: boolean): string[];
     getPostAlterTable(tableDiff: TableDifference, safe: boolean): string[];

package/MsSqlSchemaHelper.js

@@ -7,12 +7,43 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         false: ['0'],
         'getdate()': ['current_timestamp'],
     };
+    // `stripAutoNotNullFilter` unwraps balanced per-clause parens before calling `.exec`, so we
+    // only need to match the bare form here — previously the pattern allowed independently
+    // optional leading/trailing parens, which accepted unbalanced strings like `([col] IS NOT NULL`.
+    static AUTO_NOT_NULL_RE = /^\[([^\]]+)\]\s+IS\s+NOT\s+NULL$/i;
+    // MSSQL `filter_definition` and `where` predicates use `[…]` bracket-quoting for identifiers,
+    // so `splitTopLevelAnd` must treat `[` as opening a quoted span (otherwise `[some and col]`
+    // would split mid-identifier).
+    get bracketQuotedIdentifiers() {
+        return true;
+    }
     getManagementDbName() {
         return 'master';
     }
     getDropDatabaseSQL(name) {
+        // `set offline` rejects all connections including the issuing session, so there is no
+        // single-user race window where a torn-down pool connection can reconnect between the
+        // mode switch and the drop (SQL Server error 3702 "currently in use"). Dropping an
+        // offline database leaves the underlying `.mdf`/`.ldf` files behind though, which
+        // makes a subsequent `create database` with the same name fail with error 5170
+        // ("file already exists"). Capture the physical paths up front and call
+        // `master.sys.xp_delete_files` after the drop to clean them up.
         const quoted = this.quote(name);
-        return `if db_id(${this.platform.quoteValue(name)}) is not null begin alter database ${quoted} set single_user with rollback immediate; drop database ${quoted}; end`;
+        const literal = this.platform.quoteValue(name);
+        return (`if db_id(${literal}) is not null begin ` +
+            `declare @drop_files table (path nvarchar(260)); ` +
+            `insert into @drop_files (path) select physical_name from sys.master_files where database_id = db_id(${literal}); ` +
+            `alter database ${quoted} set offline with rollback immediate; ` +
+            `drop database ${quoted}; ` +
+            `declare @drop_path nvarchar(260); ` +
+            `declare drop_files_cursor cursor local fast_forward for select path from @drop_files; ` +
+            `open drop_files_cursor; fetch next from drop_files_cursor into @drop_path; ` +
+            `while @@fetch_status = 0 begin ` +
+            `begin try exec master.sys.xp_delete_files @drop_path; end try begin catch end catch; ` +
+            `fetch next from drop_files_cursor into @drop_path; ` +
+            `end ` +
+            `close drop_files_cursor; deallocate drop_files_cursor; ` +
+            `end`);
     }
     disableForeignKeysSQL() {
         return `exec sp_MSforeachtable 'alter table ? nocheck constraint all';`;
@@ -148,6 +179,7 @@ export class MsSqlSchemaHelper extends SchemaHelper {
       col.name as column_name,
       schema_name(t.schema_id) as schema_name,
       (case when filter_definition is not null then concat('where ', filter_definition) else null end) as expression,
+      filter_definition as filter_definition,
       ind.is_disabled as is_disabled,
       ind.type as index_type,
       ind.fill_factor as fill_factor,
@@ -192,15 +224,31 @@ export class MsSqlSchemaHelper extends SchemaHelper {
             if (index.fill_factor > 0) {
                 indexDef.fillFactor = index.fill_factor;
             }
-            if (index.column_name?.match(/[(): ,"'`]/) || index.expression?.match(/where /i)) {
-                indexDef.expression = index.expression; // required for the `getCreateIndexSQL()` call
+            /* v8 ignore next: function-based / computed-column introspection path, same as pre-PR */
+            if (index.column_name?.match(/[(): ,"'`]/)) {
+                indexDef.expression = index.expression;
                 indexDef.expression = this.getCreateIndexSQL(index.table_name, indexDef, !!index.expression);
             }
+            else if (index.filter_definition) {
+                // Auto-NOT-NULL stripping runs post-mapIndexes (needs the consolidated column list).
+                indexDef.where = index.filter_definition;
+            }
             ret[key] ??= [];
             ret[key].push(indexDef);
         }
         for (const key of Object.keys(ret)) {
             ret[key] = await this.mapIndexes(ret[key]);
+            for (const idx of ret[key]) {
+                if (idx.where) {
+                    const stripped = this.stripAutoNotNullFilter(idx.where, idx.columnNames, MsSqlSchemaHelper.AUTO_NOT_NULL_RE);
+                    if (stripped === '') {
+                        delete idx.where;
+                    }
+                    else {
+                        idx.where = stripped;
+                    }
+                }
+            }
         }
         return ret;
     }
@@ -285,6 +333,82 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         }
         return ret;
     }
+    /** Generates SQL to create an MSSQL trigger. MSSQL supports AFTER and INSTEAD OF only. */
+    createTrigger(table, trigger) {
+        if (trigger.expression) {
+            return trigger.expression;
+        }
+        /* v8 ignore next 3 */
+        if (trigger.timing === 'before') {
+            throw new Error(`MSSQL does not support BEFORE triggers. Use AFTER or INSTEAD OF for trigger "${trigger.name}".`);
+        }
+        const timing = trigger.timing.toUpperCase();
+        const events = trigger.events.map(e => e.toUpperCase()).join(', ');
+        const qualifiedName = this.getSchemaQualifiedName(table, trigger.name);
+        return `create trigger ${qualifiedName} on ${table.getQuotedName()} ${timing} ${events} as begin ${trigger.body}; end`;
+    }
+    /** Generates SQL to drop an MSSQL trigger. */
+    dropTrigger(table, trigger) {
+        return `drop trigger if exists ${this.getSchemaQualifiedName(table, trigger.name)}`;
+    }
+    getSchemaQualifiedName(table, name) {
+        const defaultSchema = this.platform.getDefaultSchemaName();
+        if (table.schema && table.schema !== defaultSchema) {
+            return `${this.quote(table.schema)}.${this.quote(name)}`;
+        }
+        return this.quote(name);
+    }
+    async getAllTriggers(connection, tablesBySchemas) {
+        const conditions = [];
+        for (const [schema, tables] of tablesBySchemas) {
+            const names = tables.map(t => this.platform.quoteValue(t.table_name)).join(', ');
+            const schemaName = this.platform.quoteValue(schema ?? this.platform.getDefaultSchemaName());
+            conditions.push(`(schema_name(p.schema_id) = ${schemaName} and p.name in (${names}))`);
+        }
+        const sql = `select t.name as trigger_name, schema_name(p.schema_id) as schema_name,
+      p.name as table_name, te.type_desc as event,
+      case when t.is_instead_of_trigger = 1 then 'INSTEAD OF' else 'AFTER' end as timing,
+      object_definition(t.object_id) as definition
+    from sys.triggers t
+    join sys.trigger_events te on t.object_id = te.object_id
+    join sys.objects p on t.parent_id = p.object_id
+    where (${conditions.join(' or ')})
+    order by t.name, te.type_desc`;
+        const allTriggers = await connection.execute(sql);
+        const ret = {};
+        const triggerMap = new Map();
+        for (const row of allTriggers) {
+            const key = this.getTableKey(row);
+            const dedupeKey = `${key}:${row.trigger_name}`;
+            const event = row.event.toLowerCase();
+            if (triggerMap.has(dedupeKey)) {
+                const existing = triggerMap.get(dedupeKey);
+                if (!existing.events.includes(event)) {
+                    existing.events.push(event);
+                }
+                continue;
+            }
+            // Parse body from full trigger definition
+            let body = '';
+            if (row.definition) {
+                const bodyMatch = /\bas\s+begin\s+([\s\S]*)\s*end\s*;?\s*$/i.exec(row.definition);
+                if (bodyMatch) {
+                    body = bodyMatch[1].trim().replace(/;\s*$/, '');
+                }
+            }
+            ret[key] ??= [];
+            const trigger = {
+                name: row.trigger_name,
+                timing: row.timing.toLowerCase(),
+                events: [event],
+                forEach: 'row', // MSSQL has no FOR EACH ROW/STATEMENT syntax; match the metadata default to avoid false diffs
+                body,
+            };
+            ret[key].push(trigger);
+            triggerMap.set(dedupeKey, trigger);
+        }
+        return ret;
+    }
     async loadInformationSchema(schema, connection, tables, schemas, ctx) {
         if (tables.length === 0) {
             return;
@@ -294,12 +418,16 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         const indexes = await this.getAllIndexes(connection, tablesBySchema, ctx);
         const checks = await this.getAllChecks(connection, tablesBySchema, ctx);
         const fks = await this.getAllForeignKeys(connection, tablesBySchema, ctx);
+        const triggers = await this.getAllTriggers(connection, tablesBySchema);
         for (const t of tables) {
             const key = this.getTableKey(t);
             const table = schema.addTable(t.table_name, t.schema_name, t.table_comment);
             const pks = await this.getPrimaryKeys(connection, indexes[key], table.name, table.schema);
             const enums = this.getEnumDefinitions(checks[key] ?? []);
             table.init(columns[key], indexes[key], checks[key], pks, fks[key], enums);
+            if (triggers[key]) {
+                table.setTriggers(triggers[key]);
+            }
         }
     }
     getPreAlterTable(tableDiff, safe) {
@@ -460,7 +588,7 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         const clustered = index.clustered ? 'clustered ' : '';
         let sql = `create ${index.unique ? 'unique ' : ''}${clustered}index ${keyName} on ${this.quote(tableName)} `;
         if (index.expression && partialExpression) {
-            return sql + `(${index.expression})` + this.getMsSqlIndexSuffix(index);
+            return sql + `(${index.expression})` + this.getMsSqlIndexSuffix(index) + this.getIndexWhereClause(index);
         }
         // Build column list with advanced options
         const columns = this.getIndexColumns(index);
@@ -469,7 +597,7 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         if (index.include?.length) {
             sql += ` include (${index.include.map(c => this.quote(c)).join(', ')})`;
         }
-        sql += this.getMsSqlIndexSuffix(index);
+        sql += this.getMsSqlIndexSuffix(index) + this.getIndexWhereClause(index);
         // Disabled indexes need to be created first, then disabled
         if (index.disabled) {
             sql += `;\nalter index ${keyName} on ${this.quote(tableName)} disable`;
@@ -514,13 +642,16 @@ export class MsSqlSchemaHelper extends SchemaHelper {
         if (index.expression) {
             return index.expression;
         }
-        const needsWhereClause = index.unique && index.columnNames.some(column => table.getColumn(column)?.nullable);
-        if (!needsWhereClause) {
+        const needsAutoNotNull = index.unique && index.columnNames.some(column => table.getColumn(column)?.nullable);
+        if (!needsAutoNotNull) {
             return this.getCreateIndexSQL(table.getShortestName(), index);
         }
-        // Generate without disabled suffix, insert WHERE clause, then re-add disabled
-        let sql = this.getCreateIndexSQL(table.getShortestName(), { ...index, disabled: false });
-        sql += ' where ' + index.columnNames.map(c => `${this.quote(c)} is not null`).join(' and ');
+        // Strip `index.where` from the base SQL so we can combine it with the auto NOT-NULL guard
+        // ourselves, wrapping the user predicate in parens to defuse operator precedence
+        // (a bare `a = 1 or b = 2 and [col] is not null` would bind as `a = 1 or (b = 2 and …)`).
+        let sql = this.getCreateIndexSQL(table.getShortestName(), { ...index, where: undefined, disabled: false });
+        const autoNotNull = index.columnNames.map(c => `${this.quote(c)} is not null`).join(' and ');
+        sql += index.where ? ` where (${index.where}) and ${autoNotNull}` : ` where ${autoNotNull}`;
         if (index.disabled) {
             sql += `;\nalter index ${this.quote(index.keyName)} on ${table.getQuotedName()} disable`;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/mssql",
-  "version": "7.1.0-dev.2",
+  "version": "7.1.0-dev.21",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",
@@ -47,17 +47,17 @@
     "copy": "node ../../scripts/copy.mjs"
   },
   "dependencies": {
-    "@mikro-orm/sql": "7.1.0-dev.2",
+    "@mikro-orm/sql": "7.1.0-dev.21",
     "kysely": "0.28.16",
     "tarn": "3.0.2",
     "tedious": "19.2.1",
     "tsqlstring": "1.0.1"
   },
   "devDependencies": {
-    "@mikro-orm/core": "^7.0.11"
+    "@mikro-orm/core": "^7.0.12"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.1.0-dev.2"
+    "@mikro-orm/core": "7.1.0-dev.21"
   },
   "engines": {
     "node": ">= 22.17.0"