@mikro-orm/knex 7.0.0-dev.3 → 7.0.0-dev.5

package/AbstractSqlDriver.js

@@ -252,6 +252,9 @@ export class AbstractSqlDriver extends DatabaseDriver {
                 : meta2.props.filter(prop => this.platform.shouldHaveColumn(prop, hint.children || []));
             const tz = this.platform.getTimezone();
             for (const prop of targetProps) {
+                if (prop.fieldNames.every(name => typeof root[`${relationAlias}__${name}`] === 'undefined')) {
+                    continue;
+                }
                 if (prop.fieldNames.length > 1) { // composite keys
                     const fk = prop.fieldNames.map(name => root[`${relationAlias}__${name}`]);
                     const pk = Utils.mapFlatCompositePrimaryKey(fk, prop);
@@ -927,11 +930,11 @@ export class AbstractSqlDriver extends DatabaseDriver {
         const fields = [];
         const populate = options.populate ?? [];
         const joinedProps = this.joinedProps(meta, populate, options);
-        const shouldHaveColumn = (prop, populate, fields) => {
+        const shouldHaveColumn = (meta, prop, populate, fields) => {
             if (!this.platform.shouldHaveColumn(prop, populate, options.exclude)) {
                 return false;
             }
-            if (!fields || fields.includes('*') || prop.primary) {
+            if (!fields || fields.includes('*') || prop.primary || meta.root.discriminatorColumn === prop.name) {
                 return true;
             }
             return fields.some(f => f === prop.name || f.toString().startsWith(prop.name + '.'));
@@ -941,7 +944,7 @@ export class AbstractSqlDriver extends DatabaseDriver {
         if (options.parentJoinPath) {
             // alias all fields in the primary table
             meta.props
-                .filter(prop => shouldHaveColumn(prop, populate, options.explicitFields))
+                .filter(prop => shouldHaveColumn(meta, prop, populate, options.explicitFields))
                 .forEach(prop => fields.push(...this.mapPropToFieldNames(qb, prop, options.parentTableAlias)));
         }
         for (const hint of joinedProps) {
@@ -1289,6 +1292,9 @@ export class AbstractSqlDriver extends DatabaseDriver {
             if (!options.fields.includes('*') && !options.fields.includes(`${qb.alias}.*`)) {
                 ret.unshift(...meta.primaryKeys.filter(pk => !options.fields.includes(pk)));
             }
+            if (meta.root.discriminatorColumn && !options.fields.includes(`${qb.alias}.${meta.root.discriminatorColumn}`)) {
+                ret.push(meta.root.discriminatorColumn);
+            }
         }
         else if (!Utils.isEmpty(options.exclude) || lazyProps.some(p => !p.formula && (p.kind !== '1:1' || p.owner))) {
             const props = meta.props.filter(prop => this.platform.shouldHaveColumn(prop, populate, options.exclude, false));

package/dialects/mssql/MsSqlNativeQueryBuilder.js

@@ -65,9 +65,11 @@ export class MsSqlNativeQueryBuilder extends NativeQueryBuilder {
             this.params.push(...clause.fields.params);
         }
         else if (clause.fields.length > 0) {
-            // const fields = clause.fields.map(field => this.quote(field));
-            const conflictColumn = this.quote(clause.fields[0]);
-            this.parts.push(`on ${this.getTableName()}.${conflictColumn} = tsource.${conflictColumn}`);
+            const fields = clause.fields.map(field => {
+                const col = this.quote(field);
+                return `${this.getTableName()}.${col} = tsource.${col}`;
+            });
+            this.parts.push(`on ${fields.join(' and ')}`);
         }
         const sourceColumns = keys.map(field => `tsource.${this.quote(field)}`).join(', ');
         const destinationColumns = keys.map(field => this.quote(field)).join(', ');

package/dialects/sqlite/BaseSqlitePlatform.d.ts

@@ -63,7 +63,6 @@ export declare abstract class BaseSqlitePlatform extends AbstractSqlPlatform {
      */
     processDateProperty(value: unknown): string | number | Date;
     getIndexName(tableName: string, columns: string[], type: 'index' | 'unique' | 'foreign' | 'primary' | 'sequence'): string;
-    supportsDownMigrations(): boolean;
     supportsDeferredUniqueConstraints(): boolean;
     getFullTextWhereClause(): string;
     quoteVersionValue(value: Date | number, prop: EntityProperty): Date | string | number;

package/dialects/sqlite/BaseSqlitePlatform.js

@@ -84,10 +84,6 @@ export class BaseSqlitePlatform extends AbstractSqlPlatform {
         }
         return super.getIndexName(tableName, columns, type);
     }
-    // TODO enable once tests are green
-    supportsDownMigrations() {
-        return false;
-    }
     supportsDeferredUniqueConstraints() {
         return false;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/knex",
-  "version": "7.0.0-dev.3",
+  "version": "7.0.0-dev.5",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "type": "module",
   "exports": {
@@ -54,9 +54,9 @@
     "sqlstring": "2.3.3"
   },
   "devDependencies": {
-    "@mikro-orm/core": "^6.4.5"
+    "@mikro-orm/core": "^6.4.7"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "7.0.0-dev.3"
+    "@mikro-orm/core": "7.0.0-dev.5"
   }
 }

package/query/CriteriaNode.js

@@ -69,16 +69,12 @@ export class CriteriaNode {
         let joinAlias = qb.getAliasForJoinPath(this.getPath());
         if (!joinAlias && this.parent && [ReferenceKind.MANY_TO_ONE, ReferenceKind.ONE_TO_ONE].includes(this.prop.kind) && this.prop.owner) {
             joinAlias = qb.getAliasForJoinPath(this.parent.getPath());
-            return Utils.getPrimaryKeyHash(this.prop.joinColumns.map(col => `${joinAlias ?? qb.alias}.${col}`));
+            return Utils.getPrimaryKeyHash(this.prop.ownColumns.map(col => `${joinAlias ?? qb.alias}.${col}`));
         }
         const alias = joinAlias ?? qb.alias;
         if (this.prop.kind === ReferenceKind.MANY_TO_MANY) {
             return Utils.getPrimaryKeyHash(this.prop.inverseJoinColumns.map(col => `${alias}.${col}`));
         }
-        // if we found a matching join, we need to use the target table column names, as we use that alias instead of the root
-        if (!joinAlias && this.prop.owner && this.prop.joinColumns.length > 1) {
-            return Utils.getPrimaryKeyHash(this.prop.joinColumns.map(col => `${alias}.${col}`));
-        }
         return Utils.getPrimaryKeyHash(this.prop.referencedColumnNames.map(col => `${alias}.${col}`));
     }
     getPath(addIndex = false) {

package/query/QueryBuilderHelper.js

@@ -39,9 +39,6 @@ export class QueryBuilderHelper {
                 const prop = this.getProperty(f, a);
                 const fkIdx2 = prop?.fieldNames.findIndex(name => name === f) ?? -1;
                 if (fkIdx2 !== -1) {
-                    if (prop?.ownColumns && !prop.ownColumns.includes(f)) {
-                        continue;
-                    }
                     parts.push(this.mapper(a !== this.alias ? `${a}.${prop.fieldNames[fkIdx2]}` : prop.fieldNames[fkIdx2], type, value, alias));
                 }
                 else if (prop) {
@@ -62,9 +59,6 @@ export class QueryBuilderHelper {
                     }
                 });
             }
-            if (parts.length === 1) {
-                return parts[0];
-            }
             return raw('(' + parts.map(part => this.platform.quoteIdentifier(part)).join(', ') + ')');
         }
         const rawField = RawQueryFragment.getKnownFragment(field);
@@ -473,8 +467,8 @@ export class QueryBuilderHelper {
             parts.push(sql);
             params.push(...params2);
         }
-        else if (op === '$in' && Array.isArray(value[op]) && value[op].length === 0) {
-            parts.push(`1 = 0`);
+        else if (['$in', '$nin'].includes(op) && Array.isArray(value[op]) && value[op].length === 0) {
+            parts.push(`1 = ${op === '$in' ? 0 : 1}`);
         }
         else if (value[op] instanceof RawQueryFragment || value[op] instanceof NativeQueryBuilder) {
             const query = value[op] instanceof NativeQueryBuilder ? value[op].toRaw() : value[op];

package/schema/SqlSchemaGenerator.js

@@ -103,9 +103,10 @@ export class SqlSchemaGenerator extends AbstractSchemaGenerator {
             return super.clearDatabase(options);
         }
         await this.execute(this.helper.disableForeignKeysSQL());
-        for (const meta of this.getOrderedMetadata(options?.schema).reverse()) {
+        const schema = options?.schema ?? this.config.get('schema', this.platform.getDefaultSchemaName());
+        for (const meta of this.getOrderedMetadata(schema).reverse()) {
             await this.driver.createQueryBuilder(meta.className, this.em?.getTransactionContext(), 'write', false)
-                .withSchema(options?.schema)
+                .withSchema(schema)
                 .truncate()
                 .execute();
         }