@mikro-orm/knex 6.3.11-dev.17 → 6.3.11-dev.19

package/AbstractSqlDriver.js

@@ -261,7 +261,7 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
                 else if (prop.runtimeType === 'Date') {
                     const alias = `${relationAlias}__${prop.fieldNames[0]}`;
                     const value = root[alias];
-                    if (tz && tz !== 'local' && typeof value === 'string' && !value.includes('+') && !value.endsWith('Z')) {
+                    if (tz && tz !== 'local' && typeof value === 'string' && !value.includes('+') && value.lastIndexOf('-') < 11 && !value.endsWith('Z')) {
                         relationPojo[prop.name] = this.platform.parseDate(value + tz);
                     }
                     else if (['string', 'number'].includes(typeof value)) {
@@ -562,7 +562,7 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
             params.push(value);
         };
         for (const key of keys) {
-            const prop = meta.properties[key];
+            const prop = meta.properties[key] ?? meta.root.properties[key];
             prop.fieldNames.forEach((fieldName, fieldNameIdx) => {
                 if (fields.has(fieldName)) {
                     return;

package/dialects/mysql/MySqlColumnCompiler.d.ts

@@ -1,11 +1,7 @@
 import BaseMySqlColumnCompiler from 'knex/lib/dialects/mysql/schema/mysql-columncompiler';
+import type { IncrementOptions } from '../../typings';
 export declare class MySqlColumnCompiler extends BaseMySqlColumnCompiler {
-    increments(this: any, options?: {
-        primaryKey: boolean;
-        unsigned: boolean;
-    }): string;
-    bigincrements(this: any, options?: {
-        primaryKey: boolean;
-        unsigned: boolean;
-    }): string;
+    increments(options: IncrementOptions): string;
+    bigincrements(options: IncrementOptions): string;
+    private generateDDL;
 }

package/dialects/mysql/MySqlColumnCompiler.js

@@ -8,14 +8,19 @@ exports.MySqlColumnCompiler = void 0;
 const mysql_columncompiler_1 = __importDefault(require("knex/lib/dialects/mysql/schema/mysql-columncompiler"));
 class MySqlColumnCompiler extends mysql_columncompiler_1.default {
     // we need the old behaviour to be able to add auto_increment to a column that is already PK
-    increments(options = { primaryKey: true, unsigned: true }) {
-        const type = options.unsigned ? 'int unsigned' : 'int';
-        return `${type} not null auto_increment` + (this.tableCompiler._canBeAddPrimaryKey(options) ? ' primary key' : '');
+    increments(options) {
+        return this.generateDDL(options);
     }
     /* istanbul ignore next */
-    bigincrements(options = { primaryKey: true, unsigned: true }) {
-        const type = options.unsigned ? 'bigint unsigned' : 'bigint';
-        return `${type} not null auto_increment` + (this.tableCompiler._canBeAddPrimaryKey(options) ? ' primary key' : '');
+    bigincrements(options) {
+        return this.generateDDL(options);
+    }
+    generateDDL(options = {}) {
+        const { primaryKey = true, unsigned = true, type = 'int' } = options;
+        return type
+            + (unsigned ? ' unsigned' : '')
+            + ' not null auto_increment'
+            + (this.tableCompiler._canBeAddPrimaryKey({ primaryKey }) ? ' primary key' : '');
     }
 }
 exports.MySqlColumnCompiler = MySqlColumnCompiler;

package/dialects/mysql/MySqlSchemaHelper.d.ts

@@ -4,7 +4,6 @@ import { type Dictionary, type Type } from '@mikro-orm/core';
 import type { AbstractSqlConnection } from '../../AbstractSqlConnection';
 import { SchemaHelper } from '../../schema/SchemaHelper';
 import type { DatabaseSchema } from '../../schema/DatabaseSchema';
-import type { DatabaseTable } from '../../schema/DatabaseTable';
 export declare class MySqlSchemaHelper extends SchemaHelper {
     private readonly _cache;
     static readonly DEFAULT_VALUES: {
@@ -27,8 +26,6 @@ export declare class MySqlSchemaHelper extends SchemaHelper {
     getRenameColumnSQL(tableName: string, oldColumnName: string, to: Column): string;
     getRenameIndexSQL(tableName: string, index: IndexDef, oldIndexName: string): string;
     getChangeColumnCommentSQL(tableName: string, to: Column, schemaName?: string): string;
-    createTableColumn(table: Knex.TableBuilder, column: Column, fromTable: DatabaseTable, changedProperties?: Set<string>): Knex.ColumnBuilder | undefined;
-    configureColumn(column: Column, col: Knex.ColumnBuilder, knex: Knex, changedProperties?: Set<string>): Knex.ColumnBuilder;
     private getColumnDeclarationSQL;
     getForeignKeysSQL(tableName: string, schemaName?: string): string;
     getAllEnumDefinitions(connection: AbstractSqlConnection, tables: Table[]): Promise<Dictionary<Dictionary<string[]>>>;

package/dialects/mysql/MySqlSchemaHelper.js

@@ -208,18 +208,6 @@ class MySqlSchemaHelper extends SchemaHelper_1.SchemaHelper {
         const columnName = this.platform.quoteIdentifier(to.name);
         return `alter table ${tableName} modify ${columnName} ${this.getColumnDeclarationSQL(to)}`;
     }
-    createTableColumn(table, column, fromTable, changedProperties) {
-        if (column.mappedType instanceof core_1.MediumIntType) {
-            return table.specificType(column.name, this.getColumnDeclarationSQL(column, true));
-        }
-        return super.createTableColumn(table, column, fromTable, changedProperties);
-    }
-    configureColumn(column, col, knex, changedProperties) {
-        if (column.mappedType instanceof core_1.MediumIntType) {
-            return col;
-        }
-        return super.configureColumn(column, col, knex, changedProperties);
-    }
     getColumnDeclarationSQL(col, addPrimary = false) {
         let ret = col.type;
         ret += col.unsigned ? ' unsigned' : '';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/knex",
-  "version": "6.3.11-dev.17",
+  "version": "6.3.11-dev.19",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "main": "index.js",
   "module": "index.mjs",
@@ -66,7 +66,7 @@
     "@mikro-orm/core": "^6.3.10"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "6.3.11-dev.17",
+    "@mikro-orm/core": "6.3.11-dev.19",
     "better-sqlite3": "*",
     "libsql": "*",
     "mariadb": "*"

package/schema/SchemaHelper.js

@@ -129,9 +129,9 @@ class SchemaHelper {
         if (column.autoincrement && !column.generated && !compositePK && (!changedProperties || changedProperties.has('autoincrement') || changedProperties.has('type'))) {
             const primaryKey = !changedProperties && !this.hasNonDefaultPrimaryKeyName(fromTable);
             if (column.mappedType instanceof core_1.BigIntType) {
-                return table.bigIncrements(column.name, { primaryKey, unsigned: column.unsigned });
+                return table.bigIncrements(column.name, { primaryKey, unsigned: column.unsigned, type: column.type });
             }
-            return table.increments(column.name, { primaryKey, unsigned: column.unsigned });
+            return table.increments(column.name, { primaryKey, unsigned: column.unsigned, type: column.type });
         }
         if (column.mappedType instanceof core_1.EnumType && column.enumItems?.every(item => core_1.Utils.isString(item))) {
             return table.enum(column.name, column.enumItems);

package/typings.d.ts

@@ -185,14 +185,13 @@ export interface ICriteriaNode<T extends object> {
     getPath(addIndex?: boolean): string;
     getPivotPath(path: string): string;
 }
+export type IncrementOptions = {
+    primaryKey?: boolean;
+    unsigned?: boolean;
+    type?: Column['type'];
+};
 export interface ExpandedTableBuilder extends Knex.TableBuilder {
-    increments(columnName?: string, options?: {
-        primaryKey?: boolean;
-        unsigned?: boolean;
-    }): Knex.ColumnBuilder;
-    bigIncrements(columnName?: string, options?: {
-        primaryKey?: boolean;
-        unsigned?: boolean;
-    }): Knex.ColumnBuilder;
+    increments(columnName?: string, options?: IncrementOptions): Knex.ColumnBuilder;
+    bigIncrements(columnName?: string, options?: IncrementOptions): Knex.ColumnBuilder;
 }
 export {};