@mikro-orm/knex 6.1.9-dev.1 → 6.1.9-dev.11

package/README.md

@@ -9,6 +9,7 @@ TypeScript ORM for Node.js based on Data Mapper, [Unit of Work](https://mikro-or
 [![NPM version](https://img.shields.io/npm/v/@mikro-orm/core.svg)](https://www.npmjs.com/package/@mikro-orm/core)
 [![NPM dev version](https://img.shields.io/npm/v/@mikro-orm/core/next.svg)](https://www.npmjs.com/package/@mikro-orm/core)
 [![Chat on slack](https://img.shields.io/badge/chat-on%20slack-blue.svg)](https://join.slack.com/t/mikroorm/shared_invite/enQtNTM1ODYzMzM4MDk3LWM4ZDExMjU5ZDhmNjA2MmM3MWMwZmExNjhhNDdiYTMwNWM0MGY5ZTE3ZjkyZTMzOWExNDgyYmMzNDE1NDI5NjA)
+[![Chat on discord](https://img.shields.io/badge/chat-on%20discord-blue.svg)](https://discord.gg/ynAmaVDV)
 [![Downloads](https://img.shields.io/npm/dm/@mikro-orm/core.svg)](https://www.npmjs.com/package/@mikro-orm/core)
 [![Coverage Status](https://img.shields.io/coveralls/mikro-orm/mikro-orm.svg)](https://coveralls.io/r/mikro-orm/mikro-orm?branch=master)
 [![Maintainability](https://api.codeclimate.com/v1/badges/27999651d3adc47cfa40/maintainability)](https://codeclimate.com/github/mikro-orm/mikro-orm/maintainability)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/knex",
-  "version": "6.1.9-dev.1",
+  "version": "6.1.9-dev.11",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "main": "index.js",
   "module": "index.mjs",
@@ -66,6 +66,6 @@
     "@mikro-orm/core": "^6.1.8"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "6.1.9-dev.1"
+    "@mikro-orm/core": "6.1.9-dev.11"
   }
 }

package/schema/SchemaHelper.d.ts

@@ -18,6 +18,7 @@ export declare abstract class SchemaHelper {
     getForeignKeys(connection: AbstractSqlConnection, tableName: string, schemaName?: string): Promise<Dictionary>;
     protected getTableKey(t: Table): string;
     getEnumDefinitions(connection: AbstractSqlConnection, checks: CheckDef[], tableName: string, schemaName?: string): Promise<Dictionary<string[]>>;
+    getCreateNativeEnumSQL(name: string, values: unknown[], schema?: string): string;
     getDropNativeEnumSQL(name: string, schema?: string): string;
     getAlterNativeEnumSQL(name: string, schema?: string, value?: string): string;
     loadInformationSchema(schema: DatabaseSchema, connection: AbstractSqlConnection, tables: Table[], schemas?: string[]): Promise<void>;

package/schema/SchemaHelper.js

@@ -47,6 +47,9 @@ class SchemaHelper {
     async getEnumDefinitions(connection, checks, tableName, schemaName) {
         return {};
     }
+    getCreateNativeEnumSQL(name, values, schema) {
+        throw new Error('Not supported by given driver');
+    }
     getDropNativeEnumSQL(name, schema) {
         throw new Error('Not supported by given driver');
     }

package/schema/SqlSchemaGenerator.js

@@ -60,6 +60,17 @@ class SqlSchemaGenerator extends core_1.AbstractSchemaGenerator {
             }
             ret += await this.dump(this.knex.schema.createSchemaIfNotExists(namespace));
         }
+        if (this.platform.supportsNativeEnums()) {
+            const created = [];
+            for (const [enumName, enumOptions] of Object.entries(toSchema.getNativeEnums())) {
+                if (created.includes(enumName)) {
+                    continue;
+                }
+                created.push(enumName);
+                const sql = this.helper.getCreateNativeEnumSQL(enumName, enumOptions, options.schema ?? this.config.get('schema'));
+                ret += await this.dump(this.knex.schema.raw(sql), '\n');
+            }
+        }
         for (const tableDef of toSchema.getTables()) {
             ret += await this.dump(this.createTable(tableDef));
         }
@@ -284,12 +295,22 @@ class SqlSchemaGenerator extends core_1.AbstractSchemaGenerator {
         const ret = [];
         const [schemaName, tableName] = this.splitTableName(diff.name);
         if (this.platform.supportsNativeEnums()) {
+            const createdNativeEnums = [];
             const changedNativeEnums = [];
-            for (const { column, changedProperties } of Object.values(diff.changedColumns)) {
-                if (column.nativeEnumName && changedProperties.has('enumItems') && column.nativeEnumName in diff.fromTable.nativeEnums) {
+            for (const { column, changedProperties, fromColumn } of Object.values(diff.changedColumns)) {
+                if (!column.nativeEnumName) {
+                    continue;
+                }
+                if (changedProperties.has('enumItems') && column.nativeEnumName in diff.fromTable.nativeEnums) {
                     changedNativeEnums.push([column.nativeEnumName, column.enumItems, diff.fromTable.getColumn(column.name).enumItems]);
                 }
+                else if (changedProperties.has('type') && !(column.nativeEnumName in diff.fromTable.nativeEnums)) {
+                    createdNativeEnums.push([column.nativeEnumName, column.enumItems]);
+                }
             }
+            core_1.Utils.removeDuplicates(createdNativeEnums).forEach(([enumName, items]) => {
+                ret.push(this.knex.schema.raw(this.helper.getCreateNativeEnumSQL(enumName, items, schemaName)));
+            });
             core_1.Utils.removeDuplicates(changedNativeEnums).forEach(([enumName, itemsNew, itemsOld]) => {
                 // postgres allows only adding new items, the values are case insensitive
                 itemsOld = itemsOld.map(v => v.toLowerCase());
@@ -331,7 +352,7 @@ class SqlSchemaGenerator extends core_1.AbstractSchemaGenerator {
                         .onDelete(foreignKey.deleteRule);
                 }
             }
-            for (const { column, changedProperties } of Object.values(diff.changedColumns)) {
+            for (const { column, changedProperties, fromColumn } of Object.values(diff.changedColumns)) {
                 if (changedProperties.size === 1 && changedProperties.has('comment')) {
                     continue;
                 }