@mikro-orm/knex 6.0.0-dev.83 → 6.0.0-dev.84

package/AbstractSqlDriver.d.ts

@@ -32,6 +32,7 @@ export declare abstract class AbstractSqlDriver<Connection extends AbstractSqlCo
     nativeDelete<T extends object>(entityName: string, where: FilterQuery<T> | string | any, options?: DeleteOptions<T>): Promise<QueryResult<T>>;
     syncCollection<T extends object, O extends object>(coll: Collection<T, O>, options?: DriverMethodOptions): Promise<void>;
     loadFromPivotTable<T extends object, O extends object>(prop: EntityProperty, owners: Primary<O>[][], where?: FilterQuery<any>, orderBy?: OrderDefinition<T>, ctx?: Transaction, options?: FindOptions<T, any, any>): Promise<Dictionary<T[]>>;
+    private getPivotOrderBy;
     execute<T extends QueryResult | EntityData<AnyEntity> | EntityData<AnyEntity>[] = EntityData<AnyEntity>[]>(queryOrKnex: string | Knex.QueryBuilder | Knex.Raw, params?: any[], method?: 'all' | 'get' | 'run', ctx?: Transaction): Promise<T>;
     /**
      * 1:1 owner side needs to be marked for population so QB auto-joins the owner id

package/AbstractSqlDriver.js

@@ -512,9 +512,15 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
     }
     async loadFromPivotTable(prop, owners, where = {}, orderBy, ctx, options) {
         const pivotProp2 = this.getPivotInverseProperty(prop);
+        const prop2 = prop.targetMeta.properties[prop.mappedBy ?? prop.inversedBy];
         const ownerMeta = this.metadata.find(pivotProp2.type);
         const pivotMeta = this.metadata.find(prop.pivotEntity);
-        const cond = { [`${prop.pivotEntity}.${pivotProp2.name}`]: { $in: ownerMeta.compositePK ? owners : owners.map(o => o[0]) } };
+        const qb = this.createQueryBuilder(prop.type, ctx, options?.connectionType).withSchema(this.getSchemaName(prop.targetMeta, options));
+        const pivotAlias = qb.getNextAlias(pivotMeta.tableName);
+        const pivotKey = pivotProp2.joinColumns.map(column => `${pivotAlias}.${column}`).join(core_1.Utils.PK_SEPARATOR);
+        const cond = {
+            [pivotKey]: { $in: ownerMeta.compositePK ? owners : owners.map(o => o[0]) },
+        };
         /* istanbul ignore if */
         if (!core_1.Utils.isEmpty(where) && Object.keys(where).every(k => core_1.Utils.isOperator(k, false))) {
             where = cond;
@@ -522,13 +528,22 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
         else {
             where = { ...where, ...cond };
         }
-        orderBy = this.getPivotOrderBy(prop, orderBy);
-        const qb = this.createQueryBuilder(prop.type, ctx, options?.connectionType)
-            .unsetFlag(core_1.QueryFlag.CONVERT_CUSTOM_TYPES)
-            .withSchema(this.getSchemaName(prop.targetMeta, options));
-        const populate = this.autoJoinOneToOneOwner(prop.targetMeta, [{ field: prop.pivotEntity }]);
+        orderBy = this.getPivotOrderBy(prop, pivotAlias, orderBy);
+        const populate = this.autoJoinOneToOneOwner(prop.targetMeta, []);
         const fields = this.buildFields(prop.targetMeta, (options?.populate ?? []), [], qb, options?.fields);
-        qb.select(fields).populate(populate).where(where).orderBy(orderBy).setLockMode(options?.lockMode, options?.lockTableAliases);
+        const k1 = !prop.owner ? 'joinColumns' : 'inverseJoinColumns';
+        const k2 = prop.owner ? 'joinColumns' : 'inverseJoinColumns';
+        const cols = [
+            ...prop[k1].map(col => `${pivotAlias}.${col} as fk__${col}`),
+            ...prop[k2].map(col => `${pivotAlias}.${col} as fk__${col}`),
+        ];
+        fields.push(...cols);
+        qb.select(fields)
+            .join(prop2.name, pivotAlias, {}, 'pivotJoin', undefined, options?.schema)
+            .populate(populate)
+            .where(where)
+            .orderBy(orderBy)
+            .setLockMode(options?.lockMode, options?.lockTableAliases);
         if (owners.length === 1 && (options?.offset != null || options?.limit != null)) {
             qb.limit(options.limit, options.offset);
         }
@@ -561,6 +576,18 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
         });
         return map;
     }
+    getPivotOrderBy(prop, pivotAlias, orderBy) {
+        if (!core_1.Utils.isEmpty(orderBy)) {
+            return orderBy;
+        }
+        if (!core_1.Utils.isEmpty(prop.orderBy)) {
+            return core_1.Utils.asArray(prop.orderBy);
+        }
+        if (prop.fixedOrder) {
+            return [{ [`${pivotAlias}.${prop.fixedOrderColumn}`]: core_1.QueryOrder.ASC }];
+        }
+        return [];
+    }
     async execute(queryOrKnex, params = [], method = 'all', ctx) {
         return this.rethrow(this.connection.execute(queryOrKnex, params, method, ctx));
     }
@@ -707,9 +734,7 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
             deleteDiff = [];
         }
         if (deleteDiff === true || deleteDiff.length > 0) {
-            const qb1 = this.createQueryBuilder(prop.pivotEntity, options?.ctx, 'write')
-                .withSchema(this.getSchemaName(meta, options))
-                .unsetFlag(core_1.QueryFlag.CONVERT_CUSTOM_TYPES);
+            const qb1 = this.createQueryBuilder(prop.pivotEntity, options?.ctx, 'write').withSchema(this.getSchemaName(meta, options));
             const knex = qb1.getKnex();
             if (Array.isArray(deleteDiff)) {
                 knex.whereIn(prop.inverseJoinColumns, deleteDiff);
@@ -737,7 +762,6 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
         else {
             await core_1.Utils.runSerial(items, item => {
                 return this.createQueryBuilder(prop.pivotEntity, options?.ctx, 'write')
-                    .unsetFlag(core_1.QueryFlag.CONVERT_CUSTOM_TYPES)
                     .withSchema(this.getSchemaName(meta, options))
                     .insert(item)
                     .execute('run', false);
@@ -746,7 +770,7 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
     }
     async lockPessimistic(entity, options) {
         const meta = (0, core_1.helper)(entity).__meta;
-        const qb = this.createQueryBuilder(entity.constructor.name, options.ctx).unsetFlag(core_1.QueryFlag.CONVERT_CUSTOM_TYPES).withSchema(options.schema ?? meta.schema);
+        const qb = this.createQueryBuilder(entity.constructor.name, options.ctx).withSchema(options.schema ?? meta.schema);
         const cond = core_1.Utils.getPrimaryKeyCond(entity, meta.primaryKeys);
         qb.select((0, core_1.raw)('1')).where(cond).setLockMode(options.lockMode, options.lockTableAliases);
         await this.rethrow(qb.execute());

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/knex",
-  "version": "6.0.0-dev.83",
+  "version": "6.0.0-dev.84",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "main": "index.js",
   "module": "index.mjs",
@@ -66,6 +66,6 @@
     "@mikro-orm/core": "^5.7.10"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "~6.0.0-dev.83"
+    "@mikro-orm/core": "~6.0.0-dev.84"
   }
 }

package/query/QueryBuilder.d.ts

@@ -91,11 +91,11 @@ export declare class QueryBuilder<T extends object = AnyEntity> {
     delete(cond?: QBFilterQuery): DeleteQueryBuilder<T>;
     truncate(): TruncateQueryBuilder<T>;
     count(field?: string | string[], distinct?: boolean): CountQueryBuilder<T>;
-    join(field: string, alias: string, cond?: QBFilterQuery, type?: 'leftJoin' | 'innerJoin' | 'pivotJoin', path?: string): this;
-    leftJoin(field: string, alias: string, cond?: QBFilterQuery): this;
-    joinAndSelect(field: string, alias: string, cond?: QBFilterQuery, type?: 'leftJoin' | 'innerJoin' | 'pivotJoin', path?: string, fields?: string[]): SelectQueryBuilder<T>;
-    leftJoinAndSelect(field: string, alias: string, cond?: QBFilterQuery, fields?: string[]): SelectQueryBuilder<T>;
-    innerJoinAndSelect(field: string, alias: string, cond?: QBFilterQuery, fields?: string[]): SelectQueryBuilder<T>;
+    join(field: string, alias: string, cond?: QBFilterQuery, type?: 'leftJoin' | 'innerJoin' | 'pivotJoin', path?: string, schema?: string): this;
+    leftJoin(field: string, alias: string, cond?: QBFilterQuery, schema?: string): this;
+    joinAndSelect(field: string, alias: string, cond?: QBFilterQuery, type?: 'leftJoin' | 'innerJoin' | 'pivotJoin', path?: string, fields?: string[], schema?: string): SelectQueryBuilder<T>;
+    leftJoinAndSelect(field: string, alias: string, cond?: QBFilterQuery, fields?: string[], schema?: string): SelectQueryBuilder<T>;
+    innerJoinAndSelect(field: string, alias: string, cond?: QBFilterQuery, fields?: string[], schema?: string): SelectQueryBuilder<T>;
     protected getFieldsForJoinedLoad(prop: EntityProperty<T>, alias: string, explicitFields?: string[]): Field<T>[];
     withSubQuery(subQuery: Knex.QueryBuilder, alias: string): this;
     where(cond: QBFilterQuery<T>, operator?: keyof typeof GroupOperator): this;
@@ -209,7 +209,6 @@ export declare class QueryBuilder<T extends object = AnyEntity> {
     private hasToManyJoins;
     private wrapPaginateSubQuery;
     private wrapModifySubQuery;
-    private autoJoinPivotTable;
     private getSchema;
     private createAlias;
     private createMainAlias;

package/query/QueryBuilder.js

@@ -137,18 +137,18 @@ class QueryBuilder {
         }
         return this.init(enums_1.QueryType.COUNT);
     }
-    join(field, alias, cond = {}, type = 'innerJoin', path) {
-        this.joinReference(field, alias, cond, type, path);
+    join(field, alias, cond = {}, type = 'innerJoin', path, schema) {
+        this.joinReference(field, alias, cond, type, path, schema);
         return this;
     }
-    leftJoin(field, alias, cond = {}) {
-        return this.join(field, alias, cond, 'leftJoin');
+    leftJoin(field, alias, cond = {}, schema) {
+        return this.join(field, alias, cond, 'leftJoin', undefined, schema);
     }
-    joinAndSelect(field, alias, cond = {}, type = 'innerJoin', path, fields) {
+    joinAndSelect(field, alias, cond = {}, type = 'innerJoin', path, fields, schema) {
         if (!this.type) {
             this.select('*');
         }
-        const prop = this.joinReference(field, alias, cond, type, path);
+        const prop = this.joinReference(field, alias, cond, type, path, schema);
         this.addSelect(this.getFieldsForJoinedLoad(prop, alias, fields));
         const [fromAlias] = this.helper.splitField(field);
         const populate = this._joinedProps.get(fromAlias);
@@ -162,11 +162,11 @@ class QueryBuilder {
         this._joinedProps.set(alias, item);
         return this;
     }
-    leftJoinAndSelect(field, alias, cond = {}, fields) {
-        return this.joinAndSelect(field, alias, cond, 'leftJoin', undefined, fields);
+    leftJoinAndSelect(field, alias, cond = {}, fields, schema) {
+        return this.joinAndSelect(field, alias, cond, 'leftJoin', undefined, fields, schema);
     }
-    innerJoinAndSelect(field, alias, cond = {}, fields) {
-        return this.joinAndSelect(field, alias, cond, 'innerJoin', undefined, fields);
+    innerJoinAndSelect(field, alias, cond = {}, fields, schema) {
+        return this.joinAndSelect(field, alias, cond, 'innerJoin', undefined, fields, schema);
     }
     getFieldsForJoinedLoad(prop, alias, explicitFields) {
         const fields = [];
@@ -614,7 +614,7 @@ class QueryBuilder {
         }
         return qb;
     }
-    joinReference(field, alias, cond, type, path) {
+    joinReference(field, alias, cond, type, path, schema) {
         this.ensureNotFinalized();
         const [fromAlias, fromField] = this.helper.splitField(field);
         const q = (str) => `'${str}'`;
@@ -639,7 +639,7 @@ class QueryBuilder {
         let aliasedName = `${fromAlias}.${prop.name}#${alias}`;
         path ??= `${(Object.values(this._joins).find(j => j.alias === fromAlias)?.path ?? entityName)}.${prop.name}`;
         if (prop.kind === core_1.ReferenceKind.ONE_TO_MANY) {
-            this._joins[aliasedName] = this.helper.joinOneToReference(prop, fromAlias, alias, type, cond);
+            this._joins[aliasedName] = this.helper.joinOneToReference(prop, fromAlias, alias, type, cond, schema);
         }
         else if (prop.kind === core_1.ReferenceKind.MANY_TO_MANY) {
             let pivotAlias = alias;
@@ -648,15 +648,15 @@ class QueryBuilder {
                 pivotAlias = oldPivotAlias ?? this.getNextAlias(prop.pivotEntity);
                 aliasedName = `${fromAlias}.${prop.name}#${pivotAlias}`;
             }
-            const joins = this.helper.joinManyToManyReference(prop, fromAlias, alias, pivotAlias, type, cond, path);
+            const joins = this.helper.joinManyToManyReference(prop, fromAlias, alias, pivotAlias, type, cond, path, schema);
             Object.assign(this._joins, joins);
             this.createAlias(prop.pivotEntity, pivotAlias);
         }
         else if (prop.kind === core_1.ReferenceKind.ONE_TO_ONE) {
-            this._joins[aliasedName] = this.helper.joinOneToReference(prop, fromAlias, alias, type, cond);
+            this._joins[aliasedName] = this.helper.joinOneToReference(prop, fromAlias, alias, type, cond, schema);
         }
         else { // MANY_TO_ONE
-            this._joins[aliasedName] = this.helper.joinManyToOneReference(prop, fromAlias, alias, type, cond);
+            this._joins[aliasedName] = this.helper.joinManyToOneReference(prop, fromAlias, alias, type, cond, schema);
         }
         if (!this._joins[aliasedName].path && path) {
             this._joins[aliasedName].path = path;
@@ -839,10 +839,7 @@ class QueryBuilder {
                 this._populateMap[join] = this._joins[join].alias;
                 return;
             }
-            if (this.metadata.find(field)?.pivotTable) { // pivot table entity
-                this.autoJoinPivotTable(field);
-            }
-            else if (meta && this.helper.isOneToOneInverse(fromField)) {
+            if (meta && this.helper.isOneToOneInverse(fromField)) {
                 const prop = meta.properties[fromField];
                 const alias = this.getNextAlias(prop.pivotEntity ?? prop.type);
                 const aliasedName = `${fromAlias}.${prop.name}#${alias}`;
@@ -982,17 +979,6 @@ class QueryBuilder {
             [core_1.Utils.getPrimaryKeyHash(meta.primaryKeys)]: { $in: subSubQuery },
         });
     }
-    autoJoinPivotTable(field) {
-        const pivotMeta = this.metadata.find(field);
-        const owner = pivotMeta.relations[0];
-        const inverse = pivotMeta.relations[1];
-        const prop = this._cond[pivotMeta.name + '.' + owner.name] || this._orderBy[pivotMeta.name + '.' + owner.name] ? inverse : owner;
-        const pivotAlias = this.getNextAlias(pivotMeta.name);
-        this._joins[field] = this.helper.joinPivotTable(field, prop, this.mainAlias.aliasName, pivotAlias, 'leftJoin');
-        core_1.Utils.renameKey(this._cond, `${field}.${owner.name}`, core_1.Utils.getPrimaryKeyHash(owner.fieldNames.map(fieldName => `${pivotAlias}.${fieldName}`)), true);
-        core_1.Utils.renameKey(this._cond, `${field}.${inverse.name}`, core_1.Utils.getPrimaryKeyHash(inverse.fieldNames.map(fieldName => `${pivotAlias}.${fieldName}`)), true);
-        this._populateMap[field] = this._joins[field].alias;
-    }
     getSchema(alias) {
         const { metadata } = alias;
         const metaSchema = metadata?.schema && metadata.schema !== '*' ? metadata.schema : undefined;
@@ -1044,6 +1030,9 @@ class QueryBuilder {
         if (this._data) {
             object.data = this._data;
         }
+        if (this._schema) {
+            object.schema = this._schema;
+        }
         if (!core_1.Utils.isEmpty(this._cond)) {
             object.where = this._cond;
         }

package/query/QueryBuilderHelper.d.ts

@@ -20,10 +20,9 @@ export declare class QueryBuilderHelper {
     mapper(field: string | Knex.Raw, type?: QueryType): string;
     mapper(field: string | Knex.Raw, type?: QueryType, value?: any, alias?: string | null): string;
     processData(data: Dictionary, convertCustomTypes: boolean, multi?: boolean): any;
-    joinOneToReference(prop: EntityProperty, ownerAlias: string, alias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond?: Dictionary): JoinOptions;
-    joinManyToOneReference(prop: EntityProperty, ownerAlias: string, alias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond?: Dictionary): JoinOptions;
-    joinManyToManyReference(prop: EntityProperty, ownerAlias: string, alias: string, pivotAlias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond: Dictionary, path: string): Dictionary<JoinOptions>;
-    joinPivotTable(field: string, prop: EntityProperty, ownerAlias: string, alias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond?: Dictionary): JoinOptions;
+    joinOneToReference(prop: EntityProperty, ownerAlias: string, alias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond?: Dictionary, schema?: string): JoinOptions;
+    joinManyToOneReference(prop: EntityProperty, ownerAlias: string, alias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond?: Dictionary, schema?: string): JoinOptions;
+    joinManyToManyReference(prop: EntityProperty, ownerAlias: string, alias: string, pivotAlias: string, type: 'leftJoin' | 'innerJoin' | 'pivotJoin', cond: Dictionary, path: string, schema?: string): Dictionary<JoinOptions>;
     processJoins(qb: Knex.QueryBuilder, joins: Dictionary<JoinOptions>, schema?: string): void;
     private processJoinClause;
     private wrapQueryGroup;

package/query/QueryBuilderHelper.js

@@ -106,28 +106,28 @@ class QueryBuilderHelper {
         }
         return data;
     }
-    joinOneToReference(prop, ownerAlias, alias, type, cond = {}) {
+    joinOneToReference(prop, ownerAlias, alias, type, cond = {}, schema) {
         const prop2 = prop.targetMeta.properties[prop.mappedBy || prop.inversedBy];
         const table = this.getTableName(prop.type);
-        const schema = this.driver.getSchemaName(prop.targetMeta);
         const joinColumns = prop.owner ? prop.referencedColumnNames : prop2.joinColumns;
         const inverseJoinColumns = prop.referencedColumnNames;
         const primaryKeys = prop.owner ? prop.joinColumns : prop2.referencedColumnNames;
         return {
-            prop, type, cond, ownerAlias, alias, table, schema,
+            prop, type, cond, ownerAlias, alias, table,
             joinColumns, inverseJoinColumns, primaryKeys,
+            schema: this.driver.getSchemaName(prop.targetMeta, { schema }),
         };
     }
-    joinManyToOneReference(prop, ownerAlias, alias, type, cond = {}) {
+    joinManyToOneReference(prop, ownerAlias, alias, type, cond = {}, schema) {
         return {
             prop, type, cond, ownerAlias, alias,
             table: this.getTableName(prop.type),
-            schema: this.driver.getSchemaName(prop.targetMeta),
+            schema: this.driver.getSchemaName(prop.targetMeta, { schema }),
             joinColumns: prop.referencedColumnNames,
             primaryKeys: prop.fieldNames,
         };
     }
-    joinManyToManyReference(prop, ownerAlias, alias, pivotAlias, type, cond, path) {
+    joinManyToManyReference(prop, ownerAlias, alias, pivotAlias, type, cond, path, schema) {
         const pivotMeta = this.metadata.find(prop.pivotEntity);
         const ret = {
             [`${ownerAlias}.${prop.name}#${pivotAlias}`]: {
@@ -138,7 +138,7 @@ class QueryBuilderHelper {
                 inverseJoinColumns: prop.inverseJoinColumns,
                 primaryKeys: prop.referencedColumnNames,
                 table: pivotMeta.tableName,
-                schema: this.driver.getSchemaName(pivotMeta),
+                schema: this.driver.getSchemaName(pivotMeta, { schema }),
                 path: path.endsWith('[pivot]') ? path : `${path}[pivot]`,
             },
         };
@@ -146,23 +146,10 @@ class QueryBuilderHelper {
             return ret;
         }
         const prop2 = prop.owner ? pivotMeta.relations[1] : pivotMeta.relations[0];
-        ret[`${pivotAlias}.${prop2.name}#${alias}`] = this.joinManyToOneReference(prop2, pivotAlias, alias, type);
+        ret[`${pivotAlias}.${prop2.name}#${alias}`] = this.joinManyToOneReference(prop2, pivotAlias, alias, type, undefined, schema);
         ret[`${pivotAlias}.${prop2.name}#${alias}`].path = path;
         return ret;
     }
-    joinPivotTable(field, prop, ownerAlias, alias, type, cond = {}) {
-        const pivotMeta = this.metadata.find(field);
-        const prop2 = pivotMeta.relations[0] === prop ? pivotMeta.relations[1] : pivotMeta.relations[0];
-        return {
-            prop, type, cond, ownerAlias, alias,
-            inverseAlias: ownerAlias,
-            table: pivotMeta.collection,
-            schema: pivotMeta.schema,
-            joinColumns: prop.joinColumns,
-            inverseJoinColumns: prop2.joinColumns,
-            primaryKeys: prop.referencedColumnNames,
-        };
-    }
     processJoins(qb, joins, schema) {
         Object.values(joins).forEach(join => {
             let table = `${join.table} as ${join.alias}`;