@mikro-orm/knex 6.0.0-dev.61 → 6.0.0-dev.62

package/AbstractSqlDriver.js

@@ -846,7 +846,7 @@ class AbstractSqlDriver extends core_1.DatabaseDriver {
                 ret.push((0, core_1.raw)(`${prop.formula(alias)} as ${aliased}`));
             });
             meta.props
-                .filter(prop => prop.customType?.convertToDatabaseValueSQL || prop.customType?.convertToJSValueSQL)
+                .filter(prop => prop.hasConvertToDatabaseValueSQL || prop.hasConvertToJSValueSQL)
                 .forEach(prop => ret.push(prop.name));
         }
         return ret.length > 0 ? core_1.Utils.unique(ret) : ['*'];

package/AbstractSqlPlatform.d.ts

@@ -14,6 +14,7 @@ export declare abstract class AbstractSqlPlatform extends Platform {
     quoteValue(value: any): string;
     formatQuery(sql: string, params: readonly any[]): string;
     getSearchJsonPropertySQL(path: string, type: string, aliased: boolean): string;
+    getSearchJsonPropertyKey(path: string[], type: string, aliased: boolean): string;
     isRaw(value: any): boolean;
     supportsSchemas(): boolean;
     /** @inheritDoc */

package/AbstractSqlPlatform.js

@@ -76,6 +76,14 @@ class AbstractSqlPlatform extends core_1.Platform {
     getSearchJsonPropertySQL(path, type, aliased) {
         return this.getSearchJsonPropertyKey(path.split('->'), type, aliased);
     }
+    getSearchJsonPropertyKey(path, type, aliased) {
+        const [a, ...b] = path;
+        const quoteKey = (key) => key.match(/^[a-z]\w*$/i) ? key : `"${key}"`;
+        if (aliased) {
+            return (0, core_1.raw)(alias => `json_extract(${this.quoteIdentifier(`${alias}.${a}`)}, '$.${b.map(quoteKey).join('.')}')`);
+        }
+        return (0, core_1.raw)(`json_extract(${this.quoteIdentifier(a)}, '$.${b.map(quoteKey).join('.')}')`);
+    }
     isRaw(value) {
         return super.isRaw(value) || (typeof value === 'object' && value !== null && value.client && ['Ref', 'Raw'].includes(value.constructor.name));
     }

package/SqlEntityRepository.d.ts

@@ -18,5 +18,12 @@ export declare class SqlEntityRepository<T extends object> extends EntityReposit
      * Returns configured knex instance.
      */
     getKnex(type?: ConnectionType): Knex;
+    /**
+     * @inheritDoc
+     */
+    getEntityManager(): SqlEntityManager;
+    /**
+     * @inheritDoc
+     */
     protected get em(): SqlEntityManager;
 }

package/SqlEntityRepository.js

@@ -11,7 +11,7 @@ class SqlEntityRepository extends core_1.EntityRepository {
      * Creates a QueryBuilder instance
      */
     createQueryBuilder(alias) {
-        return this.em.createQueryBuilder(this.entityName, alias);
+        return this.getEntityManager().createQueryBuilder(this.entityName, alias);
     }
     /**
      * Shortcut for `createQueryBuilder()`
@@ -23,10 +23,19 @@ class SqlEntityRepository extends core_1.EntityRepository {
      * Returns configured knex instance.
      */
     getKnex(type) {
-        return this.em.getConnection(type).getKnex();
+        return this.getEntityManager().getConnection(type).getKnex();
     }
+    /**
+     * @inheritDoc
+     */
+    getEntityManager() {
+        return this._em;
+    }
+    /**
+     * @inheritDoc
+     */
     get em() {
-        return this._em.getContext(false);
+        return this._em;
     }
 }
 exports.SqlEntityRepository = SqlEntityRepository;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/knex",
-  "version": "6.0.0-dev.61",
+  "version": "6.0.0-dev.62",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "main": "index.js",
   "module": "index.mjs",
@@ -63,9 +63,9 @@
     "sqlstring": "2.3.3"
   },
   "devDependencies": {
-    "@mikro-orm/core": "^5.6.16"
+    "@mikro-orm/core": "^5.7.2"
   },
   "peerDependencies": {
-    "@mikro-orm/core": "~6.0.0-dev.61"
+    "@mikro-orm/core": "~6.0.0-dev.62"
   }
 }

package/query/CriteriaNode.js

@@ -97,7 +97,7 @@ class CriteriaNode {
     [util_1.inspect.custom]() {
         const o = {};
         ['entityName', 'key', 'index', 'payload']
-            .filter(k => this[k] != null)
+            .filter(k => this[k] !== undefined)
             .forEach(k => o[k] = this[k]);
         return `${this.constructor.name} ${(0, util_1.inspect)(o)}`;
     }

package/query/CriteriaNodeFactory.js

@@ -37,9 +37,6 @@ class CriteriaNodeFactory {
     }
     static createObjectNode(metadata, entityName, payload, parent, key) {
         const meta = metadata.find(entityName);
-        if (!parent && Object.keys(payload).every(k => meta?.properties[k]?.kind === core_1.ReferenceKind.SCALAR)) {
-            return this.createScalarNode(metadata, entityName, payload, parent, key);
-        }
         const node = new ObjectCriteriaNode_1.ObjectCriteriaNode(metadata, entityName, parent, key);
         node.payload = Object.keys(payload).reduce((o, item) => {
             o[item] = this.createObjectItemNode(metadata, entityName, node, payload, item, meta);

package/query/QueryBuilder.js

@@ -370,6 +370,7 @@ class QueryBuilder {
     getKnexQuery() {
         this.finalize();
         const qb = this.getQueryBase();
+        qb.__raw = true; // tag it as there is now way to check via `instanceof`
         core_1.Utils.runIfNotEmpty(() => this.helper.appendQueryCondition(this.type ?? enums_1.QueryType.SELECT, this._cond, qb), this._cond && !this._onConflict);
         core_1.Utils.runIfNotEmpty(() => qb.groupBy(this.prepareFields(this._groupBy, 'groupBy')), this._groupBy);
         core_1.Utils.runIfNotEmpty(() => this.helper.appendQueryCondition(this.type ?? enums_1.QueryType.SELECT, this._having, qb, undefined, 'having'), this._having);
@@ -709,7 +710,7 @@ class QueryBuilder {
         });
         const meta = this.mainAlias.metadata;
         /* istanbul ignore next */
-        const requiresSQLConversion = meta?.props.filter(p => p.customType?.convertToJSValueSQL) ?? [];
+        const requiresSQLConversion = meta?.props.filter(p => p.hasConvertToJSValueSQL) ?? [];
         if (this.flags.has(core_1.QueryFlag.CONVERT_CUSTOM_TYPES) && (fields.includes('*') || fields.includes(`${this.mainAlias.aliasName}.*`)) && requiresSQLConversion.length > 0) {
             requiresSQLConversion.forEach(p => ret.push(this.helper.mapper(p.name, this.type)));
         }
@@ -940,6 +941,7 @@ class QueryBuilder {
         // multiple sub-queries are needed to get around mysql limitations with order by + limit + where in + group by (o.O)
         // https://stackoverflow.com/questions/17892762/mysql-this-version-of-mysql-doesnt-yet-support-limit-in-all-any-some-subqu
         const subSubQuery = this.getKnex().select(pks).from(knexQuery);
+        subSubQuery.__raw = true; // tag it as there is now way to check via `instanceof`
         this._limit = undefined;
         this._offset = undefined;
         this.select(this._fields).where({ [core_1.Utils.getPrimaryKeyHash(meta.primaryKeys)]: { $in: subSubQuery } });

package/query/QueryBuilderHelper.js

@@ -73,7 +73,7 @@ class QueryBuilderHelper {
             const as = alias === null ? '' : ` as ${aliased}`;
             return this.knex.raw(`${prop.formula(alias2)}${as}`);
         }
-        if (prop?.customType?.convertToJSValueSQL) {
+        if (prop?.hasConvertToJSValueSQL) {
             const prefixed = this.prefix(field, isTableNameAliasRequired, true);
             const valueSQL = prop.customType.convertToJSValueSQL(prefixed, this.platform);
             if (alias === null) {
@@ -301,7 +301,7 @@ class QueryBuilderHelper {
     }
     appendOnConflictClause(type, onConflict, qb) {
         onConflict.forEach(item => {
-            const sub = qb.onConflict(item.fields);
+            const sub = item.fields.length > 0 ? qb.onConflict(item.fields) : qb.onConflict();
             core_1.Utils.runIfNotEmpty(() => sub.ignore(), item.ignore);
             core_1.Utils.runIfNotEmpty(() => {
                 let mergeParam = item.merge;
@@ -618,9 +618,10 @@ class QueryBuilderHelper {
             if (prop.customType && convertCustomTypes && !this.platform.isRaw(data[k])) {
                 data[k] = prop.customType.convertToDatabaseValue(data[k], this.platform, { fromQuery: true, key: k, mode: 'query-data' });
             }
-            if (prop.customType && 'convertToDatabaseValueSQL' in prop.customType && !this.platform.isRaw(data[k])) {
+            if (prop.hasConvertToDatabaseValueSQL && !this.platform.isRaw(data[k])) {
                 const quoted = this.platform.quoteValue(data[k]);
-                data[k] = this.knex.raw(prop.customType.convertToDatabaseValueSQL(quoted, this.platform).replace(/\?/, '\\?'));
+                const sql = prop.customType.convertToDatabaseValueSQL(quoted, this.platform);
+                data[k] = this.knex.raw(sql.replace(/\?/, '\\?'));
             }
             if (!prop.customType && (Array.isArray(data[k]) || core_1.Utils.isPlainObject(data[k]))) {
                 data[k] = JSON.stringify(data[k]);

package/schema/SchemaComparator.js

@@ -439,6 +439,11 @@ class SchemaComparator {
             const defaultValueTo = !['0', 'false', 'f', 'n', 'no', 'off'].includes('' + to.default);
             return defaultValueFrom === defaultValueTo;
         }
+        if (to.mappedType instanceof core_1.JsonType) {
+            const defaultValueFrom = (0, core_1.parseJsonSafe)(from.default.replace(/^'(.*)'$/, '$1'));
+            const defaultValueTo = (0, core_1.parseJsonSafe)(to.default?.replace(/^'(.*)'$/, '$1'));
+            return core_1.Utils.equals(defaultValueFrom, defaultValueTo);
+        }
         if (to.mappedType instanceof core_1.DateTimeType && from.default && to.default) {
             // normalize now/current_timestamp defaults, also remove `()` from the end of default expression
             const defaultValueFrom = from.default.toLowerCase().replace('current_timestamp', 'now').replace(/\(\)$/, '');