@mikro-orm/core 7.1.5-dev.17 → 7.1.5-dev.19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikro-orm/core",
-  "version": "7.1.5-dev.17",
+  "version": "7.1.5-dev.19",
   "description": "TypeScript ORM for Node.js based on Data Mapper, Unit of Work and Identity Map patterns. Supports MongoDB, MySQL, PostgreSQL and SQLite databases as well as usage with vanilla JavaScript.",
   "keywords": [
     "data-mapper",

package/unit-of-work/UnitOfWork.js

@@ -993,21 +993,21 @@ export class UnitOfWork {
         const commitOrderReversed = [...commitOrder].reverse();
         // early delete - when we recreate entity in the same UoW, we need to issue those delete queries before inserts
         for (const meta of commitOrderReversed) {
-            await this.commitDeleteChangeSets(groups[ChangeSetType.DELETE_EARLY].get(meta) ?? [], ctx);
+            await this.commitDeleteChangeSets(groups[ChangeSetType.DELETE_EARLY].get(meta._id) ?? [], ctx);
         }
         // early update - when we recreate entity in the same UoW, we need to issue those delete queries before inserts
         for (const meta of commitOrder) {
-            await this.commitUpdateChangeSets(groups[ChangeSetType.UPDATE_EARLY].get(meta) ?? [], ctx);
+            await this.commitUpdateChangeSets(groups[ChangeSetType.UPDATE_EARLY].get(meta._id) ?? [], ctx);
         }
         // extra updates
         await this.commitExtraUpdates(ChangeSetType.UPDATE_EARLY, ctx);
         // create
         for (const meta of commitOrder) {
-            await this.commitCreateChangeSets(groups[ChangeSetType.CREATE].get(meta) ?? [], ctx);
+            await this.commitCreateChangeSets(groups[ChangeSetType.CREATE].get(meta._id) ?? [], ctx);
         }
         // update
         for (const meta of commitOrder) {
-            await this.commitUpdateChangeSets(groups[ChangeSetType.UPDATE].get(meta) ?? [], ctx);
+            await this.commitUpdateChangeSets(groups[ChangeSetType.UPDATE].get(meta._id) ?? [], ctx);
         }
         // extra updates
         await this.commitExtraUpdates(ChangeSetType.UPDATE, ctx);
@@ -1015,7 +1015,7 @@ export class UnitOfWork {
         await this.commitCollectionUpdates(ctx);
         // delete - entity deletions need to be in reverse commit order
         for (const meta of commitOrderReversed) {
-            await this.commitDeleteChangeSets(groups[ChangeSetType.DELETE].get(meta) ?? [], ctx);
+            await this.commitDeleteChangeSets(groups[ChangeSetType.DELETE].get(meta._id) ?? [], ctx);
         }
         // take snapshots of all persisted collections
         const visited = new Set();
@@ -1209,7 +1209,10 @@ export class UnitOfWork {
                 return;
             }
             const group = groups[cs.type];
-            const groupKey = cs.meta.inheritanceType === 'tpt' ? cs.meta : cs.rootMeta;
+            // keyed by `_id` so the groups share keys with `getCommitOrder()`, which dedupes by `_id`;
+            // two `EntityMetadata` instances with the same `_id` (shared metadata cache) must not split
+            // a group between them, or the lookup in `persistToDatabase()` misses and drops it (GH #7903)
+            const groupKey = cs.meta.inheritanceType === 'tpt' ? cs.meta._id : cs.rootMeta._id;
             const classGroup = group.get(groupKey) ?? [];
             classGroup.push(cs);
             if (!group.has(groupKey)) {

package/utils/Utils.js

@@ -141,7 +141,7 @@ export function parseJsonSafe(value) {
 /** Collection of general-purpose utility methods used throughout the ORM. */
 export class Utils {
     static PK_SEPARATOR = '~~~';
-    static #ORM_VERSION = '7.1.5-dev.17';
+    static #ORM_VERSION = '7.1.5-dev.19';
     /**
      * Checks if the argument is instance of `Object`. Returns false for arrays.
      */