@mikey-pro/eslint-config 8.0.15 → 8.0.17

package/index.js

@@ -14,6 +14,7 @@ import importSortPlugin from 'eslint-plugin-simple-import-sort';
 import perfectionistPlugin from 'eslint-plugin-perfectionist';
 import noSecretsPlugin from 'eslint-plugin-no-secrets';
 import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests';
+import sonarjsPlugin from 'eslint-plugin-sonarjs';
 
 import { baseOverrides } from './overrides.js';
 import { baseRules } from './rules.js';
@@ -81,6 +82,7 @@ const config = [
       perfectionist: perfectionistPlugin,
       'no-secrets': noSecretsPlugin,
       'no-only-tests': noOnlyTestsPlugin,
+      sonarjs: sonarjsPlugin,
     },
     rules: {
       ...baseRules,
@@ -88,6 +90,7 @@ const config = [
       ...compatPlugin.configs.recommended.rules,
       ...cssModules.configs.recommended.rules,
       ...importPlugin.configs.recommended.rules,
+      ...sonarjsPlugin.configs.recommended.rules,
       'prettier/prettier': ['warn', {
         parser: 'babel',
         endOfLine: 'lf',
@@ -125,6 +128,15 @@ const config = [
       'import/no-cycle': 'warn',
       'import/no-useless-path-segments': 'warn',
       'import/no-anonymous-default-export': 'warn',
+
+      // SonarJS rules
+      'sonarjs/cognitive-complexity': ['error', 15],
+      'sonarjs/no-duplicate-string': ['error', 5],
+      'sonarjs/no-redundant-boolean': 'error',
+      'sonarjs/prefer-immediate-return': 'error',
+      'sonarjs/no-small-switch': 'warn',
+      'sonarjs/no-duplicated-branches': 'error',
+      'sonarjs/max-switch-cases': ['warn', 10],
     },
     settings: {
       'json/json-with-comments-files': [],

package/overrides.js

@@ -4,6 +4,7 @@ import typescriptParser from '@typescript-eslint/parser';
 import typeScriptPlugin from '@typescript-eslint/eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import markdownPlugin from 'eslint-plugin-markdownlint';
+import jestPlugin from 'eslint-plugin-jest';
 
 const currentDir = path.dirname(fileURLToPath(import.meta.url));
 
@@ -357,13 +358,17 @@ const json5 = {
 };
 
 const jestJs = {
-  files: ['*.test.js'],
-  plugins: ['jest'],
+  files: ['*.test.js', '**/__tests__/**/*.js'],
+  plugins: {
+    jest: jestPlugin,
+  },
   extends: ['plugin:jest/all'],
   env: {
     jest: true,
   },
   rules: {
+    'jest/prefer-spy-on': 'warn',
+    'jest/require-top-level-describe': 'error',
     'unicorn/no-array-callback-reference': 'off',
     'jest/unbound-method': 'off',
     'unicorn/prevent-abbreviations': [
@@ -376,14 +381,19 @@ const jestJs = {
 };
 
 const jestTs = {
-  files: ['*.test.ts'],
+  files: ['*.test.ts', '**/__tests__/**/*.ts'],
   parser: '@typescript-eslint/parser',
-  plugins: ['@typescript-eslint', 'jest'],
+  plugins: {
+    '@typescript-eslint': typeScriptPlugin,
+    jest: jestPlugin,
+  },
   extends: ['plugin:jest/all'],
   env: {
     jest: true,
   },
   rules: {
+    'jest/prefer-spy-on': 'warn',
+    'jest/require-top-level-describe': 'error',
     'unicorn/no-array-callback-reference': 'off',
     'jest/unbound-method': 'off',
     'unicorn/prevent-abbreviations': [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikey-pro/eslint-config",
-  "version": "8.0.15",
+  "version": "8.0.17",
   "description": "Mikey Pro ESLint configuration",
   "main": "index.js",
   "types": "index.d.ts",

package/rules.js

@@ -202,37 +202,21 @@ export const baseRules = {
 
   // Security
   'security/detect-non-literal-fs-filename': 'error',
-  'security/detect-unsafe-regex': ['error', {
-    allowDollarMatchAll: false,
-    maxLength: 50
-  }],
+  'security/detect-unsafe-regex': 'error',
   'security/detect-buffer-noassert': 'error',
   'security/detect-child-process': 'warn',
   'security/detect-disable-mustache-escape': 'error',
-  'security/detect-possible-timing-attacks': ['error', {
-    threshold: 8,
-    catchAliases: true
-  }],
-  'security/detect-non-literal-regexp': ['error', {
-    report: 'error',
-    warnOnDynamicRegexp: true
-  }],
+  'security/detect-possible-timing-attacks': 'error',
+  'security/detect-non-literal-regexp': 'error',
   'security/detect-non-literal-require': 'error',
 
-  // Better testing
-  'jest/prefer-spy-on': 'warn',
-  'jest/require-top-level-describe': 'error',
-
-  // Code Quality
-  'sonarjs/cognitive-complexity': ['error', 15],
-  'sonarjs/no-duplicate-string': ['error', 5],
-  'sonarjs/no-redundant-boolean': 'error',
-  'sonarjs/prefer-immediate-return': 'error',
+  'no-duplicate-imports': 'error',
+  'no-unreachable': 'error',
+  'no-constant-condition': 'error',
+  'complexity': ['error', { max: 15 }],
 
   // RegExp
   'regexp/no-missing-g-flag': 'error',
-  'regexp/no-useless-flag': 'error',
-  'regexp/prefer-quantifier': 'error',
 
   // Enhanced TypeScript
   'etc/no-commented-out-code': 'warn',
@@ -258,9 +242,6 @@ export const baseRules = {
 
   // Code Quality
   'write-good-comments/write-good-comments': 'warn',
-  'sonarjs/no-small-switch': 'warn',
-  'sonarjs/no-duplicated-branches': 'error',
-  'sonarjs/max-switch-cases': ['warn', 10],
 
   // Import Safety
   'import/no-cycle': ['error', {