@mikey-pro/eslint-config 8.0.14 → 8.0.16

package/index.js

@@ -14,6 +14,7 @@ import importSortPlugin from 'eslint-plugin-simple-import-sort';
 import perfectionistPlugin from 'eslint-plugin-perfectionist';
 import noSecretsPlugin from 'eslint-plugin-no-secrets';
 import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests';
+// Remove jest plugin import since it's now in overrides.js
 
 import { baseOverrides } from './overrides.js';
 import { baseRules } from './rules.js';
@@ -81,6 +82,7 @@ const config = [
       perfectionist: perfectionistPlugin,
       'no-secrets': noSecretsPlugin,
       'no-only-tests': noOnlyTestsPlugin,
+      // Remove jest plugin from here since it's in overrides
     },
     rules: {
       ...baseRules,

package/overrides.js

@@ -4,6 +4,7 @@ import typescriptParser from '@typescript-eslint/parser';
 import typeScriptPlugin from '@typescript-eslint/eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import markdownPlugin from 'eslint-plugin-markdownlint';
+import jestPlugin from 'eslint-plugin-jest';
 
 const currentDir = path.dirname(fileURLToPath(import.meta.url));
 
@@ -357,13 +358,17 @@ const json5 = {
 };
 
 const jestJs = {
-  files: ['*.test.js'],
-  plugins: ['jest'],
+  files: ['*.test.js', '**/__tests__/**/*.js'],
+  plugins: {
+    jest: jestPlugin,
+  },
   extends: ['plugin:jest/all'],
   env: {
     jest: true,
   },
   rules: {
+    'jest/prefer-spy-on': 'warn',
+    'jest/require-top-level-describe': 'error',
     'unicorn/no-array-callback-reference': 'off',
     'jest/unbound-method': 'off',
     'unicorn/prevent-abbreviations': [
@@ -376,14 +381,19 @@ const jestJs = {
 };
 
 const jestTs = {
-  files: ['*.test.ts'],
+  files: ['*.test.ts', '**/__tests__/**/*.ts'],
   parser: '@typescript-eslint/parser',
-  plugins: ['@typescript-eslint', 'jest'],
+  plugins: {
+    '@typescript-eslint': typeScriptPlugin,
+    jest: jestPlugin,
+  },
   extends: ['plugin:jest/all'],
   env: {
     jest: true,
   },
   rules: {
+    'jest/prefer-spy-on': 'warn',
+    'jest/require-top-level-describe': 'error',
     'unicorn/no-array-callback-reference': 'off',
     'jest/unbound-method': 'off',
     'unicorn/prevent-abbreviations': [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikey-pro/eslint-config",
-  "version": "8.0.14",
+  "version": "8.0.16",
   "description": "Mikey Pro ESLint configuration",
   "main": "index.js",
   "types": "index.d.ts",

package/rules.js

@@ -73,6 +73,14 @@ export const baseRules = {
         '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
       selector: 'WithStatement',
     },
+    {
+      selector: "CallExpression[callee.property.name='reduce'][arguments.length<2]",
+      message: 'Provide initialValue to reduce'
+    },
+    {
+      selector: "CallExpression[callee.property.name='forEach']",
+      message: 'Use for...of instead'
+    }
   ],
   'no-shadow': 'off',
   'no-shadow-restricted-names': 'warn',
@@ -122,7 +130,7 @@ export const baseRules = {
   ],
   radix: 'warn',
   'filenames/match-regex': 'off',
-  'require-atomic-updates': 'error',
+  'require-atomic-updates': ['error', { allowProperties: false }],
   'sort-imports': 'off',
   'rest-spread-spacing': 'off',
   semi: 'off',
@@ -176,7 +184,7 @@ export const baseRules = {
 
   // Error handling
   'no-await-in-loop': 'warn',
-  'no-promise-executor-return': 'error',
+  'no-promise-executor-return': ['error', { allowVoid: true }],
   'no-unsafe-optional-chaining': 'error',
 
   // Modern practices
@@ -193,12 +201,14 @@ export const baseRules = {
   'promise/prefer-await-to-callbacks': 'warn',
 
   // Security
-  'security/detect-non-literal-fs-filename': 'warn',
+  'security/detect-non-literal-fs-filename': 'error',
   'security/detect-unsafe-regex': 'error',
-
-  // Better testing
-  'jest/prefer-spy-on': 'warn',
-  'jest/require-top-level-describe': 'error',
+  'security/detect-buffer-noassert': 'error',
+  'security/detect-child-process': 'warn',
+  'security/detect-disable-mustache-escape': 'error',
+  'security/detect-possible-timing-attacks': 'error',
+  'security/detect-non-literal-regexp': 'error',
+  'security/detect-non-literal-require': 'error',
 
   // Code Quality
   'sonarjs/cognitive-complexity': ['error', 15],
@@ -206,18 +216,15 @@ export const baseRules = {
   'sonarjs/no-redundant-boolean': 'error',
   'sonarjs/prefer-immediate-return': 'error',
 
-  // RegExp
-  'regexp/no-missing-g-flag': 'error',
-  'regexp/no-useless-flag': 'error',
-  'regexp/prefer-quantifier': 'error',
-
   // Enhanced TypeScript
   'etc/no-commented-out-code': 'warn',
   'etc/no-implicit-any-catch': 'error',
   'etc/prefer-interface': 'error',
 
   // Enhanced Import Rules
-  'import/no-relative-parent-imports': 'warn',
+  'import/no-relative-parent-imports': ['error', {
+    ignore: ['@/components', '@/utils', '@/types']
+  }],
   'import/no-extraneous-dependencies': ['error', {
     devDependencies: ['**/*.test.{js,ts}', '**/*.spec.{js,ts}', '**/test/**']
   }],
@@ -226,11 +233,6 @@ export const baseRules = {
   'promise/no-nesting': 'warn',
   'promise/prefer-await-to-then': 'warn',
 
-  // Security Enhancements
-  'security/detect-buffer-noassert': 'error',
-  'security/detect-child-process': 'warn',
-  'security/detect-disable-mustache-escape': 'error',
-
   // Code Organization
   'typescript-sort-keys/interface': 'warn',
   'typescript-sort-keys/string-enum': 'warn',
@@ -242,14 +244,17 @@ export const baseRules = {
   'sonarjs/no-duplicated-branches': 'error',
   'sonarjs/max-switch-cases': ['warn', 10],
 
-  // Additional Security
-  'security/detect-possible-timing-attacks': ['error', { threshold: 10 }],
-  'security/detect-non-literal-regexp': ['error', { report: 'error' }],
-  'security/detect-non-literal-require': 'error',
-
-  // Better Type Safety
+  // Import Safety
+  'import/no-cycle': ['error', {
+    maxDepth: 1,
+    ignoreExternal: true
+  }],
   'import/no-relative-packages': 'error',
   'import/no-self-import': 'error',
+  'import/no-namespace': 'error',
+  'import/no-empty-named-blocks': 'error',
+  'import/no-duplicates': ['error', { 'prefer-inline': true }],
+  'import/no-import-module-exports': 'error',
 
   // Architecture Boundaries
   'boundaries/element-types': [
@@ -270,87 +275,6 @@ export const baseRules = {
   'radar/cognitive-complexity': ['error', 15],
 
   // Enhanced Security
-  'security/detect-non-literal-fs-filename': ['error', { allowInlineConfig: false }],
-  'security/detect-unsafe-regex': ['error', { allowDollarMatchAll: false }],
-  'security/detect-buffer-noassert': 'error',
-
-  // Better Type Safety
-  'import/no-cycle': ['error', { maxDepth: 1 }],
-  'import/no-relative-packages': 'error',
-  'unicorn/prefer-module': 'error',
-
-  // Code Style
-  'perfectionist/sort-named-imports': [
-    'warn',
-    {
-      type: 'natural',
-      order: 'asc',
-      'ignore-case': true
-    }
-  ],
-
-  // Enhanced Security
-  'security/detect-possible-timing-attacks': ['error', {
-    threshold: 8,
-    catchAliases: true
-  }],
-  'security/detect-non-literal-regexp': ['error', {
-    report: 'error',
-    warnOnDynamicRegexp: true
-  }],
-  'security/detect-unsafe-regex': ['error', {
-    maxLength: 50
-  }],
-
-  // Import Safety
-  'import/no-import-module-exports': 'error',
-  'import/no-relative-parent-imports': ['error', {
-    ignore: ['@/components', '@/utils', '@/types']
-  }],
-
-  // Better Code Organization
-  'perfectionist/sort-objects': ['error', {
-    type: 'natural',
-    order: 'asc',
-    'spread-last': true
-  }],
-  'perfectionist/sort-named-imports': ['error', {
-    type: 'natural',
-    order: 'asc',
-    'ignore-case': true
-  }],
-
-  // Advanced Performance
-  'no-restricted-syntax': [
-    'error',
-    {
-      selector: "CallExpression[callee.property.name='reduce'][arguments.length<2]",
-      message: 'Provide initialValue to reduce'
-    },
-    {
-      selector: "CallExpression[callee.property.name='forEach']",
-      message: 'Use for...of instead'
-    }
-  ],
-  'require-atomic-updates': ['error', { allowProperties: false }],
-  'no-constant-binary-expression': 'error',
-
-  // Better Error Handling
-  'no-implicit-coercion': ['error', { boolean: false, number: true, string: true }],
-  'unicorn/prefer-type-error': 'error',
-  'unicorn/no-useless-undefined': ['error', { checkArguments: true }],
-
-  // Enhanced Import Safety
-  'import/no-cycle': ['error', { maxDepth: 1, ignoreExternal: true }],
-  'import/no-relative-packages': 'error',
-  'import/no-self-import': 'error',
-
-  // Type Safety
-  'unicorn/prefer-at': 'error',
-  'unicorn/prefer-string-replace-all': 'error',
-  'unicorn/require-post-message-target-origin': 'error',
-
-  // Security
   'n/no-unsupported-features/es-syntax': ['error', {
     version: '>=18.0.0',
     ignores: ['modules', 'dynamicImport']
@@ -369,11 +293,25 @@ export const baseRules = {
 
   // Better Error Handling
   'max-classes-per-file': ['error', 1],
-  'no-promise-executor-return': ['error', { allowVoid: true }],
   'unicorn/catch-error-name': ['error', { name: 'error' }],
+  'unicorn/no-useless-undefined': ['error', { checkArguments: true }],
+  'unicorn/prefer-type-error': 'error',
 
-  // Enhanced Import Safety
-  'import/no-namespace': 'error',
-  'import/no-empty-named-blocks': 'error',
-  'import/no-duplicates': ['error', { 'prefer-inline': true }]
+  // Code Style
+  'perfectionist/sort-named-imports': ['error', {
+    type: 'natural',
+    order: 'asc',
+    'ignore-case': true
+  }],
+  'perfectionist/sort-objects': ['error', {
+    type: 'natural',
+    order: 'asc',
+    'spread-last': true
+  }],
+
+  // Advanced Performance
+  'no-implicit-coercion': ['error', { boolean: false, number: true, string: true }],
+  'unicorn/prefer-at': 'error',
+  'unicorn/prefer-string-replace-all': 'error',
+  'unicorn/require-post-message-target-origin': 'error'
 };