@mikey-pro/eslint-config 7.4.0 → 7.5.0

package/index.js

@@ -1,4 +1,5 @@
-const path = require('node:path');
+const overrides = require('./overrides');
+const rules = require('./rules');
 
 module.exports = {
   env: {
@@ -14,7 +15,7 @@ module.exports = {
     'plugin:compat/recommended',
     'plugin:css-modules/recommended',
     'plugin:import/recommended',
-    'plugin:prettier/all',
+    'plugin:prettier/recommended',
   ],
   ignorePatterns: [
     '**/dist/**/*',
@@ -33,193 +34,7 @@ module.exports = {
     'LICENSE',
     'CNAME',
   ],
-  overrides: [
-    {
-      files: ['*.ts', '*.tsx'],
-      extends: [
-        'plugin:@typescript-eslint/all',
-        'plugin:@typescript-eslint/recommended-requiring-type-checking',
-        'plugin:import/typescript',
-      ],
-      parser: '@typescript-eslint/parser',
-      parserOptions: {
-        ecmaFeatures: {
-          jsx: true,
-        },
-        ecmaVersion: 'latest',
-        extraFileExtensions: ['.vue', '.svelte'],
-        sourceType: 'module',
-        project: 'tsconfig.json',
-        tsconfigRootDir: path.join(__dirname, '../../..'),
-      },
-      plugins: ['@typescript-eslint'],
-      rules: {
-        '@typescript-eslint/unbound-method': 'off',
-        '@typescript-eslint/naming-convention': 'off',
-        'prettier/prettier': ['warn', { parser: 'typescript' }],
-      },
-      settings: {
-        'import/parsers': {
-          '@typescript-eslint/parser': ['.ts', '.tsx'],
-        },
-        'import/resolver': {
-          typescript: {
-            alwaysTryTypes: true,
-          },
-        },
-      },
-    },
-    {
-      files: ['*.css'],
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'css' }],
-      },
-    },
-    {
-      files: ['*.scss'],
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'scss' }],
-      },
-    },
-    {
-      files: ['*.less'],
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'less' }],
-      },
-    },
-    {
-      extends: ['plugin:yml/standard'],
-      files: ['*.yaml', '*.yml'],
-      parser: 'yaml-eslint-parser',
-      rules: {
-        'yml/quotes': ['warn', { prefer: 'double', avoidEscape: true }],
-        'prettier/prettier': ['warn', { parser: 'yaml', singleQuote: false }],
-      },
-    },
-    {
-      extends: ['plugin:toml/standard'],
-      files: ['*.toml'],
-      parser: 'toml-eslint-parser',
-      rules: {
-        'prettier/prettier': 'off',
-      },
-    },
-    {
-      files: ['*.md'],
-      parser: 'eslint-plugin-markdownlint/parser',
-      extends: ['plugin:markdownlint/recommended'],
-      rules: {
-        'markdownlint/md033': 'off',
-        'markdownlint/md041': 'off',
-        'prettier/prettier': ['warn', { parser: 'markdown' }],
-      },
-    },
-    {
-      files: ['package.json'],
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'json' }],
-      },
-      settings: {
-        'json/package-json-sort-order': [
-          'name',
-          'version',
-          'description',
-          'private',
-          'main',
-          'type',
-          'types',
-          'typings',
-          'browser',
-          'engines',
-          'scripts',
-          'husky',
-          'dependencies',
-          'devDependencies',
-          'peerDependencies',
-          'files',
-          'bin',
-          'productName',
-          'homepage',
-          'repository',
-          'bugs',
-          'license',
-          'keywords',
-          'author',
-          'contributors',
-          'funding',
-        ],
-      },
-    },
-    {
-      files: ['*.md.json'],
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'json' }],
-      },
-    },
-    {
-      extends: ['plugin:@html-eslint/recommended'],
-      files: ['*.html'],
-      parser: '@html-eslint/parser',
-      plugins: ['@html-eslint'],
-      rules: {
-        '@html-eslint/indent': 'off',
-        '@html-eslint/no-extra-spacing-attrs': 'off',
-        '@html-eslint/require-closing-tags': 'off',
-        'disable-autofix/@html-eslint/require-closing-tags': [
-          'warn',
-          { selfClosing: 'always' },
-        ],
-        'spaced-comment': 'off',
-        'prettier/prettier': ['warn', { parser: 'html' }],
-      },
-    },
-    {
-      extends: ['plugin:jsonc/recommended-with-jsonc'],
-      files: ['*.jsonc', '*rc'],
-      parser: 'jsonc-eslint-parser',
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'json' }],
-      },
-    },
-    {
-      extends: ['plugin:jsonc/recommended-with-json5'],
-      files: ['*.json5'],
-      parser: 'jsonc-eslint-parser',
-      rules: {
-        'prettier/prettier': ['warn', { parser: 'json5' }],
-      },
-    },
-    {
-      files: ['*.test.js'],
-      plugins: ['jest'],
-      extends: ['plugin:jest/all'],
-      env: {
-        jest: true,
-      },
-      rules: {
-        'unicorn/no-array-callback-reference': 'off',
-        'jest/unbound-method': 'off',
-      },
-    },
-    {
-      files: ['*.test.ts'],
-      parser: '@typescript-eslint/parser',
-      plugins: ['@typescript-eslint', 'jest'],
-      extends: ['plugin:jest/all'],
-      env: {
-        jest: true,
-      },
-      rules: {
-        'unicorn/no-array-callback-reference': 'off',
-        'jest/unbound-method': 'off',
-      },
-    },
-    {
-      files: ['*.cy.*'],
-      plugins: ['cypress'],
-      extends: ['plugin:cypress/recommended'],
-    },
-  ],
+  overrides: [...overrides],
   parser: '@babel/eslint-parser',
   parserOptions: {
     babelOptions: {
@@ -249,163 +64,7 @@ module.exports = {
     'import',
   ],
   root: true,
-  rules: {
-    camelcase: 'warn',
-    'class-methods-use-this': 'off',
-    'constructor-super': 'warn',
-    'dot-notation': 'warn',
-    'func-names': 'off',
-    'import/extensions': ['warn', 'never', { ignorePackages: true }],
-    'import/no-commonjs': 'off',
-    'import/default': 'off',
-    'import/named': 'off',
-    'import/namespace': 'off',
-    'import/no-named-as-default-member': 'off',
-    'import/no-unresolved': [
-      'warn',
-      { amd: true, commonjs: true, ignore: ['^node:'] },
-    ],
-    'import/order': [
-      'warn',
-      {
-        alphabetize: {
-          order: 'asc',
-        },
-        'newlines-between': 'always',
-      },
-    ],
-    'jsx-quotes': 'warn',
-    'keyword-spacing': 'warn',
-    'no-caller': 'warn',
-    'no-confusing-arrow': 'warn',
-    'no-console': 'off',
-    'no-const-assign': 'warn',
-    'no-delete-var': 'warn',
-    'no-dupe-class-members': 'warn',
-    'no-dupe-keys': 'warn',
-    'no-duplicate-imports': 'warn',
-    'no-else-return': 'warn',
-    'no-empty': 'off',
-    'no-empty-pattern': 'off',
-    'no-extra-parens': 'off',
-    'no-extra-bind': 'warn',
-    'no-extra-semi': 'warn',
-    'no-floating-decimal': 'warn',
-    'no-iterator': 'warn',
-    'no-lonely-if': 'warn',
-    'no-mixed-spaces-and-tabs': ['warn', 'smart-tabs'],
-    'no-multi-str': 'warn',
-    'no-new-wrappers': 'warn',
-    'no-process-exit': 'off',
-    'no-proto': 'warn',
-    'no-redeclare': 'warn',
-    'no-restricted-syntax': [
-      'warn',
-      {
-        message:
-          'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
-        selector: 'ForInStatement',
-      },
-      {
-        message:
-          'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
-        selector: 'LabeledStatement',
-      },
-      {
-        message:
-          '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
-        selector: 'WithStatement',
-      },
-    ],
-    'no-shadow': 'off',
-    'no-shadow-restricted-names': 'warn',
-    'no-spaced-func': 'warn',
-    'no-this-before-super': 'warn',
-    'no-undef-init': 'warn',
-    'no-underscore-dangle': 'off',
-    'no-unneeded-ternary': 'warn',
-    'no-unused-vars': [
-      'warn',
-      {
-        args: 'after-used',
-        ignoreRestSiblings: true,
-      },
-    ],
-    'no-useless-call': 'warn',
-    'no-useless-computed-key': 'warn',
-    'no-useless-concat': 'warn',
-    'no-useless-constructor': 'warn',
-    'no-useless-escape': 'warn',
-    'no-useless-rename': 'warn',
-    'no-useless-return': 'warn',
-    'no-var': 'warn',
-    'no-with': 'warn',
-    'object-curly-spacing': ['off', 'always'],
-    'object-shorthand': 'warn',
-    'prefer-arrow-callback': 'warn',
-    'prefer-destructuring': [
-      'warn',
-      {
-        array: false,
-        object: true,
-      },
-    ],
-    'prefer-rest-params': 'warn',
-    'prefer-spread': 'warn',
-    'prefer-template': 'warn',
-    'prefer-const': 'off',
-    'disable-autofix/prefer-const': 'warn',
-    'prettier/prettier': ['warn', { parser: 'babel' }],
-    'quote-props': ['warn', 'as-needed'],
-    quotes: [
-      'off',
-      'single',
-      {
-        allowTemplateLiterals: true,
-        avoidEscape: true,
-      },
-    ],
-    radix: 'warn',
-    'filenames/match-regex': 'off',
-    'require-atomic-updates': 'off',
-    'sort-imports': 'off',
-    'rest-spread-spacing': 'off',
-    semi: 'off',
-    'sort-vars': 'warn',
-    'space-before-function-paren': [
-      'off',
-      { anonymous: 'always', asyncArrow: 'always', named: 'never' },
-    ],
-    'space-in-parens': ['off', 'never'],
-    'spaced-comment': [
-      'warn',
-      'always',
-      {
-        block: {
-          balanced: true,
-          exceptions: ['*'],
-          markers: ['!'],
-        },
-        line: {
-          exceptions: ['-', '+'],
-          markers: ['/'],
-        },
-      },
-    ],
-    strict: ['warn', 'never'],
-    'unicode-bom': 'warn',
-    'unicorn/filename-case': [
-      'warn',
-      {
-        cases: {
-          camelCase: true,
-          pascalCase: true,
-        },
-        ignore: ['.*.md'],
-      },
-    ],
-    'unicorn/import-index': ['warn', { ignoreImports: true }],
-  },
+  rules,
   settings: {
     'json/json-with-comments-files': [],
     polyfills: ['Promise'],

package/overrides.js

@@ -0,0 +1,281 @@
+const path = require('node:path');
+
+const ts = {
+  files: ['*.ts', '*.tsx'],
+  extends: [
+    'plugin:@typescript-eslint/all',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:import/typescript',
+  ],
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+    ecmaVersion: 'latest',
+    extraFileExtensions: ['.vue', '.svelte'],
+    sourceType: 'module',
+    project: 'tsconfig.json',
+    tsconfigRootDir: path.join(__dirname, '../../..'),
+  },
+  plugins: ['@typescript-eslint'],
+  rules: {
+    '@typescript-eslint/class-methods-use-this': 'off',
+    '@typescript-eslint/consistent-type-imports': [
+      'warn',
+      { fixStyle: 'inline-type-imports' },
+    ],
+    '@typescript-eslint/explicit-member-accessibility': [
+      'warn',
+      {
+        accessibility: 'explicit',
+        overrides: {
+          accessors: 'explicit',
+          constructors: 'no-public',
+          methods: 'explicit',
+          properties: 'off',
+          parameterProperties: 'explicit',
+        },
+      },
+    ],
+    '@typescript-eslint/init-declarations': 'off',
+    '@typescript-eslint/max-params': 'off',
+    '@typescript-eslint/member-ordering': [
+      'warn',
+      {
+        default: [
+          'public-static-field',
+          'public-static-method',
+          'protected-static-field',
+          'protected-static-method',
+          'private-static-field',
+          'private-static-method',
+          'public-instance-field',
+          'protected-instance-field',
+          'private-instance-field',
+          'public-constructor',
+          'protected-constructor',
+          'private-constructor',
+          'public-instance-method',
+          'protected-instance-method',
+          'private-instance-method',
+        ],
+      },
+    ],
+    '@typescript-eslint/naming-convention': 'off',
+    '@typescript-eslint/no-extraneous-class': [
+      'warn',
+      {
+        allowEmpty: true,
+        allowConstructorOnly: false,
+        allowStaticOnly: false,
+        allowWithDecorator: false,
+      },
+    ],
+    '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-magic-numbers': 'off',
+    '@typescript-eslint/no-unnecessary-condition': 'off',
+    '@typescript-eslint/parameter-properties': 'off',
+    '@typescript-eslint/prefer-nullish-coalescing': 'off',
+    '@typescript-eslint/prefer-readonly': 'off',
+    '@typescript-eslint/prefer-readonly-parameter-types': 'off',
+    '@typescript-eslint/strict-boolean-expressions': 'off',
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
+    'prettier/prettier': ['warn', { parser: 'typescript' }],
+  },
+  settings: {
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts', '.tsx'],
+    },
+    'import/resolver': {
+      typescript: {
+        alwaysTryTypes: true,
+      },
+    },
+  },
+};
+
+const css = {
+  files: ['*.css'],
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'css' }],
+  },
+};
+
+const scss = {
+  files: ['*.scss'],
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'scss' }],
+  },
+};
+
+const less = {
+  files: ['*.less'],
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'less' }],
+  },
+};
+
+const yaml = {
+  extends: ['plugin:yml/standard'],
+  files: ['*.yaml', '*.yml'],
+  parser: 'yaml-eslint-parser',
+  rules: {
+    'yml/quotes': ['warn', { prefer: 'double', avoidEscape: true }],
+    'prettier/prettier': ['warn', { parser: 'yaml', singleQuote: false }],
+  },
+};
+
+const toml = {
+  extends: ['plugin:toml/standard'],
+  files: ['*.toml'],
+  parser: 'toml-eslint-parser',
+  rules: {
+    'prettier/prettier': 'off',
+  },
+};
+
+const md = {
+  files: ['*.md'],
+  parser: 'eslint-plugin-markdownlint/parser',
+  extends: ['plugin:markdownlint/recommended'],
+  rules: {
+    'markdownlint/md033': 'off',
+    'markdownlint/md041': 'off',
+    'prettier/prettier': ['warn', { parser: 'markdown' }],
+  },
+};
+
+const packageJson = {
+  files: ['package.json'],
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'json' }],
+  },
+  settings: {
+    'json/package-json-sort-order': [
+      'name',
+      'version',
+      'description',
+      'private',
+      'main',
+      'type',
+      'types',
+      'typings',
+      'browser',
+      'engines',
+      'scripts',
+      'husky',
+      'dependencies',
+      'devDependencies',
+      'peerDependencies',
+      'files',
+      'bin',
+      'productName',
+      'homepage',
+      'repository',
+      'bugs',
+      'license',
+      'keywords',
+      'author',
+      'contributors',
+      'funding',
+    ],
+  },
+};
+
+const mdJson = {
+  files: ['*.md.json'],
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'json' }],
+  },
+};
+
+const html = {
+  files: ['*.html'],
+  extends: ['plugin:@html-eslint/recommended'],
+  parser: '@html-eslint/parser',
+  plugins: ['@html-eslint'],
+  rules: {
+    '@html-eslint/element-newline': 'off',
+    '@html-eslint/indent': 'off',
+    '@html-eslint/no-extra-spacing-attrs': 'off',
+    '@html-eslint/require-closing-tags': 'off',
+    'disable-autofix/@html-eslint/require-closing-tags': [
+      'warn',
+      { selfClosing: 'always' },
+    ],
+    'spaced-comment': 'off',
+    strict: 'off',
+    'prettier/prettier': ['warn', { parser: 'html' }],
+  },
+};
+
+const jsonc = {
+  extends: ['plugin:jsonc/recommended-with-jsonc'],
+  files: ['*.jsonc', '*rc'],
+  parser: 'jsonc-eslint-parser',
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'json' }],
+  },
+};
+
+const json5 = {
+  extends: ['plugin:jsonc/recommended-with-json5'],
+  files: ['*.json5'],
+  parser: 'jsonc-eslint-parser',
+  rules: {
+    'prettier/prettier': ['warn', { parser: 'json5' }],
+  },
+};
+
+const jestJs = {
+  files: ['*.test.js'],
+  plugins: ['jest'],
+  extends: ['plugin:jest/all'],
+  env: {
+    jest: true,
+  },
+  rules: {
+    'unicorn/no-array-callback-reference': 'off',
+    'jest/unbound-method': 'off',
+  },
+};
+
+const jestTs = {
+  files: ['*.test.ts'],
+  parser: '@typescript-eslint/parser',
+  plugins: ['@typescript-eslint', 'jest'],
+  extends: ['plugin:jest/all'],
+  env: {
+    jest: true,
+  },
+  rules: {
+    'unicorn/no-array-callback-reference': 'off',
+    'jest/unbound-method': 'off',
+  },
+};
+
+const cypress = {
+  files: ['*.cy.*'],
+  plugins: ['cypress'],
+  extends: ['plugin:cypress/recommended'],
+};
+
+module.exports = {
+  ts,
+  css,
+  scss,
+  less,
+  yaml,
+  toml,
+  md,
+  packageJson,
+  mdJson,
+  html,
+  jsonc,
+  json5,
+  jestJs,
+  jestTs,
+  cypress,
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mikey-pro/eslint-config",
-  "version": "7.4.0",
+  "version": "7.5.0",
   "description": "Mikey Pro ESLint configuration",
   "main": "index.js",
   "dependencies": {
@@ -11,19 +11,19 @@
     "@cypress/eslint-plugin-json": "^3.2.3",
     "@html-eslint/eslint-plugin": "^0.24.1",
     "@html-eslint/parser": "^0.24.1",
-    "@typescript-eslint/eslint-plugin": "^7.6.0",
-    "@typescript-eslint/parser": "^7.6.0",
+    "@typescript-eslint/eslint-plugin": "^7.7.1",
+    "@typescript-eslint/parser": "^7.7.1",
     "eslint-config-prettier": "^9.1",
     "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-plugin-compat": "^4.2",
     "eslint-plugin-css-modules": "^2.12",
-    "eslint-plugin-cypress": "^2.15.1",
+    "eslint-plugin-cypress": "^3.0.2",
     "eslint-plugin-disable-autofix": "^4.3.0",
     "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^28.2.0",
+    "eslint-plugin-jest": "^28.3.0",
     "eslint-plugin-jsonc": "^2.15.1",
     "eslint-plugin-markdownlint": "^0.5.0",
-    "eslint-plugin-n": "^17.2.0",
+    "eslint-plugin-n": "^17.3.1",
     "eslint-plugin-only-warn": "^1.1.0",
     "eslint-plugin-prettier": "^5.1",
     "eslint-plugin-promise": "^6.1.1",
@@ -36,6 +36,7 @@
   },
   "files": [
     "index.js",
+    "overrides.js",
     "README.md",
     "LICENSE"
   ],