@midscene/shared 1.7.5 → 1.7.6-beta-20260423130231.0

package/dist/es/mcp/tool-generator.mjs

@@ -68,10 +68,13 @@ function transformSchemaField(key, value) {
         value
     ];
 }
-function extractActionSchema(paramSchema) {
+function extractActionSchema(paramSchema, actionName) {
     if (!paramSchema) return {};
     const shape = getZodObjectShape(paramSchema);
-    if (!shape) return paramSchema;
+    if (!shape) {
+        const typeName = paramSchema?._def?.typeName ?? 'unknown';
+        throw new Error(`Action "${actionName}" declared a non-object paramSchema (${typeName}). CLI and MCP tool schemas must be a ZodObject (e.g. z.object({ uri: z.string() })) or undefined. Wrap primitive fields in an object schema.`);
+    }
     return Object.fromEntries(Object.entries(shape).map(([key, value])=>transformSchemaField(key, value)));
 }
 function getPromptText(prompt) {
@@ -289,7 +292,7 @@ function mergeToolCliMetadata(base, extra) {
 function generateToolsFromActionSpace(actionSpace, getAgent, sanitizeArgs = (args)=>args, initArgSchema = {}, initArgCliMetadata) {
     return actionSpace.map((action)=>{
         const schema = {
-            ...extractActionSchema(action.paramSchema),
+            ...extractActionSchema(action.paramSchema, action.name),
             ...initArgSchema
         };
         return {

package/dist/lib/mcp/tool-generator.js

@@ -97,10 +97,13 @@ function transformSchemaField(key, value) {
         value
     ];
 }
-function extractActionSchema(paramSchema) {
+function extractActionSchema(paramSchema, actionName) {
     if (!paramSchema) return {};
     const shape = getZodObjectShape(paramSchema);
-    if (!shape) return paramSchema;
+    if (!shape) {
+        const typeName = paramSchema?._def?.typeName ?? 'unknown';
+        throw new Error(`Action "${actionName}" declared a non-object paramSchema (${typeName}). CLI and MCP tool schemas must be a ZodObject (e.g. z.object({ uri: z.string() })) or undefined. Wrap primitive fields in an object schema.`);
+    }
     return Object.fromEntries(Object.entries(shape).map(([key, value])=>transformSchemaField(key, value)));
 }
 function getPromptText(prompt) {
@@ -318,7 +321,7 @@ function mergeToolCliMetadata(base, extra) {
 function generateToolsFromActionSpace(actionSpace, getAgent, sanitizeArgs = (args)=>args, initArgSchema = {}, initArgCliMetadata) {
     return actionSpace.map((action)=>{
         const schema = {
-            ...extractActionSchema(action.paramSchema),
+            ...extractActionSchema(action.paramSchema, action.name),
             ...initArgSchema
         };
         return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@midscene/shared",
-  "version": "1.7.5",
+  "version": "1.7.6-beta-20260423130231.0",
   "repository": "https://github.com/web-infra-dev/midscene",
   "homepage": "https://midscenejs.com/",
   "types": "./dist/types/index.d.ts",

package/src/mcp/tool-generator.ts

@@ -153,10 +153,19 @@ function transformSchemaField(
 }
 
 /**
- * Extract and transform schema from action's paramSchema
+ * Extract and transform schema from action's paramSchema.
+ *
+ * CLI and MCP both expose parameters as named fields, so the only schema
+ * shapes we can surface are ZodObject (any number of fields) or undefined
+ * (the action takes no parameters). A primitive schema like `z.string()`
+ * silently degraded to leaking the ZodString instance's prototype methods
+ * as CLI flags — see https://github.com/web-infra-dev/midscene/issues/2313.
+ * Reject such schemas up front so the next author gets a loud error
+ * instead of a silent misconfiguration at runtime.
  */
 function extractActionSchema(
   paramSchema: z.ZodTypeAny | undefined,
+  actionName: string,
 ): Record<string, z.ZodTypeAny> {
   if (!paramSchema) {
     return {};
@@ -164,7 +173,12 @@ function extractActionSchema(
 
   const shape = getZodObjectShape(paramSchema);
   if (!shape) {
-    return paramSchema as unknown as Record<string, z.ZodTypeAny>;
+    const typeName =
+      (paramSchema as unknown as { _def?: { typeName?: string } })?._def
+        ?.typeName ?? 'unknown';
+    throw new Error(
+      `Action "${actionName}" declared a non-object paramSchema (${typeName}). CLI and MCP tool schemas must be a ZodObject (e.g. z.object({ uri: z.string() })) or undefined. Wrap primitive fields in an object schema.`,
+    );
   }
 
   return Object.fromEntries(
@@ -476,7 +490,7 @@ export function generateToolsFromActionSpace(
 ): ToolDefinition[] {
   return actionSpace.map((action) => {
     const schema = {
-      ...extractActionSchema(action.paramSchema as z.ZodTypeAny),
+      ...extractActionSchema(action.paramSchema as z.ZodTypeAny, action.name),
       ...initArgSchema,
     };