@midnight-ntwrk/wallet-sdk-hd 3.0.1 → 3.0.3

package/README.md

@@ -1,3 +1,10 @@
+> [!IMPORTANT]
+> **This package has moved.** The `@midnight-ntwrk` scope is published only
+> during the migration window and will stop receiving updates. Please migrate to
+> [`@midnightntwrk/wallet-sdk-hd`](https://www.npmjs.com/package/@midnightntwrk/wallet-sdk-hd).
+
+---
+
 # Midnight SDK HD Wallet
 
 This package provides support for Hierarchical Deterministic (HD) Wallet.

package/dist/HDWallet.d.ts

@@ -40,7 +40,8 @@ export declare class HDWallet {
     static fromSeed(seed: Uint8Array): HDWalletResult;
     selectAccount(account: number): AccountKey;
     /**
-     * Once all keys are derived - clear internals from private data, so that they do not reside in memory longer than needed.
+     * Once all keys are derived - clear internals from private data, so that they do not reside in memory longer than
+     * needed.
      */
     clear(): void;
 }

package/dist/HDWallet.js

@@ -10,7 +10,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import { HDKey } from '@scure/bip32';
+import { HARDENED_OFFSET, HDKey } from '@scure/bip32';
 export const Roles = {
     NightExternal: 0,
     NightInternal: 1,
@@ -20,6 +20,9 @@ export const Roles = {
 };
 const PURPOSE = 44;
 const COIN_TYPE = 2400;
+// BIP32 path components (account, role, index) are integers in [0, 2^31);
+// @scure/bip32 inlines this check inside derive() and throws, so guard here
+const isValidChildIndex = (value) => Number.isSafeInteger(value) && value >= 0 && value < HARDENED_OFFSET;
 const CompositeDerivationResult = {
     fromResults: (results) => {
         const { succeededKeys, failedRoles } = results.reduce((acc, result) => {
@@ -58,7 +61,8 @@ export class HDWallet {
         return new AccountKey(this.rootKey, account);
     }
     /**
-     * Once all keys are derived - clear internals from private data, so that they do not reside in memory longer than needed.
+     * Once all keys are derived - clear internals from private data, so that they do not reside in memory longer than
+     * needed.
      */
     clear() {
         this.rootKey.wipePrivateData();
@@ -90,6 +94,9 @@ export class RoleKey {
     }
     // Finally, derive the key at the given index.
     deriveKeyAt(index) {
+        if (![this.account, this.role, index].every(isValidChildIndex)) {
+            return { type: 'keyOutOfBounds' };
+        }
         const path = `m/${PURPOSE}'/${COIN_TYPE}'/${this.account}'/${this.role}/${index}`;
         const derivedKey = this.rootKey.derive(path);
         return derivedKey.privateKey ? { type: 'keyDerived', key: derivedKey.privateKey } : { type: 'keyOutOfBounds' };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@midnight-ntwrk/wallet-sdk-hd",
-  "version": "3.0.1",
+  "version": "3.0.3",
   "type": "module",
   "main": "./dist/index.js",
   "module": "./dist/index.js",
@@ -8,14 +8,16 @@
   "author": "Midnight Foundation",
   "license": "Apache-2.0",
   "publishConfig": {
-    "registry": "https://npm.pkg.github.com/"
+    "registry": "https://registry.npmjs.org/",
+    "access": "public"
   },
   "files": [
     "dist/"
   ],
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/midnight-ntwrk/artifacts.git"
+    "url": "git+https://github.com/midnightntwrk/midnight-wallet.git",
+    "directory": "packages/hd"
   },
   "exports": {
     ".": {
@@ -28,7 +30,7 @@
     "@scure/bip39": "^2.0.1"
   },
   "devDependencies": {
-    "@ethereumjs/wallet": "^10.0.0"
+    "@ethereumjs/wallet": "10.0.0"
   },
   "scripts": {
     "typecheck": "tsc -b ./tsconfig.json --noEmit --force",