@middy/secrets-manager 2.5.6 → 3.0.0-alpha.3

package/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2017-2021 Luciano Mammino, will Farrell and the [Middy team](https://github.com/middyjs/middy/graphs/contributors)
+Copyright (c) 2017-2022 Luciano Mammino, will Farrell and the [Middy team](https://github.com/middyjs/middy/graphs/contributors)
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/README.md

@@ -53,13 +53,10 @@ npm install --save @middy/secrets-manager
 - `disablePrefetch` (boolean) (default `false`): On cold start requests will trigger early if they can. Setting `awsClientAssumeRole` disables prefetch.
 - `cacheKey` (string) (default `secrets-manager`): Cache key for the fetched data responses. Must be unique across all middleware.
 - `cacheExpiry` (number) (default `-1`): How long fetch data responses should be cached for. `-1`: cache forever, `0`: never cache, `n`: cache for n ms.
-- `setToEnv` (boolean) (default `false`): Store secrets to `process.env`. **Storing secrets in `process.env` is considered security bad practice**
 - `setToContext` (boolean) (default `false`): Store secrets to `request.context`.
 
 NOTES:
 - Lambda is required to have IAM permission for `secretsmanager:GetSecretValue`
-- `setToEnv` and `setToContext` are included for legacy support and should be avoided for performance and security reasons. See main documentation for best practices.
-- `setToEnv` can only assign secrets of type string
 
 ## Sample usage
 
@@ -99,7 +96,7 @@ Everyone is very welcome to contribute to this repository. Feel free to [raise i
 
 ## License
 
-Licensed under [MIT License](LICENSE). Copyright (c) 2017-2021 Luciano Mammino, will Farrell, and the [Middy team](https://github.com/middyjs/middy/graphs/contributors).
+Licensed under [MIT License](LICENSE). Copyright (c) 2017-2022 Luciano Mammino, will Farrell, and the [Middy team](https://github.com/middyjs/middy/graphs/contributors).
 
 <a href="https://app.fossa.io/projects/git%2Bgithub.com%2Fmiddyjs%2Fmiddy?ref=badge_large">
   <img src="https://app.fossa.io/api/projects/git%2Bgithub.com%2Fmiddyjs%2Fmiddy.svg?type=large" alt="FOSSA Status"  style="max-width:100%;">

package/index.js

@@ -1,15 +1,15 @@
-const {
+import {
   canPrefetch,
   createPrefetchClient,
   createClient,
-  processCache,
   getCache,
+  getInternal,
+  processCache,
   modifyCache,
-  jsonSafeParse,
-  getInternal
-} = require('@middy/util')
-const SecretsManager = require('aws-sdk/clients/secretsmanager') // v2
-// const { SecretsManager } = require('@aws-sdk/client-secrets-manager')  // v3
+  jsonSafeParse
+} from '@middy/util'
+import SecretsManager from 'aws-sdk/clients/secretsmanager.js' // v2
+// import { SecretsManager } from '@aws-sdk/client-secrets-manager'  // v3
 
 const defaults = {
   AwsClient: SecretsManager,
@@ -20,7 +20,6 @@ const defaults = {
   disablePrefetch: false,
   cacheKey: 'secrets-manager',
   cacheExpiry: -1,
-  setToEnv: false, // can return object when requesting db credentials, cannot set to process.env
   setToContext: false
 }
 
@@ -41,7 +40,7 @@ const secretsManagerMiddleware = (opts = {}) => {
         .promise() // Required for aws-sdk v2
         .then((resp) => jsonSafeParse(resp.SecretString))
         .catch((e) => {
-          const value = getCache(options.cacheKey)?.value ?? {}
+          const value = getCache(options.cacheKey).value ?? {}
           value[internalKey] = undefined
           modifyCache(options.cacheKey, value)
           throw e
@@ -65,10 +64,9 @@ const secretsManagerMiddleware = (opts = {}) => {
 
     Object.assign(request.internal, value)
 
-    if (options.setToContext || options.setToEnv) {
+    if (options.setToContext) {
       const data = await getInternal(Object.keys(options.fetchData), request)
-      if (options.setToEnv) Object.assign(process.env, data)
-      if (options.setToContext) Object.assign(request.context, data)
+      Object.assign(request.context, data)
     }
 
     prefetch = null
@@ -78,4 +76,4 @@ const secretsManagerMiddleware = (opts = {}) => {
     before: secretsManagerMiddlewareBefore
   }
 }
-module.exports = secretsManagerMiddleware
+export default secretsManagerMiddleware

package/package.json

@@ -1,23 +1,25 @@
 {
   "name": "@middy/secrets-manager",
-  "version": "2.5.6",
+  "version": "3.0.0-alpha.3",
   "description": "Secrets Manager middleware for the middy framework",
-  "type": "commonjs",
+  "type": "module",
   "engines": {
-    "node": ">=12"
+    "node": ">=14"
   },
   "engineStrict": true,
   "publishConfig": {
     "access": "public"
   },
-  "main": "index.js",
+  "exports": "./index.js",
   "types": "index.d.ts",
   "files": [
+    "index.js",
     "index.d.ts"
   ],
   "scripts": {
     "test": "npm run test:unit",
-    "test:unit": "ava"
+    "test:unit": "ava",
+    "test:benchmark": "node __benchmarks__/index.js"
   },
   "license": "MIT",
   "keywords": [
@@ -44,12 +46,12 @@
   },
   "homepage": "https://github.com/middyjs/middy#readme",
   "dependencies": {
-    "@middy/util": "^2.5.6"
+    "@middy/util": "^3.0.0-alpha.3"
   },
   "devDependencies": {
-    "@middy/core": "^2.5.6",
+    "@middy/core": "^3.0.0-alpha.3",
     "aws-sdk": "^2.939.0",
     "aws-xray-sdk": "^3.3.3"
   },
-  "gitHead": "0c789f55b4adf691f977b0d9904d1a805bb3bb2b"
+  "gitHead": "1441158711580313765e6d156046ef0fade0d156"
 }