@middy/secrets-manager 2.5.2 → 2.5.6

package/index.d.ts

@@ -1,19 +1,8 @@
 import { SecretsManager } from 'aws-sdk'
-import { captureAWSClient } from 'aws-xray-sdk'
 import middy from '@middy/core'
+import { Options as MiddyOptions } from '@middy/util'
 
-interface Options<SM = SecretsManager> {
-  AwsClient?: new() => SM
-  awsClientOptions?: Partial<SecretsManager.Types.ClientConfiguration>
-  awsClientAssumeRole?: string
-  awsClientCapture?: typeof captureAWSClient
-  fetchData?: { [key: string]: string }
-  disablePrefetch?: boolean
-  cacheKey?: string
-  cacheExpiry?: number
-  setToEnv?: boolean
-  setToContext?: boolean
-}
+interface Options<SM = SecretsManager> extends MiddyOptions<SM, SecretsManager.Types.ClientConfiguration> {}
 
 declare function secretsManager (options?: Options): middy.MiddlewareObj
 

package/index.js

@@ -1,5 +1,3 @@
-"use strict";
-
 const {
   canPrefetch,
   createPrefetchClient,
@@ -9,87 +7,75 @@ const {
   modifyCache,
   jsonSafeParse,
   getInternal
-} = require('@middy/util');
-
-const SecretsManager = require('aws-sdk/clients/secretsmanager'); // v2
+} = require('@middy/util')
+const SecretsManager = require('aws-sdk/clients/secretsmanager') // v2
 // const { SecretsManager } = require('@aws-sdk/client-secrets-manager')  // v3
 
-
 const defaults = {
   AwsClient: SecretsManager,
   awsClientOptions: {},
   awsClientAssumeRole: undefined,
   awsClientCapture: undefined,
-  fetchData: {},
-  // If more than 2, consider writing own using ListSecrets
+  fetchData: {}, // If more than 2, consider writing own using ListSecrets
   disablePrefetch: false,
   cacheKey: 'secrets-manager',
   cacheExpiry: -1,
-  setToEnv: false,
-  // can return object when requesting db credentials, cannot set to process.env
+  setToEnv: false, // can return object when requesting db credentials, cannot set to process.env
   setToContext: false
-};
+}
 
 const secretsManagerMiddleware = (opts = {}) => {
-  const options = { ...defaults,
-    ...opts
-  };
+  const options = { ...defaults, ...opts }
 
   const fetch = (request, cachedValues = {}) => {
-    const values = {}; // Multiple secrets can be requested in a single requests,
+    const values = {}
+
+    // Multiple secrets can be requested in a single requests,
     // however this is likely uncommon IRL, increases complexity to handle,
     // and will require recursive promise resolution impacting performance.
     // See https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/SecretsManager.html#listSecrets-property
-
     for (const internalKey of Object.keys(options.fetchData)) {
-      if (cachedValues[internalKey]) continue;
-      values[internalKey] = client.getSecretValue({
-        SecretId: options.fetchData[internalKey]
-      }).promise() // Required for aws-sdk v2
-      .then(resp => jsonSafeParse(resp.SecretString)).catch(e => {
-        var _getCache$value, _getCache;
-
-        const value = (_getCache$value = (_getCache = getCache(options.cacheKey)) === null || _getCache === void 0 ? void 0 : _getCache.value) !== null && _getCache$value !== void 0 ? _getCache$value : {};
-        value[internalKey] = undefined;
-        modifyCache(options.cacheKey, value);
-        throw e;
-      });
+      if (cachedValues[internalKey]) continue
+      values[internalKey] = client
+        .getSecretValue({ SecretId: options.fetchData[internalKey] })
+        .promise() // Required for aws-sdk v2
+        .then((resp) => jsonSafeParse(resp.SecretString))
+        .catch((e) => {
+          const value = getCache(options.cacheKey)?.value ?? {}
+          value[internalKey] = undefined
+          modifyCache(options.cacheKey, value)
+          throw e
+        })
     }
+    return values
+  }
 
-    return values;
-  };
-
-  let prefetch, client;
-
+  let prefetch, client
   if (canPrefetch(options)) {
-    client = createPrefetchClient(options);
-    prefetch = processCache(options, fetch);
+    client = createPrefetchClient(options)
+    prefetch = processCache(options, fetch)
   }
 
-  const secretsManagerMiddlewareBefore = async request => {
-    var _prefetch;
-
+  const secretsManagerMiddlewareBefore = async (request) => {
     if (!client) {
-      client = await createClient(options, request);
+      client = await createClient(options, request)
     }
 
-    const {
-      value
-    } = (_prefetch = prefetch) !== null && _prefetch !== void 0 ? _prefetch : processCache(options, fetch, request);
-    Object.assign(request.internal, value);
+    const { value } = prefetch ?? processCache(options, fetch, request)
+
+    Object.assign(request.internal, value)
 
     if (options.setToContext || options.setToEnv) {
-      const data = await getInternal(Object.keys(options.fetchData), request);
-      if (options.setToEnv) Object.assign(process.env, data);
-      if (options.setToContext) Object.assign(request.context, data);
+      const data = await getInternal(Object.keys(options.fetchData), request)
+      if (options.setToEnv) Object.assign(process.env, data)
+      if (options.setToContext) Object.assign(request.context, data)
     }
 
-    prefetch = null;
-  };
+    prefetch = null
+  }
 
   return {
     before: secretsManagerMiddlewareBefore
-  };
-};
-
-module.exports = secretsManagerMiddleware;
+  }
+}
+module.exports = secretsManagerMiddleware

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@middy/secrets-manager",
-  "version": "2.5.2",
+  "version": "2.5.6",
   "description": "Secrets Manager middleware for the middy framework",
   "type": "commonjs",
   "engines": {
@@ -44,12 +44,12 @@
   },
   "homepage": "https://github.com/middyjs/middy#readme",
   "dependencies": {
-    "@middy/util": "^2.5.2"
+    "@middy/util": "^2.5.6"
   },
   "devDependencies": {
-    "@middy/core": "^2.5.2",
+    "@middy/core": "^2.5.6",
     "aws-sdk": "^2.939.0",
     "aws-xray-sdk": "^3.3.3"
   },
-  "gitHead": "a2bb757a7a13638ae64277f8eecfcf11c1af17d4"
+  "gitHead": "0c789f55b4adf691f977b0d9904d1a805bb3bb2b"
 }