@microsoft/vscode-azext-azureauth 1.3.2 → 2.0.0

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change Log
 
+## 1.4.0 - 2023-11-03
+* [#1619](https://github.com/microsoft/vscode-azuretools/pull/1619) Make `getSession` synchronous to fix an issue that broke app service deployments
+
 ## 1.3.0 - 2023-10-23
 
 * [#1610](https://github.com/microsoft/vscode-azuretools/pull/1610) Add `signInToTenant` command which facilitates signing in to a specific tenant.

package/out/src/AzureSubscriptionProvider.d.ts

@@ -1,6 +1,6 @@
 import type * as vscode from 'vscode';
 import type { AzureSubscription } from './AzureSubscription';
-import { TenantIdDescription } from '@azure/arm-subscriptions';
+import type { TenantIdDescription } from '@azure/arm-resources-subscriptions';
 /**
  * An interface for obtaining Azure subscription information
  */

package/out/src/VSCodeAzureSubscriptionProvider.d.ts

@@ -1,4 +1,4 @@
-import type { TenantIdDescription } from '@azure/arm-subscriptions';
+import type { TenantIdDescription } from '@azure/arm-resources-subscriptions';
 import * as vscode from 'vscode';
 import type { AzureSubscription, SubscriptionId, TenantId } from './AzureSubscription';
 import type { AzureSubscriptionProvider } from './AzureSubscriptionProvider';
@@ -99,5 +99,4 @@ export declare class VSCodeAzureSubscriptionProvider extends vscode.Disposable i
      * @returns A client, the credential used by the client, and the authentication function
      */
     private getSubscriptionClient;
-    private getToken;
 }

package/out/src/VSCodeAzureSubscriptionProvider.js

@@ -21,7 +21,6 @@ var __asyncValues = (this && this.__asyncValues) || function (o) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.VSCodeAzureSubscriptionProvider = void 0;
-const node_fetch_1 = require("node-fetch"); // have to explicitly use node-fetch v2.6.7 otherwise when @azure/client-core makes a streaming request, it fails on windows
 const vscode = require("vscode");
 const NotSignedInError_1 = require("./NotSignedInError");
 const getSessionFromVSCode_1 = require("./getSessionFromVSCode");
@@ -75,13 +74,31 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
      * @returns A list of tenants.
      */
     getTenants() {
+        var _a, e_1, _b, _c;
         return __awaiter(this, void 0, void 0, function* () {
-            const listTenantsResponse = yield (0, node_fetch_1.default)('https://management.azure.com/tenants?api-version=2022-12-01', {
-                headers: {
-                    Authorization: `Bearer ${yield this.getToken()}`,
+            const { client } = yield this.getSubscriptionClient();
+            const results = [];
+            try {
+                for (var _d = true, _e = __asyncValues(client.tenants.list()), _f; _f = yield _e.next(), _a = _f.done, !_a;) {
+                    _c = _f.value;
+                    _d = false;
+                    try {
+                        const tenant = _c;
+                        results.push(tenant);
+                    }
+                    finally {
+                        _d = true;
+                    }
                 }
-            });
-            return (yield listTenantsResponse.json()).value;
+            }
+            catch (e_1_1) { e_1 = { error: e_1_1 }; }
+            finally {
+                try {
+                    if (!_d && !_a && (_b = _e.return)) yield _b.call(_e);
+                }
+                finally { if (e_1) throw e_1.error; }
+            }
+            return results;
         });
     }
     /**
@@ -100,8 +117,6 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
         return __awaiter(this, void 0, void 0, function* () {
             const tenantIds = yield this.getTenantFilters();
             const shouldFilterTenants = filter && !!tenantIds.length; // If the list is empty it is treated as "no filter"
-            const subscriptionIds = yield this.getSubscriptionFilters();
-            const shouldFilterSubscriptions = filter && !!subscriptionIds.length; // If the list is empty it is treated as "no filter"
             const results = [];
             try {
                 this.suppressSignInEvents = true;
@@ -118,19 +133,18 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
                         continue;
                     }
                     // For each tenant, get the list of subscriptions
-                    for (const subscription of yield this.getSubscriptionsForTenant(tenantId)) {
-                        // If filtering is enabled, and the current subscription is not in that list, then skip it
-                        if (shouldFilterSubscriptions && !subscriptionIds.includes(subscription.subscriptionId)) {
-                            continue;
-                        }
-                        results.push(subscription);
-                    }
+                    results.push(...yield this.getSubscriptionsForTenant(tenantId));
                 }
             }
             finally {
                 this.suppressSignInEvents = false;
             }
-            return results.sort((a, b) => a.name.localeCompare(b.name));
+            const sortSubscriptions = (subscriptions) => subscriptions.sort((a, b) => a.name.localeCompare(b.name));
+            const subscriptionIds = yield this.getSubscriptionFilters();
+            if (filter && !!subscriptionIds.length) { // If the list is empty it is treated as "no filter"
+                return sortSubscriptions(results.filter(sub => subscriptionIds.includes(sub.subscriptionId)));
+            }
+            return sortSubscriptions(results);
         });
     }
     /**
@@ -207,7 +221,7 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
      * @returns The list of subscriptions for the tenant.
      */
     getSubscriptionsForTenant(tenantId) {
-        var _a, e_1, _b, _c;
+        var _a, e_2, _b, _c;
         return __awaiter(this, void 0, void 0, function* () {
             const { client, credential, authentication } = yield this.getSubscriptionClient(tenantId);
             const environment = (0, configuredAzureEnv_1.getConfiguredAzureEnv)();
@@ -235,12 +249,12 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
                     }
                 }
             }
-            catch (e_1_1) { e_1 = { error: e_1_1 }; }
+            catch (e_2_1) { e_2 = { error: e_2_1 }; }
             finally {
                 try {
                     if (!_d && !_a && (_b = _e.return)) yield _b.call(_e);
                 }
-                finally { if (e_1) throw e_1.error; }
+                finally { if (e_2) throw e_2.error; }
             }
             return subscriptions;
         });
@@ -252,42 +266,32 @@ class VSCodeAzureSubscriptionProvider extends vscode.Disposable {
      *
      * @returns A client, the credential used by the client, and the authentication function
      */
-    getSubscriptionClient(tenantId) {
+    getSubscriptionClient(tenantId, scopes) {
         return __awaiter(this, void 0, void 0, function* () {
-            const armSubs = yield Promise.resolve().then(() => require('@azure/arm-subscriptions'));
-            const getSession = (scopes) => __awaiter(this, void 0, void 0, function* () {
-                const session = yield (0, getSessionFromVSCode_1.getSessionFromVSCode)(scopes, tenantId, { createIfNone: false, silent: true });
-                if (!session) {
-                    throw new NotSignedInError_1.NotSignedInError();
-                }
-                return session;
-            });
+            const armSubs = yield Promise.resolve().then(() => require('@azure/arm-resources-subscriptions'));
+            const session = yield (0, getSessionFromVSCode_1.getSessionFromVSCode)(scopes, tenantId, { createIfNone: false, silent: true });
+            if (!session) {
+                throw new NotSignedInError_1.NotSignedInError();
+            }
             const credential = {
-                getToken: (scopes) => __awaiter(this, void 0, void 0, function* () {
+                getToken: () => __awaiter(this, void 0, void 0, function* () {
                     return {
-                        token: (yield getSession(scopes)).accessToken,
+                        token: session.accessToken,
                         expiresOnTimestamp: 0
                     };
                 })
             };
+            const configuredAzureEnv = (0, configuredAzureEnv_1.getConfiguredAzureEnv)();
+            const endpoint = configuredAzureEnv.resourceManagerEndpointUrl;
             return {
-                client: new armSubs.SubscriptionClient(credential),
+                client: new armSubs.SubscriptionClient(credential, { endpoint }),
                 credential: credential,
                 authentication: {
-                    getSession,
+                    getSession: () => session
                 }
             };
         });
     }
-    getToken(tenantId) {
-        return __awaiter(this, void 0, void 0, function* () {
-            const session = yield (0, getSessionFromVSCode_1.getSessionFromVSCode)([], tenantId, { createIfNone: false, silent: true });
-            if (!session) {
-                throw new NotSignedInError_1.NotSignedInError();
-            }
-            return session.accessToken;
-        });
-    }
 }
 exports.VSCodeAzureSubscriptionProvider = VSCodeAzureSubscriptionProvider;
 //# sourceMappingURL=VSCodeAzureSubscriptionProvider.js.map

package/out/src/getSessionFromVSCode.js

@@ -16,9 +16,12 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getSessionFromVSCode = void 0;
 const configuredAzureEnv_1 = require("./utils/configuredAzureEnv");
 const vscode = require("vscode");
+function ensureEndingSlash(value) {
+    return value.endsWith('/') ? value : `${value}/`;
+}
 function getResourceScopes(scopes) {
     if (scopes === undefined || scopes === "" || scopes.length === 0) {
-        scopes = `${(0, configuredAzureEnv_1.getConfiguredAzureEnv)().resourceManagerEndpointUrl}.default`;
+        scopes = ensureEndingSlash((0, configuredAzureEnv_1.getConfiguredAzureEnv)().resourceManagerEndpointUrl);
     }
     const arrScopes = (Array.isArray(scopes) ? scopes : [scopes])
         .map((scope) => {

package/out/src/utils/configuredAzureEnv.js

@@ -35,10 +35,10 @@ function getConfiguredAzureEnv() {
     const authProviderConfig = vscode.workspace.getConfiguration(CustomCloudConfigurationSection);
     const environmentSettingValue = authProviderConfig.get(CloudEnvironmentSettingName);
     if (environmentSettingValue === CloudEnvironmentSettingValue.ChinaCloud) {
-        return Object.assign(Object.assign({}, azureEnv.Environment.get(azureEnv.Environment.ChinaCloud.name)), { isCustomCloud: false });
+        return Object.assign(Object.assign({}, azureEnv.Environment.ChinaCloud), { isCustomCloud: false });
     }
     else if (environmentSettingValue === CloudEnvironmentSettingValue.USGovernment) {
-        return Object.assign(Object.assign({}, azureEnv.Environment.get(azureEnv.Environment.USGovernment.name)), { isCustomCloud: false });
+        return Object.assign(Object.assign({}, azureEnv.Environment.USGovernment), { isCustomCloud: false });
     }
     else if (environmentSettingValue === CloudEnvironmentSettingValue.Custom) {
         const customCloud = authProviderConfig.get(CustomEnvironmentSettingName);

package/out/src/utils/getUnauthenticatedTenants.d.ts

@@ -1,4 +1,4 @@
-import type { TenantIdDescription } from "@azure/arm-subscriptions";
+import type { TenantIdDescription } from "@azure/arm-resources-subscriptions";
 import type { AzureSubscriptionProvider } from "../AzureSubscriptionProvider";
 /**
  * @returns list of tenants that VS Code doesn't have sessions for

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@microsoft/vscode-azext-azureauth",
     "author": "Microsoft Corporation",
-    "version": "1.3.2",
+    "version": "2.0.0",
     "description": "Azure authentication helpers for Visual Studio Code",
     "tags": [
         "azure",
@@ -52,8 +52,7 @@
         "typescript": "^4.9.4"
     },
     "dependencies": {
-        "@azure/arm-subscriptions": "^5.1.0",
-        "@azure/ms-rest-azure-env": "^2.0.0",
-        "node-fetch": "2.6.7"
+        "@azure/arm-resources-subscriptions": "^2.1.0",
+        "@azure/ms-rest-azure-env": "^2.0.0"
     }
 }