@microsoft/sp-tslint-rules 1.22.1 → 1.23.0-beta.0

package/lib-commonjs/importRequiresChunkNameRule.js

@@ -11,19 +11,6 @@ Object.defineProperty(exports, "Rule", {
 const _tsutils = require("tsutils");
 const _typescript = /*#__PURE__*/ _interop_require_wildcard(require("typescript"));
 const _tslint = /*#__PURE__*/ _interop_require_wildcard(require("tslint"));
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -76,8 +63,16 @@ function _interop_require_wildcard(obj, nodeInterop) {
  *  - propertyName :"value"
  *  - propertyName : "value"
  */ const COMMENT_PART_REGEX = /^([A-Za-z]+)\s*:\s*('[^']+'|"[^"]+")$/;
-var _Lint_Rules_AbstractRule;
-class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
+class Rule extends _tslint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'import-requires-chunk-name',
+        description: 'Requires that calls to import(...) for code splitting include a webpack chunk name',
+        rationale: 'Unnamed chunks are difficult to manage.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, (ctx)=>{
             const childCallback = (node)=>{
@@ -117,14 +112,5 @@ class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
         });
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'import-requires-chunk-name',
-    description: 'Requires that calls to import(...) for code splitting include a webpack chunk name',
-    rationale: 'Unnamed chunks are difficult to manage.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'functionality',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./importRequiresChunkNameRule.js.map

package/lib-commonjs/noAsyncAwaitRule.js

@@ -11,19 +11,6 @@ Object.defineProperty(exports, "Rule", {
 const _tsutils = require("tsutils");
 const _typescript = /*#__PURE__*/ _interop_require_wildcard(require("typescript"));
 const _tslint = /*#__PURE__*/ _interop_require_wildcard(require("tslint"));
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -65,21 +52,20 @@ function _interop_require_wildcard(obj, nodeInterop) {
     }
     return newObj;
 }
-var _Lint_Rules_AbstractRule;
-class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
+class Rule extends _tslint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'no-async-await',
+        description: 'Warn when using async/await functions.',
+        rationale: 'async/await has overhead when emitting ES5 JavaScript',
+        optionsDescription: 'No options available.',
+        options: undefined,
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(source) {
         return this.applyWithFunction(source, noAsyncAwait);
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'no-async-await',
-    description: 'Warn when using async/await functions.',
-    rationale: 'async/await has overhead when emitting ES5 JavaScript',
-    optionsDescription: 'No options available.',
-    options: undefined,
-    type: 'functionality',
-    typescriptOnly: false
-});
 function noAsyncAwait(context, node) {
     if (!node) {
         _typescript.forEachChild(context.sourceFile, (n)=>noAsyncAwait(context, n));

package/lib-commonjs/noRequireEnsureRule.js

@@ -11,19 +11,6 @@ Object.defineProperty(exports, "Rule", {
 const _tsutils = require("tsutils");
 const _typescript = /*#__PURE__*/ _interop_require_wildcard(require("typescript"));
 const _tslint = /*#__PURE__*/ _interop_require_wildcard(require("tslint"));
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -65,8 +52,16 @@ function _interop_require_wildcard(obj, nodeInterop) {
     }
     return newObj;
 }
-var _Lint_Rules_AbstractRule;
-class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
+class Rule extends _tslint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'no-require-ensure',
+        description: 'Warns about the use of the require.ensure function.',
+        rationale: '`require.ensure` is outdated. Use `import(...)` instead.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, (ctx)=>{
             const childCallback = (node)=>{
@@ -82,14 +77,5 @@ class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
         });
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'no-require-ensure',
-    description: 'Warns about the use of the require.ensure function.',
-    rationale: '`require.ensure` is outdated. Use `import(...)` instead.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'functionality',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./noRequireEnsureRule.js.map

package/lib-commonjs/pairReactDomRenderUnmountRule.js

@@ -11,19 +11,6 @@ Object.defineProperty(exports, "Rule", {
 const _tsutils = /*#__PURE__*/ _interop_require_wildcard(require("tsutils"));
 const _typescript = /*#__PURE__*/ _interop_require_wildcard(require("typescript"));
 const _tslint = /*#__PURE__*/ _interop_require_wildcard(require("tslint"));
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -65,8 +52,17 @@ function _interop_require_wildcard(obj, nodeInterop) {
     }
     return newObj;
 }
-var _Lint_Rules_AbstractRule;
-class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
+class Rule extends _tslint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'pair-react-dom-render-unmount',
+        description: 'Pair ReactDOM render and unmount calls in one file.' + ' If a ReactDOM render tree is not unmounted when disposed, it will cause a memory leak.',
+        rationale: 'Pair the render and unmount calls to avoid memory leak.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'maintainability',
+        typescriptOnly: false
+    };
+    _reactDOMImportNamespaceName;
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, this._walk.bind(this));
     }
@@ -118,19 +114,6 @@ class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
         _tsutils.isIdentifier(node.expression.expression) && node.expression.expression.text === this._reactDOMImportNamespaceName && // method
         _tsutils.isIdentifier(node.expression.name) && node.expression.name.text === methodName);
     }
-    constructor(...args){
-        super(...args);
-        _define_property(this, "_reactDOMImportNamespaceName", void 0);
-    }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'pair-react-dom-render-unmount',
-    description: 'Pair ReactDOM render and unmount calls in one file.' + ' If a ReactDOM render tree is not unmounted when disposed, it will cause a memory leak.',
-    rationale: 'Pair the render and unmount calls to avoid memory leak.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'maintainability',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./pairReactDomRenderUnmountRule.js.map

package/lib-commonjs/validKillSwitchGuidRule.js

@@ -11,19 +11,6 @@ Object.defineProperty(exports, "Rule", {
 const _tslint = /*#__PURE__*/ _interop_require_wildcard(require("tslint"));
 const _tsutils = require("tsutils");
 const _typescript = /*#__PURE__*/ _interop_require_wildcard(require("typescript"));
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -65,21 +52,20 @@ function _interop_require_wildcard(obj, nodeInterop) {
     }
     return newObj;
 }
-var _Lint_Rules_AbstractRule;
-class Rule extends (_Lint_Rules_AbstractRule = _tslint.Rules.AbstractRule) {
+class Rule extends _tslint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'valid-kill-switch-guid',
+        description: 'Warn if _SPKillSwitch.isActivated is being called with an incorrect argument',
+        rationale: 'Compile time type safety',
+        optionsDescription: 'No options available.',
+        options: undefined,
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(source) {
         return this.applyWithFunction(source, validKillSwitchGuid);
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'valid-kill-switch-guid',
-    description: 'Warn if _SPKillSwitch.isActivated is being called with an incorrect argument',
-    rationale: 'Compile time type safety',
-    optionsDescription: 'No options available.',
-    options: undefined,
-    type: 'functionality',
-    typescriptOnly: false
-});
 function validKillSwitchGuid(context, node) {
     if (!node) {
         _typescript.forEachChild(context.sourceFile, (n)=>validKillSwitchGuid(context, n));

package/lib-esm/importRequiresChunkNameRule.js

@@ -1,16 +1,3 @@
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 import { isCallExpression, forEachComment } from 'tsutils';
 import * as ts from 'typescript';
 import * as Lint from 'tslint';
@@ -25,12 +12,20 @@ import * as Lint from 'tslint';
  *  - propertyName :"value"
  *  - propertyName : "value"
  */ const COMMENT_PART_REGEX = /^([A-Za-z]+)\s*:\s*('[^']+'|"[^"]+")$/;
-var _Lint_Rules_AbstractRule;
 /**
  * This rule requires that import(...) statements include a /* webpackChunkName: '...' *\/ comment.
  *
  * See documentation here: https://webpack.js.org/api/module-methods/#import-
- */ export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
+ */ export class Rule extends Lint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'import-requires-chunk-name',
+        description: 'Requires that calls to import(...) for code splitting include a webpack chunk name',
+        rationale: 'Unnamed chunks are difficult to manage.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, (ctx)=>{
             const childCallback = (node)=>{
@@ -70,14 +65,5 @@ var _Lint_Rules_AbstractRule;
         });
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'import-requires-chunk-name',
-    description: 'Requires that calls to import(...) for code splitting include a webpack chunk name',
-    rationale: 'Unnamed chunks are difficult to manage.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'functionality',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./importRequiresChunkNameRule.js.map

package/lib-esm/noAsyncAwaitRule.js

@@ -1,38 +1,24 @@
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 import { isArrowFunction, isFunctionDeclaration, isFunctionExpression, isMethodDeclaration } from 'tsutils';
 import * as ts from 'typescript';
 import * as Lint from 'tslint';
-var _Lint_Rules_AbstractRule;
 /**
  * Check for any functions with the `async` modifier. If a function does not have the `async`
  * modifier then we defer to TSC to fail on `await` keywords since `await` has to be used
  * within an `async` context.
- */ export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
+ */ export class Rule extends Lint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'no-async-await',
+        description: 'Warn when using async/await functions.',
+        rationale: 'async/await has overhead when emitting ES5 JavaScript',
+        optionsDescription: 'No options available.',
+        options: undefined,
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(source) {
         return this.applyWithFunction(source, noAsyncAwait);
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'no-async-await',
-    description: 'Warn when using async/await functions.',
-    rationale: 'async/await has overhead when emitting ES5 JavaScript',
-    optionsDescription: 'No options available.',
-    options: undefined,
-    type: 'functionality',
-    typescriptOnly: false
-});
 function noAsyncAwait(context, node) {
     if (!node) {
         ts.forEachChild(context.sourceFile, (n)=>noAsyncAwait(context, n));

package/lib-esm/noRequireEnsureRule.js

@@ -1,21 +1,16 @@
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 import { isCallExpression, isIdentifier, isPropertyAccessExpression } from 'tsutils';
 import * as ts from 'typescript';
 import * as Lint from 'tslint';
-var _Lint_Rules_AbstractRule;
-export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
+export class Rule extends Lint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'no-require-ensure',
+        description: 'Warns about the use of the require.ensure function.',
+        rationale: '`require.ensure` is outdated. Use `import(...)` instead.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, (ctx)=>{
             const childCallback = (node)=>{
@@ -31,14 +26,5 @@ export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
         });
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'no-require-ensure',
-    description: 'Warns about the use of the require.ensure function.',
-    rationale: '`require.ensure` is outdated. Use `import(...)` instead.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'functionality',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./noRequireEnsureRule.js.map

package/lib-esm/pairReactDomRenderUnmountRule.js

@@ -1,21 +1,17 @@
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 import * as tsUtils from 'tsutils';
 import * as ts from 'typescript';
 import * as Lint from 'tslint';
-var _Lint_Rules_AbstractRule;
-export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
+export class Rule extends Lint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'pair-react-dom-render-unmount',
+        description: 'Pair ReactDOM render and unmount calls in one file.' + ' If a ReactDOM render tree is not unmounted when disposed, it will cause a memory leak.',
+        rationale: 'Pair the render and unmount calls to avoid memory leak.',
+        optionsDescription: 'No options available.',
+        options: {},
+        type: 'maintainability',
+        typescriptOnly: false
+    };
+    _reactDOMImportNamespaceName;
     apply(sourceFile) {
         return this.applyWithFunction(sourceFile, this._walk.bind(this));
     }
@@ -67,19 +63,6 @@ export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
         tsUtils.isIdentifier(node.expression.expression) && node.expression.expression.text === this._reactDOMImportNamespaceName && // method
         tsUtils.isIdentifier(node.expression.name) && node.expression.name.text === methodName);
     }
-    constructor(...args){
-        super(...args);
-        _define_property(this, "_reactDOMImportNamespaceName", void 0);
-    }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'pair-react-dom-render-unmount',
-    description: 'Pair ReactDOM render and unmount calls in one file.' + ' If a ReactDOM render tree is not unmounted when disposed, it will cause a memory leak.',
-    rationale: 'Pair the render and unmount calls to avoid memory leak.',
-    optionsDescription: 'No options available.',
-    options: {},
-    type: 'maintainability',
-    typescriptOnly: false
-});
 
 //# sourceMappingURL=./pairReactDomRenderUnmountRule.js.map

package/lib-esm/validKillSwitchGuidRule.js

@@ -1,38 +1,24 @@
-function _define_property(obj, key, value) {
-    if (key in obj) {
-        Object.defineProperty(obj, key, {
-            value: value,
-            enumerable: true,
-            configurable: true,
-            writable: true
-        });
-    } else {
-        obj[key] = value;
-    }
-    return obj;
-}
 import * as Lint from 'tslint';
 import { isCallExpression, isIdentifier, isPropertyAccessExpression } from 'tsutils';
 import * as ts from 'typescript';
-var _Lint_Rules_AbstractRule;
 /**
  * Validate valid GUID strings are being passed as an argument to SPKillSwitch.isActivated calls.
  * JavaScript does not have a native GUID type. We removed expensive runtime parsing during production
  * builds when checking kill switches. In order to ensure type safety, we are validating at build time with tslint.
- */ export class Rule extends (_Lint_Rules_AbstractRule = Lint.Rules.AbstractRule) {
+ */ export class Rule extends Lint.Rules.AbstractRule {
+    static metadata = {
+        ruleName: 'valid-kill-switch-guid',
+        description: 'Warn if _SPKillSwitch.isActivated is being called with an incorrect argument',
+        rationale: 'Compile time type safety',
+        optionsDescription: 'No options available.',
+        options: undefined,
+        type: 'functionality',
+        typescriptOnly: false
+    };
     apply(source) {
         return this.applyWithFunction(source, validKillSwitchGuid);
     }
 }
-_define_property(Rule, "metadata", {
-    ruleName: 'valid-kill-switch-guid',
-    description: 'Warn if _SPKillSwitch.isActivated is being called with an incorrect argument',
-    rationale: 'Compile time type safety',
-    optionsDescription: 'No options available.',
-    options: undefined,
-    type: 'functionality',
-    typescriptOnly: false
-});
 function validKillSwitchGuid(context, node) {
     if (!node) {
         ts.forEachChild(context.sourceFile, (n)=>validKillSwitchGuid(context, n));

package/package.json

@@ -1,9 +1,12 @@
 {
   "name": "@microsoft/sp-tslint-rules",
-  "version": "1.22.1",
+  "version": "1.23.0-beta.0",
   "description": "SharePoint Framework tslint rules",
-  "license": "https://aka.ms/spfx/license",
   "homepage": "http://aka.ms/spfx",
+  "license": "https://aka.ms/spfx/license",
+  "engines": {
+    "node": ">=18.17.1 <19.0.0 || >=22.14.0 < 23.0.0"
+  },
   "main": "lib-commonjs/index.js",
   "module": "lib-esm/index.js",
   "typings": "lib-dts/index.d.ts",
@@ -27,17 +30,14 @@
       ]
     }
   },
-  "engines": {
-    "node": ">=18.17.1 <19.0.0 || >=22.14.0 < 23.0.0"
-  },
   "dependencies": {
     "tslint": "~6.1.3",
     "tsutils": "~2.11.2",
     "typescript": "5.3.3"
   },
   "devDependencies": {
-    "@rushstack/heft": "1.1.2",
-    "eslint": "8.57.1",
+    "@rushstack/heft": "1.2.7",
+    "eslint": "9.37.0",
     "@msinternal/internal-node-rig": "0.1.0"
   },
   "scripts": {