@microsoft/omnichannel-chat-components 1.1.17-main.f21df63 → 1.1.17-main.fba10aa

package/lib/cjs/components/chatbutton/ChatButton.blankAnnouncements.a11y.spec.js

@@ -0,0 +1,162 @@
+"use strict";
+
+require("@testing-library/jest-dom/extend-expect");
+var _react = require("@testing-library/react");
+var _BroadcastService = require("../../services/BroadcastService");
+var _ChatButton = _interopRequireDefault(require("./ChatButton"));
+var _LoadingPane = _interopRequireDefault(require("../loadingpane/LoadingPane"));
+var _react2 = _interopRequireDefault(require("react"));
+var _defaultChatButtonProps = require("./common/defaultProps/defaultChatButtonProps");
+var _defaultLoadingPaneProps = require("../loadingpane/common/defaultProps/defaultLoadingPaneProps");
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+/**
+ * Repro / catcher for internal tracking — screen reader announces hidden / irrelevant
+ * text such as "blank" while navigating the chat surface. NVDA / JAWS announce
+ * "blank" when they encounter:
+ *   - an element with an announceable role (button, link, textbox, listitem,
+ *     progressbar, etc.) that has an empty accessible name (no aria-label, no
+ *     aria-labelledby, no associated <label>, and no own text content), OR
+ *   - a live region (`aria-live="polite"` / `aria-live="assertive"`) that is
+ *     mounted with empty text content (each tick announces "blank").
+ *
+ * This catcher walks several rendered LCW surfaces and asserts neither pattern
+ * is present. Deterministic DOM contract — no SR needed.
+ *
+ * Surfaces covered today:
+ *   - ChatButton (default props) — regression guard; passes today.
+ *   - ChatButton with notification bubble forced visible at unreadCount=0 —
+ *     regression guard for the empty-live-region path; passes today.
+ *   - LoadingPane (default props) — regression guard; passes today.
+ *
+ * Scope note: the original bug surfaces inside WebChat-rendered chat session
+ * content (message bubbles, attachments, agent-supplied HTML), which is not
+ * reachable from chat-components unit tests. The Playwright catcher
+ * `automation_tests/e2e/areas/accessibility/blankAnnouncements.spec.ts` on
+ * `chore/a11y-tooling-foundation` walks the full a11y tree of a built
+ * `dist/out.js` and is the right vehicle for enumerating per-offender fixes.
+ * Promote additional surfaces here as they are wired into the catcher harness.
+ */
+
+beforeAll(() => {
+  (0, _BroadcastService.BroadcastServiceInitialize)("testChannel");
+});
+afterEach(() => {
+  (0, _react.cleanup)();
+});
+const ANNOUNCEABLE_ROLES = new Set(["button", "link", "textbox", "combobox", "listbox", "listitem", "menu", "menuitem", "checkbox", "radio", "switch", "tab", "treeitem", "option", "searchbox", "progressbar", "alert", "status"]);
+const ANNOUNCEABLE_TAGS = new Set(["button", "a", "input", "select", "textarea"]);
+const isInsideAriaHidden = el => {
+  let cursor = el;
+  while (cursor) {
+    if (cursor.getAttribute("aria-hidden") === "true") return true;
+    cursor = cursor.parentElement;
+  }
+  return false;
+};
+const accessibleNameOf = el => {
+  const ariaLabel = (el.getAttribute("aria-label") || "").trim();
+  if (ariaLabel) return ariaLabel;
+  const labelledBy = (el.getAttribute("aria-labelledby") || "").trim();
+  if (labelledBy) {
+    const referenced = labelledBy.split(/\s+/).map(id => {
+      var _document$getElementB;
+      return ((_document$getElementB = document.getElementById(id)) === null || _document$getElementB === void 0 ? void 0 : _document$getElementB.textContent) || "";
+    }).join(" ").trim();
+    if (referenced) return referenced;
+  }
+  if (el.tagName.toLowerCase() === "input") {
+    const id = el.id;
+    if (id) {
+      var _label$textContent;
+      const label = document.querySelector(`label[for="${CSS.escape(id)}"]`);
+      const labelText = label === null || label === void 0 || (_label$textContent = label.textContent) === null || _label$textContent === void 0 ? void 0 : _label$textContent.trim();
+      if (labelText) return labelText;
+    }
+    const placeholder = (el.getAttribute("placeholder") || "").trim();
+    if (placeholder) return placeholder;
+  }
+  if (el.tagName.toLowerCase() === "a") {
+    const title = (el.getAttribute("title") || "").trim();
+    if (title) return title;
+  }
+  return (el.textContent || "").trim();
+};
+const isAnnounceable = el => {
+  if (isInsideAriaHidden(el)) return false;
+  const role = (el.getAttribute("role") || "").toLowerCase();
+  if (role === "presentation" || role === "none") return false;
+  if (role && ANNOUNCEABLE_ROLES.has(role)) return true;
+  if (ANNOUNCEABLE_TAGS.has(el.tagName.toLowerCase())) {
+    // <input type="hidden"> is not announceable.
+    if (el.tagName.toLowerCase() === "input" && (el.getAttribute("type") || "").toLowerCase() === "hidden") {
+      return false;
+    }
+    return true;
+  }
+  return false;
+};
+const findEmptyAnnounceable = root => {
+  return Array.from(root.querySelectorAll("*")).filter(el => isAnnounceable(el) && accessibleNameOf(el) === "");
+};
+const findEmptyLiveRegions = root => {
+  return Array.from(root.querySelectorAll("[aria-live]")).filter(el => {
+    if (isInsideAriaHidden(el)) return false;
+    const live = (el.getAttribute("aria-live") || "").toLowerCase();
+    if (live !== "polite" && live !== "assertive") return false;
+    return (el.textContent || "").trim() === "";
+  });
+};
+const summarize = offenders => offenders.map(el => ({
+  tag: el.tagName.toLowerCase(),
+  id: el.id,
+  role: el.getAttribute("role"),
+  ariaLabel: el.getAttribute("aria-label"),
+  ariaLabelledBy: el.getAttribute("aria-labelledby"),
+  classes: el.className
+}));
+describe("ChatButton — 'blank' / empty-name announcements (internal tracking regression guard)", () => {
+  it("no announceable role/tag in the chat-button subtree may have an empty accessible name", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    expect(summarize(findEmptyAnnounceable(button))).toEqual([]);
+  });
+  it("no live region (aria-live=polite/assertive) in the chat-button subtree may be mounted with empty text", () => {
+    const props = {
+      ..._defaultChatButtonProps.defaultChatButtonProps,
+      controlProps: {
+        ..._defaultChatButtonProps.defaultChatButtonProps.controlProps,
+        unreadMessageCount: "0",
+        hideNotificationBubble: false
+      }
+    };
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    expect(summarize(findEmptyLiveRegions(button))).toEqual([]);
+  });
+});
+describe("LoadingPane — 'blank' / empty-name announcements (internal tracking regression guard)", () => {
+  it("no announceable role/tag in the loading-pane subtree may have an empty accessible name", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_LoadingPane.default, _defaultLoadingPaneProps.defaultLoadingPaneProps));
+    const pane = container.firstElementChild;
+    expect(pane).not.toBeNull();
+    expect(summarize(findEmptyAnnounceable(pane))).toEqual([]);
+  });
+  it("no live region (aria-live=polite/assertive) in the loading-pane subtree may be mounted with empty text", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_LoadingPane.default, _defaultLoadingPaneProps.defaultLoadingPaneProps));
+    const pane = container.firstElementChild;
+    expect(pane).not.toBeNull();
+    expect(summarize(findEmptyLiveRegions(pane))).toEqual([]);
+  });
+});

package/lib/cjs/components/chatbutton/ChatButton.browseMode.a11y.spec.js

@@ -0,0 +1,236 @@
+"use strict";
+
+require("@testing-library/jest-dom/extend-expect");
+var _react = require("@testing-library/react");
+var _BroadcastService = require("../../services/BroadcastService");
+var _ChatButton = _interopRequireDefault(require("./ChatButton"));
+var _react2 = _interopRequireDefault(require("react"));
+var _defaultChatButtonProps = require("./common/defaultProps/defaultChatButtonProps");
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+/**
+ * Repro / catcher for internal tracking — NVDA / JAWS in browse mode (virtual cursor)
+ * land on "Let's Chat, We're Online" multiple times when navigating with the
+ * down-arrow key.
+ *
+ * Root cause in code: `ChatButton` renders a Fluent UI `<Stack role="button">`
+ * with `tabIndex={0}` whose accessible name is computed from its visible
+ * children — a `<Label>` for the title (e.g. "Let's Chat!") and a `<Label>`
+ * for the subtitle (e.g. "We're online."). In browse mode, NVDA / JAWS treat
+ * the button itself AND each inner text node as separate virtual-cursor stops,
+ * each carrying the same announceable name fragments. There is no
+ * `aria-label` set by default, and the inner labels are not marked
+ * `aria-hidden="true"` (which is what would collapse them into a single
+ * announcement under the button container).
+ *
+ * Catcher contract: in the rendered chat-button subtree, at most ONE element
+ * may expose each of the title / subtitle strings as an announceable name
+ * source. An "announceable name source" here is:
+ *   - an `aria-label` attribute on a focusable / role-bearing element, OR
+ *   - a visible `<Label>` (or other text-bearing element) that is NOT
+ *     `aria-hidden="true"` and is not nested inside an element that is
+ *     `aria-hidden="true"`.
+ *
+ * Regression guard: in the rendered DOM, the parent role=button Stack owns a
+ * single consolidated aria-label (synthesized from title + subtitle, plus
+ * unread-count fragment when applicable) and the inner Labels live inside an
+ * aria-hidden text container so browse-mode lands on the button exactly once.
+ * Override paths (componentOverrides.title/subtitle/textContainer or a
+ * consumer-supplied controlProps.ariaLabel) are preserved unchanged so
+ * customers who manage their own accessible names are not affected.
+ */
+
+beforeAll(() => {
+  (0, _BroadcastService.BroadcastServiceInitialize)("testChannel");
+});
+afterEach(() => {
+  (0, _react.cleanup)();
+});
+const isInsideAriaHidden = el => {
+  let cursor = el;
+  while (cursor) {
+    if (cursor.getAttribute("aria-hidden") === "true") return true;
+    cursor = cursor.parentElement;
+  }
+  return false;
+};
+const visibleTextElementsMatching = (root, text) => {
+  return Array.from(root.querySelectorAll("*")).filter(el => {
+    if (isInsideAriaHidden(el)) return false;
+    // Only count leaf-ish text-bearing elements (don't double-count
+    // ancestors whose textContent obviously aggregates children).
+    const ownText = Array.from(el.childNodes).filter(n => n.nodeType === Node.TEXT_NODE).map(n => (n.textContent || "").trim()).join(" ").trim();
+    return ownText === text;
+  });
+};
+
+/**
+ * Regression guard for internal tracking — ChatButton must not produce duplicate
+ * NVDA / JAWS browse-mode stops. Visible title / subtitle text is excluded
+ * from the accessibility tree (aria-hidden) and the button container owns a
+ * single consolidated aria-label.
+ */
+describe("ChatButton — browse-mode duplicate stops (internal tracking)", () => {
+  it("title text 'Let's Chat!' must NOT appear as a visible (non-aria-hidden) name source in the chat-button subtree", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    const titleStops = visibleTextElementsMatching(button, "Let's Chat!");
+    // The visible title should be excluded from the accessibility tree
+    // (e.g. via aria-hidden on the text container) so the announced name
+    // comes solely from the consolidated aria-label on the button. Any
+    // exposed text-bearing element with this exact text creates an
+    // additional browse-mode stop and reproduces internal tracking.
+    expect(titleStops.length).toBe(0);
+  });
+  it("subtitle text 'We're online.' must NOT appear as a visible (non-aria-hidden) name source in the chat-button subtree", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    const subtitleStops = visibleTextElementsMatching(button, "We're online.");
+    expect(subtitleStops.length).toBe(0);
+  });
+  it("the chat-button container must own a single consolidated aria-label so browse mode lands on it once", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    // Either the container has a non-empty aria-label, OR every inner
+    // text-bearing descendant is aria-hidden so the computed name comes
+    // from the inner text exactly once with no extra browse-mode stops.
+    const hasAriaLabel = !!(button.getAttribute("aria-label") || "").trim();
+    const innerVisibleText = visibleTextElementsMatching(button, "Let's Chat!").length + visibleTextElementsMatching(button, "We're online.").length;
+    // Today: hasAriaLabel === false (default ariaLabel is undefined) AND
+    // innerVisibleText > 0. The catcher requires at least one of these
+    // to flip.
+    expect(hasAriaLabel || innerVisibleText === 0).toBe(true);
+  });
+  it("the synthesized aria-label includes the unread-count fragment when hideNotificationBubble=false and unreadMessageCount > 0", () => {
+    const props = {
+      ..._defaultChatButtonProps.defaultChatButtonProps,
+      controlProps: {
+        ..._defaultChatButtonProps.defaultChatButtonProps.controlProps,
+        hideNotificationBubble: false,
+        unreadMessageCount: "3",
+        ariaLabelUnreadMessageString: "you have new messages",
+        titleText: "Let's Chat!",
+        subtitleText: "We're online."
+      }
+    };
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+    const button = container.firstElementChild;
+    const ariaLabel = button.getAttribute("aria-label") || "";
+    expect(ariaLabel).toContain("3");
+    expect(ariaLabel).toContain("you have new messages");
+    expect(ariaLabel).toContain("Let's Chat!");
+    expect(ariaLabel).toContain("We're online.");
+  });
+  it("a consumer-supplied controlProps.ariaLabel wins over the synthesized label", () => {
+    const props = {
+      ..._defaultChatButtonProps.defaultChatButtonProps,
+      controlProps: {
+        ..._defaultChatButtonProps.defaultChatButtonProps.controlProps,
+        ariaLabel: "Talk to a live agent"
+      }
+    };
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+    const button = container.firstElementChild;
+    expect(button.getAttribute("aria-label")).toBe("Talk to a live agent");
+  });
+  it("componentOverrides.textContainer preserves consumer-rendered visible text (synthesis is skipped)", () => {
+    const customText = "My custom chat text";
+    const props = {
+      ..._defaultChatButtonProps.defaultChatButtonProps,
+      componentOverrides: {
+        textContainer: /*#__PURE__*/_react2.default.createElement("div", {
+          id: "my-custom-text"
+        }, customText)
+      }
+    };
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+    const button = container.firstElementChild;
+    // The custom text MUST remain visible in the a11y tree so consumers
+    // who replace the text container keep their announced text.
+    const customStops = visibleTextElementsMatching(button, customText);
+    expect(customStops.length).toBeGreaterThan(0);
+    // And the button must NOT carry a synthesized aria-label that would
+    // override the consumer's content.
+    const ariaLabel = (button.getAttribute("aria-label") || "").trim();
+    expect(ariaLabel).toBe("");
+  });
+  it("componentOverrides.title preserves consumer-rendered visible title (synthesis is skipped)", () => {
+    const customTitle = "Custom override title";
+    const props = {
+      ..._defaultChatButtonProps.defaultChatButtonProps,
+      componentOverrides: {
+        title: /*#__PURE__*/_react2.default.createElement("span", {
+          id: "my-custom-title"
+        }, customTitle)
+      }
+    };
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+    const button = container.firstElementChild;
+    const customStops = visibleTextElementsMatching(button, customTitle);
+    expect(customStops.length).toBeGreaterThan(0);
+    const ariaLabel = (button.getAttribute("aria-label") || "").trim();
+    expect(ariaLabel).toBe("");
+  });
+
+  // Regression guard for the strict string-equality slip-throughs that
+  // brittle `unreadMessageCount !== "0"` allowed: values that coerce to
+  // numeric 0 (or non-numeric noise) must NOT render the bubble nor pollute
+  // the synthesized aria-label with a "0 you have new messages" fragment.
+  describe.each([["padded zero (' 0 ')", " 0 "], ["decimal zero ('0.0')", "0.0"], ["empty string ('')", ""], ["non-numeric ('abc')", "abc"]])("zero-equivalent unreadMessageCount: %s", (_label, value) => {
+    it("does NOT render the notification bubble", () => {
+      const props = {
+        ..._defaultChatButtonProps.defaultChatButtonProps,
+        controlProps: {
+          ..._defaultChatButtonProps.defaultChatButtonProps.controlProps,
+          hideNotificationBubble: false,
+          unreadMessageCount: value,
+          ariaLabelUnreadMessageString: "you have new messages"
+        }
+      };
+      const {
+        container
+      } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+      const bubble = container.querySelector("[id$='-notification-bubble']");
+      expect(bubble).toBeNull();
+    });
+    it("does NOT inject the unread-count fragment into the synthesized aria-label", () => {
+      const props = {
+        ..._defaultChatButtonProps.defaultChatButtonProps,
+        controlProps: {
+          ..._defaultChatButtonProps.defaultChatButtonProps.controlProps,
+          hideNotificationBubble: false,
+          unreadMessageCount: value,
+          ariaLabelUnreadMessageString: "you have new messages"
+        }
+      };
+      const {
+        container
+      } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, props));
+      const button = container.firstElementChild;
+      const ariaLabel = button.getAttribute("aria-label") || "";
+      expect(ariaLabel).not.toContain("you have new messages");
+      // and the raw zero-equivalent must not leak into the label
+      if (value.trim().length > 0) {
+        expect(ariaLabel).not.toContain(value.trim());
+      }
+    });
+  });
+});

package/lib/cjs/components/chatbutton/ChatButton.browseMode.unfixed.a11y.spec.js

@@ -0,0 +1,115 @@
+"use strict";
+
+require("@testing-library/jest-dom/extend-expect");
+var _react = require("@testing-library/react");
+var _BroadcastService = require("../../services/BroadcastService");
+var _ChatButton = _interopRequireDefault(require("./ChatButton"));
+var _react2 = _interopRequireDefault(require("react"));
+var _defaultChatButtonControlProps = require("./common/defaultProps/defaultChatButtonControlProps");
+var _defaultChatButtonProps = require("./common/defaultProps/defaultChatButtonProps");
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+const expectedTitle = _defaultChatButtonControlProps.defaultChatButtonControlProps.titleText;
+const expectedSubtitle = _defaultChatButtonControlProps.defaultChatButtonControlProps.subtitleText;
+
+/**
+ * Repro / catcher for internal tracking — NVDA / JAWS in browse mode (virtual cursor)
+ * land on "Let's Chat, We're Online" multiple times when navigating with the
+ * down-arrow key.
+ *
+ * Root cause in code: `ChatButton` renders a Fluent UI `<Stack role="button">`
+ * with `tabIndex={0}` whose accessible name is computed from its visible
+ * children — a `<Label>` for the title (e.g. "Let's Chat!") and a `<Label>`
+ * for the subtitle (e.g. "We're online."). In browse mode, NVDA / JAWS treat
+ * the button itself AND each inner text node as separate virtual-cursor stops,
+ * each carrying the same announceable name fragments. There is no
+ * `aria-label` set by default, and the inner labels are not marked
+ * `aria-hidden="true"` (which is what would collapse them into a single
+ * announcement under the button container).
+ *
+ * Catcher contract: the title / subtitle strings must NOT appear as
+ * additional announceable name sources in the chat-button subtree (only the
+ * single consolidated aria-label on the role=button container should name the
+ * button). An "announceable name source" here is:
+ *   - an `aria-label` attribute on a focusable / role-bearing element, OR
+ *   - a visible `<Label>` (or other text-bearing element) that is NOT
+ *     `aria-hidden="true"` and is not nested inside an element that is
+ *     `aria-hidden="true"`.
+ *
+ * Expected to FAIL today: the rendered DOM contains BOTH the title text node
+ * AND the subtitle text node as bare visible text, and the parent Stack has
+ * no `aria-label` to consolidate them. Browse-mode therefore sees three
+ * stops (button, title, subtitle) all carrying the same combined name.
+ */
+
+beforeAll(() => {
+  (0, _BroadcastService.BroadcastServiceInitialize)("testChannel");
+});
+afterEach(() => {
+  (0, _react.cleanup)();
+});
+const isInsideAriaHidden = el => {
+  let cursor = el;
+  while (cursor) {
+    if (cursor.getAttribute("aria-hidden") === "true") return true;
+    cursor = cursor.parentElement;
+  }
+  return false;
+};
+const visibleTextElementsMatching = (root, text) => {
+  return Array.from(root.querySelectorAll("*")).filter(el => {
+    if (isInsideAriaHidden(el)) return false;
+    // Only count leaf-ish text-bearing elements (don't double-count
+    // ancestors whose textContent obviously aggregates children).
+    const ownText = Array.from(el.childNodes).filter(n => n.nodeType === Node.TEXT_NODE).map(n => (n.textContent || "").trim()).join(" ").trim();
+    return ownText === text;
+  });
+};
+
+/**
+ * SKIPPED until the source fix lands. Un-skip the describe below to validate
+ * the fix to internal tracking; the suite is expected to FAIL today against unfixed
+ * source. Mirrors the chat-widget `*.unfixed.a11y.spec.tsx` convention.
+ */
+describe.skip("ChatButton — browse-mode duplicate stops (internal tracking)", () => {
+  it(`title text '${expectedTitle}' must NOT appear as a visible (non-aria-hidden) name source in the chat-button subtree`, () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    const titleStops = visibleTextElementsMatching(button, expectedTitle);
+    // The visible title should be excluded from the accessibility tree
+    // (e.g. via aria-hidden on the text container) so the announced name
+    // comes solely from the consolidated aria-label on the button. Any
+    // exposed text-bearing element with this exact text creates an
+    // additional browse-mode stop and reproduces internal tracking.
+    expect(titleStops.length).toBe(0);
+  });
+  it(`subtitle text '${expectedSubtitle}' must NOT appear as a visible (non-aria-hidden) name source in the chat-button subtree`, () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    const subtitleStops = visibleTextElementsMatching(button, expectedSubtitle);
+    expect(subtitleStops.length).toBe(0);
+  });
+  it("the chat-button container must own a single consolidated aria-label so browse mode lands on it once", () => {
+    const {
+      container
+    } = (0, _react.render)(/*#__PURE__*/_react2.default.createElement(_ChatButton.default, _defaultChatButtonProps.defaultChatButtonProps));
+    const button = container.firstElementChild;
+    expect(button).not.toBeNull();
+    // Either the container has a non-empty aria-label, OR every inner
+    // text-bearing descendant is aria-hidden so the computed name comes
+    // from the inner text exactly once with no extra browse-mode stops.
+    const hasAriaLabel = !!(button.getAttribute("aria-label") || "").trim();
+    const innerVisibleText = visibleTextElementsMatching(button, expectedTitle).length + visibleTextElementsMatching(button, expectedSubtitle).length;
+    // Today: hasAriaLabel === false (default ariaLabel is undefined) AND
+    // innerVisibleText > 0. The catcher requires at least one of these
+    // to flip.
+    expect(hasAriaLabel || innerVisibleText === 0).toBe(true);
+  });
+});

package/lib/cjs/components/chatbutton/ChatButton.js

@@ -17,13 +17,24 @@ var _defaultChatButtonSubTitleStyles = require("./common/defaultStyles/defaultCh
 var _defaultChatButtonTextContainerStyles = require("./common/defaultStyles/defaultChatButtonTextContainerStyles");
 var _defaultChatButtonTitleStyles = require("./common/defaultStyles/defaultChatButtonTitleStyles");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function (e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != typeof e && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (const t in e) "default" !== t && {}.hasOwnProperty.call(e, t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, t)) && (i.get || i.set) ? o(f, t, i) : f[t] = e[t]); return f; })(e, t); }
+// Returns true when the unread-message count represents a positive number.
+// Defensive against non-strict callers that may pass " 0 ", "0.0", "" or a
+// stringified numeric 0; only a finite count strictly greater than zero counts
+// as "unread" for both the notification bubble and the synthesized aria-label.
+function hasUnreadMessages(unreadMessageCount) {
+  if (unreadMessageCount === undefined || unreadMessageCount === null) {
+    return false;
+  }
+  const parsed = Number(unreadMessageCount);
+  return Number.isFinite(parsed) && parsed > 0;
+}
 function NotificationBubble(props, parentId) {
   var _props$styleProps, _props$controlProps;
   const notificationBubbleStyles = {
     root: Object.assign({}, _defaultChatButtonNotificationBubbleStyles.defaultChatButtonNotificationBubbleStyles, (_props$styleProps = props.styleProps) === null || _props$styleProps === void 0 ? void 0 : _props$styleProps.notificationBubbleStyleProps)
   };
   const unreadMessageCount = ((_props$controlProps = props.controlProps) === null || _props$controlProps === void 0 ? void 0 : _props$controlProps.unreadMessageCount) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.unreadMessageCount);
-  if (unreadMessageCount !== "0") {
+  if (hasUnreadMessages(unreadMessageCount)) {
     var _props$componentOverr, _props$controlProps2, _props$controlProps3, _props$styleProps2, _props$controlProps4, _props$controlProps5;
     return (0, _decodeComponentString.decodeComponentString)((_props$componentOverr = props.componentOverrides) === null || _props$componentOverr === void 0 ? void 0 : _props$componentOverr.notificationBubble) || /*#__PURE__*/_react2.default.createElement(_react.Stack, {
       "aria-live": "polite",
@@ -49,7 +60,7 @@ function IconContainer(props, parentId) {
   });
 }
 function TextContainer(props, parentId) {
-  var _props$styleProps5, _props$styleProps6, _props$styleProps7, _props$controlProps6, _props$controlProps7, _props$controlProps8, _props$controlProps9, _props$controlProps0, _props$controlProps1, _props$componentOverr3, _props$styleProps8, _props$componentOverr4, _props$styleProps9, _props$componentOverr5, _props$styleProps0;
+  var _props$styleProps5, _props$styleProps6, _props$styleProps7, _props$controlProps6, _props$controlProps7, _props$controlProps8, _props$controlProps9, _props$controlProps0, _props$controlProps1, _props$componentOverr3, _props$componentOverr4, _props$componentOverr5, _props$styleProps8, _props$componentOverr6, _props$styleProps9, _props$componentOverr7, _props$styleProps0;
   const textContainerStyles = {
     root: Object.assign({}, _defaultChatButtonTextContainerStyles.defaultChatButtonTextContainerStyles, (_props$styleProps5 = props.styleProps) === null || _props$styleProps5 === void 0 ? void 0 : _props$styleProps5.textContainerStyleProps)
   };
@@ -65,16 +76,26 @@ function TextContainer(props, parentId) {
   const titleText = ((_props$controlProps9 = props.controlProps) === null || _props$controlProps9 === void 0 ? void 0 : _props$controlProps9.titleText) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.titleText);
   const subtitleDir = ((_props$controlProps0 = props.controlProps) === null || _props$controlProps0 === void 0 ? void 0 : _props$controlProps0.dir) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.dir);
   const subtitleText = ((_props$controlProps1 = props.controlProps) === null || _props$controlProps1 === void 0 ? void 0 : _props$controlProps1.subtitleText) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.subtitleText);
-  return (0, _decodeComponentString.decodeComponentString)((_props$componentOverr3 = props.componentOverrides) === null || _props$componentOverr3 === void 0 ? void 0 : _props$componentOverr3.textContainer) || /*#__PURE__*/_react2.default.createElement(_react.Stack, {
+
+  // internal tracking: when the default title / subtitle Labels are used, hide the
+  // text container subtree from the accessibility tree. The button container
+  // owns a consolidated aria-label that already announces the same text, so
+  // exposing the inner Labels causes NVDA / JAWS browse-mode to land on the
+  // same announcement multiple times. Customer overrides for title /
+  // subtitle keep their default a11y behavior so they can manage their own
+  // accessible names.
+  const hideTextFromA11yTree = !((_props$componentOverr3 = props.componentOverrides) !== null && _props$componentOverr3 !== void 0 && _props$componentOverr3.title) && !((_props$componentOverr4 = props.componentOverrides) !== null && _props$componentOverr4 !== void 0 && _props$componentOverr4.subtitle);
+  return (0, _decodeComponentString.decodeComponentString)((_props$componentOverr5 = props.componentOverrides) === null || _props$componentOverr5 === void 0 ? void 0 : _props$componentOverr5.textContainer) || /*#__PURE__*/_react2.default.createElement(_react.Stack, {
     styles: textContainerStyles,
     className: (_props$styleProps8 = props.styleProps) === null || _props$styleProps8 === void 0 || (_props$styleProps8 = _props$styleProps8.classNames) === null || _props$styleProps8 === void 0 ? void 0 : _props$styleProps8.textContainerClassName,
-    id: parentId + "-text-container"
-  }, !hideChatTitle && ((0, _decodeComponentString.decodeComponentString)((_props$componentOverr4 = props.componentOverrides) === null || _props$componentOverr4 === void 0 ? void 0 : _props$componentOverr4.title) || /*#__PURE__*/_react2.default.createElement(_react.Label, {
+    id: parentId + "-text-container",
+    "aria-hidden": hideTextFromA11yTree || undefined
+  }, !hideChatTitle && ((0, _decodeComponentString.decodeComponentString)((_props$componentOverr6 = props.componentOverrides) === null || _props$componentOverr6 === void 0 ? void 0 : _props$componentOverr6.title) || /*#__PURE__*/_react2.default.createElement(_react.Label, {
     styles: titleStyles,
     dir: titleDir,
     className: (_props$styleProps9 = props.styleProps) === null || _props$styleProps9 === void 0 || (_props$styleProps9 = _props$styleProps9.classNames) === null || _props$styleProps9 === void 0 ? void 0 : _props$styleProps9.titleClassName,
     id: parentId + "-title"
-  }, titleText)), !hideChatSubtitle && ((0, _decodeComponentString.decodeComponentString)((_props$componentOverr5 = props.componentOverrides) === null || _props$componentOverr5 === void 0 ? void 0 : _props$componentOverr5.subtitle) || /*#__PURE__*/_react2.default.createElement(_react.Label, {
+  }, titleText)), !hideChatSubtitle && ((0, _decodeComponentString.decodeComponentString)((_props$componentOverr7 = props.componentOverrides) === null || _props$componentOverr7 === void 0 ? void 0 : _props$componentOverr7.subtitle) || /*#__PURE__*/_react2.default.createElement(_react.Label, {
     styles: subtitleStyles,
     dir: subtitleDir,
     className: (_props$styleProps0 = props.styleProps) === null || _props$styleProps0 === void 0 || (_props$styleProps0 = _props$styleProps0.classNames) === null || _props$styleProps0 === void 0 ? void 0 : _props$styleProps0.subtitleClassName,
@@ -82,21 +103,36 @@ function TextContainer(props, parentId) {
   }, subtitleText)));
 }
 function ChatButton(props) {
-  var _props$controlProps10, _props$controlProps11, _props$controlProps12, _props$controlProps13, _props$controlProps14, _props$controlProps15, _props$controlProps16, _props$controlProps17, _props$styleProps1;
+  var _props$controlProps10, _props$controlProps11, _props$controlProps12, _props$controlProps13, _props$controlProps14, _props$controlProps15, _props$controlProps16, _props$controlProps17, _props$controlProps18, _props$controlProps19, _props$controlProps20, _props$controlProps21, _props$controlProps22, _props$componentOverr8, _props$componentOverr9, _props$componentOverr0, _props$controlProps23, _props$styleProps1;
   const elementId = ((_props$controlProps10 = props.controlProps) === null || _props$controlProps10 === void 0 ? void 0 : _props$controlProps10.id) ?? _Constants.Ids.DefaultChatButtonId;
-  const defaultAriaLabel = ((_props$controlProps11 = props.controlProps) === null || _props$controlProps11 === void 0 ? void 0 : _props$controlProps11.ariaLabel) ?? _defaultChatButtonControlProps.defaultChatButtonControlProps.ariaLabel;
-  const defaultRole = ((_props$controlProps12 = props.controlProps) === null || _props$controlProps12 === void 0 ? void 0 : _props$controlProps12.role) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.role);
-  const containersDir = ((_props$controlProps13 = props.controlProps) === null || _props$controlProps13 === void 0 ? void 0 : _props$controlProps13.dir) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.dir);
-  const hideChatButton = ((_props$controlProps14 = props.controlProps) === null || _props$controlProps14 === void 0 ? void 0 : _props$controlProps14.hideChatButton) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatButton);
-  const hideChatIcon = ((_props$controlProps15 = props.controlProps) === null || _props$controlProps15 === void 0 ? void 0 : _props$controlProps15.hideChatIcon) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatIcon);
-  const hideChatTextContainer = ((_props$controlProps16 = props.controlProps) === null || _props$controlProps16 === void 0 ? void 0 : _props$controlProps16.hideChatTextContainer) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatTextContainer);
-  const hideNotificationBubble = ((_props$controlProps17 = props.controlProps) === null || _props$controlProps17 === void 0 ? void 0 : _props$controlProps17.hideNotificationBubble) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideNotificationBubble);
+  const defaultRole = ((_props$controlProps11 = props.controlProps) === null || _props$controlProps11 === void 0 ? void 0 : _props$controlProps11.role) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.role);
+  const containersDir = ((_props$controlProps12 = props.controlProps) === null || _props$controlProps12 === void 0 ? void 0 : _props$controlProps12.dir) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.dir);
+  const hideChatButton = ((_props$controlProps13 = props.controlProps) === null || _props$controlProps13 === void 0 ? void 0 : _props$controlProps13.hideChatButton) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatButton);
+  const hideChatIcon = ((_props$controlProps14 = props.controlProps) === null || _props$controlProps14 === void 0 ? void 0 : _props$controlProps14.hideChatIcon) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatIcon);
+  const hideChatTextContainer = ((_props$controlProps15 = props.controlProps) === null || _props$controlProps15 === void 0 ? void 0 : _props$controlProps15.hideChatTextContainer) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatTextContainer);
+  const hideNotificationBubble = ((_props$controlProps16 = props.controlProps) === null || _props$controlProps16 === void 0 ? void 0 : _props$controlProps16.hideNotificationBubble) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideNotificationBubble);
+
+  // internal tracking: when the consumer has not supplied a custom aria-label and
+  // the default title / subtitle Labels are in play, synthesize a single
+  // consolidated aria-label from the visible text so NVDA / JAWS browse
+  // mode lands on the role=button container exactly once. The text
+  // container is also marked aria-hidden in TextContainer so the inner
+  // labels do not produce additional virtual-cursor stops.
+  const titleText = ((_props$controlProps17 = props.controlProps) === null || _props$controlProps17 === void 0 ? void 0 : _props$controlProps17.titleText) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.titleText);
+  const subtitleText = ((_props$controlProps18 = props.controlProps) === null || _props$controlProps18 === void 0 ? void 0 : _props$controlProps18.subtitleText) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.subtitleText);
+  const hideChatTitle = ((_props$controlProps19 = props.controlProps) === null || _props$controlProps19 === void 0 ? void 0 : _props$controlProps19.hideChatTitle) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatTitle);
+  const hideChatSubtitle = ((_props$controlProps20 = props.controlProps) === null || _props$controlProps20 === void 0 ? void 0 : _props$controlProps20.hideChatSubtitle) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.hideChatSubtitle);
+  const unreadMessageCount = ((_props$controlProps21 = props.controlProps) === null || _props$controlProps21 === void 0 ? void 0 : _props$controlProps21.unreadMessageCount) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.unreadMessageCount);
+  const ariaLabelUnreadMessageString = ((_props$controlProps22 = props.controlProps) === null || _props$controlProps22 === void 0 ? void 0 : _props$controlProps22.ariaLabelUnreadMessageString) ?? (_defaultChatButtonControlProps.defaultChatButtonControlProps === null || _defaultChatButtonControlProps.defaultChatButtonControlProps === void 0 ? void 0 : _defaultChatButtonControlProps.defaultChatButtonControlProps.ariaLabelUnreadMessageString);
+  const canSynthesizeAriaLabel = !hideChatTextContainer && !((_props$componentOverr8 = props.componentOverrides) !== null && _props$componentOverr8 !== void 0 && _props$componentOverr8.textContainer) && !((_props$componentOverr9 = props.componentOverrides) !== null && _props$componentOverr9 !== void 0 && _props$componentOverr9.title) && !((_props$componentOverr0 = props.componentOverrides) !== null && _props$componentOverr0 !== void 0 && _props$componentOverr0.subtitle);
+  const synthesizedAriaLabel = canSynthesizeAriaLabel ? [!hideNotificationBubble && hasUnreadMessages(unreadMessageCount) ? `${unreadMessageCount} ${ariaLabelUnreadMessageString ?? ""}`.trim() : "", !hideChatTitle ? titleText : "", !hideChatSubtitle ? subtitleText : ""].filter(Boolean).join(" ").trim() : "";
+  const defaultAriaLabel = ((_props$controlProps23 = props.controlProps) === null || _props$controlProps23 === void 0 ? void 0 : _props$controlProps23.ariaLabel) ?? _defaultChatButtonControlProps.defaultChatButtonControlProps.ariaLabel ?? (synthesizedAriaLabel || undefined);
   const chatButtonGroupStyles = {
     root: Object.assign({}, _defaultChatButtonGeneralStyles.defaultChatButtonGeneralStyles, (_props$styleProps1 = props.styleProps) === null || _props$styleProps1 === void 0 ? void 0 : _props$styleProps1.generalStyleProps)
   };
   const handleInitiateChatClick = (0, _react2.useCallback)(() => {
-    var _props$controlProps18;
-    if ((_props$controlProps18 = props.controlProps) !== null && _props$controlProps18 !== void 0 && _props$controlProps18.onClick) {
+    var _props$controlProps24;
+    if ((_props$controlProps24 = props.controlProps) !== null && _props$controlProps24 !== void 0 && _props$controlProps24.onClick) {
       const customEvent = {
         elementType: _Constants.ElementType.ChatButton,
         elementId: elementId,