@microsoft/1ds-post-js 3.2.7 → 3.2.8

package/src/HttpManager.ts

@@ -22,7 +22,7 @@ import { EventBatch } from "./EventBatch";
 import { IChannelConfiguration } from "./Index";
 import {
     DEFAULT_CACHE_CONTROL, DEFAULT_CONTENT_TYPE, STR_API_KEY, STR_AUTH_XTOKEN, STR_CACHE_CONTROL, STR_CLIENT_ID, STR_CLIENT_VERSION,
-    STR_CONTENT_TYPE_HEADER, STR_DISABLED_PROPERTY_NAME, STR_DROPPED, STR_KILL_DURATION_HEADER, STR_KILL_DURATION_SECONDS_HEADER,
+    STR_CONTENT_TYPE_HEADER, STR_DISABLED_PROPERTY_NAME, STR_DROPPED, STR_EMPTY, STR_KILL_DURATION_HEADER, STR_KILL_DURATION_SECONDS_HEADER,
     STR_KILL_TOKENS_HEADER, STR_MSA_DEVICE_TICKET, STR_MSFPC, STR_NO_RESPONSE_BODY, STR_OTHER, STR_POST_METHOD, STR_REQUEUE,
     STR_RESPONSE_FAIL, STR_SENDING, STR_TIME_DELTA_HEADER, STR_TIME_DELTA_TO_APPLY, STR_UPLOAD_TIME
 } from "./InternalConstants";
@@ -85,7 +85,7 @@ function _getResponseText(xhr: XMLHttpRequest | IXDomainRequest) {
         // Best effort, as XHR may throw while XDR wont so just ignore
     }
 
-    return "";
+    return STR_EMPTY;
 }
 
 interface IInternalXhrOverride extends IXHROverride {
@@ -178,6 +178,7 @@ export class HttpManager {
         let _disableXhrSync: boolean;
         let _disableFetchKeepAlive: boolean;
         let _canHaveReducedPayload: boolean;
+        let _addNoResponse: boolean;
 
         dynamicProto(HttpManager, this, (_self) => {
             let _sendCredentials = true;
@@ -211,6 +212,7 @@ export class HttpManager {
                 _xhrTimeout = channelConfig.xhrTimeout;
                 _disableXhrSync = !!channelConfig.disableXhrSync;
                 _disableFetchKeepAlive = !!channelConfig.disableFetchKeepAlive;
+                _addNoResponse = channelConfig.addNoResponse !== false;
 
                 _useBeacons = !isReactNative(); // Only use beacons if not running in React Native
                 _serializer = new Serializer(_core, valueSanitizer, stringifyObjects, enableCompoundKey);
@@ -361,7 +363,9 @@ export class HttpManager {
                         // As a sync request (during unload), it is unlikely that we will get a chance to process the response so
                         // just like beacon send assume that the events have been accepted and processed
                         ignoreResponse = true;
-                        theUrl += _noResponseQs;
+                        if (_addNoResponse) {
+                            theUrl += _noResponseQs;
+                        }
                     }
                 }
 
@@ -377,7 +381,7 @@ export class HttpManager {
 
                 fetch(theUrl, requestInit).then((response) => {
                     let headerMap = {};
-                    let responseText = "";
+                    let responseText = STR_EMPTY;
                     var headers = response.headers;
                     if (headers) {
                         headers["forEach"]((value: string, name: string) => {
@@ -495,7 +499,7 @@ export class HttpManager {
                 let internalPayloadData = payload as IInternalPayloadData;
                 let status = 200;
                 let thePayload = internalPayloadData._thePayload;
-                let theUrl = payload.urlString + _noResponseQs;
+                let theUrl = payload.urlString + (_addNoResponse ? _noResponseQs : STR_EMPTY);
 
                 try {
                     let nav = getNavigator();
@@ -529,7 +533,7 @@ export class HttpManager {
                     _warnToConsole(_logger, "Failed to send telemetry using sendBeacon API. Ex:" + dumpObj(ex));
                     status = 0;
                 } finally {
-                    _doOnComplete(oncomplete, status, {}, "");
+                    _doOnComplete(oncomplete, status, {}, STR_EMPTY);
                 }
             }
 
@@ -799,7 +803,7 @@ export class HttpManager {
                 _addRequestDetails(requestDetails, STR_CLIENT_ID, "NO_AUTH", useHeaders);
                 _addRequestDetails(requestDetails, STR_CLIENT_VERSION, FullVersionString, useHeaders);
 
-                let apiQsKeys = "";
+                let apiQsKeys = STR_EMPTY;
                 arrForEach(thePayload.apiKeys, (apiKey) => {
                     if (apiQsKeys.length > 0) {
                         apiQsKeys += ",";
@@ -1197,7 +1201,7 @@ export class HttpManager {
                     }
                 }
 
-                return "";
+                return STR_EMPTY;
             }
 
             function _handleCollectorResponse(responseText: string): void {

package/src/InternalConstants.ts

@@ -8,6 +8,7 @@
 // Generally you should only put values that are used more than 2 times and then only if not already exposed as a constant (such as SdkCoreNames)
 // as when using "short" named values from here they will be will be minified smaller than the SdkCoreNames[eSdkCoreNames.xxxx] value.
 
+export const STR_EMPTY = "";
 export const STR_POST_METHOD = "POST";
 export const STR_DISABLED_PROPERTY_NAME: string = "Microsoft_ApplicationInsights_BypassAjaxInstrumentation";
 

package/src/PostChannel.ts

@@ -160,7 +160,7 @@ export default class PostChannel extends BaseTelemetryPlugin implements IChannel
     
                         // Override endpointUrl if provided in Post config
                         let endpointUrl = _config.overrideEndpointUrl ? _config.overrideEndpointUrl : coreConfig.endpointUrl;
-                        _self._notificationManager = coreConfig.extensionConfig.NotificationManager;
+                        _self._notificationManager = core.getNotifyMgr();
                         _httpManager.initialize(endpointUrl, _self.core as IExtendedAppInsightsCore, _self, _xhrOverride, _config);
     
                         let excludePageUnloadEvents = coreConfig.disablePageUnloadEvents || [];

package/src/Serializer.ts

@@ -13,6 +13,7 @@ import {
 } from "@microsoft/1ds-core-js";
 import { IPostTransmissionTelemetryItem } from "./DataModels";
 import { EventBatch } from "./EventBatch";
+import { STR_EMPTY } from "./InternalConstants";
 
 /**
  * Note: This is an optimization for V8-based browsers. When V8 concatenates a string,
@@ -124,7 +125,7 @@ export class Serializer {
             _self.createPayload = (retryCnt: number, isTeardown: boolean, isSync: boolean, isReducedPayload: boolean, sendReason: SendRequestReason, sendType: EventSendType): ISerializedPayload => {
                 return {
                     apiKeys: [],
-                    payloadBlob: "",
+                    payloadBlob: STR_EMPTY,
                     overflow: null,
                     sizeExceed: [],
                     failedEvts: [],