@micromag/element-video 0.3.590 → 0.3.591

package/es/index.js

@@ -64,7 +64,7 @@ var defaultProps = {
   playsInline: true,
   preload: 'auto',
   disablePictureInPicture: true,
-  disableHls: true,
+  disableHls: false,
   shouldLoad: true,
   withoutCors: false,
   className: null,
@@ -196,14 +196,20 @@ var Video = function Video(_ref) {
   useEffect(function () {
     setHlsTsOffset(0);
     setHlsFailed(false);
-    if (!shouldLoad || _ref16.current === null || hlsSources === null || hlsSources.length === 0) {
+    if (!shouldLoad || hlsSources === null || hlsSources.length === 0) {
       setHlsJs(null);
       return;
     }
     var hls = new Hls({
       maxBufferLength: 15,
       // seconds. prevents loading too much per screen.
-      startLevel: qualityStartLevel !== null ? qualityStartLevel : -1
+      startLevel: qualityStartLevel !== null ? qualityStartLevel : -1,
+      enableWorker: true
+      // debug: true,
+      // lowLatencyMode: true,
+      // backBufferLength: 90,
+      // testBandwidth: qualityStartLevel === null,
+      // startFragPrefetch: true,
     });
     hls.on(Hls.Events.LEVEL_SWITCHED, function (_, _ref5) {
       var level = _ref5.level;
@@ -250,21 +256,35 @@ var Video = function Video(_ref) {
     hls.on(Hls.Events.BUFFER_APPENDED, _onHlsBufferAppended);
     hls.loadSource(hlsSources[0].url);
     setHlsJs(hls);
-  }, [shouldLoad, hlsSources, _ref16]);
+  }, [shouldLoad, hlsSources]);
 
-  // attach hls.js when the <video> ref is ready
+  // attach hls.js when the <video> ref or the hls.js instance is ready
   useEffect(function () {
     if (hlsJs !== null && _ref16.current !== null) {
       hlsJs.attachMedia(_ref16.current);
+      // if (onQualityLevelChange !== null) {
+      //     onQualityLevelChange(hlsJs.currentLevel, ref.current);
+      // }
     }
     return function () {
       if (hlsJs !== null) {
         hlsJs.detachMedia();
-        hlsJs.destroy();
       }
     };
   }, [hlsJs, _ref16.current]);
 
+  // cleanup hls.js instance when it is no longer needed
+  useEffect(function () {
+    return (
+      // teardown func
+      function () {
+        if (hlsJs !== null) {
+          hlsJs.destroy();
+        }
+      }
+    );
+  }, [hlsJs]);
+
   // handle changes of qualityStartLevel when an hls.js instance exists
   useEffect(function () {
     if (hlsJs !== null) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@micromag/element-video",
-    "version": "0.3.590",
+    "version": "0.3.591",
     "private": false,
     "description": "",
     "keywords": [
@@ -72,5 +72,5 @@
         "access": "public",
         "registry": "https://registry.npmjs.org/"
     },
-    "gitHead": "aee5033c29da327111287f71fd59cb77f469306a"
+    "gitHead": "408109a7ecf28442e75871359a3a9cba22e06344"
 }